@umituz/web-polar-payment 1.0.13 → 1.0.15

package/src/presentation/components/PolarProvider.tsx

@@ -16,11 +16,7 @@ import type {
   OrderItem,
 } from '../../domain/entities';
 import { PolarContext } from '../hooks/usePolarBilling';
-
-/**
- * PolarProvider Component
- * @description Context provider for Polar billing management.
- */
+import { normalizeUserId, isValidProductId, isValidCheckoutUrl, isProductionInsecureUrl } from '../../infrastructure/utils/validations.util';
 
 interface PolarProviderProps {
   adapter: PolarAdapter;
@@ -33,74 +29,85 @@ const FREE_STATUS: SubscriptionStatus = {
   subscriptionStatus: 'none',
 };
 
-function normalizeUserId(userId: string | undefined): string | undefined {
-  if (typeof userId !== 'string') return undefined;
-  const trimmed = userId.trim();
-  return trimmed.length > 0 ? trimmed : undefined;
-}
-
 export function PolarProvider({ adapter, userId, children }: PolarProviderProps) {
   const [status, setStatus] = useState<SubscriptionStatus>(FREE_STATUS);
   const [loading, setLoading] = useState(true);
+
   const adapterRef = useRef(adapter);
+  const statusRef = useRef({ setStatus, setLoading });
+  const userIdRef = useRef(normalizeUserId(userId));
+  const refreshMountedRef = useRef(true);
+
   adapterRef.current = adapter;
-  const refreshAbortRef = useRef<AbortController | null>(null);
+  statusRef.current = { setStatus, setLoading };
+  userIdRef.current = normalizeUserId(userId);
 
   const refresh = useCallback(async () => {
-    const uid = normalizeUserId(userId);
+    const uid = userIdRef.current;
+    const { setStatus, setLoading } = statusRef.current;
+
     if (!uid) {
       setStatus(FREE_STATUS);
       setLoading(false);
       return;
     }
 
-    refreshAbortRef.current?.abort();
-    const ctrl = new AbortController();
-    refreshAbortRef.current = ctrl;
+    refreshMountedRef.current = true;
 
     try {
       setLoading(true);
       const s = await adapterRef.current.getStatus(uid);
-      if (!ctrl.signal.aborted) setStatus(s);
+      if (refreshMountedRef.current) setStatus(s);
     } catch (err) {
-      if (!ctrl.signal.aborted) {
+      if (refreshMountedRef.current) {
         console.error('[polar-billing] getStatus failed:', err);
         setStatus(FREE_STATUS);
       }
     } finally {
-      if (!ctrl.signal.aborted) setLoading(false);
+      if (refreshMountedRef.current) setLoading(false);
     }
-  }, [userId]);
+  }, []);
 
   useEffect(() => {
+    refreshMountedRef.current = true;
     refresh();
-    return () => { refreshAbortRef.current?.abort(); };
-  }, [refresh]);
+    return () => { refreshMountedRef.current = false; };
+  }, [userId]);
 
   const startCheckout = useCallback(async (params: CheckoutParams) => {
-    const uid = normalizeUserId(userId);
-    const result = await adapterRef.current.createCheckout({ ...params, userId: uid });
-    if (!result.url.startsWith('https://')) {
-      throw new Error('[polar-billing] Invalid checkout URL returned: URL must start with https://');
+    if (!isValidProductId(params.productId)) {
+      throw new Error('[polar-billing] Invalid productId: must be a non-empty string');
     }
+
+    const uid = userIdRef.current;
+    const result = await adapterRef.current.createCheckout({ ...params, userId: uid ?? undefined });
+
+    if (!isValidCheckoutUrl(result.url)) {
+      throw new Error('[polar-billing] Invalid checkout URL returned: URL must start with https:// or http://');
+    }
+
+    if (isProductionInsecureUrl(result.url)) {
+      console.warn('[polar-billing] WARNING: Using insecure http:// URL in production environment');
+    }
+
     window.location.href = result.url;
-  }, [userId]);
+  }, []);
 
   const syncSubscription = useCallback(async (): Promise<SyncResult> => {
-    const uid = normalizeUserId(userId);
+    const uid = userIdRef.current;
     if (!uid) return { synced: false };
 
     const checkoutId = new URLSearchParams(window.location.search).get('checkout_id') ?? undefined;
     const result = await adapterRef.current.syncSubscription(uid, checkoutId);
     if (result.synced) await refresh();
     return result;
-  }, [userId, refresh]);
+  }, [refresh]);
 
   const getBillingHistory = useCallback(async (): Promise<OrderItem[]> => {
-    const uid = normalizeUserId(userId);
+    const uid = userIdRef.current;
     if (!uid) return [];
     return adapterRef.current.getBillingHistory(uid);
-  }, [userId]);
+  }, []);
 
   const cancelSubscription = useCallback(
     async (reason?: CancellationReason): Promise<CancelResult> => {
@@ -112,10 +119,10 @@ export function PolarProvider({ adapter, userId, children }: PolarProviderProps)
   );
 
   const getPortalUrl = useCallback(async (): Promise<string> => {
-    const uid = normalizeUserId(userId);
+    const uid = userIdRef.current;
     if (!uid) throw new Error('[polar-billing] Cannot get portal URL: No authenticated user');
     return adapterRef.current.getPortalUrl(uid);
-  }, [userId]);
+  }, []);
 
   const value = useMemo(
     () => ({
@@ -128,7 +135,7 @@ export function PolarProvider({ adapter, userId, children }: PolarProviderProps)
       cancelSubscription,
       getPortalUrl,
     }),
-    [status, loading, refresh, startCheckout, syncSubscription, getBillingHistory, cancelSubscription, getPortalUrl],
+    [status, loading, refresh, syncSubscription],
   );
 
   return <PolarContext.Provider value={value}>{children}</PolarContext.Provider>;

package/src/presentation/hooks/usePolarBilling.ts

@@ -21,10 +21,6 @@ export interface PolarContextValue {
 
 export const PolarContext = createContext<PolarContextValue | undefined>(undefined);
 
-/**
- * usePolarBilling Hook
- * @description Hook to access Polar billing context
- */
 export function usePolarBilling(): PolarContextValue {
   const ctx = useContext(PolarContext);
   if (!ctx) throw new Error('usePolarBilling must be used within <PolarProvider>');

package/src/presentation/index.ts

@@ -1,7 +1,2 @@
-/**
- * Presentation Layer
- * Subpath: @umituz/web-polar-payment/presentation
- */
-
 export * from './components/PolarProvider';
 export * from './hooks/usePolarBilling';