@umituz/web-localization 1.1.5 → 1.1.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/web-localization",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "description": "Google Translate integrated localization package for web applications",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/domain/interfaces/translation-service.interface.ts

@@ -9,7 +9,6 @@ import type {
  */
 export interface TranslationServiceConfig {
   minDelay?: number;
-  maxRetries?: number;
   timeout?: number;
   apiKey?: string; // Optional if using public API
 }

package/src/infrastructure/constants/index.ts

@@ -12,6 +12,6 @@ export const DEFAULT_LOCALES_DIR = "src/locales";
 export const DEFAULT_SOURCE_DIR = "src";
 export const DEFAULT_BASE_LANGUAGE = "en-US";
 
-// Rate limiter defaults
-export const RATE_LIMIT_DEFAULT_DELAY = 100;
-export const RATE_LIMIT_MIN_DELAY = 0;
+// Translation batch settings
+export const TRANSLATION_BATCH_SIZE = 50;
+export const TRANSLATION_CONCURRENCY_LIMIT = 10;

package/src/infrastructure/services/cli.service.ts

@@ -129,6 +129,8 @@ export class CLIService {
       if (stats.successCount > 0) {
         fs.writeFileSync(targetPath, generateTypeScriptContent(targetData, langCode));
         console.log(chalk.green(`   ✅ Successfully translated ${stats.successCount} keys.`));
+      } else if (stats.failureCount > 0) {
+        console.log(chalk.red(`   ❌ Failed to translate ${stats.failureCount} keys.`));
       } else {
         console.log(chalk.gray("   ✨ Already up to date."));
       }

package/src/infrastructure/services/google-translate.service.ts

@@ -23,6 +23,8 @@ import {
   DEFAULT_MIN_DELAY,
   DEFAULT_TIMEOUT,
   DEFAULT_MAX_RETRIES,
+  TRANSLATION_BATCH_SIZE,
+  TRANSLATION_CONCURRENCY_LIMIT,
 } from "../constants/index.js";
 
 class GoogleTranslateService implements ITranslationService {
@@ -127,11 +129,10 @@ class GoogleTranslateService implements ITranslationService {
     }
 
     // Process requests concurrently with controlled parallelism
-    const concurrencyLimit = 10;
     const chunks: TranslationRequest[][] = [];
 
-    for (let i = 0; i < requests.length; i += concurrencyLimit) {
-      chunks.push(requests.slice(i, i + concurrencyLimit));
+    for (let i = 0; i < requests.length; i += TRANSLATION_CONCURRENCY_LIMIT) {
+      chunks.push(requests.slice(i, i + TRANSLATION_CONCURRENCY_LIMIT));
     }
 
     for (const chunk of chunks) {
@@ -213,7 +214,7 @@ class GoogleTranslateService implements ITranslationService {
         );
       } else if (typeof enValue === "string") {
         stats.totalCount++;
-        if (force || needsTranslation(targetValue, enValue)) {
+        if (force || needsTranslation(targetValue)) {
           textsToTranslate.push({key, enValue, currentPath});
         } else {
           stats.skippedCount++;
@@ -222,9 +223,8 @@ class GoogleTranslateService implements ITranslationService {
     }
 
     if (textsToTranslate.length > 0) {
-      const batchSize = 50;
-      for (let i = 0; i < textsToTranslate.length; i += batchSize) {
-        const batch = textsToTranslate.slice(i, i + batchSize);
+      for (let i = 0; i < textsToTranslate.length; i += TRANSLATION_BATCH_SIZE) {
+        const batch = textsToTranslate.slice(i, i + TRANSLATION_BATCH_SIZE);
         const results = await this.translateBatch(
           batch.map(item => ({
             text: item.enValue,
@@ -324,7 +324,7 @@ class GoogleTranslateService implements ITranslationService {
         return translatedStr;
       } catch (error) {
         clearTimeout(timeoutId);
-        if (attempt === retries) {
+        if (attempt === retries - 1) {
           throw error;
         }
         const delay = backoffMs * Math.pow(2, attempt);

package/src/infrastructure/utils/rate-limit.util.ts

@@ -3,13 +3,13 @@
  * @description Controls the frequency of API requests
  */
 
-import { RATE_LIMIT_DEFAULT_DELAY } from "../constants/index.js";
+import { DEFAULT_MIN_DELAY } from "../constants/index.js";
 
 export class RateLimiter {
   private lastRequestTime = 0;
   private readonly minDelay: number;
 
-  constructor(minDelay = RATE_LIMIT_DEFAULT_DELAY) {
+  constructor(minDelay = DEFAULT_MIN_DELAY) {
     if (minDelay < 0) {
       throw new Error("minDelay must be non-negative");
     }

package/src/infrastructure/utils/text-validator.util.ts

@@ -4,7 +4,6 @@
 
 // Default words/patterns to skip during translation
 const DEFAULT_SKIPLIST = ["@umituz"] as const;
-const skiplist = [...DEFAULT_SKIPLIST];
 
 /**
  * Validates if the text is suitable for translation
@@ -20,15 +19,14 @@ export function isValidText(text: unknown): text is string {
  * Checks if a word should be skipped (e.g., proper nouns, symbols)
  */
 export function shouldSkipWord(text: string): boolean {
-  return skiplist.some(word => text.includes(word));
+  return DEFAULT_SKIPLIST.some(word => text.includes(word));
 }
 
 /**
  * Determines if a key needs translation
  */
-export function needsTranslation(targetValue: unknown, _sourceValue: string): boolean {
+export function needsTranslation(targetValue: unknown): boolean {
   if (typeof targetValue !== "string") return true;
   if (targetValue.length === 0) return true; // Empty string means untranslated
-  // Do NOT return true if target === source anymore, to avoid infinite translations for words that are identical in both languages
   return false;
 }