@umituz/react-native-subscription 2.37.36 → 2.37.38

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-subscription",
-  "version": "2.37.36",
+  "version": "2.37.38",
   "description": "Complete subscription management with RevenueCat, paywall UI, and credits system for React Native apps",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/domains/credits/application/CreditsInitializer.ts

@@ -7,6 +7,7 @@ import { getCreditDocumentOrDefault } from "./creditDocumentHelpers";
 import { calculateNewCredits, buildCreditsData, shouldSkipStatusSyncWrite } from "./creditOperationUtils";
 import { calculateCreditLimit } from "./CreditLimitCalculator";
 import { generatePurchaseMetadata } from "./PurchaseMetadataGenerator";
+import { PURCHASE_ID_PREFIXES } from "../core/CreditsConstants";
 
 export async function initializeCreditsTransaction(
     _db: Firestore,
@@ -21,6 +22,18 @@ export async function initializeCreditsTransaction(
 
     return runTransaction(async (transaction: Transaction) => {
         const creditsDoc = await transaction.get(creditsRef);
+
+        // Status sync must NEVER create new documents.
+        // Credits documents are only created by purchase/renewal flows.
+        const isStatusSync = purchaseId.startsWith(PURCHASE_ID_PREFIXES.STATUS_SYNC);
+        if (isStatusSync && !creditsDoc.exists()) {
+            return {
+                credits: 0,
+                alreadyProcessed: true,
+                finalData: null
+            };
+        }
+
         const existingData = getCreditDocumentOrDefault(creditsDoc, platform);
 
         if (existingData.processedPurchases.includes(purchaseId)) {

package/src/domains/credits/application/credit-strategies/SyncCreditStrategy.ts

@@ -1,8 +1,9 @@
 import { ICreditStrategy, type CreditAllocationParams } from "./ICreditStrategy";
 
 /**
- * Strategy for existing premium users during a simple status synchronization.
- * Preserves their current credits to avoid accidental resets.
+ * Strategy for status synchronization (app open, auth state changes).
+ * ONLY preserves existing credits. NEVER allocates new credits.
+ * New credits are ONLY allocated by purchase and renewal flows.
  */
 export class SyncCreditStrategy implements ICreditStrategy {
     canHandle(params: CreditAllocationParams): boolean {
@@ -10,18 +11,14 @@ export class SyncCreditStrategy implements ICreditStrategy {
     }
 
     execute(params: CreditAllocationParams): number {
+        // Status sync only preserves existing credits, never allocates new ones
         const existingCredits = params.existingData?.credits;
-        const hasExistingCredits = typeof existingCredits === 'number' && existingCredits >= 0;
-        const hasExistingDocument = (params.existingData?.processedPurchases?.length ?? 0) > 0;
-
-        if (params.isSubscriptionActive && !hasExistingDocument) {
-            return params.creditLimit;
-        }
-
-        if (hasExistingCredits && params.existingData) {
-            return params.existingData.credits;
+        if (typeof existingCredits === 'number' && existingCredits >= 0) {
+            return existingCredits;
         }
 
-        return params.creditLimit;
+        // No existing credits = no document = return 0
+        // Credits are only allocated through purchase/renewal flows
+        return 0;
     }
 }

package/src/domains/credits/infrastructure/operations/CreditsWriter.ts

@@ -8,6 +8,6 @@ export async function syncExpiredStatus(ref: DocumentReference): Promise<void> {
     isPremium: false,
     status: SUBSCRIPTION_STATUS.EXPIRED,
     willRenew: false,
-    expirationDate: serverTimestamp(),
+    lastUpdatedAt: serverTimestamp(),
   }, { merge: true });
 }

package/src/domains/credits/presentation/deduct-credit/mutationConfig.ts

@@ -3,7 +3,7 @@ import { timezoneService } from "@umituz/react-native-design-system";
 import type { UserCredits, DeductCreditsResult } from "../../core/Credits";
 import type { CreditsRepository } from "../../infrastructure/CreditsRepository";
 import { creditsQueryKeys } from "../creditsQueryKeys";
-import { calculateRemaining } from "../../../../shared/utils/numberUtils";
+import { calculateRemaining } from "../../../../shared/utils/numberUtils.core";
 
 export interface MutationContext {
   previousCredits: UserCredits | null;

package/src/domains/subscription/application/SubscriptionSyncProcessor.ts

@@ -5,8 +5,7 @@ import { getCreditsRepository } from "../../credits/infrastructure/CreditsReposi
 import { extractRevenueCatData } from "./SubscriptionSyncUtils";
 import { emitCreditsUpdated } from "./syncEventEmitter";
 import { generatePurchaseId, generateRenewalId } from "./syncIdGenerators";
-import { handleExpiredSubscription, handleFreeUserInitialization, handlePremiumStatusSync } from "./statusChangeHandlers";
-import { NO_SUBSCRIPTION_PRODUCT_ID } from "./syncConstants";
+import { handleExpiredSubscription, handlePremiumStatusSync } from "./statusChangeHandlers";
 import type { PackageType } from "../../revenuecat/core/types";
 
 export class SubscriptionSyncProcessor {
@@ -76,17 +75,21 @@ export class SubscriptionSyncProcessor {
       return;
     }
 
-    // Free user case
+    // Free user case - no Firestore document needed
+    // Credits absence means no subscription (app handles null gracefully)
     if (!isPremium && !productId) {
-      await handleFreeUserInitialization(creditsUserId);
       return;
     }
 
-    // Premium user case
+    // Premium user case - productId is required
+    if (!productId) {
+      return;
+    }
+
     await handlePremiumStatusSync(
       creditsUserId,
       isPremium,
-      productId ?? NO_SUBSCRIPTION_PRODUCT_ID,
+      productId,
       expiresAt ?? null,
       willRenew ?? false,
       periodType ?? null

package/src/domains/subscription/application/statusChangeHandlers.ts

@@ -3,27 +3,13 @@ import type { PeriodType } from "../core/SubscriptionConstants";
 import { PURCHASE_SOURCE, PURCHASE_TYPE } from "../core/SubscriptionConstants";
 import { getCreditsRepository } from "../../credits/infrastructure/CreditsRepositoryManager";
 import { emitCreditsUpdated } from "./syncEventEmitter";
-import { generateInitSyncId, generateStatusSyncId } from "./syncIdGenerators";
-import { NO_SUBSCRIPTION_PRODUCT_ID, DEFAULT_FREE_USER_DATA } from "./syncConstants";
+import { generateStatusSyncId } from "./syncIdGenerators";
 
 export const handleExpiredSubscription = async (userId: string): Promise<void> => {
   await getCreditsRepository().syncExpiredStatus(userId);
   emitCreditsUpdated(userId);
 };
 
-export const handleFreeUserInitialization = async (userId: string): Promise<void> => {
-  const stableSyncId = generateInitSyncId(userId);
-  await getCreditsRepository().initializeCredits(
-    userId,
-    stableSyncId,
-    NO_SUBSCRIPTION_PRODUCT_ID,
-    PURCHASE_SOURCE.SETTINGS,
-    DEFAULT_FREE_USER_DATA,
-    PURCHASE_TYPE.INITIAL
-  );
-  emitCreditsUpdated(userId);
-};
-
 export const handlePremiumStatusSync = async (
   userId: string,
   isPremium: boolean,

package/src/domains/subscription/application/syncConstants.ts

@@ -1,16 +1 @@
-import type { RevenueCatData } from "../../revenuecat/core/types";
-
 export const NO_SUBSCRIPTION_PRODUCT_ID = 'no_subscription';
-
-export const DEFAULT_FREE_USER_DATA: RevenueCatData = {
-  isPremium: false,
-  expirationDate: null,
-  willRenew: false,
-  periodType: null,
-  packageType: null,
-  originalTransactionId: null,
-  unsubscribeDetectedAt: null,
-  billingIssueDetectedAt: null,
-  store: null,
-  ownershipType: null,
-};

package/src/domains/subscription/application/syncIdGenerators.ts

@@ -10,10 +10,6 @@ export const generateRenewalId = (originalTransactionId: string | null, productI
     : `renewal_${productId}_${Date.now()}`;
 };
 
-export const generateInitSyncId = (userId: string): string => {
-  return `init_sync_${userId}`;
-};
-
 export const generateStatusSyncId = (userId: string, isPremium: boolean): string => {
   return `status_sync_${userId}_${isPremium ? 'premium' : 'free'}`;
 };

package/src/shared/utils/numberUtils.ts

@@ -1 +0,0 @@
-export { calculateRemaining } from "./numberUtils.core";