@umituz/react-native-settings 5.3.42 → 5.3.44

package/dist/account.d.ts

@@ -6,7 +6,7 @@
  *
  * Usage:
  *   import {
- *     useSettingsScreenConfigWithAuth,
+ *     useSettingsScreenConfig,
  *     AccountScreen,
  *     ProfileSection,
  *   } from '@umituz/react-native-settings/account';
@@ -22,6 +22,5 @@ export { AccountScreen, ProfileSection } from "@umituz/react-native-auth";
 export { useAuth, useUserProfile, useAuthHandlers } from "@umituz/react-native-auth";
 export type { AccountScreenConfig } from "@umituz/react-native-auth";
 export { useSettingsScreenConfig } from './presentation/hooks/useSettingsScreenConfig';
-export { useSettingsScreenConfig as useSettingsScreenConfigWithAuth } from './presentation/hooks/useSettingsScreenConfig';
 export type { UseSettingsScreenConfigParams, SettingsScreenConfigResult, SettingsFeatures, } from './presentation/hooks/useSettingsScreenConfig';
 export type { AccountConfig } from './presentation/navigation/types';

package/dist/domains/feedback/domain/entities/FeatureRequestEntity.d.ts

@@ -18,13 +18,3 @@ export interface FeatureRequestItem {
     createdAt: string;
     updatedAt: string;
 }
-export interface FeatureRequestVote {
-    type: VoteType;
-    votedAt: string;
-}
-export interface FeatureRequestSubmitData {
-    title: string;
-    description: string;
-    type: string;
-    rating?: number;
-}

package/dist/domains/feedback/domain/entities/FeedbackEntity.d.ts

@@ -2,24 +2,4 @@
  * Feedback Entity
  */
 export type FeedbackType = 'general' | 'bug_report' | 'feature_request' | 'improvement' | 'other';
-export type FeedbackStatus = 'pending' | 'reviewed' | 'resolved' | 'closed';
 export type FeedbackRating = 1 | 2 | 3 | 4 | 5;
-export interface FeedbackEntity {
-    id: string;
-    userId: string | null;
-    userEmail?: string | null;
-    type: FeedbackType;
-    title: string;
-    description: string;
-    rating?: FeedbackRating;
-    status: FeedbackStatus;
-    deviceInfo?: {
-        platform: string;
-        osVersion: string;
-        appVersion: string;
-    };
-    metadata?: Record<string, unknown>;
-    createdAt: string;
-    updatedAt: string;
-}
-export declare function createFeedback(userId: string | null, type: FeedbackType, title: string, description: string, userEmail?: string | null, rating?: FeedbackRating, deviceInfo?: FeedbackEntity['deviceInfo'], metadata?: Record<string, unknown>): Omit<FeedbackEntity, 'id'>;

package/dist/domains/feedback/index.d.ts

@@ -8,4 +8,3 @@ export * from './presentation/components/SupportSection';
 export * from './presentation/hooks/useFeedbackForm';
 export * from './domain/entities/FeedbackEntity';
 export * from './domain/entities/FeatureRequestEntity';
-export * from './domain/repositories/IFeedbackRepository';

package/dist/presentation/utils/index.d.ts

@@ -4,5 +4,4 @@
 export * from "./config-creators";
 export * from "./userProfileUtils";
 export * from "./accountConfigUtils";
-export * from "./faqTranslator";
 export * from "./settingsConfigFactory";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-settings",
-  "version": "5.3.42",
+  "version": "5.3.44",
   "description": "Complete settings hub for React Native apps - consolidated package with settings, localization, about, legal, appearance, feedback, FAQs, rating, and gamification",
   "main": "./src/index.ts",
   "types": "./dist/index.d.ts",

package/src/account.ts

@@ -6,7 +6,7 @@
  *
  * Usage:
  *   import {
- *     useSettingsScreenConfigWithAuth,
+ *     useSettingsScreenConfig,
  *     AccountScreen,
  *     ProfileSection,
  *   } from '@umituz/react-native-settings/account';
@@ -31,9 +31,6 @@ export type { AccountScreenConfig } from "@umituz/react-native-auth";
 // Base hook (already handles auth internally via useAuth/useUserProfile/useAuthHandlers)
 export { useSettingsScreenConfig } from './presentation/hooks/useSettingsScreenConfig';
 
-// Alias for clarity - useSettingsScreenConfig already includes auth
-export { useSettingsScreenConfig as useSettingsScreenConfigWithAuth } from './presentation/hooks/useSettingsScreenConfig';
-
 // Re-export types
 export type {
   UseSettingsScreenConfigParams,

package/src/domains/feedback/README.md

@@ -16,7 +16,7 @@ Provides components and utilities for collecting user feedback including feedbac
 
 **Domain:**
 - `/Users/umituz/Desktop/github/umituz/apps/artificial_intelligence/npm-packages/react-native-settings/src/domains/feedback/domain/entities/FeedbackEntity.ts`
-- `/Users/umituz/Desktop/github/umituz/apps/artificial_intelligence/npm-packages/react-native-settings/src/domains/feedback/domain/repositories/IFeedbackRepository.ts`
+- `/Users/umituz/Desktop/github/umituz/apps/artificial_intelligence/npm-packages/react-native-settings/src/domains/feedback/domain/entities/FeatureRequestEntity.ts`
 
 **Index:**
 - `/Users/umituz/Desktop/github/umituz/apps/artificial_intelligence/npm-packages/react-native-settings/src/domains/feedback/index.ts`
@@ -26,14 +26,12 @@ Provides components and utilities for collecting user feedback including feedbac
 1. **Form State Management**: Use useFeedbackForm hook for centralized form state and validation
 2. **Type Categorization**: Categorize feedback by type (bug, feature, general, etc.) for better routing
 3. **Star Rating Integration**: Integrate with Rating domain for 1-5 star ratings
-4. **Repository Pattern**: Use IFeedbackRepository interface for abstracted feedback submission
-5. **Validation First**: Always validate form state before submission to prevent invalid data
+4. **Validation First**: Always validate form state before submission to prevent invalid data
 
 ## Restrictions (Forbidden)
 
 ### DO NOT
 - ❌ DO NOT submit feedback without validating required fields (type, title)
-- ❌ DO NOT bypass the repository pattern when submitting feedback
 - ❌ DO NOT use FeedbackForm without providing texts configuration
 - ❌ DO NOT handle feedback submission manually when the hook provides everything needed
 

package/src/domains/feedback/domain/entities/FeatureRequestEntity.ts

@@ -21,15 +21,3 @@ export interface FeatureRequestItem {
   createdAt: string;
   updatedAt: string;
 }
-
-export interface FeatureRequestVote {
-  type: VoteType;
-  votedAt: string;
-}
-
-export interface FeatureRequestSubmitData {
-  title: string;
-  description: string;
-  type: string;
-  rating?: number;
-}

package/src/domains/feedback/domain/entities/FeedbackEntity.ts

@@ -9,51 +9,4 @@ export type FeedbackType =
   | 'improvement'
   | 'other';
 
-export type FeedbackStatus = 'pending' | 'reviewed' | 'resolved' | 'closed';
-
 export type FeedbackRating = 1 | 2 | 3 | 4 | 5;
-
-export interface FeedbackEntity {
-  id: string;
-  userId: string | null;
-  userEmail?: string | null;
-  type: FeedbackType;
-  title: string;
-  description: string;
-  rating?: FeedbackRating;
-  status: FeedbackStatus;
-  deviceInfo?: {
-    platform: string;
-    osVersion: string;
-    appVersion: string;
-  };
-  metadata?: Record<string, unknown>;
-  createdAt: string;
-  updatedAt: string;
-}
-
-export function createFeedback(
-  userId: string | null,
-  type: FeedbackType,
-  title: string,
-  description: string,
-  userEmail?: string | null,
-  rating?: FeedbackRating,
-  deviceInfo?: FeedbackEntity['deviceInfo'],
-  metadata?: Record<string, unknown>
-): Omit<FeedbackEntity, 'id'> {
-  const now = new Date().toISOString();
-  return {
-    userId,
-    userEmail,
-    type,
-    title,
-    description,
-    rating,
-    status: 'pending',
-    deviceInfo,
-    metadata,
-    createdAt: now,
-    updatedAt: now,
-  };
-}

package/src/domains/feedback/index.ts

@@ -9,4 +9,3 @@ export * from './presentation/components/SupportSection';
 export * from './presentation/hooks/useFeedbackForm';
 export * from './domain/entities/FeedbackEntity';
 export * from './domain/entities/FeatureRequestEntity';
-export * from './domain/repositories/IFeedbackRepository';

package/src/domains/feedback/infrastructure/useFeatureRequests.ts

@@ -4,7 +4,7 @@
  * Works with both authenticated and anonymous users
  */
 
-import { useState, useEffect, useCallback } from "react";
+import { useState, useEffect, useCallback, useRef } from "react";
 import { Platform } from "react-native";
 import { useAuth } from "@umituz/react-native-auth";
 import {
@@ -48,6 +48,13 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
   const [userVotes, setUserVotes] = useState<Record<string, VoteType>>({});
   const [isLoading, setIsLoading] = useState(true);
 
+  // Ref to avoid stale closure in vote()
+  const userVotesRef = useRef(userVotes);
+  userVotesRef.current = userVotes;
+
+  // Guard against rapid double-tap on the same request
+  const votingInProgress = useRef(new Set<string>());
+
   const fetchAll = useCallback(async () => {
     const db = getFirestore();
     if (!db) {
@@ -58,7 +65,6 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
     try {
       setIsLoading(true);
 
-      // Fetch requests
       const q = query(collection(db, COLLECTION), orderBy("votes", "desc"));
       const snapshot = await getDocs(q);
 
@@ -82,17 +88,25 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
 
       setRequests(items);
 
-      // Fetch user votes
-      if (userId) {
-        const votes: Record<string, VoteType> = {};
-        for (const reqDoc of snapshot.docs) {
+      // Fetch user votes in parallel (not N+1 sequential)
+      if (userId && snapshot.docs.length > 0) {
+        const votePromises = snapshot.docs.map(async (reqDoc) => {
           const voteRef = doc(db, COLLECTION, reqDoc.id, "votes", userId);
           const voteSnap = await getDoc(voteRef);
           if (voteSnap.exists()) {
-            votes[reqDoc.id] = voteSnap.data().type as VoteType;
+            return [reqDoc.id, voteSnap.data().type as VoteType] as const;
           }
+          return null;
+        });
+
+        const results = await Promise.all(votePromises);
+        const votes: Record<string, VoteType> = {};
+        for (const result of results) {
+          if (result) votes[result[0]] = result[1];
         }
         setUserVotes(votes);
+      } else {
+        setUserVotes({});
       }
     } catch (error) {
       if (__DEV__) console.warn("[useFeatureRequests] Load failed:", error);
@@ -108,10 +122,18 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
   const vote = useCallback(async (requestId: string, type: VoteType) => {
     if (!userId) return;
 
+    // Prevent rapid double-tap on the same request
+    if (votingInProgress.current.has(requestId)) return;
+    votingInProgress.current.add(requestId);
+
     const db = getFirestore();
-    if (!db) return;
+    if (!db) {
+      votingInProgress.current.delete(requestId);
+      return;
+    }
 
-    const previousVote = userVotes[requestId];
+    // Read latest vote from ref (not stale closure)
+    const previousVote = userVotesRef.current[requestId] as VoteType | undefined;
     const isUndo = previousVote === type;
 
     // Optimistic UI
@@ -150,23 +172,26 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
         await updateDoc(requestRef, { votes: increment(type === "up" ? 1 : -1) });
       }
     } catch (error) {
-      // Rollback
       if (__DEV__) console.warn("[useFeatureRequests] Vote failed:", error);
+      // Rollback using previous known state
       setUserVotes((prev) => {
         const next = { ...prev };
         if (previousVote) next[requestId] = previousVote; else delete next[requestId];
         return next;
       });
       fetchAll();
+    } finally {
+      votingInProgress.current.delete(requestId);
     }
-  }, [userId, userVotes, fetchAll]);
+  }, [userId, fetchAll]);
 
   const submitRequest = useCallback(async (data: { title: string; description: string; type: string; rating?: number }) => {
     const db = getFirestore();
     if (!db) throw new Error("Firestore not available");
     if (!userId) throw new Error("User not authenticated");
 
-    await addDoc(collection(db, COLLECTION), {
+    // Create the feature request
+    const docRef = await addDoc(collection(db, COLLECTION), {
       title: data.title,
       description: data.description,
       type: data.type || "feature_request",
@@ -181,6 +206,12 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
       updatedAt: serverTimestamp(),
     });
 
+    // Create the creator's upvote doc so votes count matches reality
+    await setDoc(doc(db, COLLECTION, docRef.id, "votes", userId), {
+      type: "up" as VoteType,
+      votedAt: serverTimestamp(),
+    });
+
     await fetchAll();
   }, [userId, user?.isAnonymous, fetchAll]);
 

package/src/domains/feedback/presentation/screens/FeatureRequestScreen.tsx

@@ -4,13 +4,11 @@ import {
   StyleSheet,
   TouchableOpacity,
   ScrollView,
-  FlatList,
   ActivityIndicator,
 } from "react-native";
 import {
   AtomicText,
   AtomicIcon,
-  AtomicButton,
 } from "@umituz/react-native-design-system/atoms";
 import { useAppDesignTokens } from "@umituz/react-native-design-system/theme";
 import { ScreenLayout } from "@umituz/react-native-design-system/layouts";
@@ -47,10 +45,6 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
     dismissed: t.status?.dismissed || "Dismissed",
   };
 
-  const handleVote = useCallback(async (id: string, type: VoteType) => {
-    await vote(id, type);
-  }, [vote]);
-
   const handleSubmit = useCallback(async (data: any) => {
     setIsSubmitting(true);
     try {
@@ -90,19 +84,19 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
     }
   })();
 
-  const renderRequestItem = ({ item }: { item: FeatureRequestItem }) => {
+  const renderRequestCard = (item: FeatureRequestItem) => {
     const voted = userVotes[item.id] || null;
 
     return (
-      <View style={[styles.card, { backgroundColor: tokens.colors.surfaceSecondary, borderColor: tokens.colors.borderLight }]}>
+      <View key={item.id} style={[styles.card, { backgroundColor: tokens.colors.surfaceSecondary, borderColor: tokens.colors.borderLight }]}>
         <View style={styles.voteColumn}>
-          <TouchableOpacity onPress={() => handleVote(item.id, 'up')}>
+          <TouchableOpacity onPress={() => vote(item.id, 'up')}>
             <AtomicIcon name="chevron-up" size="md" color={voted === 'up' ? "primary" : "textSecondary" as any} />
           </TouchableOpacity>
           <AtomicText style={[styles.voteCount, { color: voted === 'up' ? tokens.colors.primary : tokens.colors.textPrimary }]}>
             {item.votes}
           </AtomicText>
-          <TouchableOpacity onPress={() => handleVote(item.id, 'down')}>
+          <TouchableOpacity onPress={() => vote(item.id, 'down')}>
             <AtomicIcon name="chevron-down" size="md" color={voted === 'down' ? "primary" : "textSecondary" as any} />
           </TouchableOpacity>
         </View>
@@ -196,13 +190,9 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
             </AtomicText>
           </View>
         ) : (
-          <FlatList
-            data={filteredRequests}
-            renderItem={renderRequestItem}
-            keyExtractor={item => item.id}
-            scrollEnabled={false}
-            contentContainerStyle={styles.listContent}
-          />
+          <View style={styles.listContent}>
+            {filteredRequests.map(renderRequestCard)}
+          </View>
         )}
       </ScrollView>
 

package/src/presentation/hooks/useSettingsScreenConfig.ts

@@ -10,7 +10,6 @@ import { useMemo } from "react";
 import { useAuth, useUserProfile, useAuthHandlers } from "@umituz/react-native-auth";
 import { createUserProfileDisplay } from "../utils/userProfileUtils";
 import { createAccountConfig } from "../utils/accountConfigUtils";
-import { translateFAQData } from "../utils/faqTranslator";
 import { useSettingsConfigFactory } from "../utils/settingsConfigFactory";
 import type { SettingsConfig, SettingsTranslations } from "../screens/types";
 import type { FeedbackFormData } from "../utils/config-creators";
@@ -151,16 +150,11 @@ export const useSettingsScreenConfig = (
     translations: translations?.account as any,
   }), [user, userProfileData, handleSignIn, handleSignOut, handleDeleteAccount, translations]);
 
-  const translatedFaqData = useMemo(() =>
-    translateFAQData(faqData, appInfo),
-    [faqData, appInfo]
-  );
-
   return {
     settingsConfig,
     userProfile,
     accountConfig,
-    translatedFaqData,
+    translatedFaqData: faqData,
     isLoading: loading,
     isAuthReady,
   };

package/src/presentation/utils/index.ts

@@ -5,5 +5,4 @@
 export * from "./config-creators";
 export * from "./userProfileUtils";
 export * from "./accountConfigUtils";
-export * from "./faqTranslator";
 export * from "./settingsConfigFactory";

package/src/domains/feedback/domain/repositories/IFeedbackRepository.ts

@@ -1,28 +0,0 @@
-/**
- * Feedback Repository Interface
- */
-
-import type { FeedbackEntity } from '../entities/FeedbackEntity';
-
-export interface FeedbackError {
-  message: string;
-  code?: 'SUBMIT_FAILED' | 'FETCH_FAILED' | 'DELETE_FAILED' | 'VALIDATION_ERROR';
-}
-
-export type FeedbackResult<T> =
-  | {
-      success: true;
-      data: T;
-    }
-  | {
-      success: false;
-      error: FeedbackError;
-    };
-
-export interface IFeedbackRepository {
-  submitFeedback(
-    feedback: FeedbackEntity | Omit<FeedbackEntity, 'id'>
-  ): Promise<FeedbackResult<FeedbackEntity>>;
-  getUserFeedback(userId: string): Promise<FeedbackResult<FeedbackEntity[]>>;
-  deleteFeedback(feedbackId: string): Promise<FeedbackResult<boolean>>;
-}

package/src/presentation/utils/faqTranslator.ts

@@ -1,9 +0,0 @@
-import type { FAQData } from "../navigation/types";
-import type { AppInfo } from "../navigation/types";
-
-export const translateFAQData = (
-  faqData: FAQData | undefined,
-  _appInfo: AppInfo
-): FAQData | undefined => {
-  return faqData;
-};