@umituz/react-native-settings 5.3.42 → 5.3.43

package/dist/domains/feedback/domain/entities/FeatureRequestEntity.d.ts

@@ -18,13 +18,3 @@ export interface FeatureRequestItem {
     createdAt: string;
     updatedAt: string;
 }
-export interface FeatureRequestVote {
-    type: VoteType;
-    votedAt: string;
-}
-export interface FeatureRequestSubmitData {
-    title: string;
-    description: string;
-    type: string;
-    rating?: number;
-}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-settings",
-  "version": "5.3.42",
+  "version": "5.3.43",
   "description": "Complete settings hub for React Native apps - consolidated package with settings, localization, about, legal, appearance, feedback, FAQs, rating, and gamification",
   "main": "./src/index.ts",
   "types": "./dist/index.d.ts",

package/src/domains/feedback/domain/entities/FeatureRequestEntity.ts

@@ -21,15 +21,3 @@ export interface FeatureRequestItem {
   createdAt: string;
   updatedAt: string;
 }
-
-export interface FeatureRequestVote {
-  type: VoteType;
-  votedAt: string;
-}
-
-export interface FeatureRequestSubmitData {
-  title: string;
-  description: string;
-  type: string;
-  rating?: number;
-}

package/src/domains/feedback/infrastructure/useFeatureRequests.ts

@@ -4,7 +4,7 @@
  * Works with both authenticated and anonymous users
  */
 
-import { useState, useEffect, useCallback } from "react";
+import { useState, useEffect, useCallback, useRef } from "react";
 import { Platform } from "react-native";
 import { useAuth } from "@umituz/react-native-auth";
 import {
@@ -48,6 +48,13 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
   const [userVotes, setUserVotes] = useState<Record<string, VoteType>>({});
   const [isLoading, setIsLoading] = useState(true);
 
+  // Ref to avoid stale closure in vote()
+  const userVotesRef = useRef(userVotes);
+  userVotesRef.current = userVotes;
+
+  // Guard against rapid double-tap on the same request
+  const votingInProgress = useRef(new Set<string>());
+
   const fetchAll = useCallback(async () => {
     const db = getFirestore();
     if (!db) {
@@ -58,7 +65,6 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
     try {
       setIsLoading(true);
 
-      // Fetch requests
       const q = query(collection(db, COLLECTION), orderBy("votes", "desc"));
       const snapshot = await getDocs(q);
 
@@ -82,17 +88,25 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
 
       setRequests(items);
 
-      // Fetch user votes
-      if (userId) {
-        const votes: Record<string, VoteType> = {};
-        for (const reqDoc of snapshot.docs) {
+      // Fetch user votes in parallel (not N+1 sequential)
+      if (userId && snapshot.docs.length > 0) {
+        const votePromises = snapshot.docs.map(async (reqDoc) => {
           const voteRef = doc(db, COLLECTION, reqDoc.id, "votes", userId);
           const voteSnap = await getDoc(voteRef);
           if (voteSnap.exists()) {
-            votes[reqDoc.id] = voteSnap.data().type as VoteType;
+            return [reqDoc.id, voteSnap.data().type as VoteType] as const;
           }
+          return null;
+        });
+
+        const results = await Promise.all(votePromises);
+        const votes: Record<string, VoteType> = {};
+        for (const result of results) {
+          if (result) votes[result[0]] = result[1];
         }
         setUserVotes(votes);
+      } else {
+        setUserVotes({});
       }
     } catch (error) {
       if (__DEV__) console.warn("[useFeatureRequests] Load failed:", error);
@@ -108,10 +122,18 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
   const vote = useCallback(async (requestId: string, type: VoteType) => {
     if (!userId) return;
 
+    // Prevent rapid double-tap on the same request
+    if (votingInProgress.current.has(requestId)) return;
+    votingInProgress.current.add(requestId);
+
     const db = getFirestore();
-    if (!db) return;
+    if (!db) {
+      votingInProgress.current.delete(requestId);
+      return;
+    }
 
-    const previousVote = userVotes[requestId];
+    // Read latest vote from ref (not stale closure)
+    const previousVote = userVotesRef.current[requestId] as VoteType | undefined;
     const isUndo = previousVote === type;
 
     // Optimistic UI
@@ -150,23 +172,26 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
         await updateDoc(requestRef, { votes: increment(type === "up" ? 1 : -1) });
       }
     } catch (error) {
-      // Rollback
       if (__DEV__) console.warn("[useFeatureRequests] Vote failed:", error);
+      // Rollback using previous known state
       setUserVotes((prev) => {
         const next = { ...prev };
         if (previousVote) next[requestId] = previousVote; else delete next[requestId];
         return next;
       });
       fetchAll();
+    } finally {
+      votingInProgress.current.delete(requestId);
     }
-  }, [userId, userVotes, fetchAll]);
+  }, [userId, fetchAll]);
 
   const submitRequest = useCallback(async (data: { title: string; description: string; type: string; rating?: number }) => {
     const db = getFirestore();
     if (!db) throw new Error("Firestore not available");
     if (!userId) throw new Error("User not authenticated");
 
-    await addDoc(collection(db, COLLECTION), {
+    // Create the feature request
+    const docRef = await addDoc(collection(db, COLLECTION), {
       title: data.title,
       description: data.description,
       type: data.type || "feature_request",
@@ -181,6 +206,12 @@ export function useFeatureRequests(): UseFeatureRequestsResult {
       updatedAt: serverTimestamp(),
     });
 
+    // Create the creator's upvote doc so votes count matches reality
+    await setDoc(doc(db, COLLECTION, docRef.id, "votes", userId), {
+      type: "up" as VoteType,
+      votedAt: serverTimestamp(),
+    });
+
     await fetchAll();
   }, [userId, user?.isAnonymous, fetchAll]);
 

package/src/domains/feedback/presentation/screens/FeatureRequestScreen.tsx

@@ -4,13 +4,11 @@ import {
   StyleSheet,
   TouchableOpacity,
   ScrollView,
-  FlatList,
   ActivityIndicator,
 } from "react-native";
 import {
   AtomicText,
   AtomicIcon,
-  AtomicButton,
 } from "@umituz/react-native-design-system/atoms";
 import { useAppDesignTokens } from "@umituz/react-native-design-system/theme";
 import { ScreenLayout } from "@umituz/react-native-design-system/layouts";
@@ -47,10 +45,6 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
     dismissed: t.status?.dismissed || "Dismissed",
   };
 
-  const handleVote = useCallback(async (id: string, type: VoteType) => {
-    await vote(id, type);
-  }, [vote]);
-
   const handleSubmit = useCallback(async (data: any) => {
     setIsSubmitting(true);
     try {
@@ -90,19 +84,19 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
     }
   })();
 
-  const renderRequestItem = ({ item }: { item: FeatureRequestItem }) => {
+  const renderRequestCard = (item: FeatureRequestItem) => {
     const voted = userVotes[item.id] || null;
 
     return (
-      <View style={[styles.card, { backgroundColor: tokens.colors.surfaceSecondary, borderColor: tokens.colors.borderLight }]}>
+      <View key={item.id} style={[styles.card, { backgroundColor: tokens.colors.surfaceSecondary, borderColor: tokens.colors.borderLight }]}>
         <View style={styles.voteColumn}>
-          <TouchableOpacity onPress={() => handleVote(item.id, 'up')}>
+          <TouchableOpacity onPress={() => vote(item.id, 'up')}>
             <AtomicIcon name="chevron-up" size="md" color={voted === 'up' ? "primary" : "textSecondary" as any} />
           </TouchableOpacity>
           <AtomicText style={[styles.voteCount, { color: voted === 'up' ? tokens.colors.primary : tokens.colors.textPrimary }]}>
             {item.votes}
           </AtomicText>
-          <TouchableOpacity onPress={() => handleVote(item.id, 'down')}>
+          <TouchableOpacity onPress={() => vote(item.id, 'down')}>
             <AtomicIcon name="chevron-down" size="md" color={voted === 'down' ? "primary" : "textSecondary" as any} />
           </TouchableOpacity>
         </View>
@@ -196,13 +190,9 @@ export const FeatureRequestScreen: React.FC<any> = ({ config, texts }) => {
             </AtomicText>
           </View>
         ) : (
-          <FlatList
-            data={filteredRequests}
-            renderItem={renderRequestItem}
-            keyExtractor={item => item.id}
-            scrollEnabled={false}
-            contentContainerStyle={styles.listContent}
-          />
+          <View style={styles.listContent}>
+            {filteredRequests.map(renderRequestCard)}
+          </View>
         )}
       </ScrollView>