@umituz/react-native-firebase 2.4.71 → 2.4.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-firebase",
-  "version": "2.4.71",
+  "version": "2.4.72",
   "description": "Unified Firebase package for React Native apps - Auth and Firestore services using Firebase JS SDK (no native modules).",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -128,19 +128,14 @@
       "default": "./src/index.ts"
     },
     "./auth": {
-      "react-native": "./src/auth/index.ts",
-      "types": "./src/auth/index.ts",
-      "default": "./src/auth/index.ts"
+      "react-native": "./src/domains/auth/index.ts",
+      "types": "./src/domains/auth/index.ts",
+      "default": "./src/domains/auth/index.ts"
     },
     "./firestore": {
-      "react-native": "./src/firestore/index.ts",
-      "types": "./src/firestore/index.ts",
-      "default": "./src/firestore/index.ts"
-    },
-    "./storage": {
-      "react-native": "./src/storage/index.ts",
-      "types": "./src/storage/index.ts",
-      "default": "./src/storage/index.ts"
+      "react-native": "./src/domains/firestore/index.ts",
+      "types": "./src/domains/firestore/index.ts",
+      "default": "./src/domains/firestore/index.ts"
     },
     "./init": {
       "react-native": "./src/init/index.ts",

package/src/domains/account-deletion/infrastructure/services/account-deletion.service.ts

@@ -77,7 +77,10 @@ export async function deleteCurrentUser(
         };
       }
 
-      await markUserDeleted(user.uid);
+      const marked = await markUserDeleted(user.uid);
+      if (!marked && __DEV__) {
+        console.warn('[AccountDeletion] Failed to mark user document as deleted before account removal');
+      }
       await deleteUser(user);
       return successResult();
     } catch (error: unknown) {
@@ -185,7 +188,10 @@ async function attemptReauth(user: User, options: AccountDeletionOptions, origin
         }
       }
 
-      await markUserDeleted(currentUser.uid);
+      const marked = await markUserDeleted(currentUser.uid);
+      if (!marked && __DEV__) {
+        console.warn('[AccountDeletion] Failed to mark user document as deleted before account removal (reauth path)');
+      }
       await deleteUser(currentUser);
       return successResult();
     } catch (err: unknown) {
@@ -218,6 +224,10 @@ export async function deleteUserAccount(user: User | null): Promise<AccountDelet
   }
 
   try {
+    const marked = await markUserDeleted(user.uid);
+    if (!marked && __DEV__) {
+      console.warn('[AccountDeletion] Failed to mark user document as deleted (deleteUserAccount)');
+    }
     await deleteUser(user);
     return successResult();
   } catch (error: unknown) {

package/src/domains/auth/infrastructure/services/user-document.service.ts

@@ -84,7 +84,10 @@ export async function markUserDeleted(userId: string): Promise<boolean> {
       updatedAt: serverTimestamp(),
     }, { merge: true });
     return true;
-  } catch {
+  } catch (error) {
+    if (typeof __DEV__ !== "undefined" && __DEV__) {
+      console.error("[UserDocumentService] Failed to mark user deleted:", error);
+    }
     return false;
   }
 }

package/src/domains/firestore/presentation/hooks/useFirestoreMutation.ts

@@ -40,7 +40,7 @@ export function useFirestoreMutation<TData, TVars, TContext = unknown>(
 
   return useMutation<TData, Error, TVars, TContext>({
     ...rest,
-    onSuccess: (data, variables, context) => {
+    onSuccess: (data, variables, _context) => {
       if (invalidateKeys?.length) {
         invalidateKeys.forEach((key) => {
           queryClient.invalidateQueries({ queryKey: key });

package/src/domains/firestore/presentation/hooks/useFirestoreSnapshot.ts

@@ -20,7 +20,7 @@
  * ```
  */
 
-import { useEffect, useRef } from 'react';
+import { useEffect, useMemo, useRef } from 'react';
 import {
   useQuery,
   useQueryClient,
@@ -46,19 +46,22 @@ export function useFirestoreSnapshot<TData>(
   const queryClient = useQueryClient();
   const unsubscribeRef = useRef<(() => void) | null>(null);
 
+  // Stabilize queryKey to prevent unnecessary listener re-subscriptions
+  const stableKeyString = JSON.stringify(queryKey);
+  const stableQueryKey = useMemo(() => queryKey, [stableKeyString]);
+
   useEffect(() => {
     if (!enabled) return;
 
     unsubscribeRef.current = subscribe((data) => {
-      queryClient.setQueryData(queryKey, data);
+      queryClient.setQueryData(stableQueryKey, data);
     });
 
     return () => {
       unsubscribeRef.current?.();
       unsubscribeRef.current = null;
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [enabled, queryClient, ...queryKey]);
+  }, [enabled, queryClient, stableQueryKey, subscribe]);
 
   return useQuery<TData, Error>({
     queryKey,

package/src/domains/firestore/utils/operation/operation-executor.util.ts

@@ -24,28 +24,40 @@ export async function withFirestore<T>(
 
 /**
  * Execute a Firestore operation that returns void
- * @throws {Error} if Firestore is not available
+ * Returns Result<void> for consistent error handling
  */
 export async function withFirestoreVoid(
   operation: (db: Firestore) => Promise<void>,
-): Promise<void> {
+): Promise<Result<void>> {
   const db = getFirestore();
   if (!db) {
-    throw new Error('[withFirestoreVoid] Firestore is not available');
+    return createNoDbErrorResult<void>();
+  }
+  try {
+    await operation(db);
+    return { success: true, data: undefined as void };
+  } catch (error) {
+    const message = error instanceof Error ? error.message : 'Operation failed';
+    return { success: false, error: { code: 'firestore/operation-failed', message } };
   }
-  return operation(db);
 }
 
 /**
  * Execute a Firestore operation that returns boolean
- * @throws {Error} if Firestore is not available
+ * Returns Result<boolean> for consistent error handling
  */
 export async function withFirestoreBool(
   operation: (db: Firestore) => Promise<boolean>,
-): Promise<boolean> {
+): Promise<Result<boolean>> {
   const db = getFirestore();
   if (!db) {
-    throw new Error('[withFirestoreBool] Firestore is not available');
+    return createNoDbErrorResult<boolean>();
+  }
+  try {
+    const result = await operation(db);
+    return { success: true, data: result };
+  } catch (error) {
+    const message = error instanceof Error ? error.message : 'Operation failed';
+    return { success: false, error: { code: 'firestore/operation-failed', message } };
   }
-  return operation(db);
 }

package/src/domains/firestore/utils/pagination.helper.ts

@@ -55,7 +55,8 @@ export class PaginationHelper<T> {
    * @returns Page limit
    */
   getLimit(params?: PaginationParams, defaultLimit: number = 10): number {
-    return params?.limit ?? defaultLimit;
+    const limit = params?.limit ?? defaultLimit;
+    return Math.max(1, Math.floor(limit));
   }
 
   /**

package/src/domains/firestore/utils/transaction/transaction.util.ts

@@ -11,6 +11,7 @@ import {
 import { getFirestore } from "../../infrastructure/config/FirestoreClient";
 import { hasCodeProperty } from "../../../../shared/domain/utils/type-guards.util";
 import { ERROR_MESSAGES } from "../../../../shared/domain/utils/error-handlers/error-messages";
+import { isQuotaError } from "../../../../shared/domain/utils/error-handlers/error-checkers";
 
 /**
  * Execute a transaction with automatic DB instance check.
@@ -28,6 +29,11 @@ export async function runTransaction<T>(
   } catch (error) {
     const errorMessage = error instanceof Error ? error.message : 'Unknown error';
     const errorCode = hasCodeProperty(error) ? error.code : 'unknown';
+
+    if (isQuotaError(error)) {
+      throw new Error(`[runTransaction] ${ERROR_MESSAGES.FIRESTORE.QUOTA_EXCEEDED}: ${errorMessage} (Code: ${errorCode})`);
+    }
+
     throw new Error(`[runTransaction] Transaction failed: ${errorMessage} (Code: ${errorCode})`);
   }
 }

package/src/init/createFirebaseInitModule.ts

@@ -39,7 +39,7 @@ export interface FirebaseInitModuleConfig {
 export function createFirebaseInitModule(
   config: FirebaseInitModuleConfig = {}
 ): InitModule {
-  const { authInitializer, critical = false } = config;
+  const { authInitializer, critical = true } = config;
 
   return {
     name: 'firebase',

package/src/shared/domain/utils/index.ts

@@ -6,6 +6,7 @@
 // Result types and helpers
 export type {
   Result,
+  FailureResult,
 } from './result/result-types';
 
 export {
@@ -13,6 +14,11 @@ export {
   failureResultFrom,
 } from './result/result-creators';
 
+export {
+  isSuccess,
+  isFailure,
+} from './result/result-helpers';
+
 // Async operation execution
 export {
   executeOperation,

package/src/shared/domain/utils/result/result-helpers.ts

@@ -3,7 +3,7 @@
  * Utility functions for working with Result type
  */
 
-import type { Result, SuccessResult } from './result-types';
+import type { Result, SuccessResult, FailureResult } from './result-types';
 
 /**
  * Check if result is successful
@@ -11,3 +11,10 @@ import type { Result, SuccessResult } from './result-types';
 export function isSuccess<T>(result: Result<T>): result is SuccessResult<T> {
   return result.success === true && result.error === undefined;
 }
+
+/**
+ * Check if result is a failure
+ */
+export function isFailure<T>(result: Result<T>): result is FailureResult {
+  return result.success === false && result.error !== undefined;
+}

package/src/shared/domain/utils/validators/firebase.validator.ts

@@ -26,8 +26,8 @@ export function isValidFirebaseAuthDomain(authDomain: string): boolean {
     return false;
   }
   return (
-    authDomain.includes('.firebaseapp.com') ||
-    authDomain.includes('.web.app')
+    authDomain.endsWith('.firebaseapp.com') ||
+    authDomain.endsWith('.web.app')
   );
 }
 

package/src/shared/infrastructure/config/services/FirebaseInitializationService.ts

@@ -82,6 +82,7 @@ export async function initializeAllFirebaseServices(
       await options.authInitializer();
       authSuccess = true;
     } catch (error) {
+      authSuccess = false;
       authError = error instanceof Error ? error.message : 'Auth initialization failed';
     }
   }