@umituz/react-native-firebase 2.4.34 → 2.4.35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-firebase",
-  "version": "2.4.34",
+  "version": "2.4.35",
   "description": "Unified Firebase package for React Native apps - Auth and Firestore services using Firebase JS SDK (no native modules).",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/domains/auth/infrastructure/services/apple-auth.service.ts

@@ -8,6 +8,7 @@ import {
   OAuthProvider,
   signInWithCredential,
   type Auth,
+  type UserCredential,
 } from "firebase/auth";
 import { Platform } from "react-native";
 import { generateNonce, hashNonce } from "./crypto.util";
@@ -43,7 +44,7 @@ export class AppleAuthService {
     }
   }
 
-  private convertToAppleAuthResult(result: Result<{ userCredential: any; isNewUser: boolean }>): AppleAuthResult {
+  private convertToAppleAuthResult(result: Result<{ userCredential: UserCredential; isNewUser: boolean }>): AppleAuthResult {
     return convertToOAuthResult(result, "Apple sign-in failed");
   }
 

package/src/domains/auth/infrastructure/services/google-auth.service.ts

@@ -7,6 +7,7 @@ import {
   GoogleAuthProvider,
   signInWithCredential,
   type Auth,
+  type UserCredential,
 } from "firebase/auth";
 import type { GoogleAuthConfig, GoogleAuthResult } from "./google-auth.types";
 import { executeAuthOperation, type Result } from "../../../../shared/domain/utils";
@@ -26,7 +27,7 @@ export class GoogleAuthService extends ConfigurableService<GoogleAuthConfig> {
     );
   }
 
-  private convertToGoogleAuthResult(result: Result<{ userCredential: any; isNewUser: boolean }>): GoogleAuthResult {
+  private convertToGoogleAuthResult(result: Result<{ userCredential: UserCredential; isNewUser: boolean }>): GoogleAuthResult {
     return convertToOAuthResult(result, "Google sign-in failed");
   }
 

package/src/domains/auth/infrastructure/services/google-oauth.service.ts

@@ -68,7 +68,7 @@ export class GoogleOAuthService {
   async signInWithOAuth(
     auth: Auth,
     config?: GoogleOAuthConfig,
-    promptAsync?: () => Promise<any>
+    promptAsync?: () => Promise<{ type: string; authentication?: { idToken?: string } | null }>
   ): Promise<GoogleAuthResult> {
     if (!isExpoAuthAvailable) {
       return {

package/src/domains/auth/infrastructure/services/user-document-builder.util.ts

@@ -17,7 +17,7 @@ function hasProviderData(user: unknown): user is { providerData: { providerId: s
     typeof user === 'object' &&
     user !== null &&
     'providerData' in user &&
-    Array.isArray((user as any).providerData)
+    Array.isArray((user as Record<string, unknown>).providerData)
   );
 }
 
@@ -27,7 +27,6 @@ function hasProviderData(user: unknown): user is { providerData: { providerId: s
 export function getSignUpMethod(user: UserDocumentUser): string | undefined {
   if (user.isAnonymous) return "anonymous";
   if (user.email) {
-    // FIX: Use type guard instead of unsafe cast
     if (hasProviderData(user) && user.providerData.length > 0) {
       const providerId = user.providerData[0]?.providerId;
       if (providerId === "google.com") return "google";

package/src/domains/auth/infrastructure/services/utils/auth-result-converter.util.ts

@@ -4,6 +4,7 @@
  * Eliminates duplicate result conversion logic in OAuth providers (Apple, Google)
  */
 
+import type { UserCredential } from 'firebase/auth';
 import { isSuccess } from '../../../../../shared/domain/utils/result/result-helpers';
 import type { Result } from '../../../../../shared/domain/utils/result/result-types';
 
@@ -13,7 +14,7 @@ import type { Result } from '../../../../../shared/domain/utils/result/result-ty
  */
 interface OAuthAuthSuccessResult {
   success: true;
-  userCredential: any;
+  userCredential: UserCredential;
   isNewUser: boolean;
 }
 
@@ -42,18 +43,18 @@ type OAuthAuthResult = OAuthAuthSuccessResult | OAuthAuthErrorResult;
  * @example
  * ```typescript
  * // In AppleAuthService
- * private convertToAppleAuthResult(result: Result<{ userCredential: any; isNewUser: boolean }>): AppleAuthResult {
+ * private convertToAppleAuthResult(result: Result<{ userCredential: UserCredential; isNewUser: boolean }>): AppleAuthResult {
  *   return convertToOAuthResult(result, "Apple sign-in failed");
  * }
  *
  * // In GoogleAuthService
- * private convertToGoogleAuthResult(result: Result<{ userCredential: any; isNewUser: boolean }>): GoogleAuthResult {
+ * private convertToGoogleAuthResult(result: Result<{ userCredential: UserCredential; isNewUser: boolean }>): GoogleAuthResult {
  *   return convertToOAuthResult(result, "Google sign-in failed");
  * }
  * ```
  */
 export function convertToOAuthResult(
-  result: Result<{ userCredential: any; isNewUser: boolean }>,
+  result: Result<{ userCredential: UserCredential; isNewUser: boolean }>,
   defaultErrorMessage: string = 'Authentication failed'
 ): OAuthAuthResult {
   if (isSuccess(result) && result.data) {

package/src/domains/auth/presentation/hooks/useAnonymousAuth.ts

@@ -5,9 +5,9 @@
 
 import { useState, useEffect, useCallback, useRef } from "react";
 import { onAuthStateChanged, type Auth, type User } from "firebase/auth";
-import type { AuthCheckResult } from "../../infrastructure/services/auth-utils.service";
+import { createAuthCheckResult, type AuthCheckResult } from "../../infrastructure/services/auth-utils.service";
 import { anonymousAuthService, type AnonymousAuthResult } from "../../infrastructure/services/anonymous-auth.service";
-import { createAuthStateChangeHandler, userToAuthCheckResult } from "./utils/auth-state-change.handler";
+import { createAuthStateChangeHandler } from "./utils/auth-state-change.handler";
 
 export interface UseAnonymousAuthResult extends AuthCheckResult {
   /**
@@ -69,10 +69,9 @@ export function useAnonymousAuth(auth: Auth | null): UseAnonymousAuthResult {
     }
 
     if (!auth) {
-      setAuthState(userToAuthCheckResult(null));
+      setAuthState(createAuthCheckResult(null));
       setLoading(false);
       setError(null);
-      // FIX: Always return cleanup function to prevent memory leaks
       return () => {
         if (unsubscribeRef.current) {
           unsubscribeRef.current();
@@ -93,8 +92,7 @@ export function useAnonymousAuth(auth: Auth | null): UseAnonymousAuthResult {
       const authError = err instanceof Error ? err : new Error('Auth listener setup failed');
       setError(authError);
       setLoading(false);
-      // FIX: Reset auth state on error to prevent stale data
-      setAuthState(userToAuthCheckResult(null));
+      setAuthState(createAuthCheckResult(null));
     }
 
     // Cleanup function

package/src/domains/auth/presentation/hooks/utils/auth-state-change.handler.ts

@@ -44,8 +44,3 @@ export function createAuthStateChangeHandler(
   };
 }
 
-/**
- * Convert Firebase User to AuthCheckResult
- * Re-exports createAuthCheckResult for convenience
- */
-export const userToAuthCheckResult = createAuthCheckResult;

package/src/shared/domain/guards/firebase-error.guard.ts

@@ -27,9 +27,8 @@ export function isFirestoreError(error: unknown): error is FirestoreError {
     error !== null &&
     'code' in error &&
     'message' in error &&
-    // FIX: Also check that properties are strings
-    typeof (error as any).code === 'string' &&
-    typeof (error as any).message === 'string'
+    typeof (error as { code: unknown; message: unknown }).code === 'string' &&
+    typeof (error as { code: unknown; message: unknown }).message === 'string'
   );
 }
 
@@ -42,9 +41,8 @@ export function isAuthError(error: unknown): error is AuthError {
     error !== null &&
     'code' in error &&
     'message' in error &&
-    // FIX: Also check that properties are strings
-    typeof (error as any).code === 'string' &&
-    typeof (error as any).message === 'string'
+    typeof (error as { code: unknown; message: unknown }).code === 'string' &&
+    typeof (error as { code: unknown; message: unknown }).message === 'string'
   );
 }