@umituz/react-native-firebase 2.4.33 → 2.4.34

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-firebase",
-  "version": "2.4.33",
+  "version": "2.4.34",
   "description": "Unified Firebase package for React Native apps - Auth and Firestore services using Firebase JS SDK (no native modules).",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/domains/firestore/infrastructure/repositories/BaseRepository.ts

@@ -61,12 +61,21 @@ export abstract class BaseRepository implements IPathResolver {
   getUserCollection(userId: string): CollectionReference<DocumentData> | null {
     const db = this.getDb();
     if (!db) return null;
+    if (!userId || userId.trim() === '') {
+      throw new Error('userId must be a non-empty string');
+    }
     return collection(db, 'users', userId, this.collectionName);
   }
 
   getDocRef(userId: string, documentId: string): DocumentReference<DocumentData> | null {
     const db = this.getDb();
     if (!db) return null;
+    if (!userId || userId.trim() === '') {
+      throw new Error('userId must be a non-empty string');
+    }
+    if (!documentId || documentId.trim() === '') {
+      throw new Error('documentId must be a non-empty string');
+    }
     return doc(db, 'users', userId, this.collectionName, documentId);
   }
 

package/src/domains/firestore/utils/deduplication/pending-query-manager.util.ts

@@ -41,15 +41,12 @@ export class PendingQueryManager {
   }
 
   /**
-   * Add query to pending list with guaranteed cleanup
+   * Add query to pending list.
+   * Cleanup is handled by the caller's finally block in deduplicate().
    */
   add(key: string, promise: Promise<unknown>): void {
-    const wrappedPromise = promise.finally(() => {
-      this.pendingQueries.delete(key);
-    });
-
     this.pendingQueries.set(key, {
-      promise: wrappedPromise,
+      promise,
       timestamp: Date.now(),
     });
   }