@umituz/react-native-firebase 1.13.161 → 1.13.163

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@umituz/react-native-firebase",
-  "version": "1.13.161",
+  "version": "1.13.163",
   "description": "Unified Firebase package for React Native apps - Auth and Firestore services using Firebase JS SDK (no native modules).",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/auth/infrastructure/services/account-deletion.service.ts

@@ -50,7 +50,11 @@ export async function deleteCurrentUser(
     const code = authErr?.code ?? "auth/failed";
     const message = authErr?.message ?? "Account deletion failed";
 
-    if (code === "auth/requires-recent-login" && (options.autoReauthenticate || options.password || options.googleIdToken)) {
+    // Determine if we should attempt reauthentication
+    const hasCredentials = !!(options.password || options.googleIdToken);
+    const shouldReauth = options.autoReauthenticate === true || hasCredentials;
+
+    if (code === "auth/requires-recent-login" && shouldReauth) {
       const reauth = await attemptReauth(user, options);
       if (reauth) return reauth;
     }
@@ -93,7 +97,10 @@ async function attemptReauth(user: User, options: AccountDeletionOptions): Promi
 
   if (res.success) {
     try {
-      await deleteUser(user);
+      // After reauthentication, get fresh user reference from auth
+      const auth = getFirebaseAuth();
+      const currentUser = auth?.currentUser || user;
+      await deleteUser(currentUser);
       return successResult();
     } catch (err: unknown) {
       const authErr = err instanceof Error ? (err as { code?: string; message?: string }) : null;

package/src/auth/infrastructure/services/apple-auth.service.ts

@@ -22,9 +22,10 @@ let AppleAuthentication: any = null;
 let isAppleAuthAvailable = false;
 
 try {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   AppleAuthentication = require("expo-apple-authentication");
   isAppleAuthAvailable = true;
-} catch (error) {
+} catch {
   // expo-apple-authentication not available - this is fine if not using Apple auth
   console.info("expo-apple-authentication is not installed. Apple authentication will not be available.");
 }

package/src/auth/infrastructure/services/auth-listener.service.ts

@@ -6,7 +6,7 @@
 import { onIdTokenChanged, type User } from "firebase/auth";
 import { getFirebaseAuth } from "../config/FirebaseAuthClient";
 import type { Result } from "../../../domain/utils";
-import { successResult, failureResultFrom } from "../../../domain/utils";
+import { failureResultFrom } from "../../../domain/utils";
 
 export interface AuthListenerConfig {
   /**

package/src/auth/infrastructure/services/email-auth.service.ts

@@ -82,11 +82,17 @@ export async function signUpWithEmail(
       );
     }
 
-    // Update display name if provided
+    // Update display name if provided (non-critical operation)
     if (credentials.displayName && userCredential.user) {
-      await updateProfile(userCredential.user, {
-        displayName: credentials.displayName.trim(),
-      });
+      try {
+        await updateProfile(userCredential.user, {
+          displayName: credentials.displayName.trim(),
+        });
+      } catch (profileError) {
+        // Profile update failed but account was created successfully
+        // Log the error but don't fail the signup
+        console.warn("Profile update failed after account creation:", profileError);
+      }
     }
 
     return { success: true, data: userCredential.user };

package/src/auth/infrastructure/services/google-oauth.service.ts

@@ -8,13 +8,12 @@ import type { Auth } from "firebase/auth";
 import type { GoogleAuthResult } from "./google-auth.types";
 import { googleAuthService } from "./google-auth.service";
 
-// Conditional imports - these packages are optional
-let ExpoAuthSession: any = null;
+// Conditional import - expo-web-browser is optional
 let ExpoWebBrowser: any = null;
 let isExpoAuthAvailable = false;
 
 try {
-  ExpoAuthSession = require("expo-auth-session/providers/google");
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   ExpoWebBrowser = require("expo-web-browser");
   isExpoAuthAvailable = true;
 
@@ -22,9 +21,9 @@ try {
   if (ExpoWebBrowser?.maybeCompleteAuthSession) {
     ExpoWebBrowser.maybeCompleteAuthSession();
   }
-} catch (error) {
-  // expo-auth-session not available - this is fine if not using Google OAuth
-  console.info("expo-auth-session is not installed. Google OAuth will not be available.");
+} catch {
+  // expo-web-browser not available - this is fine if not using Google OAuth
+  console.info("expo-web-browser is not installed. Google OAuth will not be available.");
 }
 
 export interface GoogleOAuthConfig {
@@ -33,12 +32,6 @@ export interface GoogleOAuthConfig {
   androidClientId?: string;
 }
 
-export interface GoogleOAuthHookResult {
-  request: any;
-  response: any;
-  promptAsync: (() => Promise<any>) | null;
-}
-
 const PLACEHOLDER_CLIENT_ID = "000000000000-placeholder.apps.googleusercontent.com";
 
 function validateGoogleConfig(config?: GoogleOAuthConfig): boolean {
@@ -69,41 +62,6 @@ export class GoogleOAuthService {
     return validateGoogleConfig(config);
   }
 
-  /**
-   * Create auth request hook
-   * This mimics the behavior of expo-auth-session's useAuthRequest hook
-   */
-  createAuthRequest(config?: GoogleOAuthConfig): GoogleOAuthHookResult {
-    if (!isExpoAuthAvailable || !ExpoAuthSession?.useAuthRequest) {
-      return {
-        request: null,
-        response: null,
-        promptAsync: null,
-      };
-    }
-
-    try {
-      const [request, response, promptAsync] = ExpoAuthSession.useAuthRequest({
-        iosClientId: config?.iosClientId || PLACEHOLDER_CLIENT_ID,
-        webClientId: config?.webClientId || PLACEHOLDER_CLIENT_ID,
-        androidClientId: config?.androidClientId || PLACEHOLDER_CLIENT_ID,
-      });
-
-      return {
-        request: request ?? null,
-        response: response ?? null,
-        promptAsync: promptAsync ?? null,
-      };
-    } catch (error) {
-      console.error("Failed to create Google auth request:", error);
-      return {
-        request: null,
-        response: null,
-        promptAsync: null,
-      };
-    }
-  }
-
   /**
    * Sign in with Google using OAuth flow
    */

package/src/auth/presentation/hooks/useGoogleOAuth.ts

@@ -9,6 +9,18 @@ import { googleOAuthService } from "../../infrastructure/services/google-oauth.s
 import { getFirebaseAuth } from "../../infrastructure/config/FirebaseAuthClient";
 import type { GoogleOAuthConfig } from "../../infrastructure/services/google-oauth.service";
 
+// Conditional import for expo-auth-session
+let ExpoAuthSession: any = null;
+let isExpoAuthAvailable = false;
+
+try {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
+  ExpoAuthSession = require("expo-auth-session/providers/google");
+  isExpoAuthAvailable = true;
+} catch {
+  // expo-auth-session not available - hook will return unavailable state
+}
+
 export interface UseGoogleOAuthResult {
   signInWithGoogle: () => Promise<SocialAuthResult>;
   googleLoading: boolean;
@@ -23,6 +35,8 @@ export interface SocialAuthResult {
   error?: string;
 }
 
+const PLACEHOLDER_CLIENT_ID = "000000000000-placeholder.apps.googleusercontent.com";
+
 /**
  * Hook for Google OAuth authentication
  * Requires expo-auth-session and expo-web-browser to be installed
@@ -34,9 +48,15 @@ export function useGoogleOAuth(config?: GoogleOAuthConfig): UseGoogleOAuthResult
   const googleAvailable = googleOAuthService.isAvailable();
   const googleConfigured = googleOAuthService.isConfigured(config);
 
-  // Create auth request - this will return null values if expo-auth-session is not available
-  const authRequest = googleOAuthService.createAuthRequest(config);
-  const { request, response, promptAsync } = authRequest;
+  // Call the Hook directly (only valid in React component)
+  // If expo-auth-session is not available, these will be null
+  const [request, response, promptAsync] = isExpoAuthAvailable && ExpoAuthSession?.useAuthRequest
+    ? ExpoAuthSession.useAuthRequest({
+        iosClientId: config?.iosClientId || PLACEHOLDER_CLIENT_ID,
+        webClientId: config?.webClientId || PLACEHOLDER_CLIENT_ID,
+        androidClientId: config?.androidClientId || PLACEHOLDER_CLIENT_ID,
+      })
+    : [null, null, null];
 
   // Handle OAuth response
   useEffect(() => {

package/src/firestore/index.ts

@@ -62,9 +62,6 @@ export {
   createDocumentMapper,
 } from './utils/document-mapper.helper';
 
-// Path Resolver
-export { FirestorePathResolver } from './utils/path-resolver';
-
 // Domain Constants
 export {
   FREE_TIER_LIMITS,

package/src/firestore/infrastructure/repositories/BaseRepository.ts

@@ -50,11 +50,11 @@ export abstract class BaseRepository {
    * @param userId User identifier
    * @returns CollectionReference or null if db not initialized
    */
-  protected getUserCollection(userId: string): CollectionReference<DocumentData> | null {
+  protected getUserCollection = (userId: string): CollectionReference<DocumentData> | null => {
     const db = this.getDb();
     if (!db) return null;
     return collection(db, 'users', userId, this.collectionName);
-  }
+  };
 
   /**
    * Get document reference
@@ -64,11 +64,11 @@ export abstract class BaseRepository {
    * @param documentId Document identifier
    * @returns DocumentReference or null if db not initialized
    */
-  protected getDocRef(userId: string, documentId: string): DocumentReference<DocumentData> | null {
+  protected getDocRef = (userId: string, documentId: string): DocumentReference<DocumentData> | null => {
     const db = this.getDb();
     if (!db) return null;
     return doc(db, 'users', userId, this.collectionName, documentId);
-  }
+  };
 
   /**
    * Check if Firestore is initialized
@@ -84,13 +84,11 @@ export abstract class BaseRepository {
 
   /**
    * Execute operation with error handling
-   * @param collection - Collection name for tracking
    * @param operation - Operation to execute
    * @returns Operation result
    * @throws Error if operation fails
    */
   protected async executeOperation<T>(
-    collection: string,
     operation: () => Promise<T>
   ): Promise<T> {
     if (this.state === RepositoryState.DESTROYED) {
@@ -111,27 +109,6 @@ export abstract class BaseRepository {
     }
   }
 
-  /**
-   * Track read operation
-   */
-  protected trackRead(_collection: string, _count: number = 1): void {
-    // Quota tracking delegated to middleware
-  }
-
-  /**
-   * Track write operation
-   */
-  protected trackWrite(_collection: string, _count: number = 1): void {
-    // Quota tracking delegated to middleware
-  }
-
-  /**
-   * Track delete operation
-   */
-  protected trackDelete(_collection: string, _count: number = 1): void {
-    // Quota tracking delegated to middleware
-  }
-
   /**
    * Destroy the repository
    * Prevents further operations

package/src/index.ts

@@ -62,7 +62,6 @@ export {
   BaseRepository,
   BaseQueryRepository,
   BasePaginatedRepository,
-  FirestorePathResolver,
 } from "./firestore";
 export * from "./firestore";
 export { Timestamp } from "firebase/firestore";

package/src/firestore/utils/path-resolver.ts

@@ -1,44 +0,0 @@
-import type { Firestore, CollectionReference, DocumentReference, DocumentData } from "firebase/firestore";
-import { collection, doc } from "firebase/firestore";
-
-/**
- * Resolves Firestore paths for user collections
- * Standard pattern: users/{userId}/{collectionName}
- *
- * Stateless design: db is passed to methods, not stored in constructor
- * This eliminates initialization timing issues and makes testing easier
- * This class is designed to be used across hundreds of apps.
- * All user data MUST be under users/{userId}/ for consistency.
- */
-export class FirestorePathResolver {
-    constructor(
-        private readonly collectionName: string,
-    ) { }
-
-    /**
-     * Get collection reference for a user
-     * Pattern: users/{userId}/{collectionName}
-     *
-     * @param db Firestore instance
-     * @param userId User identifier
-     * @returns CollectionReference or null if db not initialized
-     */
-    getUserCollection(db: Firestore | null, userId: string): CollectionReference<DocumentData> | null {
-        if (!db) return null;
-        return collection(db, "users", userId, this.collectionName);
-    }
-
-    /**
-     * Get document reference for a specific item
-     * Pattern: users/{userId}/{collectionName}/{documentId}
-     *
-     * @param db Firestore instance
-     * @param userId User identifier
-     * @param documentId Document identifier
-     * @returns DocumentReference or null if db not initialized
-     */
-    getDocRef(db: Firestore | null, userId: string, documentId: string): DocumentReference<DocumentData> | null {
-        if (!db) return null;
-        return doc(db, "users", userId, this.collectionName, documentId);
-    }
-}