@umbraco-cms/backoffice 17.0.0-rc4 → 17.0.1

package/dist-cms/assets/lang/da.js

@@ -548,7 +548,7 @@ export default {
         chooseMediaStartNode: 'Vælg startnode for medie',
         selectMediaType: 'Vælg medietype',
         selectIcon: 'Vælg ikon',
-        selectItem: 'Vælg item',
+        selectItem: 'Vælg element',
         selectLink: 'Vælg link',
         addLink: 'Tilføj Link',
         updateLink: 'Opdater Link',
@@ -2199,10 +2199,10 @@ export default {
         labelUsedByDocuments: 'Brugt i Dokumenter',
         labelUsedByMembers: 'Brugt i Medlemmer',
         labelUsedByMedia: 'Brugt i Medier',
-        itemHasNoReferences: 'This item has no references.',
-        labelUsedByDocumentTypes: 'Referenced by the following Document Types',
-        labelUsedByItems: 'Referenced by the following items',
-        labelDependsOnThis: 'The following items depend on this',
+        itemHasNoReferences: 'Ingen referencer',
+        labelUsedByDocumentTypes: 'Refereret af følgende Dokument Typer',
+        labelUsedByItems: 'Refereret af',
+        labelDependsOnThis: 'Følgende elementer er afhængige af dette',
         labelUsedItems: 'The following items are referenced',
         labelUsedDescendants: 'The following descendant items have dependencies',
         labelDependentDescendants: 'The following descending items have dependencies',

package/dist-cms/assets/lang/en.js

@@ -2268,7 +2268,7 @@ export default {
         unpublishWarning: 'This item or its descendants is being used. Unpublishing can lead to broken links on your website. Please take the appropriate actions.',
         deleteDisabledWarning: 'This item or its descendants is being used. Therefore, deletion has been disabled.',
         listViewDialogWarning: 'The following items you are trying to %0% are used by other content.',
-        labelUsedByItems: 'Referenced by the following items',
+        labelUsedByItems: 'Referenced by',
         labelDependsOnThis: 'The following items depend on this',
         labelDependentDescendants: 'The following descending items have dependencies',
         labelMoreReferences: (count) => {

package/dist-cms/packages/content/content/workspace/content-detail-workspace-base.d.ts

@@ -81,11 +81,12 @@ export declare abstract class UmbContentDetailWorkspaceContextBase<DetailModelTy
     getVariantValidationContext(variantId: UmbVariantId): UmbValidationController | undefined;
     constructor(host: UmbControllerHost, args: UmbContentDetailWorkspaceContextArgs<DetailModelType, ContentTypeDetailModelType, VariantModelType, VariantOptionModelType>);
     loadLanguages(): Promise<void>;
-    protected loadSegments(): Promise<void>;
     /**
-     * @deprecated Call `_processIncomingData` instead. `_scaffoldProcessData` will be removed in v.18.
+     * @deprecated Call `_loadSegmentsFor` instead. `loadSegments` will be removed in v.18.
+     * (note this was introduced in v.17, and deprecated in v.17.0.1)
      */
-    protected _scaffoldProcessData(data: DetailModelType): Promise<DetailModelType>;
+    protected loadSegments(): Promise<void>;
+    protected _loadSegmentsFor(unique: string): Promise<void>;
     protected _processIncomingData(data: DetailModelType): Promise<DetailModelType>;
     /**
      * Get the name of a variant

package/dist-cms/packages/content/content/workspace/content-detail-workspace-base.js

@@ -221,12 +221,6 @@ export class UmbContentDetailWorkspaceContextBase extends UmbEntityDetailWorkspa
         this.observe(this.variesBySegment, (varies) => {
             this._data.setVariesBySegment(varies);
             this.#variesBySegment = varies;
-            if (varies) {
-                this.loadSegments();
-            }
-            else {
-                this._segments.setValue([]);
-            }
         }, null);
         this.observe(this.structure.contentTypeDataTypeUniques, (dataTypeUniques) => {
             this.#dataTypeItemManager.setUniques(dataTypeUniques);
@@ -238,16 +232,24 @@ export class UmbContentDetailWorkspaceContextBase extends UmbEntityDetailWorkspa
         const { data } = await this.#languageRepository.requestCollection({});
         this.#languages.setValue(data?.items ?? []);
     }
+    /**
+     * @deprecated Call `_loadSegmentsFor` instead. `loadSegments` will be removed in v.18.
+     * (note this was introduced in v.17, and deprecated in v.17.0.1)
+     */
     async loadSegments() {
+        console.warn('Stop using loadSegments, call _loadSegmentsFor instead. loadSegments will be removed in v.18.');
+        const unique = await firstValueFrom(this.unique);
+        if (!unique) {
+            this._segments.setValue([]);
+            return;
+        }
+        this._loadSegmentsFor(unique);
+    }
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    async _loadSegmentsFor(unique) {
         console.warn(`UmbContentDetailWorkspaceContextBase: Segments are not implemented in the workspace context for "${this.getEntityType()}" types.`);
         this._segments.setValue([]);
     }
-    /**
-     * @deprecated Call `_processIncomingData` instead. `_scaffoldProcessData` will be removed in v.18.
-     */
-    _scaffoldProcessData(data) {
-        return this._processIncomingData(data);
-    }
     async _processIncomingData(data) {
         const contentTypeUnique = data[this.#contentTypePropertyName].unique;
         if (!contentTypeUnique) {
@@ -255,20 +257,24 @@ export class UmbContentDetailWorkspaceContextBase extends UmbEntityDetailWorkspa
         }
         // Load the content type structure, usually this comes from the data, but in this case we are making the data, and we need this to be able to complete the data. [NL]
         await this.structure.loadType(contentTypeUnique);
+        // Load segments if varying by segment, or reset to empty array:
+        if (this.#variesBySegment) {
+            await this._loadSegmentsFor(data.unique);
+        }
+        else {
+            this._segments.setValue([]);
+        }
         // Set culture and segment for all values:
         const cultures = this.#languages.getValue().map((x) => x.unique);
-        if (this.structure.variesBySegment) {
-            // TODO: v.17 Engage please note we have not implemented support for segments yet. [NL]
-            console.warn('Segments are not yet implemented for preset');
+        let segments;
+        if (this.#variesBySegment) {
+            segments = this._segments.getValue().map((s) => s.alias);
         }
-        // TODO: Add Segments for Presets:
-        const segments = this.structure.variesBySegment ? [] : undefined;
         const repo = new UmbDataTypeDetailRepository(this);
         const propertyTypes = await this.structure.getContentTypeProperties();
         const contentTypeVariesByCulture = this.structure.getVariesByCulture();
-        const contentTypeVariesBySegment = this.structure.getVariesByCulture();
+        const contentTypeVariesBySegment = this.structure.getVariesBySegment();
         const valueDefinitions = await Promise.all(propertyTypes.map(async (property) => {
-            // TODO: Implement caching for data-type requests. [NL]
             const dataType = (await repo.requestByUnique(property.dataType.unique)).data;
             // This means if its not loaded this will never resolve and the error below will never happen.
             if (!dataType) {

package/dist-cms/packages/content/content-type/workspace/content-type-workspace-context-base.js

@@ -37,7 +37,6 @@ export class UmbContentTypeWorkspaceContextBase extends UmbEntityDetailWorkspace
         this._getDataPromise = request;
         let { data } = await request;
         if (data) {
-            data = await this._processIncomingData(data);
             data = await this._scaffoldProcessData(data);
             if (this.modalContext) {
                 // Notice if the preset comes with values, they will overwrite the scaffolded values... [NL]

package/dist-cms/packages/core/tree/tree-item/tree-item-children.manager.js

@@ -208,7 +208,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
     async #loadChildren(reload = false) {
         if (this.#loadChildrenRetries > this.#requestMaxRetries) {
             this.#loadChildrenRetries = 0;
-            this.#resetChildren();
+            this.#resetChildren('error');
             return;
         }
         const repository = this.#treeContext?.getRepository();
@@ -284,7 +284,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
                     We cancel the base target and load using skip/take pagination instead.
                     This can happen if deep linked to a non existing item or all retries have failed.
                 */
-                this.#resetChildren();
+                this.#resetChildren(this.#children.getValue().length === 0 ? 'empty' : 'fallback');
             }
         }
         if (data) {
@@ -305,7 +305,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
         if (this.#loadPrevItemsRetries > this.#requestMaxRetries) {
             // If we have exceeded the maximum number of retries, we need to reset the base target and load from the top
             this.#loadPrevItemsRetries = 0;
-            this.#resetChildren();
+            this.#resetChildren('error');
             return;
         }
         const repository = this.#treeContext?.getRepository();
@@ -349,7 +349,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
                     If we can't find a new end target we reload the children from the top.
                     We cancel the base target and load using skip/take pagination instead.
                 */
-                this.#resetChildren();
+                this.#resetChildren(this.#children.getValue().length === 0 ? 'empty' : 'fallback');
             }
         }
         if (data) {
@@ -373,7 +373,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
         if (this.#loadNextItemsRetries > this.#requestMaxRetries) {
             // If we have exceeded the maximum number of retries, we need to reset the base target and load from the top
             this.#loadNextItemsRetries = 0;
-            this.#resetChildren();
+            this.#resetChildren('error');
             return;
         }
         const repository = this.#treeContext?.getRepository();
@@ -425,7 +425,7 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
                     If we can't find a new end target we reload the children from the top.
                     We cancel the base target and load using skip/take pagination instead.
                 */
-                this.#resetChildren();
+                this.#resetChildren(this.#children.getValue().length === 0 ? 'empty' : 'fallback');
             }
         }
         if (data) {
@@ -469,12 +469,71 @@ export class UmbTreeItemChildrenManager extends UmbControllerBase {
         this.offsetPagination.clear();
         this.targetPagination.clear();
     }
-    async #resetChildren() {
+    /**
+     * Loads children using offset pagination only.
+     * This is a "safe" fallback that does NOT:
+     * - Use target pagination
+     * - Retry with new targets
+     * - Call #resetChildren (preventing recursion)
+     * - Throw errors (fails gracefully)
+     */
+    async #loadChildrenWithOffsetPagination() {
+        const repository = this.#treeContext?.getRepository();
+        if (!repository) {
+            // Terminal fallback - fail silently rather than throwing
+            return;
+        }
+        this.#isLoading.setValue(true);
+        const parent = this.getStartNode() || this.getTreeItem();
+        const foldersOnly = this.getFoldersOnly();
+        const additionalArgs = this.getAdditionalRequestArgs();
+        const offsetPaging = {
+            skip: 0, // Always from the start
+            take: this.offsetPagination.getPageSize(),
+        };
+        const { data } = parent?.unique
+            ? await repository.requestTreeItemsOf({
+                parent: { unique: parent.unique, entityType: parent.entityType },
+                skip: offsetPaging.skip,
+                take: offsetPaging.take,
+                paging: offsetPaging,
+                foldersOnly,
+                ...additionalArgs,
+            })
+            : await repository.requestTreeRootItems({
+                skip: offsetPaging.skip,
+                take: offsetPaging.take,
+                paging: offsetPaging,
+                foldersOnly,
+                ...additionalArgs,
+            });
+        if (data) {
+            const items = data.items;
+            this.#children.setValue(items);
+            this.setHasChildren(data.total > 0);
+            this.offsetPagination.setTotalItems(data.total);
+        }
+        // Note: On error, we simply don't update state - UI shows stale data
+        // This is the terminal fallback, no further recovery
+        this.#isLoading.setValue(false);
+    }
+    async #resetChildren(reason = 'error') {
+        // Clear pagination state
         this.targetPagination.clear();
         this.offsetPagination.clear();
-        this.loadChildren();
-        const notificationManager = await this.getContext(UMB_NOTIFICATION_CONTEXT);
-        notificationManager?.peek('danger', { data: { message: 'Menu loading failed. Showing the first items again.' } });
+        // Reset retry counters to prevent any lingering retry state
+        this.#loadChildrenRetries = 0;
+        this.#loadPrevItemsRetries = 0;
+        this.#loadNextItemsRetries = 0;
+        // Load using offset pagination only - this is our terminal fallback
+        await this.#loadChildrenWithOffsetPagination();
+        // Only show notification for actual errors
+        if (reason === 'error') {
+            const notificationManager = await this.getContext(UMB_NOTIFICATION_CONTEXT);
+            notificationManager?.peek('danger', {
+                data: { message: 'Menu loading failed. Showing the first items again.' },
+            });
+        }
     }
     #onPageChange;
     #listenForActionEvents() {

package/dist-cms/packages/core/workspace/entity-detail/entity-detail-workspace-base.js

@@ -231,7 +231,7 @@ export class UmbEntityDetailWorkspaceContextBase extends UmbSubmittableWorkspace
             }
         }
         else if (data) {
-            const processedData = await this._processIncomingData(data);
+            const processedData = await this._scaffoldProcessData(data);
             this._data.setPersisted(processedData);
             this._data.setCurrent(processedData);
             this.observe(asObservable?.(), (entity) => this.#onDetailStoreChange(entity), 'umbEntityDetailTypeStoreObserver');
@@ -281,7 +281,6 @@ export class UmbEntityDetailWorkspaceContextBase extends UmbSubmittableWorkspace
         this._getDataPromise = request;
         let { data } = await request;
         if (data) {
-            data = await this._processIncomingData(data);
             data = await this._scaffoldProcessData(data);
             if (this.modalContext) {
                 // Notice if the preset comes with values, they will overwrite the scaffolded values... [NL]
@@ -301,7 +300,7 @@ export class UmbEntityDetailWorkspaceContextBase extends UmbSubmittableWorkspace
      * @returns {Promise<DetailModelType>} The processed data.
      */
     async _scaffoldProcessData(data) {
-        return data;
+        return await this._processIncomingData(data);
     }
     async _processIncomingData(data) {
         return data;

package/dist-cms/packages/data-type/reference/info-app/manifests.js

@@ -1,20 +1,24 @@
 import { UMB_DATA_TYPE_WORKSPACE_ALIAS } from '../../workspace/constants.js';
 import { UMB_DATA_TYPE_REFERENCE_REPOSITORY_ALIAS } from '../constants.js';
-import { UMB_WORKSPACE_CONDITION_ALIAS } from '../../../core/workspace/index.js';
+import { UMB_WORKSPACE_CONDITION_ALIAS, UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS, } from '../../../core/workspace/index.js';
 export const manifests = [
     {
         type: 'workspaceInfoApp',
         kind: 'entityReferences',
         name: 'Data Type References Workspace Info App',
         alias: 'Umb.WorkspaceInfoApp.DataType.References',
+        meta: {
+            referenceRepositoryAlias: UMB_DATA_TYPE_REFERENCE_REPOSITORY_ALIAS,
+        },
         conditions: [
             {
                 alias: UMB_WORKSPACE_CONDITION_ALIAS,
                 match: UMB_DATA_TYPE_WORKSPACE_ALIAS,
             },
+            {
+                alias: UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS,
+                match: false,
+            },
         ],
-        meta: {
-            referenceRepositoryAlias: UMB_DATA_TYPE_REFERENCE_REPOSITORY_ALIAS,
-        },
     },
 ];

package/dist-cms/packages/documents/documents/reference/info-app/manifests.js

@@ -1,20 +1,24 @@
 import { UMB_DOCUMENT_WORKSPACE_ALIAS } from '../../workspace/constants.js';
 import { UMB_DOCUMENT_REFERENCE_REPOSITORY_ALIAS } from '../constants.js';
-import { UMB_WORKSPACE_CONDITION_ALIAS } from '../../../../core/workspace/index.js';
+import { UMB_WORKSPACE_CONDITION_ALIAS, UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS, } from '../../../../core/workspace/index.js';
 export const manifests = [
     {
         type: 'workspaceInfoApp',
         kind: 'entityReferences',
         name: 'Document References Workspace Info App',
         alias: 'Umb.WorkspaceInfoApp.Document.References',
+        meta: {
+            referenceRepositoryAlias: UMB_DOCUMENT_REFERENCE_REPOSITORY_ALIAS,
+        },
         conditions: [
             {
                 alias: UMB_WORKSPACE_CONDITION_ALIAS,
                 match: UMB_DOCUMENT_WORKSPACE_ALIAS,
             },
+            {
+                alias: UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS,
+                match: false,
+            },
         ],
-        meta: {
-            referenceRepositoryAlias: UMB_DOCUMENT_REFERENCE_REPOSITORY_ALIAS,
-        },
     },
 ];

package/dist-cms/packages/documents/documents/workspace/document-workspace.context.d.ts

@@ -18,7 +18,7 @@ export declare class UmbDocumentWorkspaceContext extends UmbContentDetailWorkspa
     readonly templateId: import("rxjs").Observable<string | null>;
     constructor(host: UmbControllerHost);
     resetState(): void;
-    protected loadSegments(): Promise<void>;
+    protected _loadSegmentsFor(unique: string): Promise<void>;
     create(parent: UmbEntityModel, documentTypeUnique: string, blueprintUnique?: string): Promise<UmbDocumentDetailModel | undefined>;
     /** @deprecated will be removed in v.18 */
     getCollectionAlias(): string;

package/dist-cms/packages/documents/documents/workspace/document-workspace.context.js

@@ -152,18 +152,16 @@ export class UmbDocumentWorkspaceContext extends UmbContentDetailWorkspaceContex
         super.resetState();
         this.#isTrashedContext.setIsTrashed(false);
     }
-    async loadSegments() {
-        this.observe(this.unique, async (unique) => {
-            if (!unique) {
-                this._segments.setValue([]);
-                return;
-            }
-            const { data } = await this.#documentSegmentRepository.getDocumentByIdSegmentOptions(unique, {
-                skip: 0,
-                take: 9999,
-            });
-            this._segments.setValue(data?.items ?? []);
-        }, '_loadSegmentsUnique');
+    async _loadSegmentsFor(unique) {
+        if (!unique) {
+            this._segments.setValue([]);
+            return;
+        }
+        const { data } = await this.#documentSegmentRepository.getDocumentByIdSegmentOptions(unique, {
+            skip: 0,
+            take: 9999,
+        });
+        this._segments.setValue(data?.items ?? []);
     }
     async create(parent, documentTypeUnique, blueprintUnique) {
         if (blueprintUnique) {

package/dist-cms/packages/management-api/tree/tree-data.request-manager.js

@@ -137,6 +137,9 @@ export class UmbManagementApiTreeDataRequestManager extends UmbControllerBase {
         return args.take !== undefined ? args.take : this.#defaultTakeSize;
     }
     #getTargetResultHasValidParents(data, parentUnique) {
+        if (!data) {
+            return false;
+        }
         return data.every((item) => {
             if (item.parent) {
                 return item.parent.id === parentUnique;

package/dist-cms/packages/media/media/reference/info-app/manifests.js

@@ -1,20 +1,24 @@
 import { UMB_MEDIA_WORKSPACE_ALIAS } from '../../workspace/constants.js';
 import { UMB_MEDIA_REFERENCE_REPOSITORY_ALIAS } from '../constants.js';
-import { UMB_WORKSPACE_CONDITION_ALIAS } from '../../../../core/workspace/index.js';
+import { UMB_WORKSPACE_CONDITION_ALIAS, UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS, } from '../../../../core/workspace/index.js';
 export const manifests = [
     {
         type: 'workspaceInfoApp',
         kind: 'entityReferences',
         name: 'Media References Workspace Info App',
         alias: 'Umb.WorkspaceInfoApp.Media.References',
+        meta: {
+            referenceRepositoryAlias: UMB_MEDIA_REFERENCE_REPOSITORY_ALIAS,
+        },
         conditions: [
             {
                 alias: UMB_WORKSPACE_CONDITION_ALIAS,
                 match: UMB_MEDIA_WORKSPACE_ALIAS,
             },
+            {
+                alias: UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS,
+                match: false,
+            },
         ],
-        meta: {
-            referenceRepositoryAlias: UMB_MEDIA_REFERENCE_REPOSITORY_ALIAS,
-        },
     },
 ];

package/dist-cms/packages/members/member/reference/info-app/manifests.js

@@ -1,20 +1,24 @@
 import { UMB_MEMBER_WORKSPACE_ALIAS } from '../../workspace/constants.js';
 import { UMB_MEMBER_REFERENCE_REPOSITORY_ALIAS } from '../constants.js';
-import { UMB_WORKSPACE_CONDITION_ALIAS } from '../../../../core/workspace/index.js';
+import { UMB_WORKSPACE_CONDITION_ALIAS, UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS, } from '../../../../core/workspace/index.js';
 export const manifests = [
     {
         type: 'workspaceInfoApp',
         kind: 'entityReferences',
         name: 'Member References Workspace Info App',
         alias: 'Umb.WorkspaceInfoApp.Member.References',
+        meta: {
+            referenceRepositoryAlias: UMB_MEMBER_REFERENCE_REPOSITORY_ALIAS,
+        },
         conditions: [
             {
                 alias: UMB_WORKSPACE_CONDITION_ALIAS,
                 match: UMB_MEMBER_WORKSPACE_ALIAS,
             },
+            {
+                alias: UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS,
+                match: false,
+            },
         ],
-        meta: {
-            referenceRepositoryAlias: UMB_MEMBER_REFERENCE_REPOSITORY_ALIAS,
-        },
     },
 ];

package/dist-cms/packages/relations/relations/reference/workspace-info-app/entity-references-workspace-view-info.element.d.ts

@@ -1,5 +1,4 @@
 import type { ManifestWorkspaceInfoAppEntityReferencesKind } from './types.js';
-import { nothing } from '../../../../../external/lit/index.js';
 import { UmbLitElement } from '../../../../core/lit-element/index.js';
 export declare class UmbEntityReferencesWorkspaceInfoAppElement extends UmbLitElement {
     #private;
@@ -10,7 +9,7 @@ export declare class UmbEntityReferencesWorkspaceInfoAppElement extends UmbLitEl
     private _total;
     private _items?;
     constructor();
-    render(): typeof nothing | import("lit-html").TemplateResult<1>;
+    render(): import("lit-html").TemplateResult<1>;
     static styles: import("lit").CSSResult[];
 }
 export { UmbEntityReferencesWorkspaceInfoAppElement as element };

package/dist-cms/packages/relations/relations/reference/workspace-info-app/entity-references-workspace-view-info.element.js

@@ -74,8 +74,6 @@ let UmbEntityReferencesWorkspaceInfoAppElement = class UmbEntityReferencesWorksp
         this.#getReferences();
     }
     render() {
-        if (!this._items?.length)
-            return nothing;
         return html `
 			<umb-workspace-info-app-layout headline="#references_labelUsedByItems">
 				<div id="content">${this.#renderItems()} ${this.#renderReferencePagination()}</div>
@@ -84,7 +82,10 @@ let UmbEntityReferencesWorkspaceInfoAppElement = class UmbEntityReferencesWorksp
     }
     #renderItems() {
         if (!this._items)
-            return;
+            return nothing;
+        if (this._items.length === 0) {
+            return html `<umb-localize class="noItems" key="references_itemHasNoReferences"></umb-localize>`;
+        }
         return html `
 			<uui-ref-list>
 				${repeat(this._items, (item) => item.unique, (item) => html `<umb-entity-item-ref .item=${item}></umb-entity-item-ref>`)}
@@ -116,6 +117,11 @@ let UmbEntityReferencesWorkspaceInfoAppElement = class UmbEntityReferencesWorksp
 				display: contents;
 			}
 
+			.noItems {
+				display: block;
+				margin: var(--uui-size-space-2);
+			}
+
 			#content {
 				display: block;
 				padding: var(--uui-size-space-3) var(--uui-size-space-4);