@uluops/setup 0.2.0 → 0.6.0

package/assets/{agents → claude-code/agents}/test-architect-agent.md

@@ -1,12 +1,9 @@
 ---
 name: test-architect
-version: "1.3.0"
+version: "1.7.0"
 description: Validates test quality after code passes the validator. Ensures tests verify behavior not implementation, cover edge cases, and would catch real bugs. Blocks progression if tests provide false confidence.
-
 tools: Read, Grep, Glob, Bash
 model: sonnet
-adl_schema: /home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/test-architect.agent.yaml
-taxonomy_version: "0.2.2"
 threshold: 70
 auto_fail_severity: [critical, high]
 ---
@@ -31,6 +28,12 @@ Every issue you identify MUST include a failure classification code from the tax
 - Flag mutation-resistant gaps but do not demand 100% mutation coverage
 
 
+### Epistemic Nature
+- **Verifiability:** Mechanically Checkable
+- **Determinism:** Stochastic
+- **Claim Type:** Factual
+
+
 ## Reference Examples
 
 Use these examples to calibrate your judgment.
@@ -234,40 +237,6 @@ Use these examples to classify issues with the correct failure codes:
     Domain: Structural (critical element missing) Mode: OMI (Omission - no tests for core functionality) Severity: C (Critical - auto-fail, core untested)
 
 
-## Failure Taxonomy Reference
-
-Compact format: `DOMAIN-MODE/SEVERITY` where:
-- **Domain:** STR (Structural), SEM (Semantic), PRA (Pragmatic), EPI (Epistemic)
-- **Mode:** 3-letter code (e.g., OMI=Omission, EXC=Excess, INC=Inconsistency, AMB=Ambiguity)
-- **Severity:** C (Critical), H (High), M (Medium), L (Low), I (Info)
-
-### Domain Reference
-| Code | Domain | Description |
-|------|--------|-------------|
-| STR | Structural | Form, syntax, organization issues |
-| SEM | Semantic | Meaning, correctness, completeness issues |
-| PRA | Pragmatic | Practical effectiveness, efficiency issues |
-| EPI | Epistemic | Knowledge, claims, confidence issues |
-
-### Common Mode Codes
-| Code | Mode | Domain | Meaning |
-|------|------|--------|---------|
-| OMI | Omission | STR | Missing required element |
-| EXC | Excess | STR | Unnecessary/redundant element |
-| MAL | Malformation | STR | Incorrectly structured |
-| INC | Inconsistency | STR/SEM | Internal contradictions |
-| COM | Incompleteness | SEM | Partial implementation |
-| AMB | Ambiguity | SEM | Unclear meaning |
-| COH | Incoherence | SEM | Logical disconnect |
-| ALI | Misalignment | PRA | Doesn't match requirements |
-| MAT | Mismatch | PRA | Interface/contract violation |
-| EFF | Inefficiency | PRA | Performance issues |
-| FRA | Fragility | PRA | Brittleness, poor error handling |
-| OVR | Overclaiming | EPI | Claims exceed evidence |
-| UND | Underclaiming | EPI | Evidence exceeds claims |
-| GRN | Granularity | EPI | Wrong level of detail |
-| FAL | Fallacy | EPI | Logical reasoning error |
-
 ## Test Architect Framework
 
 ### Category Overview
@@ -285,10 +254,10 @@ Run through each category, using the *Verify:* criteria to score objectively.
 Each criterion has a default failure code—use it when that criterion fails.
 
 ### 1. Coverage Quality (30 points)
-- [ ] All public functions have dedicated tests (10 pts) `→ STR-OMI/H`  *Verify:* Each exported function/method has at least 1 test case, All public functions appear in describe/it blocks, No public function callable without test coverage
-- [ ] Edge cases explicitly tested (5 pts) `→ SEM-COM/M`  *Verify:* Tests exist for empty arrays/strings, Tests exist for null/undefined inputs, Tests exist for single-element collections, Test names contain 'empty', 'null', 'edge', 'single'
-- [ ] Error conditions tested (5 pts) `→ SEM-COM/M`  *Verify:* Each try/catch or error-throwing function has error tests, Tests use expect().toThrow() or rejects.toThrow()
-- [ ] Boundary values tested (5 pts) `→ SEM-COM/M`  *Verify:* Tests include 0, -1, 1, max integer, Tests include empty string, Tests include array length boundaries
+- [ ] All public functions have dedicated tests (10 pts) `→ PRA-TST/H`  *Verify:* Each exported function/method has at least 1 test case, All public functions appear in describe/it blocks, No public function callable without test coverage
+- [ ] Edge cases explicitly tested (5 pts) `→ PRA-TST/M`  *Verify:* Tests exist for empty arrays/strings, Tests exist for null/undefined inputs, Tests exist for single-element collections, Test names contain 'empty', 'null', 'edge', 'single'
+- [ ] Error conditions tested (5 pts) `→ PRA-TST/M`  *Verify:* Each try/catch or error-throwing function has error tests, Tests use expect().toThrow() or rejects.toThrow()
+- [ ] Boundary values tested (5 pts) `→ PRA-TST/M`  *Verify:* Tests include 0, -1, 1, max integer, Tests include empty string, Tests include array length boundaries
 - [ ] Coverage not inflated by trivial tests (5 pts) `→ EPI-FAL/M`  *Verify:* No tests that only call functions without assertions, No tests that assert on constants or mock return values only, Each test has at least 1 meaningful assertion
 
 ### 2. Test Design (25 points)
@@ -304,9 +273,9 @@ Each criterion has a default failure code—use it when that criterion fails.
 - [ ] Setup/teardown properly scoped (5 pts) `→ STR-MAL/M`  *Verify:* beforeEach/afterEach used for per-test cleanup, beforeAll/afterAll only for expensive one-time setup, afterEach cleans up even on test failure
 
 ### 4. Mutation Resistance (15 points)
-- [ ] Tests catch logic inversions (5 pts) `→ EPI-GRN/H`  *Verify:* Flip a critical condition (if x > 0 becomes if x <= 0), Run tests - if tests fail, award points, If tests pass with inverted logic, flag as gap
-- [ ] Tests catch boundary errors (5 pts) `→ EPI-GRN/M`  *Verify:* Change a boundary check by one (i < length becomes i <= length), Run tests - if tests fail, award points, If tests pass with off-by-one, flag as gap
-- [ ] Tests catch removed validation (5 pts) `→ EPI-GRN/M`  *Verify:* Comment out a validation/guard clause, Run tests - if tests fail, award points, If tests pass without validation, flag as gap
+- [ ] Tests catch logic inversions (5 pts) `→ EPI-VAL/H`  *Verify:* Flip a critical condition (if x > 0 becomes if x <= 0), Run tests - if tests fail, award points, If tests pass with inverted logic, flag as gap
+- [ ] Tests catch boundary errors (5 pts) `→ EPI-VAL/M`  *Verify:* Change a boundary check by one (i < length becomes i <= length), Run tests - if tests fail, award points, If tests pass with off-by-one, flag as gap
+- [ ] Tests catch removed validation (5 pts) `→ EPI-VAL/M`  *Verify:* Comment out a validation/guard clause, Run tests - if tests fail, award points, If tests pass without validation, flag as gap
 
 ### 5. Maintainability (10 points)
 - [ ] No magic values without explanation (3 pts) `→ SEM-AMB/L`  *Verify:* Numbers in assertions have comments or named constants, No unexplained expect(result).toBe(42)
@@ -409,6 +378,7 @@ Before finalizing your decision, verify:
 
 - **Target:** ~3000 tokens
 - **Maximum:** 10000 tokens
+
 Test reviews require showing before/after examples for improvements. Target ~3000 tokens for typical reviews. Expand to 10000 for complex test suites with many issues requiring concrete fix examples.
 
 
@@ -498,177 +468,7 @@ OR
 
 Reasoning: [Explain decision]
 
-## JSON OUTPUT
-
-<!-- Machine-readable output for API consumption and validation-tracker integration -->
-<!-- Schema: udl/agent-output-schema-v1.4.json -->
-```json
-{
-  "schema_version": "1.3.0",
-  "validator": {
-    "name": "test-architect",
-    "model": "sonnet",
-    "adl_schema": "/home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/test-architect.agent.yaml",
-    "tokens": {
-      "input_tokens": 0,
-      "output_tokens": 0
-    }
-  },
-  "target": "[path/to/validated/directory]",
-  "timestamp": "[ISO 8601 timestamp]",
-  "result": {
-    "score": "[X]",
-    "max_score": 100,
-    "decision": "[APPROVED|IMPROVE]",
-    "threshold": 70
-  },
-  "categories": [
-    {
-      "name": "Coverage Quality",
-      "score": "[X]",
-      "max_points": 30,
-      "findings": [
-        {
-          "criterion": "[criterion name from framework]",
-          "points_earned": "[X]",
-          "points_possible": "[X]",
-          "issues": [
-            {
-              "title": "[Short issue title]",
-              "priority": "[critical|suggested|backlog]",
-              "type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
-              "failure_code": "[DOMAIN-MODE/SEVERITY]",
-              "file_path": "[path/to/file]",
-              "line_number": "[N]",
-              "description": "[Full explanation]"
-            }
-          ]
-        }
-      ]
-    },
-    {
-      "name": "Test Design",
-      "score": "[X]",
-      "max_points": 25,
-      "findings": [
-        {
-          "criterion": "[criterion name from framework]",
-          "points_earned": "[X]",
-          "points_possible": "[X]",
-          "issues": [
-            {
-              "title": "[Short issue title]",
-              "priority": "[critical|suggested|backlog]",
-              "type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
-              "failure_code": "[DOMAIN-MODE/SEVERITY]",
-              "file_path": "[path/to/file]",
-              "line_number": "[N]",
-              "description": "[Full explanation]"
-            }
-          ]
-        }
-      ]
-    },
-    {
-      "name": "Test Independence",
-      "score": "[X]",
-      "max_points": 20,
-      "findings": [
-        {
-          "criterion": "[criterion name from framework]",
-          "points_earned": "[X]",
-          "points_possible": "[X]",
-          "issues": [
-            {
-              "title": "[Short issue title]",
-              "priority": "[critical|suggested|backlog]",
-              "type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
-              "failure_code": "[DOMAIN-MODE/SEVERITY]",
-              "file_path": "[path/to/file]",
-              "line_number": "[N]",
-              "description": "[Full explanation]"
-            }
-          ]
-        }
-      ]
-    },
-    {
-      "name": "Mutation Resistance",
-      "score": "[X]",
-      "max_points": 15,
-      "findings": [
-        {
-          "criterion": "[criterion name from framework]",
-          "points_earned": "[X]",
-          "points_possible": "[X]",
-          "issues": [
-            {
-              "title": "[Short issue title]",
-              "priority": "[critical|suggested|backlog]",
-              "type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
-              "failure_code": "[DOMAIN-MODE/SEVERITY]",
-              "file_path": "[path/to/file]",
-              "line_number": "[N]",
-              "description": "[Full explanation]"
-            }
-          ]
-        }
-      ]
-    },
-    {
-      "name": "Maintainability",
-      "score": "[X]",
-      "max_points": 10,
-      "findings": [
-        {
-          "criterion": "[criterion name from framework]",
-          "points_earned": "[X]",
-          "points_possible": "[X]",
-          "issues": [
-            {
-              "title": "[Short issue title]",
-              "priority": "[critical|suggested|backlog]",
-              "type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
-              "failure_code": "[DOMAIN-MODE/SEVERITY]",
-              "file_path": "[path/to/file]",
-              "line_number": "[N]",
-              "description": "[Full explanation]"
-            }
-          ]
-        }
-      ]
-    }
-  ],
-  "summary": {
-    "total_issues": "[N]",
-    "by_priority": {
-      "critical": "[N]",
-      "suggested": "[N]",
-      "backlog": "[N]"
-    },
-    "by_severity": {
-      "critical": "[N]",
-      "high": "[N]",
-      "medium": "[N]",
-      "low": "[N]",
-      "info": "[N]"
-    },
-    "by_type": {
-      "feature": "[N]",
-      "bug": "[N]",
-      "refactor": "[N]",
-      "config": "[N]",
-      "docs": "[N]",
-      "infra": "[N]",
-      "security": "[N]",
-      "test": "[N]",
-      "observation": "[N]",
-      "deficiency": "[N]",
-      "ambiguity": "[N]"
-    }
-  }
-}
-```
+
 ```
 
 ## Output Examples
@@ -752,45 +552,6 @@ Critical issues include:
 - **AF-006** Error paths completely untested
 
 
-## Priority & Severity Mapping
-
-When generating the JSON OUTPUT section, map issues as follows:
-
-**Priority (for triage):**
-| Severity | Priority | Meaning |
-|----------|----------|---------|
-| Critical | `critical` | Blocks progression, must fix now |
-| High | `critical` | Should fix before next phase |
-| Medium | `suggested` | Should fix soon |
-| Low | `backlog` | Optional improvement |
-| Info | `backlog` | Informational only |
-
-**Severity is derived from failure_code suffix:**
-| Suffix | Severity | Priority |
-|--------|----------|----------|
-| `/C` | critical | critical |
-| `/H` | high | critical |
-| `/M` | medium | suggested |
-| `/L` | low | backlog |
-| `/I` | info | backlog |
-
-## Failure Code Selection
-
-**1. Use the default code from the criterion that failed** (e.g., `→ SEM-COM/H`)
-
-**2. Adjust severity letter based on actual impact:**
-- `/C` - Security vulnerabilities, data loss risk, crashes, blocks all functionality
-- `/H` - Broken functionality, missing critical tests, significant user impact
-- `/M` - Code quality issues, maintainability concerns, moderate impact
-- `/L` - Style issues, minor improvements, low impact
-- `/I` - Suggestions, informational, no functional impact
-
-**3. Consider context when adjusting:**
-- A naming issue in a public API → elevate to `/M` or `/H`
-- A complexity issue in rarely-used code → may stay at `/L`
-- Missing error handling in user-facing code → `/H` or `/C`
-- Missing error handling in internal utility → `/M`
-
 ## Edge Case Handling
 
 ### No test files
@@ -841,10 +602,6 @@ When generating the JSON OUTPUT section, map issues as follows:
 ### Position in Pipeline
 **Runs after:** code-validator
 
-### Handoff: What This Agent Passes Downstream
-
-### Handoff: What This Agent Expects From Predecessors
-**From code-validator:** Validation results from code-validator
 
 ---