@ultraviolet/ui 1.11.0 → 1.11.2

package/dist/index.d.ts

@@ -24,11 +24,10 @@ type ActionBarProps = {
      */
     rank?: number;
     role?: string;
-    'aria-modal'?: 'true' | 'false';
     className?: string;
     'data-testid'?: string;
 };
-declare const ActionBar: ({ children, role, rank, "aria-modal": ariaModal, className, "data-testid": dataTestId, }: ActionBarProps) => react.ReactPortal;
+declare const ActionBar: ({ children, role, rank, className, "data-testid": dataTestId, }: ActionBarProps) => react.ReactPortal;
 
 type ScreenSize = keyof typeof consoleLightTheme.screens;
 type SCWUITheme = typeof consoleLightTheme;

package/dist/src/components/ActionBar/index.js

@@ -33,14 +33,12 @@ const ActionBar = _ref5 => {
     children,
     role = 'dialog',
     rank = 0,
-    'aria-modal': ariaModal = 'true',
     className,
     'data-testid': dataTestId
   } = _ref5;
   return /*#__PURE__*/createPortal(jsx(StyledDiv, {
     rank: rank,
     role: role,
-    "aria-modal": ariaModal,
     className: className,
     "data-testid": dataTestId,
     children: children

package/dist/src/components/Modal/Dialog.js

@@ -73,6 +73,7 @@ const Dialog = _ref9 => {
     backdropCss
   } = _ref9;
   const containerRef = useRef(document.createElement('div'));
+  const dialogRef = useRef(null);
   const onCloseRef = useRef(onClose);
 
   // Portal to put the modal in
@@ -97,14 +98,27 @@ const Dialog = _ref9 => {
   useEffect(() => {
     const handleEscPress = event => {
       if (event.key === 'Escape' && hideOnEsc) {
+        event.preventDefault();
+        event.stopPropagation();
         onCloseRef.current();
       }
     };
     if (open) {
-      document.addEventListener('keyup', handleEscPress);
+      dialogRef.current?.focus();
+      document.body.addEventListener('keyup', handleEscPress, {
+        capture: true
+      });
+      document.body.addEventListener('keydown', handleEscPress, {
+        capture: true
+      });
     }
     return () => {
-      document.removeEventListener('keyup', handleEscPress);
+      document.body.removeEventListener('keyup', handleEscPress, {
+        capture: true
+      });
+      document.body.removeEventListener('keydown', handleEscPress, {
+        capture: true
+      });
     };
   }, [open, onCloseRef, hideOnEsc]);
 
@@ -117,6 +131,11 @@ const Dialog = _ref9 => {
     }
   }, [preventBodyScroll, open]);
 
+  // Stop focus to prevent unexpected body loose focus
+  const stopFocus = useCallback(event => {
+    event.stopPropagation();
+  }, []);
+
   // Stop click to prevent unexpected dialog close
   const stopClick = useCallback(event => {
     event.stopPropagation();
@@ -126,15 +145,53 @@ const Dialog = _ref9 => {
   const stopKeyUp = useCallback(event => {
     event.stopPropagation();
   }, []);
+
+  // Enable focus trap inside the modal
+  const handleFocusTrap = useCallback(event => {
+    event.stopPropagation();
+    if (event.key === 'Escape') {
+      event.preventDefault();
+      return;
+    }
+    const isTabPressed = event.key === 'Tab';
+    if (!isTabPressed) {
+      return;
+    }
+    const focusableEls = dialogRef.current?.querySelectorAll('a[href]:not([disabled]), button:not([disabled]), textarea:not([disabled]), input:not([disabled]), select:not([disabled])') ?? [];
+
+    // Handle case when no interactive element are within the modal (including close icon)
+    if (focusableEls.length === 0) {
+      event.preventDefault();
+    }
+    const firstFocusableEl = focusableEls[0];
+    const lastFocusableEl = focusableEls[focusableEls.length - 1];
+    if (event.shiftKey) {
+      if (document.activeElement === firstFocusableEl || document.activeElement === dialogRef.current) {
+        lastFocusableEl.focus();
+        event.preventDefault();
+      }
+    } else if (document.activeElement === lastFocusableEl || document.activeElement === dialogRef.current) {
+      firstFocusableEl.focus();
+      event.preventDefault();
+    }
+  }, []);
+
+  // Prevent default behaviour on Escape
+  const stopCancel = event => {
+    event.preventDefault();
+    event.stopPropagation();
+  };
   return /*#__PURE__*/createPortal(jsx(StyledBackdrop, {
     "data-open": open,
     onClick: hideOnClickOutside ? onClose : undefined,
     className: backdropClassName,
     css: backdropCss,
     "data-testid": dataTestId ? `${dataTestId}-backdrop` : undefined,
+    onFocus: stopFocus,
     children: jsx(StyledDialog, {
       css: dialogCss,
       onKeyUp: stopKeyUp,
+      onKeyDown: handleFocusTrap,
       className: className,
       id: id,
       "data-testid": dataTestId,
@@ -143,6 +200,11 @@ const Dialog = _ref9 => {
       "data-size": size,
       open: open,
       onClick: stopClick,
+      onCancel: stopCancel,
+      onClose: stopCancel,
+      "aria-modal": true,
+      ref: dialogRef,
+      tabIndex: 0,
       children: open ? children : null
     })
   }), containerRef.current);

package/dist/src/components/Modal/Disclosure.js

@@ -30,7 +30,9 @@ const Disclosure = _ref => {
   if ( /*#__PURE__*/isValidElement(disclosure)) {
     return /*#__PURE__*/cloneElement(disclosure, {
       ...disclosure.props,
-      ref: disclosureRef
+      ref: disclosureRef,
+      'aria-controls': id,
+      'aria-haspopup': 'dialog'
     });
   }
   return null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ultraviolet/ui",
-  "version": "1.11.0",
+  "version": "1.11.2",
   "description": "Ultraviolet UI",
   "homepage": "https://github.com/scaleway/ultraviolet#readme",
   "repository": {
@@ -39,13 +39,13 @@
     "react-dom": "18.2.0"
   },
   "devDependencies": {
-    "@babel/core": "7.22.11",
+    "@babel/core": "7.22.15",
     "@emotion/babel-plugin": "11.11.0",
     "@emotion/react": "11.11.1",
     "@emotion/styled": "11.11.0",
-    "@types/react": "18.2.14",
+    "@types/react": "18.2.21",
     "@types/react-datepicker": "4.15.0",
-    "@types/react-dom": "18.2.6",
+    "@types/react-dom": "18.2.7",
     "react": "18.2.0",
     "react-dom": "18.2.0"
   },
@@ -68,6 +68,6 @@
     "react-use-clipboard": "1.0.9",
     "reakit": "1.3.11",
     "@ultraviolet/themes": "1.2.1",
-    "@ultraviolet/icons": "1.3.1"
+    "@ultraviolet/icons": "2.0.1"
   }
 }