@ultimat3/testing 23.0.0 → 24.0.0

package/src/job-driver-conformance.ts

@@ -0,0 +1,21 @@
+// The `JobDriver` contract as shared examples: `behavesLike(jobDriverConformance, () => driver)`
+// runs every check in `job-driver-checks.ts` against a driver of your own, one test per check.
+// The subject is called once per test — hand back a fresh driver, or one store with no rows a
+// check could mistake for its own (each check claims only from a queue it named).
+
+import { test } from 'bun:test';
+import type { JobDriver } from '@ultimat3/jobs';
+import { JOB_DRIVER_CHECKS } from './job-driver-checks';
+import type { SharedExamples } from './shared-examples';
+import { sharedExamples } from './shared-examples';
+
+export const jobDriverConformance: SharedExamples<JobDriver | Promise<JobDriver>> = sharedExamples(
+  'a job driver',
+  (subject) => {
+    for (const check of JOB_DRIVER_CHECKS) {
+      test(check.name, async () => {
+        await check.run(await subject());
+      });
+    }
+  },
+);

package/src/live-node.ts

@@ -178,6 +178,8 @@ export async function createLiveNode(options: LiveNodeOptions = {}): Promise<Liv
           data = upgradeOptions.data;
           return true;
         },
+        // No socket behind this harness, so no peer address: a health path answers the verdict.
+        requestIP: () => null,
       };
       // `/_x/sync` is `SyncNodeOptions.path`'s default and `handleUpgrade` answers 404 to
       // anything else. The `c` parameter is this connection's actor key — see `ACTORS` above.

package/src/preload.ts

@@ -12,8 +12,7 @@ import { registerFrameworkFixtures } from './framework-fixtures';
 import './matchers';
 import { installAppJsxLoader } from './app-jsx-loader';
 import { onFileBoundary } from './file-boundary';
-import { disposeLiveIslands } from './fixture-island';
-import { releasePluginsAfterIsolatedFile } from './isolated-plugins';
+import { ISOLATED_ENV, releasePluginsAfterIsolatedFile } from './isolated-plugins';
 import { installPerTestReset } from './per-test-reset';
 import { installRegistryLeakGuard } from './registry-leak-guard';
 import { sealNetwork } from './sealed-network';
@@ -44,11 +43,6 @@ Bun.env['ULTIMATE_TEST_SLOT_HELD'] ??= '1';
 // fails a later file in another package, for a reason nothing in that file explains.
 installRegistryLeakGuard();
 
-// A worker runs many files in one global unless the repo opted into `--isolate` (22.7): a mount a
-// file never disposed is disposed between files, and `file-boundary.ts` then puts `globalThis`
-// back to what the first file saw.
-onFileBoundary(disposeLiveIslands);
-
 // And per TEST: the jobs event bus stores what it is handed, so one test's published answer
 // resumed the next test's waiting run (`per-test-reset.ts`).
 installPerTestReset();
@@ -56,7 +50,7 @@ installPerTestReset();
 // A shared worker only (an isolated file is a fresh registry anyway): the app's
 // `defineApi({ pathStyle })` evaluates once per worker, in whichever file first imports it, and
 // must not be refused because an EARLIER file derived action paths under the default style.
-if (Bun.env['ULTIMATE_TEST_ISOLATED'] !== '1') {
+if (Bun.env[ISOLATED_ENV] !== '1') {
   const { forgetHandedOutActionPaths } = await import('@ultimat3/action');
   onFileBoundary(forgetHandedOutActionPaths);
 }

package/src/registry-leak-guard.ts

@@ -7,7 +7,7 @@ import { afterAll } from 'bun:test';
 import { knownTags, registeredTiers } from '@ultimat3/cache';
 import { isAppRoot } from './app-jsx-loader';
 import { RegistryLeakError } from './errors';
-import { runFileBoundary } from './file-boundary';
+import { runBoundaryHooks, runFileBoundary } from './file-boundary';
 import type { ProcessRegistrySnapshot } from './registry-snapshot';
 import {
   captureProcessRegistries,
@@ -219,6 +219,8 @@ export function installRegistryLeakGuard(): void {
   });
 
   afterAll(() => {
+    // The run's LAST file has no boundary after it: its undisposed island mounts end here.
+    runBoundaryHooks();
     close();
     if (leaks.length > 0) throw new RegistryLeakError({ leaks });
   });

package/src/registry-snapshot.ts

@@ -24,6 +24,7 @@ import { registeredTasks, restoreTasks } from '@ultimat3/jobs';
 import type { RoleMap } from '@ultimat3/policy';
 import {
   knownPermissions,
+  permissionDeclarationSites,
   restorePermissions,
   restoreRoles,
   roleDeclarationSites,
@@ -39,6 +40,8 @@ export interface ProcessRegistrySnapshot {
   readonly locales: LocaleConfig;
   readonly catalogs: readonly (readonly [Locale, Catalog])[];
   readonly permissions: readonly string[];
+  /** Restored WITH the names: a site-less permission is one the policy step can never judge. */
+  readonly permissionSites: Readonly<Record<string, readonly string[]>>;
   readonly roles: RoleMap;
   /** Kept beside the map: restoring through `defineRoles()` would rewrite every site. */
   readonly roleSites: Readonly<Record<string, string>>;
@@ -57,6 +60,7 @@ export function captureProcessRegistries(): ProcessRegistrySnapshot {
     locales: localeConfig(),
     catalogs: registeredLocales().map((locale) => [locale, catalogFor(locale)] as const),
     permissions: knownPermissions(),
+    permissionSites: permissionDeclarationSites(),
     roles: roleDefinitions(),
     roleSites: roleDeclarationSites(),
     tasks: registeredTasks(),
@@ -74,7 +78,7 @@ export function restoreProcessRegistries(snapshot: ProcessRegistrySnapshot): voi
   // a partial call can never widen `supported` back.
   configureLocales(snapshot.locales);
   restoreCatalogs(snapshot.catalogs);
-  restorePermissions(snapshot.permissions);
+  restorePermissions(snapshot.permissions, snapshot.permissionSites);
   restoreRoles(snapshot.roles, snapshot.roleSites);
   restoreTasks(snapshot.tasks);
 }
@@ -138,9 +142,26 @@ export function mergeSnapshots(
     locales: newer.locales,
     catalogs: [...catalogs],
     permissions: [...new Set([...older.permissions, ...newer.permissions])],
+    permissionSites: mergeSites(older.permissionSites, newer.permissionSites),
     roles: { ...older.roles, ...newer.roles },
     roleSites: { ...older.roleSites, ...newer.roleSites },
     tasks: [...tasks.values()],
     catalogDeclarations: Math.max(older.catalogDeclarations, newer.catalogDeclarations),
   };
 }
+
+/** Per name, every module either snapshot saw declare it — the union the names themselves are. */
+function mergeSites(
+  older: Readonly<Record<string, readonly string[]>>,
+  newer: Readonly<Record<string, readonly string[]>>,
+): Readonly<Record<string, readonly string[]>> {
+  const merged = new Map<string, Set<string>>();
+  for (const side of [older, newer]) {
+    for (const [name, at] of Object.entries(side)) {
+      const into = merged.get(name) ?? new Set<string>();
+      for (const site of at) into.add(site);
+      merged.set(name, into);
+    }
+  }
+  return Object.fromEntries([...merged].map(([name, at]) => [name, [...at]]));
+}

package/src/sealed-network.ts

@@ -36,7 +36,11 @@ const state: SealState = {
 };
 
 const matches = (route: MockRoute, url: string): boolean => {
-  if (route.match instanceof RegExp) return route.match.test(url);
+  if (route.match instanceof RegExp) {
+    // A `g`/`y` pattern's `test` resumes at `lastIndex`: without the reset, every other call missed.
+    route.match.lastIndex = 0;
+    return route.match.test(url);
+  }
   if (route.match.endsWith('*')) return url.startsWith(route.match.slice(0, -1));
   return route.match === url;
 };

package/src/template-db.ts

@@ -18,7 +18,7 @@ export interface TemplateDbConfig {
   /** Connection URL with rights to CREATE DATABASE. Absent means "fall back to PGlite". */
   readonly adminUrl?: string | undefined;
   readonly templateName?: string;
-  /** Applied once, into the template, under an advisory lock. */
+  /** Applied into the template under an advisory lock, which every worker's clone also holds. */
   readonly migrate?: (url: string) => Promise<void>;
 }
 
@@ -144,11 +144,14 @@ export async function acquireWorkerDatabase(
       // serialises them, so a failure here is a real failure and `alreadyExists` (a substring match
       // on the message) would read `relation "x_jobs" already exists` as success.
       if (config.migrate !== undefined) await config.migrate(urlFor(adminUrl, template));
+      // INSIDE the lock: `CREATE DATABASE … TEMPLATE` waits 5 s for every session on the template
+      // to leave, then refuses — and the next worker's migration opens one the moment the lock is
+      // free. Measured: a clone outside it failed whenever that migration ran past 5 s.
+      await admin.exec(dropSql(database));
+      await admin.exec(cloneSql(template, database));
     } finally {
       await admin.exec(unlockSql(template));
     }
-    await admin.exec(dropSql(database));
-    await admin.exec(cloneSql(template, database));
   } catch (error) {
     await admin.close();
     throw new TestDatabaseUnavailableError({