@ultimat3/pwa 16.0.0 → 17.0.0

package/CLAUDE.md

@@ -16,6 +16,7 @@ Tier 4. May import tiers 0–3: `core`, `schema`, `i18n`, `money`, `time`, `cach
 | Route input | `PwaRoute` is a **structural** view of render's `RouteDescriptor`. Never import render. |
 | Strategy choice | derived from render mode via `MODE_STRATEGY`. Per-route override only. |
 | Precache revision | content hash. Never the build id — that re-downloads everything per deploy. |
+| Every byte count and every threshold | a whole number of 0 or more, screened with `finiteCount` where it is READ — `buildPrecacheManifest`'s `warnBytes` AND each entry's own `bytes` (shell, route, asset), `createInstallController`'s `minEngagementMs`, `retentionPlan`'s `keep`. `totalBytes > warnBytes` is false when EITHER side is `NaN`, so one asset whose byte count did not arrive as a number took down the install-size warning for every other entry, silently, in the function whose output is otherwise byte-identical per commit; `now() - startedAt < NaN` is false at every instant, so the install prompt fired on first paint; and `Math.max(1, NaN)` is `NaN` with `slice(0, NaN)` `[]`, so a retention plan evicted every deploy including the running one. `Math.max` is not a validator — it propagates. `keep: 0` still means 1 (`version-skew.test.ts` pins it), so the floor is 0 everywhere here. `bun run finite-bounds` is the ratchet. |
 | Precache KEY | the bare URL, always. The revision addresses the FETCH (`?v=<hash>`), never the key: every strategy looks an entry up with `caches.match(req)` and `ignoreSearch` defaults to `false`, so an entry left keyed under `?v=` is a permanent miss — offline serves the fallback document instead of the precached page, and online every precached byte is downloaded twice. `addAll` still does the fetching, because its all-or-nothing failure is what stops a half-populated precache from activating; the install block only re-keys what it stored. `service-worker-runtime.test.ts` executes the emitted `sw.js` against stub `caches`/`fetch` rather than asserting its text. |
 | Precache FETCH | the revision is appended with `?` or `&`, picked per entry. `PrecacheAsset.url` is public API and a bundler emits `?v=<hash>` of its own, so a fixed `?` built `...?locale=en?v=<rev>`; `addAll` is all-or-nothing, so one non-200 there means `install` rejects and the worker never activates at all. |
 | SW scope | `assertScope` refuses a relative `swPath`. `lastIndexOf('/')` on `sw.js` is `-1`, so the directory was `''` and `scope.startsWith('')` passed for every scope — the check waved through exactly the config most likely to be wrong. |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ultimat3/pwa",
-  "version": "16.0.0",
+  "version": "17.0.0",
   "description": "Generated service worker, web manifest, icons, push and version-skew handling.",
   "license": "MIT",
   "type": "module",
@@ -31,7 +31,7 @@
     "test": "bun test"
   },
   "dependencies": {
-    "@ultimat3/core": "16.0.0",
-    "@ultimat3/seo": "16.0.0"
+    "@ultimat3/core": "17.0.0",
+    "@ultimat3/seo": "17.0.0"
   }
 }

package/src/install.ts

@@ -5,6 +5,8 @@
  * permanently on some platforms.
  */
 
+import { finiteCount } from '@ultimat3/core';
+
 /** A minimal signal so this file needs no framework runtime. */
 export interface ReadSignal<T> {
   (): T;
@@ -77,7 +79,14 @@ export interface InstallController {
 
 export function createInstallController(options: InstallOptions): InstallController {
   const host = options.host;
-  const minEngagementMs = options.minEngagementMs ?? MIN_ENGAGEMENT_MS;
+  // `now() - startedAt < NaN` is false at every instant, so a threshold that arrived non-finite
+  // does not shorten the wait — it deletes it, and the prompt fires on first paint. `0` stays
+  // legal: "ask as soon as the browser offers" is a decision, and it is a comparison that works.
+  const minEngagementMs = finiteCount(
+    'createInstallController',
+    'minEngagementMs',
+    options.minEngagementMs ?? MIN_ENGAGEMENT_MS,
+  );
   const startedAt = host.now();
 
   const canInstall = createSignal(false);

package/src/precache.ts

@@ -6,7 +6,7 @@
 
 // One formatter, in `@ultimat3/core`: the copy that lived here stopped at `mb`, and the route
 // budget message on the other side of the build stopped at `kb`, for the same byte count.
-import { formatBytes } from '@ultimat3/core';
+import { finiteCount, formatBytes } from '@ultimat3/core';
 import type { PwaRoute } from './strategies';
 
 export interface PrecacheAsset {
@@ -54,6 +54,11 @@ export const DEFAULT_PRECACHE_WARN_BYTES = 5 * 1024 * 1024;
 export function buildPrecacheManifest(input: PrecacheInput): PrecacheManifest {
   const entries = new Map<string, PrecacheEntry>();
   const add = (entry: PrecacheEntry): void => {
+    // Screened per entry, not on the total: `totalBytes > warnBytes` is false when either side is
+    // `NaN`, so ONE asset whose byte count did not arrive as a number takes down the budget
+    // warning for every other entry — silently, in a function whose output is otherwise
+    // byte-identical per commit. This runs at build time, where a refusal is the right answer.
+    finiteCount('buildPrecacheManifest', `bytes for ${entry.url}`, entry.bytes);
     if (!entries.has(entry.url)) entries.set(entry.url, entry);
   };
 
@@ -106,7 +111,11 @@ export function buildPrecacheManifest(input: PrecacheInput): PrecacheManifest {
   // rule tie-break and `@ultimat3/jobs`' `job.ts`.
   const sorted = [...entries.values()].sort((a, b) => (a.url < b.url ? -1 : a.url > b.url ? 1 : 0));
   const totalBytes = sorted.reduce((sum, entry) => sum + entry.bytes, 0);
-  const warnBytes = input.warnBytes ?? DEFAULT_PRECACHE_WARN_BYTES;
+  const warnBytes = finiteCount(
+    'buildPrecacheManifest',
+    'warnBytes',
+    input.warnBytes ?? DEFAULT_PRECACHE_WARN_BYTES,
+  );
 
   const warnings: string[] = [];
   if (totalBytes > warnBytes) {

package/src/version-skew.ts

@@ -10,6 +10,7 @@
  * The app decides what to do with that message. This package never navigates a client.
  */
 
+import { finiteCount } from '@ultimat3/core';
 import { BuildIdMissingError } from './errors';
 
 export const BUILD_ID_HEADER = 'x-ultimate-build';
@@ -90,9 +91,13 @@ export interface RetentionPlan {
  * before it is allowed to break; 3 is the sane default for a daily-deploy team.
  */
 export function retentionPlan(deploys: readonly Deploy[], keep = 3): RetentionPlan {
+  // `Math.max` is not a validator, it PROPAGATES: `Math.max(1, NaN)` is `NaN`, `slice(0, NaN)` is
+  // `[]`, and the plan then retains nothing and evicts every deploy — the running one included,
+  // which is the case `never evicts everything` pins as impossible. `0` keeps its meaning below.
+  const bound = Math.max(1, finiteCount('retentionPlan', 'keep', keep));
   const ordered = [...deploys].sort((a, b) => b.deployedAt - a.deployedAt);
-  const retained = ordered.slice(0, Math.max(1, keep));
-  const evicted = ordered.slice(Math.max(1, keep));
+  const retained = ordered.slice(0, bound);
+  const evicted = ordered.slice(bound);
   return {
     retain: retained.map((d) => d.buildId),
     evict: evicted.map((d) => d.buildId),