@ui5/webcomponents 2.4.1-rc.0 → 2.4.1

package/CHANGELOG.md

@@ -3,13 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [2.4.1-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0...v2.4.1-rc.0) (2024-11-07)
+## [2.4.1](https://github.com/UI5/webcomponents/compare/v2.4.0...v2.4.1) (2025-11-11)
+
+**Note:** Version bump only for package @ui5/webcomponents
+
+
+
+
+
+## [2.4.1](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0...v2.4.1) (2025-11-11)
+
+**Note:** Version bump only for package @ui5/webcomponents
+
 
 
-### Bug Fixes
 
-* **ui5-menu:** make close event non-bubbling ([#10133](https://github.com/SAP/ui5-webcomponents/issues/10133)) ([e7ccce9](https://github.com/SAP/ui5-webcomponents/commit/e7ccce968cab25a07837c41f36d94603c31e007e)), closes [#10041](https://github.com/SAP/ui5-webcomponents/issues/10041)
-* **ui5-select:** add support for Vue.js v-model ([#10149](https://github.com/SAP/ui5-webcomponents/issues/10149)) ([14947a7](https://github.com/SAP/ui5-webcomponents/commit/14947a7bbcf3272f56888bb466696784095b574f)), closes [#9971](https://github.com/SAP/ui5-webcomponents/issues/9971)
+
+## [2.4.1](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0...v2.4.1) (2025-11-11)
+
+**Note:** Version bump only for package @ui5/webcomponents
 
 
 

package/cypress/specs/Eventing.cy.ts

@@ -0,0 +1,44 @@
+// import { html } from "lit";
+import "../../src/Button.js";
+
+describe("Eventing", () => {
+	it("Default prevented", () => {
+		// 		cy.mount(html`<form method="get">
+		// 	<ui5-button submits>Submit</ui5-button>
+		// </form>`);
+
+		// 		cy.get("form")
+		// 			.then($item => {
+		// 				$item.get(0).addEventListener("submit", cy.stub().as("submit"));
+		// 			});
+
+		// 		cy.get("[ui5-button]")
+		// 			.then($item => {
+		// 				$item.get(0).addEventListener("click", e => e.preventDefault());
+		// 			});
+
+		// 		cy.get("[ui5-button]")
+		// 			.realClick();
+
+		// 		cy.get("@submit")
+		// 			.should("have.not.been.called");
+	});
+
+	// 	it("Default not prevented", () => {
+	// 		cy.mount(html`<form>
+	// 	<ui5-button submits>Submit</ui5-button>
+	// </form>`);
+
+	// 		cy.get("form")
+	// 			.then($item => {
+	// 				$item.get(0).addEventListener("submit", e => e.preventDefault());
+	// 				$item.get(0).addEventListener("submit", cy.stub().as("submit"));
+	// 			});
+
+	// 		cy.get("[ui5-button]")
+	// 			.realClick();
+
+// 		cy.get("@submit")
+// 			.should("have.been.called");
+// 	});
+});

package/cypress/specs/LitKeyFunction.cy.ts

@@ -37,14 +37,14 @@ describe("Lit HTML key function for #each", () => {
 			.find(".inputIcon")
 			.realClick();
 
-		// cy.get("@items")
-		// 	.eq(0)
-		// 	.should("contain.text", "<empty>")
-		// 	.should("not.have.attr", "selected");
-
-		// cy.get("@items")
-		// 	.eq(3)
-		// 	.should("contain.text", "USA")
-		// 	.should("have.attr", "selected");
+		cy.get("@items")
+			.eq(0)
+			.should("contain.text", "<empty>")
+			.should("not.have.attr", "selected");
+
+		cy.get("@items")
+			.eq(3)
+			.should("contain.text", "USA")
+			.should("have.attr", "selected");
 	});
 });

package/cypress/specs/base/Events.cy.ts

@@ -9,11 +9,8 @@ import "../../../src/MessageStrip.js";
 import "../../../src/MultiComboBox.js";
 import "../../../src/MultiComboBoxItem.js";
 import "../../../src/Panel.js";
-import "../../../src/Button.js";
 import "../../../src/CheckBox.js";
 import "../../../src/Label.js";
-import "../../../src/MenuItem.js";
-import "../../../src/Menu.js";
 
 describe("Event bubbling", () => {
 	it("test bubbling events", () => {
@@ -129,13 +126,7 @@ describe("Event bubbling", () => {
 						<ui5-option>Hello</ui5-option>
 						<ui5-option>World</ui5-option>
 						<ui5-option>Hello</ui5-option>
-					</ui5-select>
-					
-					<ui5-button id="btnOpen">Open Menu</ui5-button>
-					<ui5-menu id="myMenu" header-text="Menu" opener="btnOpen">
-						<ui5-menu-item text="New File"></ui5-menu-item>
-						<ui5-menu-item text="New Folder"></ui5-menu-item>
-					</ui5-menu>
+					</ui5-select>	
 					
 					<ui5-multi-combobox id="myMCB">
 						<ui5-mcb-item text="Cosy"></ui5-mcb-item>
@@ -147,19 +138,12 @@ describe("Event bubbling", () => {
 
 		cy.get("#app")
 			.as("app");
-
 		cy.get("[ui5-dialog]")
 			.as("dialog");
-
 		cy.get("[ui5-select]")
 			.as("select");
-
-		cy.get("[ui5-menu]")
-			.as("menu");
-
 		cy.get("[ui5-multi-combobox]")
 			.as("multiCombobox");
-
 		cy.get("[ui5-multi-combobox]")
 			.shadow()
 			.find(".inputIcon")
@@ -180,11 +164,6 @@ describe("Event bubbling", () => {
 				select.get(0).addEventListener("ui5-close", cy.stub().as("selClosed"));
 			});
 
-		cy.get("@menu")
-			.then(menu => {
-				menu.get(0).addEventListener("ui5-close", cy.stub().as("menuClosed"));
-			});
-
 		cy.get("@multiCombobox")
 			.then(multiCombobox => {
 				multiCombobox.get(0).addEventListener("ui5-close", cy.stub().as("mcbClosed"));
@@ -201,7 +180,7 @@ describe("Event bubbling", () => {
 			.eq(1)
 			.realClick();
 
-		// act - open/close the  MultiComboBox
+		// act - open the  MultiComboBox
 		cy.get("@multiComboboxIcon")
 			.realClick();
 
@@ -210,24 +189,15 @@ describe("Event bubbling", () => {
 			.find("[ui5-responsive-popover]")
 			.should("be.visible");
 
+		// act - close the MultiComboBox
 		cy.get("@multiComboboxIcon")
 			.realClick();
 
-		// act - open/close Menu
-		cy.get("@menu")
-			.ui5MenuOpen();
-
-		cy.get("[ui5-menu-item]")
-			.first()
-			.ui5MenuItemClick();
-
 		// assert - the close events of the Select and MultiComboBox do not bubble
 		cy.get("@selClosed")
 			.should("have.been.calledOnce");
 		cy.get("@mcbClosed")
 			.should("have.been.calledOnce");
-		cy.get("@menuClosed")
-			.should("have.been.calledOnce");
 		cy.get("@dialogClosed")
 			.should("not.be.called");
 		cy.get("@appClosed")

package/cypress/support/commands/Menu.commands.ts

@@ -20,7 +20,8 @@ Cypress.Commands.add("ui5MenuOpened", { prevSubject: true }, subject => {
 		.as("menu");
 
 	cy.get("@menu")
-		.should("have.attr", "open");
+		.should("be.visible")
+		.and("have.attr", "open");
 
 	cy.get("@menu")
 		.shadow()