@ui5/webcomponents 1.6.0 → 1.7.0

package/dist/TabContainer.js

@@ -13,6 +13,7 @@ import {
 	isDown,
 	isRight,
 	isLeft,
+	isUp,
 } from "@ui5/webcomponents-base/dist/Keys.js";
 import MediaRange from "@ui5/webcomponents-base/dist/MediaRange.js";
 import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
@@ -45,6 +46,8 @@ import TabsOverflowMode from "./types/TabsOverflowMode.js";
 const tabStyles = [];
 const staticAreaTabStyles = [];
 
+const PAGE_UP_DOWN_SIZE = 5;
+
 /**
  * @public
  */
@@ -156,8 +159,8 @@ const metadata = {
 		 * @type {boolean}
 		 * @defaultvalue false
 		 * @public
-		 * @deprecated Since the introduction of TabsOverflowMode overflows will always be visible if there is not enough space for all tabs,
-		 * all hidden tabs are moved to a select list in the respective overflows and are accessible via the overflowButton and / or startOverflowButton
+		 * @deprecated Since the introduction of TabsOverflowMode, overflows will always be visible if there is not enough space for all tabs,
+		 * all hidden tabs are moved to a select list in the respective overflows and are accessible via the <code>overflowButton</code> and / or <code>startOverflowButton</code> slots.
 		 */
 		showOverflow: {
 			type: Boolean,
@@ -261,8 +264,9 @@ const metadata = {
 		 *
 		 * @event sap.ui.webcomponents.main.TabContainer#tab-select
 		 * @param {HTMLElement} tab The selected <code>tab</code>.
-		 * @param {Integer} tabIndex The selected <code>tab</code> index.
+		 * @param {Integer} tabIndex The selected <code>tab</code> index in the flattened array of all tabs and their subTabs, provided by the <code>allItems</code> getter.
 		 * @public
+		 * @allowPreventDefault
 		 */
 		"tab-select": {
 			detail: {
@@ -368,7 +372,8 @@ class TabContainer extends UI5Element {
 
 		// Init ItemNavigation
 		this._itemNavigation = new ItemNavigation(this, {
-			getItemsCallback: () => this._getFocusableTabs(),
+			getItemsCallback: () => this._getFocusableRefs(),
+			skipItemsSize: PAGE_UP_DOWN_SIZE,
 		});
 	}
 
@@ -384,8 +389,7 @@ class TabContainer extends UI5Element {
 				this._selectedTab._selected = true;
 			}
 		}
-
-		this._setItemsExternalProperties(this.items);
+		this._setItemsPrivateProperties(this.items);
 
 		if (!this._animationRunning) {
 			this._contentCollapsed = this.collapsed;
@@ -397,9 +401,12 @@ class TabContainer extends UI5Element {
 	}
 
 	onAfterRendering() {
-		this.items.forEach(item => {
-			item._tabInStripDomRef = this.getDomRef().querySelector(`*[data-ui5-stable="${item.stableDomRef}"]`);
-		});
+		this._setItemsForStrip();
+
+		if (!this.shadowRoot.contains(document.activeElement)) {
+			const focusStart = this._getRootTab(this._selectedTab);
+			this._itemNavigation.setCurrentItem(focusStart);
+		}
 	}
 
 	onEnterDOM() {
@@ -424,31 +431,45 @@ class TabContainer extends UI5Element {
 		this.mediaRange = MediaRange.getCurrentRange(MediaRange.RANGESETS.RANGE_4STEPS, this.getDomRef().offsetWidth);
 	}
 
-	_setItemsExternalProperties(items) {
-		items.filter(item => !item.isSeparator).forEach((item, index, arr) => {
-			item._isInline = this.tabLayout === TabLayout.Inline;
-			item._mixedMode = this.mixedMode;
-			item._posinset = index + 1;
-			item._setsize = arr.length;
-			item._getTabContainerHeaderItemCallback = _ => this.getDomRef().querySelector(`#${item._id}`);
-			item._itemSelectCallback = this._onItemSelect.bind(this);
-			item._getRealDomRef = () => this.getDomRef().querySelector(`*[data-ui5-stable=${item.stableDomRef}]`);
-			item._realTab = this._selectedTab;
-			item._isTopLevelTab = this.items.some(i => i === item);
-			walk(items, tab => {
-				tab._realTab = item._realTab;
+	_setItemsPrivateProperties(items) {
+		// set real dom ref to all items, then return only the tabs for further processing
+		const allTabs = items.filter(item => {
+			item._getElementInStrip = () => this.getDomRef().querySelector(`*[data-ui5-stable=${item.stableDomRef}]`);
+			return !item.isSeparator;
+		});
+
+		allTabs.forEach((tab, index, arr) => {
+			tab._isInline = this.tabLayout === TabLayout.Inline;
+			tab._mixedMode = this.mixedMode;
+			tab._posinset = index + 1;
+			tab._setsize = arr.length;
+			tab._realTab = this._selectedTab;
+			tab._isTopLevelTab = items.some(i => i === tab);
+			walk(items, _tab => {
+				_tab._realTab = tab._realTab;
 			});
 		});
 	}
 
+	_onHeaderFocusin(event) {
+		let target = event.target;
+
+		const tab = getTab(target);
+		if (tab) {
+			target = tab._realTab;
+		}
+
+		this._itemNavigation.setCurrentItem(target);
+	}
+
 	async _onTabStripClick(event) {
 		const tab = getTab(event.target);
 		if (!tab || tab._realTab.disabled) {
 			return;
 		}
 
-		event.preventDefault();
 		event.stopPropagation();
+		event.preventDefault();
 		if (event.target.hasAttribute("ui5-button")) {
 			this._onTabExpandButtonClick(event);
 			return;
@@ -462,10 +483,10 @@ class TabContainer extends UI5Element {
 			if (this.responsivePopover.opened) {
 				this.responsivePopover.close();
 			} else {
-				this._setInitialFocus(this._getSelectedInPopover());
+				this._setPopoverInitialFocus();
 			}
 
-			this.responsivePopover.showAt(tab);
+			this.responsivePopover.showAt(tab._realTab.getTabInStripDomRef());
 			return;
 		}
 		this._onHeaderItemSelect(tab);
@@ -496,20 +517,27 @@ class TabContainer extends UI5Element {
 		this._addStyleIndent(this._overflowItems);
 
 		this.responsivePopover = await this._respPopover();
-		if (this.responsivePopover.opened) {
+		if (this.responsivePopover.isOpen()) {
 			this.responsivePopover.close();
 		} else {
-			this._setInitialFocus(this._getSelectedInPopover());
+			this._setPopoverInitialFocus();
 		}
 		this.responsivePopover.showAt(button);
 	}
 
-	_setInitialFocus(selectedInPopover) {
-		if (selectedInPopover.length) {
-			this.responsivePopover.initialFocus = selectedInPopover[0].id;
-		} else {
-			this.responsivePopover.initialFocus = this.responsivePopover.content[0].items.filter(item => item.classList.contains("ui5-tab-overflow-item"))[0].id;
-		}
+	async _setPopoverInitialFocus() {
+		const selectedTabInOverflow = this._getSelectedTabInOverflow();
+		const tab = selectedTabInOverflow || this._getFirstFocusableItemInOverflow();
+
+		this.responsivePopover.initialFocus = `${tab._realTab._id}-li`;
+	}
+
+	_getSelectedTabInOverflow() {
+		return this.responsivePopover.content[0].items.find(item => (item._realTab && item._realTab.selected));
+	}
+
+	_getFirstFocusableItemInOverflow() {
+		return this.responsivePopover.content[0].items.find(item => item.classList.contains("ui5-tab-overflow-item"));
 	}
 
 	_onTabStripKeyDown(event) {
@@ -530,7 +558,7 @@ class TabContainer extends UI5Element {
 			event.preventDefault(); // prevent scrolling
 		}
 
-		if (isDown(event)) {
+		if (isDown(event) || isUp(event)) {
 			if (tab._realTab.requiresExpandButton) {
 				this._onTabExpandButtonClick(event);
 			}
@@ -558,26 +586,44 @@ class TabContainer extends UI5Element {
 
 	_onHeaderItemSelect(tab) {
 		if (!tab.hasAttribute("disabled")) {
-			this._onItemSelect(tab);
-
-			if (!this.isModeStartAndEnd) {
-				this._setItemsForStrip();
-			}
+			this._onItemSelect(tab.id);
 		}
 	}
 
 	async _onOverflowListItemClick(event) {
 		event.preventDefault(); // cancel the item selection
-		const { item } = event.detail;
 
-		this._onItemSelect(item);
-		await this.responsivePopover.close();
+		this._onItemSelect(event.detail.item.id.slice(0, -3)); // strip "-li" from end of id
 
-		this._setItemsForStrip();
+		this.responsivePopover.close();
+		await renderFinished();
 
 		const selectedTopLevel = this._getRootTab(this._selectedTab);
-
-		selectedTopLevel.focus();
+		selectedTopLevel.getTabInStripDomRef().focus();
+	}
+
+	/**
+	 * Returns all slotted tabs and their subTabs in a flattened array.
+	 * The order of tabs is depth-first. For example, given the following slotted elements:
+	 * <code>
+	 * 	<ui5-tabcontainer>
+	 * 		<ui5-tab id="First">
+	 * 			...
+	 * 			<ui5-tab slot="subTabs" id="Nested">...</ui5-tab>
+	 * 		</ui5-tab>
+	 * 		<ui5-tab id="Second">...</ui5-tab>
+	 * 		<ui5-tab-separator id="sep"></ui5-tab-separator>
+	 * 		<ui5-tab id="Third">...</ui5-tab>
+	 * 	</ui5-tabcontainer>
+	 * </code>
+	 * Calling <code>allItems</code> on this TabContainer will return the instances in the following order:
+	 * <code>[ ui5-tab#First, ui5-tab#Nested, ui5-tab#Second, ui5-tab-separator#sep, ui5-tab#Third ]</code>
+	 * @public
+	 *
+	 * @returns {sap.ui.webcomponents.main.ITab[]}
+	 */
+	get allItems() {
+		return this._getAllSubItems(this.items);
 	}
 
 	_getAllSubItems(items, result = [], level = 1) {
@@ -593,44 +639,44 @@ class TabContainer extends UI5Element {
 		return result;
 	}
 
-	_onItemSelect(target) {
-		const selectedIndex = findIndex(this._allItemsAndSubItems, item => item.__id === target.id);
-		const selectedTabIndex = findIndex(this._allItemsAndSubItems, item => item.__id === target.id);
-		const selectedTab = this._allItemsAndSubItems[selectedIndex];
+	_onItemSelect(selectedTabId) {
+		const previousTab = this._selectedTab;
+		const selectedTabIndex = this._allItemsAndSubItems.findIndex(item => item.__id === selectedTabId);
+		const selectedTab = this._allItemsAndSubItems[selectedTabIndex];
 
-		// update selected items
-		this._allItemsAndSubItems
-			.forEach((item, index) => {
-				const selected = selectedIndex === index;
-				item.selected = selected;
+		const selectionSuccessful = this.selectTab(selectedTab, selectedTabIndex);
+		if (!selectionSuccessful) {
+			return;
+		}
 
-				if (item._selected) {
-					item._selected = false;
-				}
-			});
+		// update selected property on all items
+		this._allItemsAndSubItems.forEach((item, index) => {
+			const selected = selectedTabIndex === index;
+			item.selected = selected;
+
+			if (item._selected) {
+				item._selected = false;
+			}
+		});
 
 		if (this.fixed) {
-			this.selectTab(selectedTab, selectedTabIndex);
 			return;
 		}
 
 		if (!this.animate) {
-			this.toggle(selectedTab);
-			this.selectTab(selectedTab, selectedTabIndex);
-			return;
+			this.toggle(selectedTab, previousTab);
+		} else {
+			this.toggleAnimated(selectedTab, previousTab);
 		}
-
-		this.toggleAnimated(selectedTab);
-		this.selectTab(selectedTab, selectedTabIndex);
 	}
 
-	async toggleAnimated(selectedTab) {
+	async toggleAnimated(selectedTab, previousTab) {
 		const content = this.shadowRoot.querySelector(".ui5-tc__content");
 		let animationPromise = null;
 
 		this._animationRunning = true;
 
-		if (selectedTab === this._selectedTab) {
+		if (selectedTab === previousTab) {
 			// click on already selected tab - animate both directions
 			this.collapsed = !this.collapsed;
 			animationPromise = this.collapsed ? this.slideContentUp(content) : this.slideContentDown(content);
@@ -645,21 +691,31 @@ class TabContainer extends UI5Element {
 		this._animationRunning = false;
 	}
 
-	toggle(selectedTab) {
-		if (selectedTab === this._selectedTab) {
+	toggle(selectedTab, previousTab) {
+		if (selectedTab === previousTab) {
 			this.collapsed = !this.collapsed;
 		} else {
 			this.collapsed = false;
 		}
 	}
 
+	/**
+	 * Fires the <code>tab-select</code> event and changes the internal reference for the currently selected tab.
+	 * If the event is prevented, the current tab is not changed.
+	 * @private
+	 *
+	 * @param {object} selectedTab selected tab instance
+	 * @param {number} selectedTabIndex selected tab index for an array containing all tabs and sub tabs. <b>Note:</b> Use the method <code>allTabs</code> to get this array.
+	 * @returns {boolean} true if the tab selection is successful, false if it was prevented
+	 */
 	selectTab(selectedTab, selectedTabIndex) {
+		if (!this.fireEvent("tab-select", { tab: selectedTab, tabIndex: selectedTabIndex }, true)) {
+			return false;
+		}
+
 		// select the tab
 		this._selectedTab = selectedTab;
-		this.fireEvent("tab-select", {
-			tab: selectedTab,
-			tabIndex: selectedTabIndex,
-		});
+		return true;
 	}
 
 	slideContentDown(element) {
@@ -679,44 +735,34 @@ class TabContainer extends UI5Element {
 		const overflow = event.currentTarget;
 		const isEndOverflow = overflow.classList.contains("ui5-tc__overflow--end");
 		const isStartOverflow = overflow.classList.contains("ui5-tc__overflow--start");
-		const items = [];
-
 		const overflowAttr = isEndOverflow ? "end-overflow" : "start-overflow";
 
-		this._overflowItems = [];
+		this._overflowItems = this.items.filter(item => {
+			const stripRef = item.getTabInStripDomRef();
 
-		this.items.forEach(item => {
-			if (item.getTabInStripDomRef() && item.getTabInStripDomRef().hasAttribute(overflowAttr)) {
-				items.push(item);
-			}
+			return stripRef && stripRef.hasAttribute(overflowAttr);
 		});
 
-		let button;
+		this._addStyleIndent(this._overflowItems);
+
+		let opener;
 		if (isEndOverflow) {
-			button = this.overflowButton[0] || overflow.querySelector("[ui5-button]");
-			this._overflowItems = items;
-			this._addStyleIndent(this._overflowItems);
+			opener = this.overflowButton[0] || this._getEndOverflowBtnDOM();
 		}
 
 		if (isStartOverflow) {
-			button = this.startOverflowButton[0] || overflow.querySelector("[ui5-button]");
-			this._overflowItems = items;
-			this._addStyleIndent(this._overflowItems);
+			opener = this.startOverflowButton[0] || this._getStartOverflowBtnDOM();
 		}
 
 		this.responsivePopover = await this._respPopover();
 		if (this.responsivePopover.opened) {
 			this.responsivePopover.close();
 		} else {
-			this.responsivePopover.initialFocus = this.responsivePopover.content[0].items.filter(item => item.classList.contains("ui5-tab-overflow-item"))[0].id;
-			await this.responsivePopover.showAt(button);
+			this._setPopoverInitialFocus();
+			this.responsivePopover.showAt(opener);
 		}
 	}
 
-	_getSelectedInPopover() {
-		return this.responsivePopover.content[0].items.filter(item => (item._realTab && item._realTab.selected));
-	}
-
 	_addStyleIndent(tabs) {
 		const extraIndent = this._getAllSubItems(tabs)
 			.filter(tab => !tab.isSeparator)
@@ -737,10 +783,13 @@ class TabContainer extends UI5Element {
 	}
 
 	async _onOverflowKeyDown(event) {
-		const isEndOverflow = event.currentTarget.classList.contains("ui5-tc__overflow--end");
-		const isStartOverflow = event.currentTarget.classList.contains("ui5-tc__overflow--start");
+		const overflow = event.currentTarget;
+		const isEndOverflow = overflow.classList.contains("ui5-tc__overflow--end");
+		const isStartOverflow = overflow.classList.contains("ui5-tc__overflow--start");
 
 		if (isDown(event) || (isStartOverflow && isLeft(event)) || (isEndOverflow && isRight(event))) {
+			event.stopPropagation();
+			event.preventDefault();
 			await this._onOverflowClick(event);
 		}
 	}
@@ -771,9 +820,7 @@ class TabContainer extends UI5Element {
 		});
 
 		const hasOverflow = tabStrip.offsetWidth < allItemsWidth;
-
 		if (!hasOverflow) {
-			this._closeRespPopover();
 			return;
 		}
 
@@ -783,9 +830,6 @@ class TabContainer extends UI5Element {
 		} else {
 			this._updateEndOverflow(itemsDomRefs);
 		}
-
-		this._itemNavigation._init();
-		this._itemNavigation.setCurrentItem(this._getRootTab(this._selectedTab));
 	}
 
 	_getRootTab(tab) {
@@ -1033,41 +1077,31 @@ class TabContainer extends UI5Element {
 		this._endOverflowText = `+${endOverflowItemsCount}`;
 	}
 
-	async _closeRespPopover() {
-		this.responsivePopover = await this._respPopover();
-		this.responsivePopover.close();
-	}
-
-	_getFocusableTabs() {
+	_getFocusableRefs() {
 		if (!this.getDomRef()) {
 			return [];
 		}
 
-		const focusableTabs = [];
+		const focusableRefs = [];
 
 		if (!this._getStartOverflow().hasAttribute("hidden")) {
-			if (this._getCustomStartOverflowBtnDOM()) {
-				focusableTabs.push(this._getCustomStartOverflowBtnDOM());
-			} else {
-				focusableTabs.push(this._getStartOverflowBtnDOM());
-			}
+			focusableRefs.push(this.startOverflowButton[0] || this._getStartOverflowBtnDOM());
 		}
 
 		this._getTabs().forEach(tab => {
-			if (tab.getTabInStripDomRef() && !tab.getTabInStripDomRef().hasAttribute("hidden")) {
-				focusableTabs.push(tab);
+			const ref = tab.getTabInStripDomRef();
+			const focusable = ref && !ref.hasAttribute("hidden");
+
+			if (focusable) {
+				focusableRefs.push(tab);
 			}
 		});
 
 		if (!this._getEndOverflow().hasAttribute("hidden")) {
-			if (this._getCustomEndOverflowBtnDOM()) {
-				focusableTabs.push(this._getCustomEndOverflowBtnDOM());
-			} else {
-				focusableTabs.push(this._getEndOverflowBtnDOM());
-			}
+			focusableRefs.push(this.overflowButton[0] || this._getEndOverflowBtnDOM());
 		}
 
-		return focusableTabs;
+		return focusableRefs;
 	}
 
 	_getHeader() {
@@ -1090,18 +1124,10 @@ class TabContainer extends UI5Element {
 		return this.shadowRoot.querySelector(".ui5-tc__overflow--end");
 	}
 
-	_getCustomStartOverflowBtnDOM() {
-		return this.shadowRoot.querySelector("slot[name=startOverflowButton]");
-	}
-
 	_getStartOverflowBtnDOM() {
 		return this._getStartOverflow().querySelector("[ui5-button]");
 	}
 
-	_getCustomEndOverflowBtnDOM() {
-		return this.shadowRoot.querySelector("slot[name=overflowButton]");
-	}
-
 	_getEndOverflowBtnDOM() {
 		return this._getEndOverflow().querySelector("[ui5-button]");
 	}
@@ -1211,18 +1237,6 @@ const getTab = el => {
 	return false;
 };
 
-const findIndex = (arr, predicate) => {
-	for (let i = 0; i < arr.length; i++) {
-		const result = predicate(arr[i]);
-
-		if (result) {
-			return i;
-		}
-	}
-
-	return -1;
-};
-
 const walk = (tabs, callback) => {
 	[...tabs].forEach(tab => {
 		callback(tab);

package/dist/TabSeparator.js

@@ -58,8 +58,15 @@ class TabSeparator extends UI5Element {
 		return true;
 	}
 
+	/**
+	 * Returns the DOM reference of the separator that is placed in the header.
+	 * <b>Note:</b> Tabs and separators, placed in the <code>subTabs</code> slot of other tabs are not shown in the header. Calling this method on such tabs or separators will return <code>null</code>.
+	 *
+	 * @function
+	 * @public
+	 */
 	getTabInStripDomRef() {
-		return this._tabInStripDomRef;
+		return this._getElementInStrip();
 	}
 
 	get stableDomRef() {

package/dist/TextArea.js

@@ -3,6 +3,7 @@ import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
 import ResizeHandler from "@ui5/webcomponents-base/dist/delegate/ResizeHandler.js";
 import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
 import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AriaLabelHelper.js";
+import getEffectiveScrollbarStyle from "@ui5/webcomponents-base/dist/util/getEffectiveScrollbarStyle.js";
 import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
 import { getFeature } from "@ui5/webcomponents-base/dist/FeaturesRegistry.js";
 import { isEscape } from "@ui5/webcomponents-base/dist/Keys.js";
@@ -534,9 +535,9 @@ class TextArea extends UI5Element {
 			leftCharactersCount;
 
 		if (this.showExceededText) {
-			const maxLength = this.maxlength || 0;
+			const maxLength = this.maxlength;
 
-			if (maxLength) {
+			if (maxLength !== null) {
 				leftCharactersCount = maxLength - this.value.length;
 
 				if (leftCharactersCount >= 0) {
@@ -556,6 +557,10 @@ class TextArea extends UI5Element {
 
 	get classes() {
 		return {
+			root: {
+				"ui5-textarea-root": true,
+				"ui5-content-native-scrollbars": getEffectiveScrollbarStyle(),
+			},
 			valueStateMsg: {
 				"ui5-valuestatemessage--error": this.valueState === ValueState.Error,
 				"ui5-valuestatemessage--warning": this.valueState === ValueState.Warning,

package/dist/TimePickerBase.js

@@ -14,6 +14,10 @@ import {
 	isPageDownShift,
 	isPageUpShiftCtrl,
 	isPageDownShiftCtrl,
+	isTabNext,
+	isTabPrevious,
+	isF6Next,
+	isF6Previous,
 } from "@ui5/webcomponents-base/dist/Keys.js";
 import "@ui5/webcomponents-icons/dist/time-entry-request.js";
 import Icon from "./Icon.js";
@@ -348,6 +352,10 @@ class TimePickerBase extends UI5Element {
 			this.togglePicker();
 		}
 
+		if ((this._getInput().isEqualNode(e.target) && this.isOpen()) && (isTabNext(e) || isTabPrevious(e) || isF6Next(e) || isF6Previous(e))) {
+			this.closePicker();
+		}
+
 		if (this.isOpen()) {
 			return;
 		}

package/dist/TimeSelection.js

@@ -28,7 +28,6 @@ import {
 	TIMEPICKER_HOURS_LABEL,
 	TIMEPICKER_MINUTES_LABEL,
 	TIMEPICKER_SECONDS_LABEL,
-	TIMEPICKER_PERIODS_LABEL,
 } from "./generated/i18n/i18n-defaults.js";
 
 // Styles
@@ -478,7 +477,7 @@ class TimeSelection extends UI5Element {
 	}
 
 	get periodSliderTitle() {
-		return TimeSelection.i18nBundle.getText(TIMEPICKER_PERIODS_LABEL);
+		return "AM/PM";
 	}
 
 	get classes() {