@ui5/webcomponents 1.0.0-rc.8 → 1.0.2

package/src/RatingIndicator.hbs

@@ -2,18 +2,18 @@
 	role="slider"
 	aria-roledescription="{{_ariaRoleDescription}}"
 	aria-valuemin="0"
-	aria-valuenow="{{this.value}}"
-	aria-valuemax="{{this.maxValue}}"
+	aria-valuenow="{{value}}"
+	aria-valuemax="{{max}}"
 	aria-orientation="horizontal"
-	?aria-disabled="{{this.disabled}}"
-	?aria-readonly="{{this.readOnly}}"
+	aria-disabled="{{_ariaDisabled}}"
+	aria-readonly="{{ariaReadonly}}"
 	tabindex="{{tabIndex}}"
 	@focusin="{{_onfocusin}}"
 	@focusout="{{_onfocusout}}"
 	@click="{{_onclick}}"
 	@keydown="{{_onkeydown}}"
 	title="{{tooltip}}"
-	aria-label="{{ariaLabel}}"
+	aria-label="{{accessibleName}}"
 >
 	<div
 		class="ui5-rating-indicator-stars-wrapper"
@@ -23,6 +23,8 @@
 				<div class="ui5-rating-indicator-icon ui5-rating-indicator-active-icon" data-value="{{this.index}}">&#9733;</div>
 			{{else if this.halfStar}}
 				<div class="ui5-rating-indicator-icon ui5-rating-indicator-half-icon" data-value="{{this.index}}">&#9734;</div>
+			{{else if ../readonly}}
+				<div class="ui5-rating-indicator-icon ui5-rating-indicator-readonly-unselected-icon" data-value="{{this.index}}">&#9733;</div>
 			{{else}}
 				<div class="ui5-rating-indicator-icon" data-value="{{this.index}}">&#9734;</div>
 			{{/if}}

package/src/RatingIndicator.js

@@ -8,7 +8,7 @@ import {
 	isSpace,
 	isEnter,
 } from "@ui5/webcomponents-base/dist/Keys.js";
-import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
+import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
 import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
 import Float from "@ui5/webcomponents-base/dist/types/Float.js";
 import {
@@ -29,7 +29,7 @@ const metadata = {
 	properties: /** @lends sap.ui.webcomponents.main.RatingIndicator.prototype */ {
 
 		/**
-		 * The indicated value of the rating
+		 * The indicated value of the rating.
 		 * <br><br>
 		 * <b>Note:</b> If you set a number which is not round, it would be shown as follows:
 		 * <ul>
@@ -47,21 +47,22 @@ const metadata = {
 		},
 
 		/**
-		 * The number of displayed rating symbols
+		 * The number of displayed rating symbols.
 		 * @type {Integer}
 		 * @defaultvalue 5
 		 * @public
+		 * @since 1.0.0-rc.15
 		 */
-		maxValue: {
+		max: {
 			type: Integer,
 			defaultValue: 5,
 		},
 
 		/**
-		 * Defines whether the <code>ui5-rating-indicator</code> is disabled.
+		 * Defines whether the component is disabled.
 		 *
 		 * <br><br>
-		 * <b>Note:</b> A disabled <code>ui5-rating-indicator</code> is completely noninteractive.
+		 * <b>Note:</b> A disabled component is completely noninteractive.
 		 * @type {boolean}
 		 * @defaultvalue false
 		 * @public
@@ -71,9 +72,9 @@ const metadata = {
 		},
 
 		/**
-		 * Defines whether the <code>ui5-rating-indicator</code> is read-only.
+		 * Defines whether the component is read-only.
 		 * <br><br>
-		 * <b>Note:</b> A read-only <code>ui5-rating-indicator</code> is not editable,
+		 * <b>Note:</b> A read-only component is not editable,
 		 * but still provides visual feedback upon user interaction.
 		 *
 		 * @type {boolean}
@@ -85,25 +86,14 @@ const metadata = {
 		},
 
 		/**
-		 * Defines the aria-label attribute for the rating indicator.
-		 * @type {String}
-		 * @defaultvalue: undefined
-		 * @private
-		 * @since 1.0.0-rc.8
-		 */
-		ariaLabel: {
-			type: String,
-			defaultValue: undefined,
-		},
-
-		/**
-		 * Defines the tooltip for the rating indicator.
+		 * Sets the accessible aria name of the component.
+		 *
 		 * @type {String}
 		 * @defaultvalue: undefined
-		 * @private
-		 * @since 1.0.0-rc.8
+		 * @public
+		 * @since 1.0.0-rc.15
 		 */
-		title: {
+		accessibleName: {
 			type: String,
 			defaultValue: undefined,
 		},
@@ -142,23 +132,20 @@ const metadata = {
  * @class
  *
  * <h3 class="comment-api-title">Overview</h3>
- * The rating indicator is used to display a specific number of icons that are used to rate an item.
+ * The Rating Indicator is used to display a specific number of icons that are used to rate an item.
  * Additionally, it is also used to display the average and overall ratings.
  *
  * <h3>Usage</h3>
- * The reccomended number of icons is between 5 and 7.
+ * The recommended number of icons is between 5 and 7.
  *
  * <h3>Responsive Behavior</h3>
  * You can change the size of the Rating Indicator by changing its <code>font-size</code> CSS property.
  * <br>
  * Example: <code>&lt;ui5-rating-indicator style="font-size: 3rem;">&lt;/ui5-rating-indicator></code>
  *
- * <h3>Usage</h3>
- *
- * For the <code>ui5-rating-indicator</code>
  * <h3>ES6 Module Import</h3>
  *
- * <code>import @ui5/webcomponents/dist/RatingIndicator.js";</code>
+ * <code>import "@ui5/webcomponents/dist/RatingIndicator.js";</code>
  *
  * @constructor
  * @author SAP SE
@@ -186,14 +173,13 @@ class RatingIndicator extends UI5Element {
 	}
 
 	static async onDefine() {
-		await fetchI18nBundle("@ui5/webcomponents");
+		RatingIndicator.i18nBundle = await getI18nBundle("@ui5/webcomponents");
 	}
 
 	constructor() {
 		super();
 
 		this._liveValue = null; // stores the value to determine when to fire change
-		this.i18nBundle = getI18nBundle("@ui5/webcomponents");
 	}
 
 	onBeforeRendering() {
@@ -203,7 +189,7 @@ class RatingIndicator extends UI5Element {
 	calcState() {
 		this._stars = [];
 
-		for (let i = 1; i < this.maxValue + 1; i++) {
+		for (let i = 1; i < this.max + 1; i++) {
 			const remainder = Math.round((this.value - Math.floor(this.value)) * 10);
 			let halfStar = false,
 				tempValue = this.value;
@@ -255,7 +241,7 @@ class RatingIndicator extends UI5Element {
 			if (down && this.value > 0) {
 				this.value = Math.round(this.value - 1);
 				this.fireEvent("change");
-			} else if (up && this.value < this.maxValue) {
+			} else if (up && this.value < this.max) {
 				this.value = Math.round(this.value + 1);
 				this.fireEvent("change");
 			}
@@ -280,15 +266,23 @@ class RatingIndicator extends UI5Element {
 	}
 
 	get tooltip() {
-		return this.title || this.defaultTooltip;
+		return this.getAttribute("title") || this.defaultTooltip;
 	}
 
 	get defaultTooltip() {
-		return this.i18nBundle.getText(RATING_INDICATOR_TOOLTIP_TEXT);
+		return RatingIndicator.i18nBundle.getText(RATING_INDICATOR_TOOLTIP_TEXT);
 	}
 
 	get _ariaRoleDescription() {
-		return this.i18nBundle.getText(RATING_INDICATOR_TEXT);
+		return RatingIndicator.i18nBundle.getText(RATING_INDICATOR_TEXT);
+	}
+
+	get _ariaDisabled() {
+		return this.disabled || undefined;
+	}
+
+	get ariaReadonly() {
+		return this.readonly ? "true" : undefined;
 	}
 }
 

package/src/ResponsivePopover.hbs

@@ -13,14 +13,19 @@
 			{{#if header.length}}
 				<slot slot="header" name="header"></slot>
 			{{else}}
-				<header class="ui5-responsive-popover-header">
-					<ui5-title level="H5" class="ui5-responsive-popover-header-text">{{headerText}}</ui5-title>
-					<ui5-button
-						icon="decline"
-						design="Transparent"
-						@click="{{close}}"
-					>
-					</ui5-button>
+				<header class="{{classes.header}}">
+					{{#if headerText }}
+						<ui5-title level="H2" class="ui5-popup-header-text ui5-responsive-popover-header-text">{{headerText}}</ui5-title>
+					{{/if}}
+					{{#unless _hideCloseButton}}
+						<ui5-button
+							icon="decline"
+							design="Transparent"
+							aria-label="{{_closeDialogAriaLabel}}"
+							@click="{{close}}"
+						>
+						</ui5-button>
+					{{/unless}}
 				</header>
 			{{/if}}
 		{{/unless}}

package/src/ResponsivePopover.js

@@ -1,17 +1,17 @@
 import { isPhone } from "@ui5/webcomponents-base/dist/Device.js";
-import { getNextZIndex } from "./popup-utils/PopupUtils.js";
+import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
+import { getNextZIndex } from "@ui5/webcomponents-base/dist/util/PopupUtils.js";
+import { RESPONSIVE_POPOVER_CLOSE_DIALOG_BUTTON } from "./generated/i18n/i18n-defaults.js";
 import ResponsivePopoverTemplate from "./generated/templates/ResponsivePopoverTemplate.lit.js";
 import Popover from "./Popover.js";
 import Dialog from "./Dialog.js";
 import Button from "./Button.js";
 import Title from "./Title.js";
-import "@ui5/webcomponents-icons/dist/icons/decline.js";
+import "@ui5/webcomponents-icons/dist/decline.js";
 
 // Styles
 import ResponsivePopoverCss from "./generated/themes/ResponsivePopover.css.js";
 
-const POPOVER_MIN_WIDTH = 100;
-
 /**
  * @public
  */
@@ -19,16 +19,6 @@ const metadata = {
 	tag: "ui5-responsive-popover",
 	properties: /** @lends sap.ui.webcomponents.main.ResponsivePopover.prototype */ {
 
-		/**
-		 * Defines whether the component will stretch to fit its content.
-		 * <br/><b>Note:</b> by default the popover will be as wide as its opener component and will grow if the content is not fitting.
-		 * <br/><b>Note:</b> if set to true, it will take only as much space as it needs.
-		 * @private
-		 */
-		noStretch: {
-			type: Boolean,
-		},
-
 		/**
 		 * Defines if padding would be added around the content.
 		 * @private
@@ -53,6 +43,19 @@ const metadata = {
 		_hideHeader: {
 			type: Boolean,
 		},
+
+		/**
+		 * Defines whether a close button will be rendered in the header of the component
+		 * <b>Note:</b> If you are using the <code>header</code> slot, this property will have no effect
+		 *
+		 * @private
+		 * @type {Boolean}
+		 * @defaultvalue false
+		 * @since 1.0.0-rc.16
+		 */
+		_hideCloseButton: {
+			type: Boolean,
+		},
 	},
 };
 
@@ -75,48 +78,56 @@ const metadata = {
  * @public
  */
 class ResponsivePopover extends Popover {
+	constructor() {
+		super();
+	}
+
 	static get metadata() {
 		return metadata;
 	}
 
 	static get styles() {
-		return [...Popover.styles, ResponsivePopoverCss];
+		return [Popover.styles, ResponsivePopoverCss];
+	}
+
+	get classes() {
+		const allClasses = super.classes;
+
+		allClasses.header = {
+			"ui5-responsive-popover-header": true,
+			"ui5-responsive-popover-header-no-title": !this.headerText,
+		};
+
+		return allClasses;
 	}
 
 	static get template() {
 		return ResponsivePopoverTemplate;
 	}
 
-	static async onDefine() {
-		await Promise.all([
-			Button.define(),
-			Dialog.define(),
-			Title.define(),
-		]);
+	static get dependencies() {
+		return [
+			Button,
+			Dialog,
+			Title,
+		];
 	}
 
 	/**
-	 * Opens popover on desktop and dialog on mobile.
-	 * @param {HTMLElement} opener the element that the popover is opened by
+	 * Shows popover on desktop and dialog on mobile.
+	 * @param {HTMLElement} opener the element that the popover is shown at
+	 * @param {boolean} preventInitialFocus Prevents applying the focus inside the popup
 	 * @public
+	 * @async
+	 * @returns {Promise} Resolves when the responsive popover is open
 	 */
-	open(opener) {
-		this.style.display = this._isPhone ? "contents" : "";
-
-		if (this.isOpen() || (this._dialog && this._dialog.isOpen())) {
-			return;
-		}
-
+	async showAt(opener, preventInitialFocus = false) {
 		if (!isPhone()) {
-			// make popover width be >= of the opener's width
-			if (!this.noStretch) {
-				this._minWidth = Math.max(POPOVER_MIN_WIDTH, opener.getBoundingClientRect().width);
-			}
-
-			this.openBy(opener);
+			await super.showAt(opener, preventInitialFocus);
 		} else {
+			this.style.display = "contents";
 			this.style.zIndex = getNextZIndex();
-			this._dialog.open();
+			await this._dialog.show(preventInitialFocus);
 		}
 	}
 
@@ -128,7 +139,7 @@ class ResponsivePopover extends Popover {
 		if (!isPhone()) {
 			super.close(escPressed, preventRegistryUpdate, preventFocusRestore);
 		} else {
-			this._dialog.close();
+			this._dialog.close(escPressed, preventRegistryUpdate, preventFocusRestore);
 		}
 	}
 
@@ -137,25 +148,20 @@ class ResponsivePopover extends Popover {
 			return this.close();
 		}
 
-		this.open(opener);
+		this.showAt(opener);
 	}
 
+	/**
+	 * Tells if the responsive popover is open
+	 * @public
+	 * @returns {boolean}
+	 */
 	isOpen() {
 		return isPhone() ? this._dialog.isOpen() : super.isOpen();
 	}
 
-	get styles() {
-		const popoverStyles = super.styles;
-
-		popoverStyles.root = {
-			"min-width": `${this._minWidth}px`,
-		};
-
-		return popoverStyles;
-	}
-
 	get _dialog() {
-		return this.shadowRoot.querySelector("ui5-dialog");
+		return this.shadowRoot.querySelector("[ui5-dialog]");
 	}
 
 	get _isPhone() {
@@ -163,13 +169,17 @@ class ResponsivePopover extends Popover {
 	}
 
 	get _displayHeader() {
-		return this._isPhone || !this.contentOnlyOnDesktop;
+		return (this._isPhone || !this.contentOnlyOnDesktop) && super._displayHeader;
 	}
 
 	get _displayFooter() {
 		return this._isPhone || !this.contentOnlyOnDesktop;
 	}
 
+	get _closeDialogAriaLabel() {
+		return ResponsivePopover.i18nBundle.getText(RESPONSIVE_POPOVER_CLOSE_DIALOG_BUTTON);
+	}
+
 	_afterDialogOpen(event) {
 		this.opened = true;
 		this._propagateDialogEvent(event);
@@ -185,6 +195,10 @@ class ResponsivePopover extends Popover {
 
 		this.fireEvent(type, event.detail);
 	}
+
+	static async onDefine() {
+		ResponsivePopover.i18nBundle = await getI18nBundle("@ui5/webcomponents");
+	}
 }
 
 ResponsivePopover.define();

package/src/SegmentedButton.hbs

@@ -1,10 +1,17 @@
-<div
+<ul
 	@click="{{_onclick}}"
+	@keydown="{{_onkeydown}}"
+	@keyup="{{_onkeyup}}"
 	@focusin="{{_onfocusin}}"
-	class="ui5-segmentedbutton-root"
-	role="group"
+	class="ui5-segmented-button-root"
+	role="listbox"
 	dir="{{effectiveDir}}"
-	aria-roledescription="{{ariaDescription}}"
+	aria-multiselectable="true"
+	aria-describedby="{{_id}}-invisibleText"
+	aria-roledescription={{ariaDescription}}
 >
 	<slot></slot>
-</div>
+
+	<span id="{{_id}}-invisibleText" class="ui5-hidden-text">{{ariaDescribedBy}}</span>
+
+</ul>