@ui5/webcomponents 0.31.14 → 0.31.18

package/src/SegmentedButton.hbs

@@ -1,10 +1,17 @@
-<div
+<ul
 	@click="{{_onclick}}"
+	@keydown="{{_onkeydown}}"
+	@keyup="{{_onkeyup}}"
 	@focusin="{{_onfocusin}}"
-	class="ui5-segmentedbutton-root"
-	role="group"
+	class="ui5-segmented-button-root"
+	role="listbox"
 	dir="{{effectiveDir}}"
-	aria-roledescription="{{ariaDescription}}"
+	aria-multiselectable="true"
+	aria-describedby="{{_id}}-invisibleText"
+	aria-roledescription={{ariaDescription}}
 >
 	<slot></slot>
-</div>
+
+	<span id="{{_id}}-invisibleText" class="ui5-hidden-text">{{ariaDescribedBy}}</span>
+
+</ul>

package/src/SegmentedButton.js

@@ -5,8 +5,9 @@ import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18
 import ResizeHandler from "@ui5/webcomponents-base/dist/delegate/ResizeHandler.js";
 import { renderFinished } from "@ui5/webcomponents-base/dist/Render.js";
 import { isIE } from "@ui5/webcomponents-base/dist/Device.js";
-import { SEGMENTEDBUTTON_ARIA_DESCRIPTION } from "./generated/i18n/i18n-defaults.js";
-import ToggleButton from "./ToggleButton.js";
+import { isSpace, isEnter } from "@ui5/webcomponents-base/dist/Keys.js";
+import { SEGMENTEDBUTTON_ARIA_DESCRIPTION, SEGMENTEDBUTTON_ARIA_DESCRIBEDBY } from "./generated/i18n/i18n-defaults.js";
+import SegmentedButtonItem from "./SegmentedButtonItem.js";
 
 // Template
 import SegmentedButtonTemplate from "./generated/templates/SegmentedButtonTemplate.lit.js";
@@ -18,39 +19,40 @@ import SegmentedButtonCss from "./generated/themes/SegmentedButton.css.js";
  * @public
  */
 const metadata = {
-	tag: "ui5-segmentedbutton",
+	tag: "ui5-segmented-button",
+	altTag: "ui5-segmentedbutton",
 	languageAware: true,
 	properties: /** @lends sap.ui.webcomponents.main.SegmentedButton.prototype */  {},
 	managedSlots: true,
 	slots: /** @lends sap.ui.webcomponents.main.SegmentedButton.prototype */ {
 
 		/**
-		 * Defines the buttons of <code>ui5-segmentedbutton</code>.
+		 * Defines the items of <code>ui5-segmented-button</code>.
 		 * <br><br>
-		 * <b>Note:</b> Multiple buttons are allowed.
+		 * <b>Note:</b> Multiple items are allowed.
 		 * <br><br>
-		 * <b>Note:</b> Use the <code>ui5-togglebutton</code> for the intended design.
-		 * @type {HTMLElement[]}
-		 * @slot
+		 * <b>Note:</b> Use the <code>ui5-segmented-button-item</code> for the intended design.
+		 * @type {sap.ui.webcomponents.main.IButton[]}
+		 * @slot items
 		 * @public
 		 */
 		"default": {
-			propertyName: "buttons",
+			propertyName: "items",
 			type: HTMLElement,
 		},
 	},
 	events: /** @lends sap.ui.webcomponents.main.SegmentedButton.prototype */ {
 
 		/**
-		 * Fired when the selected button changes.
+		 * Fired when the selected item changes.
 		 *
 		 * @event sap.ui.webcomponents.main.SegmentedButton#selection-change
-		 * @param {HTMLElement} selectedButton the pressed button.
+		 * @param {HTMLElement} selectedItem the pressed item.
 		 * @public
 		 */
 		"selection-change": {
 			detail: {
-				selectedButton: { type: HTMLElement },
+				selectedItem: { type: HTMLElement },
 			},
 		},
 	},
@@ -61,11 +63,11 @@ const metadata = {
  *
  * <h3 class="comment-api-title">Overview</h3>
  *
- * The <code>ui5-segmentedbutton</code> shows a group of buttons. When the user clicks or taps
- * one of the buttons, it stays in a pressed state. It automatically resizes the buttons
+ * The <code>ui5-segmented-button</code> shows a group of items. When the user clicks or taps
+ * one of the items, it stays in a pressed state. It automatically resizes the items
  * to fit proportionally within the component. When no width is set, the component uses the available width.
  * <br><br>
- * <b>Note:</b> There can be just one selected <code>button</code> at a time.
+ * <b>Note:</b> There can be just one selected <code>item</code> at a time.
  *
  * <h3>ES6 Module Import</h3>
  *
@@ -75,8 +77,9 @@ const metadata = {
  * @author SAP SE
  * @alias sap.ui.webcomponents.main.SegmentedButton
  * @extends sap.ui.webcomponents.base.UI5Element
- * @tagname ui5-segmentedbutton
+ * @tagname ui5-segmented-button
  * @since 1.0.0-rc.6
+ * @appenddocs SegmentedButtonItem
  * @public
  */
 class SegmentedButton extends UI5Element {
@@ -97,7 +100,7 @@ class SegmentedButton extends UI5Element {
 	}
 
 	static get dependencies() {
-		return [ToggleButton];
+		return [SegmentedButtonItem];
 	}
 
 	static async onDefine() {
@@ -108,7 +111,7 @@ class SegmentedButton extends UI5Element {
 		super();
 
 		this._itemNavigation = new ItemNavigation(this, {
-			getItemsCallback: () => this.getSlottedNodes("buttons"),
+			getItemsCallback: () => this.getSlottedNodes("items"),
 		});
 
 		this.absoluteWidthSet = false; // set to true whenever we set absolute width to the component
@@ -128,6 +131,13 @@ class SegmentedButton extends UI5Element {
 	}
 
 	onBeforeRendering() {
+		const items = this.getSlottedNodes("items");
+
+		items.forEach((item, index, arr) => {
+			item.posInSet = index + 1;
+			item.sizeOfSet = arr.length;
+		});
+
 		this.normalizeSelection();
 	}
 
@@ -135,24 +145,24 @@ class SegmentedButton extends UI5Element {
 		await this._doLayout();
 	}
 
-	prepareToMeasureButtons() {
+	prepareToMeasureItems() {
 		this.style.width = "";
-		this.buttons.forEach(button => {
-			button.style.width = "";
+		this.items.forEach(item => {
+			item.style.width = "";
 		});
 	}
 
-	async measureButtonsWidth() {
+	async measureItemsWidth() {
 		await renderFinished();
-		this.prepareToMeasureButtons();
+		this.prepareToMeasureItems();
 
-		this.widths = this.buttons.map(button => {
+		this.widths = this.items.map(item => {
 			// +1 is added because for width 100.44px the offsetWidth property returns 100px and not 101px
-			let width = button.offsetWidth + 1;
+			let width = item.offsetWidth + 1;
 
 			if (isIE()) {
-				// in IE we are adding 1 one px beacause the width of the border on a button in the middle is not calculated and if the
-				// longest button is in the middle, it truncates
+				// in IE we are adding 1 one px beacause the width of the border on an item in the middle is not calculated and if the
+				// longest item is in the middle, it truncates
 				width += 1;
 			}
 
@@ -161,37 +171,55 @@ class SegmentedButton extends UI5Element {
 	}
 
 	normalizeSelection() {
-		this._selectedButton = this.buttons.filter(button => button.pressed).pop();
+		this._selectedItem = this.items.filter(item => item.pressed).pop();
 
-		if (this._selectedButton) {
-			this.buttons.forEach(button => {
-				button.pressed = false;
+		if (this._selectedItem) {
+			this.items.forEach(item => {
+				item.pressed = false;
 			});
-			this._selectedButton.pressed = true;
+			this._selectedItem.pressed = true;
 		}
 	}
 
-	_onclick(event) {
+	_selectItem(event) {
 		if (event.target.disabled || event.target === this.getDomRef()) {
 			return;
 		}
 
-		if (event.target !== this._selectedButton) {
-			if (this._selectedButton) {
-				this._selectedButton.pressed = false;
+		if (event.target !== this._selectedItem) {
+			if (this._selectedItem) {
+				this._selectedItem.pressed = false;
 			}
-			this._selectedButton = event.target;
+			this._selectedItem = event.target;
 			this.fireEvent("selection-change", {
-				selectedButton: this._selectedButton,
+				selectedItem: this._selectedItem,
 			});
 		}
 
-		this._selectedButton.pressed = true;
-		this._itemNavigation.setCurrentItem(this._selectedButton);
+		this._selectedItem.pressed = true;
+		this._itemNavigation.setCurrentItem(this._selectedItem);
 
 		return this;
 	}
 
+	_onclick(event) {
+		this._selectItem(event);
+	}
+
+	_onkeydown(event) {
+		if (isEnter(event)) {
+			this._selectItem(event);
+		} else if (isSpace(event)) {
+			event.preventDefault();
+		}
+	}
+
+	_onkeyup(event) {
+		if (isSpace(event)) {
+			this._selectItem(event);
+		}
+	}
+
 	_onfocusin(event) {
 		// If the component was previously focused,
 		// update the ItemNavigation to sync butons` tabindex values
@@ -202,28 +230,28 @@ class SegmentedButton extends UI5Element {
 
 		// If the component is focused for the first time
 		// focus the selected item if such present
-		if (this.selectedButton) {
-			this.selectedButton.focus();
-			this._itemNavigation.setCurrentItem(this._selectedButton);
+		if (this.selectedItem) {
+			this.selectedItem.focus();
+			this._itemNavigation.setCurrentItem(this._selectedItem);
 			this.hasPreviouslyFocusedItem = true;
 		}
 	}
 
 	async _doLayout() {
-		const buttonsHaveWidth = this.widths && this.widths.some(button => button.offsetWidth > 2); // 2 are the pixel's added for rounding & IE
-		if (!buttonsHaveWidth) {
-			await this.measureButtonsWidth();
+		const itemsHaveWidth = this.widths && this.widths.some(item => item.offsetWidth > 2); // 2 are the pixel's added for rounding & IE
+		if (!itemsHaveWidth) {
+			await this.measureItemsWidth();
 		}
 
 		const parentWidth = this.parentNode.offsetWidth;
 
 		if (!this.style.width || this.percentageWidthSet) {
-			this.style.width = `${Math.max(...this.widths) * this.buttons.length}px`;
+			this.style.width = `${Math.max(...this.widths) * this.items.length}px`;
 			this.absoluteWidthSet = true;
 		}
 
-		this.buttons.forEach(button => {
-			button.style.width = "100%";
+		this.items.forEach(item => {
+			item.style.width = "100%";
 		});
 
 		if (parentWidth <= this.offsetWidth && this.absoluteWidthSet) {
@@ -233,14 +261,18 @@ class SegmentedButton extends UI5Element {
 	}
 
 	/**
-	 * Currently selected button.
+	 * Currently selected item.
 	 *
 	 * @readonly
-	 * @type { ui5-togglebutton }
+	 * @type { ui5-segmented-button-item }
 	 * @public
 	 */
-	get selectedButton() {
-		return this._selectedButton;
+	get selectedItem() {
+		return this._selectedItem;
+	}
+
+	get ariaDescribedBy() {
+		return this.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY);
 	}
 
 	get ariaDescription() {

package/src/SegmentedButtonItem.hbs

@@ -0,0 +1,42 @@
+<li
+		role="option"
+		aria-roledescription="{{ariaDescription}}"
+		aria-posinset="{{posInSet}}"
+		aria-setsize="{{sizeOfSet}}"
+		aria-selected="{{pressed}}"
+		class="ui5-button-root"
+		aria-disabled="{{disabled}}"
+		data-sap-focus-ref
+	{{> ariaPressed}}
+		dir="{{effectiveDir}}"
+		@focusout={{_onfocusout}}
+		@focusin={{_onfocusin}}
+		@click={{_onclick}}
+		@mousedown={{_onmousedown}}
+		@mouseup={{_onmouseup}}
+		@keydown={{_onkeydown}}
+		@keyup={{_onkeyup}}
+		@touchstart="{{_ontouchstart}}"
+		@touchend="{{_ontouchend}}"
+		tabindex={{tabIndexValue}}
+		aria-label="{{ariaLabelText}}"
+		title="{{accInfo.title}}"
+>
+	{{#if icon}}
+		<ui5-icon
+			class="ui5-button-icon"
+			name="{{icon}}"
+			part="icon"
+			?show-tooltip={{showIconTooltip}}
+		></ui5-icon>
+	{{/if}}
+
+	<span id="{{_id}}-content" class="ui5-button-text">
+		<bdi>
+			<slot></slot>
+		</bdi>
+	</span>
+
+</li>
+
+{{#*inline "ariaPressed"}}{{/inline}}

package/src/SegmentedButtonItem.js

@@ -0,0 +1,112 @@
+import SegmentedButtonItemTemplate from "./generated/templates/SegmentedButtonItemTemplate.lit.js";
+import ToggleButton from "./ToggleButton.js";
+import ButtonDesign from "./types/ButtonDesign.js";
+
+import { SEGMENTEDBUTTONITEM_ARIA_DESCRIPTION } from "./generated/i18n/i18n-defaults.js";
+
+/**
+ * @public
+ */
+const metadata = {
+	tag: "ui5-segmented-button-item",
+	properties: /** @lends  sap.ui.webcomponents.main.SegmentedButtonItem.prototype */ {
+		/**
+		 * <b>Note:</b> The property is inherited and not supported. If set, it won't take any effect.
+		 *
+		 * @public
+		 */
+		design: {
+			type: ButtonDesign,
+			defaultValue: ButtonDesign.Default,
+		},
+
+		/**
+		 * <b>Note:</b> The property is inherited and not supported. If set, it won't take any effect.
+		 *
+		 * @public
+		 */
+		iconEnd: {
+			type: Boolean,
+		},
+
+		/**
+		 * <b>Note:</b> The property is inherited and not supported. If set, it won't take any effect.
+		 *
+		 * @public
+		 */
+		iconSize: {
+			type: String,
+			defaultValue: undefined,
+		},
+
+		/**
+		 * <b>Note:</b> The property is inherited and not supported. If set, it won't take any effect.
+		 *
+		 * @public
+		 */
+		submits: {
+			type: Boolean,
+		},
+
+		/**
+		 * Defines the index of the item inside of the SegmentedButton.
+		 *
+		 * @private
+		 * @type {String}
+		 */
+		posInSet: {
+			type: String,
+		},
+
+		/**
+		 * Defines how many items are inside of the SegmentedButton.
+		 *
+		 * @private
+		 * @type {String}
+		 */
+		sizeOfSet: {
+			type: String,
+		},
+	},
+};
+
+/**
+ * @class
+ *
+ *<h3 class="comment-api-title">Overview</h3>
+ *
+ * Users can use the <code>ui5-segmented-button-item</code> as part of a <code>ui5-segmented-button</code>.
+ * <br><br>
+ * Clicking or tapping on a <code>ui5-segmented-button-item</code> changes its state to <code>pressed</code>.
+ * The item returns to its initial state when the user clicks or taps on it again.
+ * By applying additional custom CSS-styling classes, apps can give a different style to any
+ * <code>ui5-segmented-button-item</code>.
+ *
+ * <h3>ES6 Module Import</h3>
+ *
+ * <code>import "@ui5/webcomponents/dist/SegmentedButtonItem";</code>
+ *
+ * @constructor
+ * @author SAP SE
+ * @alias sap.ui.webcomponents.main.SegmentedButtonItem
+ * @extends ToggleButton
+ * @tagname ui5-segmented-button-item
+ * @public
+ */
+class SegmentedButtonItem extends ToggleButton {
+	static get metadata() {
+		return metadata;
+	}
+
+	static get template() {
+		return SegmentedButtonItemTemplate;
+	}
+
+	get ariaDescription() {
+		return this.i18nBundle.getText(SEGMENTEDBUTTONITEM_ARIA_DESCRIPTION);
+	}
+}
+
+SegmentedButtonItem.define();
+
+export default SegmentedButtonItem;

package/src/Toast.hbs

@@ -1,11 +1,13 @@
-<div class="ui5-toast-root"
-	role="alert"
-	style="{{styles.root}}"
-	dir="{{effectiveDir}}"
-	@mouseover="{{_onmouseover}}"
-	@mouseleave="{{_onmouseleave}}"
-	@transitionend="{{_ontransitionend}}">
-	<bdi>
-		<slot></slot>
-	</bdi>
-</div>
+{{#if domRendered}}
+	<div class="ui5-toast-root"
+		role="alert"
+		style="{{styles.root}}"
+		dir="{{effectiveDir}}"
+		@mouseover="{{_onmouseover}}"
+		@mouseleave="{{_onmouseleave}}"
+		@transitionend="{{_ontransitionend}}">
+		<bdi>
+			<slot></slot>
+		</bdi>
+	</div>
+{{/if}}

package/src/Toast.js

@@ -79,6 +79,15 @@ const metadata = {
 		hover: {
 			type: Boolean,
 		},
+
+		/**
+		 * Indicates whether the component DOM is rendered.
+		 * @type {boolean}
+		 * @private
+		 */
+		domRendered: {
+			type: Boolean,
+		},
 	},
 	slots: /** @lends sap.ui.webcomponents.main.Toast.prototype */ {
 		/**
@@ -206,6 +215,7 @@ class Toast extends UI5Element {
 	}
 
 	_initiateOpening() {
+		this.domRendered = true;
 		requestAnimationFrame(_ => {
 			this.open = true;
 		});
@@ -215,6 +225,7 @@ class Toast extends UI5Element {
 		if (this.hover) {
 			return;
 		}
+		this.domRendered = false;
 		this.open = false;
 	}
 

package/src/Tree.hbs

@@ -3,7 +3,7 @@
     .headerText="{{headerText}}"
     .footerText="{{footerText}}"
     .noDataText="{{noDataText}}"
-    .accRole="{{_role}}"
+    .accessibleRole="{{_role}}"
     @ui5-item-click="{{_onListItemClick}}"
     @ui5-item-delete="{{_onListItemDelete}}"
     @ui5-selection-change="{{_onListSelectionChange}}"

package/src/TreeListItem.js

@@ -10,7 +10,6 @@ import {
 	TREE_ITEM_ARIA_LABEL,
 	TREE_ITEM_EXPAND_NODE,
 	TREE_ITEM_COLLAPSE_NODE,
-	LIST_ITEM_SELECTED,
 } from "./generated/i18n/i18n-defaults.js";
 
 // Template
@@ -275,7 +274,8 @@ class TreeListItem extends ListItem {
 			ariaLevel: this.level,
 			posinset: this._posinset,
 			setsize: this._setsize,
-			listItemAriaLabel: this.ariaLabelText,
+			ariaSelectedText: this.ariaSelectedText,
+			listItemAriaLabel: this.i18nBundle.getText(TREE_ITEM_ARIA_LABEL),
 		};
 	}
 
@@ -304,16 +304,6 @@ class TreeListItem extends ListItem {
 		}
 	}
 
-	get ariaLabelText() {
-		let text = this.i18nBundle.getText(TREE_ITEM_ARIA_LABEL);
-
-		if (this.selected) {
-			text += ` ${this.i18nBundle.getText(LIST_ITEM_SELECTED)}`;
-		}
-
-		return text;
-	}
-
 	get iconAccessibleName() {
 		return this.expanded ? this.i18nBundle.getText(TREE_ITEM_COLLAPSE_NODE) : this.i18nBundle.getText(TREE_ITEM_EXPAND_NODE);
 	}

package/src/i18n/messagebundle.properties

@@ -94,9 +94,15 @@ LIST_ITEM_POSITION=List item {0} of {1}
 #XACT: ARIA announcement for the list item selection.
 LIST_ITEM_SELECTED=Selected
 
+#XACT: ARIA announcement for the list item selected=false state
+LIST_ITEM_NOT_SELECTED=Not Selected
+
 #XBUT: List Multi Selection Mode Checkbox aria-label text
 ARIA_LABEL_LIST_ITEM_CHECKBOX = Multiple Selection mode.
 
+#XBUT: List Single Selection Mode RadioButton aria-label text
+ARIA_LABEL_LIST_ITEM_RADIO_BUTTON=Item Selection.
+
 #XTOL: Tooltip of messgae strip close button
 MESSAGE_STRIP_CLOSE_BUTTON=Message Strip Close
 
@@ -131,7 +137,13 @@ RATING_INDICATOR_TEXT=Rating Indicator
 RESPONSIVE_POPOVER_CLOSE_DIALOG_BUTTON=Decline
 
 #XACT: ARIA description for the segmented button
-SEGMENTEDBUTTON_ARIA_DESCRIPTION=Segmented button
+SEGMENTEDBUTTON_ARIA_DESCRIPTION=Segmented button group
+
+#XACT: ARIA described by for the segmented button
+SEGMENTEDBUTTON_ARIA_DESCRIBEDBY=Press SPACE or ENTER to select an item
+
+#XACT: ARIA description for the segmented button item
+SEGMENTEDBUTTONITEM_ARIA_DESCRIPTION=Segmented button
 
 #XACT: ARIA description for slider handle
 SLIDER_ARIA_DESCRIPTION=Slider handle

package/src/popup-utils/OpenedPopupsRegistry.js

@@ -35,7 +35,7 @@ const _keydownListener = event => {
 	}
 
 	if (isEscape(event)) {
-		openedRegistry.pop().instance.close(true);
+		openedRegistry[openedRegistry.length - 1].instance.close(true);
 	}
 };