@ui5/cli 3.0.0-beta.1 → 3.0.0-beta.2

package/CHANGELOG.md

@@ -2,7 +2,18 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-cli/compare/v3.0.0-beta.1...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-cli/compare/v3.0.0-beta.2...HEAD).
+
+<a name="v3.0.0-beta.2"></a>
+## [v3.0.0-beta.2] - 2022-11-29
+### Dependency Updates
+- Bump [@ui5](https://github.com/ui5)/server from 3.0.0-beta.1 to 3.0.0-beta.2 [`8bbfcf9`](https://github.com/SAP/ui5-cli/commit/8bbfcf9e51036c7c9b60e29f53b011a60063c2ea)
+- Bump [@ui5](https://github.com/ui5)/builder from 3.0.0-beta.1 to 3.0.0-beta.2 [`3b241bc`](https://github.com/SAP/ui5-cli/commit/3b241bca435e107772473fab226b652ab3abbe69)
+- Bump [@ui5](https://github.com/ui5)/project from 3.0.0-beta.2 to 3.0.0-beta.3 [`1654cbc`](https://github.com/SAP/ui5-cli/commit/1654cbc91d6c0483144afbe600738a6bee5b4b66)
+- Bump [@ui5](https://github.com/ui5)/project from 3.0.0-beta.1 to 3.0.0-beta.2 [`677dc78`](https://github.com/SAP/ui5-cli/commit/677dc7856363051db7a4b0b2feb312a98cec943a)
+- Bump [@ui5](https://github.com/ui5)/fs from 3.0.0-beta.2 to 3.0.0-beta.3 [`6f59a7e`](https://github.com/SAP/ui5-cli/commit/6f59a7ed1124dc7e55cbbc42bfe2262103f78ef9)
+- Bump [@ui5](https://github.com/ui5)/logger from 3.0.1-beta.0 to 3.0.1-beta.1 [`1532039`](https://github.com/SAP/ui5-cli/commit/15320397fae3ccba9a702bbb6d920367c67c738a)
+
 
 <a name="v3.0.0-beta.1"></a>
 ## [v3.0.0-beta.1] - 2022-11-07
@@ -852,6 +863,7 @@ Only Node.js v10 or higher is supported.
 <a name="v0.0.1"></a>
 ## v0.0.1 - 2018-06-06
 
+[v3.0.0-beta.2]: https://github.com/SAP/ui5-cli/compare/v3.0.0-beta.1...v3.0.0-beta.2
 [v3.0.0-beta.1]: https://github.com/SAP/ui5-cli/compare/v3.0.0-alpha.15...v3.0.0-beta.1
 [v3.0.0-alpha.15]: https://github.com/SAP/ui5-cli/compare/v3.0.0-alpha.14...v3.0.0-alpha.15
 [v3.0.0-alpha.14]: https://github.com/SAP/ui5-cli/compare/v3.0.0-alpha.13...v3.0.0-alpha.14

package/lib/cli/commands/serve.js

@@ -160,7 +160,7 @@ serve.handler = async function(argv) {
 			browserUrl += relPath;
 		}
 		const {default: open} = await import("open");
-		open(browserUrl, {url: true});
+		open(browserUrl);
 	}
 };
 

package/lib/cli/commands/tree.js

@@ -43,7 +43,7 @@ tree.handler = async function(argv) {
 		elapsedTime = await getElapsedTime(startTime);
 	}
 
-	const projects = {};
+	const projects = Object.create(null);
 	const indentWidth = 4;
 	await graph.traverseBreadthFirst(async ({project, getDependencies}) => {
 		const deps = getDependencies().map((dep) => {

package/lib/framework/add.js

@@ -1,4 +1,4 @@
-import {getRootProjectConfiguration, getFrameworkResolver, isValidSpecVersion} from "./utils.js";
+import {getRootProjectConfiguration, getFrameworkResolver} from "./utils.js";
 
 /**
  * Adds the given set of libraries to the framework libraries section in the ui5.yaml
@@ -10,10 +10,10 @@ import {getRootProjectConfiguration, getFrameworkResolver, isValidSpecVersion} f
 export default async function({projectGraphOptions, libraries}) {
 	const project = await getRootProjectConfiguration(projectGraphOptions);
 
-	if (!isValidSpecVersion(project.getSpecVersion())) {
+	if (project.getSpecVersion().lt("2.0")) {
 		throw new Error(
 			`ui5 add command requires specVersion "2.0" or higher. ` +
-			`Project ${project.getName()} uses specVersion "${project.getSpecVersion()}"`
+			`Project ${project.getName()} uses specVersion "${project.getSpecVersion().toString()}"`
 		);
 	}
 

package/lib/framework/remove.js

@@ -1,4 +1,4 @@
-import {getRootProjectConfiguration, isValidSpecVersion} from "./utils.js";
+import {getRootProjectConfiguration} from "./utils.js";
 import logger from "@ui5/logger";
 
 const log = logger.getLogger("cli:framework:remove");
@@ -13,10 +13,10 @@ const log = logger.getLogger("cli:framework:remove");
 export default async function({projectGraphOptions, libraries}) {
 	const project = await getRootProjectConfiguration(projectGraphOptions);
 
-	if (!isValidSpecVersion(project.getSpecVersion())) {
+	if (project.getSpecVersion().lt("2.0")) {
 		throw new Error(
 			`ui5 remove command requires specVersion "2.0" or higher. ` +
-			`Project ${project.getName()} uses specVersion "${project.getSpecVersion()}"`
+			`Project ${project.getName()} uses specVersion "${project.getSpecVersion().toString()}"`
 		);
 	}
 

package/lib/framework/use.js

@@ -1,4 +1,4 @@
-import {getRootProjectConfiguration, getFrameworkResolver, isValidSpecVersion} from "./utils.js";
+import {getRootProjectConfiguration, getFrameworkResolver} from "./utils.js";
 
 async function resolveVersion({frameworkName, frameworkVersion}, resolverOptions) {
 	return await getFrameworkResolver(frameworkName).resolveVersion(frameworkVersion, resolverOptions);
@@ -25,10 +25,10 @@ function getEffectiveFrameworkName({project, frameworkOptions}) {
 export default async function({projectGraphOptions, frameworkOptions}) {
 	const project = await getRootProjectConfiguration(projectGraphOptions);
 
-	if (!isValidSpecVersion(project.getSpecVersion())) {
+	if (project.getSpecVersion().lt("2.0")) {
 		throw new Error(
 			`ui5 use command requires specVersion "2.0" or higher. ` +
-			`Project ${project.getName()} uses specVersion "${project.getSpecVersion()}"`
+			`Project ${project.getName()} uses specVersion "${project.getSpecVersion().toString()}"`
 		);
 	}
 

package/lib/framework/utils.js

@@ -28,10 +28,3 @@ export function getFrameworkResolver(frameworkName) {
 		throw new Error("Invalid framework.name: " + frameworkName);
 	}
 }
-
-export function isValidSpecVersion(specVersion) {
-	// Only checks for a string and versions that are not supported
-	// The CLI relies on the @ui5/project to correctly verify the version
-	return typeof specVersion === "string" && specVersion !== "" &&
-		specVersion !== "0.1" && specVersion !== "1.0" && specVersion !== "1.1";
-}