@ui5/builder 4.0.0 → 4.0.2

package/CHANGELOG.md

@@ -2,7 +2,20 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v4.0.0...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v4.0.2...HEAD).
+
+<a name="v4.0.2"></a>
+## [v4.0.2] - 2024-08-18
+### Dependency Updates
+- Bump cheerio from 1.0.0-rc.12 to 1.0.0 ([#1078](https://github.com/SAP/ui5-builder/issues/1078)) [`d80c79d`](https://github.com/SAP/ui5-builder/commit/d80c79d5578516cf533e649e73d55602afa8b908)
+
+
+<a name="v4.0.1"></a>
+## [v4.0.1] - 2024-07-29
+### Bug Fixes
+- **manifestEnhancer:** Improve error handling [`16a4e78`](https://github.com/SAP/ui5-builder/commit/16a4e785ab71f8714b3926aa0bb8573f8da4dd08)
+- **manifestEnhancer:** Fix fallbackLocale handling [`421a375`](https://github.com/SAP/ui5-builder/commit/421a37577c11c50d938bc59f3b8fca371a703cd3)
+
 
 <a name="v4.0.0"></a>
 ## [v4.0.0] - 2024-07-23
@@ -919,6 +932,8 @@ to load the custom bundle file instead.
 
 ### Features
 - Add ability to configure component preloads and custom bundles [`2241e5f`](https://github.com/SAP/ui5-builder/commit/2241e5ff98fd95f1f80cc74959655ae7a9c660e7)
+[v4.0.2]: https://github.com/SAP/ui5-builder/compare/v4.0.1...v4.0.2
+[v4.0.1]: https://github.com/SAP/ui5-builder/compare/v4.0.0...v4.0.1
 [v4.0.0]: https://github.com/SAP/ui5-builder/compare/v3.3.0...v4.0.0
 [v3.5.1]: https://github.com/SAP/ui5-builder/compare/v3.5.0...v3.5.1
 [v3.5.0]: https://github.com/SAP/ui5-builder/compare/v3.4.1...v3.5.0

package/lib/lbt/analyzer/XMLTemplateAnalyzer.js

@@ -402,7 +402,7 @@ class XMLTemplateAnalyzer {
 					}
 				}
 			}
-		} catch (err) {
+		} catch {
 			// ignore missing resources
 			// console.warn( "node not found %s", moduleName);
 		}

package/lib/lbt/bundle/Builder.js

@@ -636,7 +636,7 @@ class BundleBuilder {
 				let resource = null;
 				try {
 					resource = await this.pool.findResourceWithInfo(module);
-				} catch (e) {
+				} catch {
 					log.error(`    couldn't find ${module}`);
 				}
 

package/lib/lbt/resources/ResourceCollector.js

@@ -140,7 +140,7 @@ class ResourceCollector {
 					let subModuleInfo;
 					try {
 						subModuleInfo = await this._pool.getModuleInfo(subModule);
-					} catch (err) {
+					} catch {
 						log.verbose(`	Missing submodule ${subModule} included by ${moduleInfo.name}`);
 					}
 					if (subModuleInfo) {

package/lib/processors/bootstrapHtmlTransformer.js

@@ -1,6 +1,6 @@
 import {getLogger} from "@ui5/logger";
 const log = getLogger("builder:processors:bootstrapHtmlTransformer");
-import cheerio from "cheerio";
+import * as cheerio from "cheerio";
 
 /**
  * @module @ui5/builder/processors/bootstrapHtmlTransformer

package/lib/processors/manifestEnhancer.js

@@ -15,7 +15,7 @@ function isAbsoluteUrl(url) {
 		const parsedUrl = new URL(url);
 		// URL with ui5 protocol shouldn't be treated as absolute URL and will be handled separately
 		return parsedUrl.protocol !== "ui5:";
-	} catch (err) {
+	} catch {
 		// URL constructor without base requires absolute URL and throws an error for relative URLs
 		return false;
 	}
@@ -212,7 +212,7 @@ class ManifestEnhancer {
 		}
 		const supportedLocales = await this.findSupportedLocales(normalizedBundleUrl);
 		if (!isTerminologyBundle && supportedLocales.length > 0) {
-			if (fallbackLocale && !supportedLocales.includes(fallbackLocale)) {
+			if (typeof fallbackLocale === "string" && !supportedLocales.includes(fallbackLocale)) {
 				log.error(
 					`${this.filePath}: ` +
 					`Generated supported locales ('${supportedLocales.join("', '")}') for ` +
@@ -221,7 +221,7 @@ class ManifestEnhancer {
 					"properties file for defined fallbackLocale or configure another available fallbackLocale"
 				);
 				return [];
-			} else if (!fallbackLocale && !supportedLocales.includes("en")) {
+			} else if (typeof fallbackLocale === "undefined" && !supportedLocales.includes("en")) {
 				log.warn(
 					`${this.filePath}: ` +
 					`Generated supported locales ('${supportedLocales.join("', '")}') for ` +
@@ -359,7 +359,7 @@ class ManifestEnhancer {
 		this.runInvoked = true;
 
 		if (!this.manifest._version) {
-			log.verbose(`${this.filePath}: _version is not defined. No supportedLocales are generated`);
+			log.verbose(`${this.filePath}: _version is not defined. No supportedLocales can be generated`);
 			return;
 		}
 
@@ -368,6 +368,11 @@ class ManifestEnhancer {
 			return;
 		}
 
+		if (!this.manifest["sap.app"]?.id) {
+			log.verbose(`${this.filePath}: sap.app/id is not defined. No supportedLocales can be generated`);
+			return;
+		}
+
 		if (this.manifest["sap.app"].type === "library") {
 			await this.processSapUi5LibraryI18n();
 		} else {

package/lib/tasks/bundlers/generateFlexChangesBundle.js

@@ -74,6 +74,7 @@ export default async function({workspace, taskUtil, options = {}}) {
 		manifestContent["sap.ui5"].dependencies = manifestContent["sap.ui5"].dependencies || {};
 		if (!Array.isArray(manifestContent["sap.ui5"].dependencies.minUI5Version)) {
 			manifestContent["sap.ui5"].dependencies.minUI5Version =
+				// eslint-disable-next-line no-constant-binary-expression
 				[manifestContent["sap.ui5"].dependencies.minUI5Version] || [""];
 		}
 		return manifestContent["sap.ui5"].dependencies.minUI5Version;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ui5/builder",
-	"version": "4.0.0",
+	"version": "4.0.2",
 	"description": "UI5 Tooling - Builder",
 	"author": {
 		"name": "SAP SE",
@@ -124,7 +124,7 @@
 		"@jridgewell/sourcemap-codec": "^1.5.0",
 		"@ui5/fs": "^4.0.0",
 		"@ui5/logger": "^4.0.1",
-		"cheerio": "1.0.0-rc.12",
+		"cheerio": "1.0.0",
 		"escape-unicode": "^0.2.0",
 		"escope": "^4.0.0",
 		"espree": "^10.1.0",
@@ -134,24 +134,26 @@
 		"pretty-data": "^0.40.0",
 		"rimraf": "^6.0.1",
 		"semver": "^7.6.3",
-		"terser": "^5.31.3",
+		"terser": "^5.31.6",
 		"workerpool": "^9.1.3",
 		"xml2js": "^0.6.2"
 	},
 	"devDependencies": {
+		"@eslint/js": "^9.8.0",
 		"@istanbuljs/esm-loader-hook": "^0.2.0",
 		"@jridgewell/trace-mapping": "^0.3.25",
-		"@ui5/project": "^4.0.0",
+		"@ui5/project": "^4.0.2",
 		"ava": "^6.1.3",
 		"chokidar-cli": "^3.0.0",
 		"cross-env": "^7.0.3",
 		"depcheck": "^1.4.7",
 		"docdash": "^2.0.2",
-		"eslint": "^8.57.0",
+		"eslint": "^9.9.0",
 		"eslint-config-google": "^0.14.0",
-		"eslint-plugin-ava": "^14.0.0",
-		"eslint-plugin-jsdoc": "^48.8.3",
+		"eslint-plugin-ava": "^15.0.1",
+		"eslint-plugin-jsdoc": "^50.2.2",
 		"esmock": "^2.6.7",
+		"globals": "^15.9.0",
 		"line-column": "^1.0.2",
 		"nyc": "^17.0.0",
 		"open-cli": "^8.0.0",