@ui5/builder 3.0.7 → 3.0.8

package/CHANGELOG.md

@@ -2,10 +2,17 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v3.0.7...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v3.0.8...HEAD).
+
+<a name="v3.0.8"></a>
+## [v3.0.8] - 2023-07-18
+### Bug Fixes
+- Revert "[INTERNAL] Remove implicit dependencies concept ([#913](https://github.com/SAP/ui5-builder/issues/913))" [`1043714`](https://github.com/SAP/ui5-builder/commit/1043714e3b952a8280f1ff7909f79db3b750eb0c)
+- **generateJsdoc:** Also process resources created by preceeding tasks [`04447bd`](https://github.com/SAP/ui5-builder/commit/04447bdec28b8bf18c24bd53e3fe8be9bdeed6c2)
+
 
 <a name="v3.0.7"></a>
-## [v3.0.7] - 2023-07-12
+## [v3.0.7] - 2023-07-13
 ### Bug Fixes
 - Don't report a missing module that's contained in another bundle ([#915](https://github.com/SAP/ui5-builder/issues/915)) [`8f23f38`](https://github.com/SAP/ui5-builder/commit/8f23f388f6d64f313ae8a89d0fcaf39ba905a70b)
 
@@ -809,6 +816,7 @@ to load the custom bundle file instead.
 
 ### Features
 - Add ability to configure component preloads and custom bundles [`2241e5f`](https://github.com/SAP/ui5-builder/commit/2241e5ff98fd95f1f80cc74959655ae7a9c660e7)
+[v3.0.8]: https://github.com/SAP/ui5-builder/compare/v3.0.7...v3.0.8
 [v3.0.7]: https://github.com/SAP/ui5-builder/compare/v3.0.6...v3.0.7
 [v3.0.6]: https://github.com/SAP/ui5-builder/compare/v3.0.5...v3.0.6
 [v3.0.5]: https://github.com/SAP/ui5-builder/compare/v3.0.4...v3.0.5

package/lib/lbt/analyzer/JSModuleAnalyzer.js

@@ -3,6 +3,7 @@ import escope from "escope";
 import {fromUI5LegacyName, fromRequireJSName, resolveRelativeRequireJSName} from "../utils/ModuleName.js";
 import moduleInfo from "../resources/ModuleInfo.js";
 const ModuleFormat = moduleInfo.Format;
+import {MODULE__JQUERY_SAP_GLOBAL, MODULE__UI5LOADER_AUTOCONFIG} from "../UI5ClientConstants.js";
 import {
 	findOwnProperty,
 	getLocation,
@@ -334,6 +335,17 @@ class JSModuleAnalyzer {
 			}
 		}
 
+		// depending on the used module APIs, add an implicit dependency to the loader entry module
+		if ( info.format === ModuleFormat.UI5_LEGACY ) {
+			info.addImplicitDependency(MODULE__JQUERY_SAP_GLOBAL);
+		} else if ( info.format === ModuleFormat.UI5_DEFINE ) {
+			// Note: the implicit dependency for sap.ui.define modules points to the standard UI5
+			// loader config module. A more general approach would be to add a dependency to the loader
+			// only, but then standard configuration would be missed by dependency resolution
+			// (to be clarified)
+			info.addImplicitDependency(MODULE__UI5LOADER_AUTOCONFIG);
+		}
+
 		if ( !bIsUi5Module ) {
 			// when there are no indicators for module APIs, mark the module as 'raw' module
 			info.rawModule = true;

package/lib/lbt/analyzer/XMLTemplateAnalyzer.js

@@ -178,6 +178,8 @@ class XMLTemplateAnalyzer {
 				// console.log(result);
 				// clear();
 				if ( isFragment ) {
+					// all fragments implicitly depend on the fragment class
+					this.info.addImplicitDependency(FRAGMENT_MODULE);
 					this._analyzeNode(result);
 				} else {
 					// views require a special handling of the root node
@@ -194,6 +196,8 @@ class XMLTemplateAnalyzer {
 	}
 
 	_analyzeViewRootNode(node) {
+		this.info.addImplicitDependency(XMLVIEW_MODULE);
+
 		const controllerName = getAttribute(node, XMLVIEW_CONTROLLERNAME_ATTRIBUTE);
 		if ( controllerName ) {
 			this._addDependency( fromUI5LegacyName(controllerName, ".controller.js"), this.conditional );

package/lib/lbt/resources/ModuleInfo.js

@@ -6,6 +6,14 @@
  */
 const STRICT = 0;
 
+/**
+ * An implicit dependency is also strict, but has not been declared. E.g. each UI5 module depends on
+ * jquery.sap.global.
+ *
+ * @private
+ */
+const IMPLICIT = 1;
+
 /**
  * A conditional dependency has to be resolved only under certain conditions that typically are
  * checked at runtime.
@@ -104,7 +112,7 @@ class ModuleInfo {
 		// included already as a submodule.
 		// If the dependency was known already, update the kind
 		// only when the new kind is stronger than the current one.
-		// STRICT is stronger than CONDITIONAL
+		// STRICT is stronger than IMPLICIT, IMPLICIT is stronger than CONDITIONAL
 		if ( dependency &&
 				dependency !== this.name &&
 				this.subModules.indexOf(dependency) < 0 &&
@@ -113,6 +121,10 @@ class ModuleInfo {
 		}
 	}
 
+	addImplicitDependency(dependency) {
+		this._addDependency(dependency, IMPLICIT);
+	}
+
 	addDependency(dependency, conditional) {
 		this._addDependency(dependency, conditional ? CONDITIONAL : STRICT);
 	}
@@ -163,6 +175,10 @@ class ModuleInfo {
 		return this._dependencies[dependency] === CONDITIONAL;
 	}
 
+	isImplicitDependency(dependency) {
+		return this._dependencies[dependency] === IMPLICIT;
+	}
+
 	get name() {
 		return this._name;
 	}

package/lib/lbt/resources/ResourceCollector.js

@@ -124,7 +124,7 @@ class ResourceCollector {
 				moduleInfo.dependencies.forEach((dep) => {
 					if ( moduleInfo.isConditionalDependency(dep) ) {
 						resourceInfo.condRequired.add(dep);
-					} else {
+					} else if ( !moduleInfo.isImplicitDependency(dep) ) {
 						resourceInfo.required.add(dep);
 					}
 				});
@@ -158,7 +158,7 @@ class ResourceCollector {
 									if (!resourceInfo.required.has(dep)) {
 										resourceInfo.condRequired.add(dep);
 									}
-								} else {
+								} else if ( !subModuleInfo.isImplicitDependency(dep) ) {
 									// Move module from condRequired to required
 									if (resourceInfo.condRequired.has(dep)) {
 										resourceInfo.condRequired.delete(dep);