@ui5/builder 3.0.0-alpha.9 → 3.0.0-beta.2

package/lib/lbt/graph/topologicalSort.js

@@ -1,6 +1,6 @@
-"use strict";
 
-const log = require("@ui5/logger").getLogger("lbt:graph:topologicalSort");
+import logger from "@ui5/logger";
+const log = logger.getLogger("lbt:graph:topologicalSort");
 
 /**
  * Represents a module and its dependencies in a dependency graph.
@@ -186,4 +186,4 @@ function topologicalSort(pool, moduleNames) {
 		});
 }
 
-module.exports = topologicalSort;
+export default topologicalSort;

package/lib/lbt/resources/LibraryFileAnalyzer.js

@@ -1,11 +1,10 @@
 /**
- * Used by the ResourcePool to read raw module info as stored in the .liubrary files.
+ * Used by the ResourcePool to read raw module info as stored in the .library files.
  * It does not (yet) analyze dependencies of the library and therefore isn't part of the analyzer package (yet).
  */
-"use strict";
-
-const xml2js = require("xml2js");
-const log = require("@ui5/logger").getLogger("lbt:resources:LibraryFileAnalyzer");
+import xml2js from "xml2js";
+import logger from "@ui5/logger";
+const log = logger.getLogger("lbt:resources:LibraryFileAnalyzer");
 
 const parser = new xml2js.Parser({
 	// explicitChildren: true,
@@ -49,8 +48,8 @@ function createRawInfo(rawModule) {
 	}
 }
 
-function getDependencyInfos( name, content ) {
-	const infos = {};
+export function getDependencyInfos( name, content ) {
+	const infos = Object.create(null);
 	parser.parseString(content, (err, result) => {
 		if ( result &&
 				result.library &&
@@ -77,5 +76,3 @@ function getDependencyInfos( name, content ) {
 	// console.log("done", infos);
 	return infos;
 }
-
-module.exports.getDependencyInfos = getDependencyInfos;

package/lib/lbt/resources/LocatorResource.js

@@ -1,4 +1,4 @@
-const Resource = require("./Resource");
+import Resource from "./Resource.js";
 
 class LocatorResource extends Resource {
 	constructor(pool, resource, moduleName) {
@@ -19,4 +19,4 @@ class LocatorResource extends Resource {
 	}
 }
 
-module.exports = LocatorResource;
+export default LocatorResource;

package/lib/lbt/resources/LocatorResourcePool.js

@@ -1,5 +1,5 @@
-const ResourcePool = require("./ResourcePool");
-const LocatorResource = require("./LocatorResource");
+import ResourcePool from "./ResourcePool.js";
+import LocatorResource from "./LocatorResource.js";
 
 class LocatorResourcePool extends ResourcePool {
 	prepare(resources, moduleNameMapping) {
@@ -16,4 +16,4 @@ class LocatorResourcePool extends ResourcePool {
 	}
 }
 
-module.exports = LocatorResourcePool;
+export default LocatorResourcePool;

package/lib/lbt/resources/ModuleInfo.js

@@ -1,4 +1,3 @@
-"use strict";
 
 /**
  * A strict dependency always has to be fulfilled and is declared as part of the module's definition.
@@ -40,7 +39,7 @@ class ModuleInfo {
 	constructor(name) {
 		this._name = name;
 		this.subModules = [];
-		this._dependencies = {};
+		this._dependencies = Object.create(null);
 		this.dynamicDependencies = false;
 
 		/**
@@ -250,4 +249,4 @@ public class ModuleInfo {
 
 } */
 
-module.exports = ModuleInfo;
+export default ModuleInfo;

package/lib/lbt/resources/Resource.js

@@ -1,7 +1,6 @@
-"use strict";
 
-const {promisify} = require("util");
-const fs = require("graceful-fs");
+import {promisify} from "node:util";
+import fs from "graceful-fs";
 const readFile = promisify(fs.readFile);
 
 class Resource {
@@ -27,4 +26,4 @@ class Resource {
 	}
 }
 
-module.exports = Resource;
+export default Resource;

package/lib/lbt/resources/ResourceCollector.js

@@ -1,13 +1,12 @@
-const ResourceInfoList = require("./ResourceInfoList");
-const ResourceFilterList = require("./ResourceFilterList");
-const ResourceInfo = require("./ResourceInfo");
-
+import ResourceInfoList from "./ResourceInfoList.js";
+import ResourceFilterList from "./ResourceFilterList.js";
+import ResourceInfo from "./ResourceInfo.js";
+import logger from "@ui5/logger";
+const log = logger.getLogger("lbt:resources:ResourceCollector");
 
 const LOCALE = /^((?:[^/]+\/)*[^/]+?)_([A-Z]{2}(?:_[A-Z]{2}(?:_[A-Z0-9_]+)?)?)(\.properties|\.hdbtextbundle)$/i;
 const THEME = /^((?:[^/]+\/)*)themes\/([^/]+)\//;
 
-const log = require("@ui5/logger").getLogger("lbt:resources:ResourceCollector");
-
 /**
  * Collects all resources in a set of resource folders or from an archive
  * and writes a 'resources.json' file for each component or library
@@ -67,7 +66,7 @@ class ResourceCollector {
 	 *
 	 * If no component is given, orphans will only be reported but not added to any component (default).
 	 *
-	 * @param {object<string, string[]>} list component to list of components
+	 * @param {Object<string, string[]>} list component to list of components
 	 */
 	setExternalResources(list) {
 		this._externalResources = list;
@@ -76,7 +75,7 @@ class ResourceCollector {
 	/**
 	 * Processes a resource
 	 *
-	 * @param {module:@ui5/fs.Resource} resource
+	 * @param {@ui5/fs/Resource} resource
 	 */
 	async visitResource(resource) {
 		const virPath = resource.getPath();
@@ -400,4 +399,4 @@ class ResourceCollector {
 	}
 }
 
-module.exports = ResourceCollector;
+export default ResourceCollector;

package/lib/lbt/resources/ResourceFilterList.js

@@ -1,6 +1,6 @@
-"use strict";
 
-const log = require("@ui5/logger").getLogger("lbt:resources:ResourceFilterList");
+import logger from "@ui5/logger";
+const log = logger.getLogger("lbt:resources:ResourceFilterList");
 
 const FILTER_PREFIXES = /^[-!+]/;
 
@@ -95,7 +95,7 @@ function makeMatcher(globPattern, fileTypesPattern) {
  * @since 1.16.2
  * @private
  */
-class ResourceFilterList {
+export default class ResourceFilterList {
 	constructor(filters, fileTypes) {
 		this.matchers = [];
 		this.matchByDefault = true;
@@ -127,43 +127,43 @@ class ResourceFilterList {
 	toString() {
 		return this.matchers.map((matcher) => matcher.pattern).join(",");
 	}
-}
 
-/**
- * Each filter entry can be a comma separated list of simple filters. Each simple filter
- * can be a pattern in resource name pattern syntax: A double asterisk '&0x2a;&0x2a;/' denotes an arbitrary
- * number of resource name segments (folders) incl. a trailing slash, whereas a simple asterisk '*'
- * denotes an arbitrary number of resource name characters, but not the segment separator '/'.
- * A dot is interpreted as a dot, all other special regular expression characters keep their
- * special meaning. This is a mixture of ANT-style path patterns and regular expressions.
- *
- * Excludes can be denoted by a leading '-' or '!', includes optionally by a leading '+'.
- * Order of filters is significant, a later exclusion overrides an earlier inclusion
- * and vice versa.
- *
- * Example:
- * <pre>
- *	 !sap/ui/core/
- *	 +sap/ui/core/utils/
- * </pre>
- * excludes everything from sap/ui/core, but includes everything from the subpackage sap/ui/core/utils/.
- *
- * Note that the filter operates on the full name of each resource. If a resource name
- * <code>prefix</code> is configured for a resource set, the filter will be applied
- * to the combination of prefix and local file path and not only to the local file path.
- *
- * @param {string} filterStr comma separated list of simple filters
- * @returns {ResourceFilterList}
- */
-ResourceFilterList.fromString = function(filterStr) {
-	const result = new ResourceFilterList();
-	if ( filterStr != null ) {
-		result.addFilters( filterStr.trim().split(/\s*,\s*/).filter(Boolean) );
+	/**
+	 * Each filter entry can be a comma separated list of simple filters. Each simple filter
+	 * can be a pattern in resource name pattern syntax: A double asterisk '&0x2a;&0x2a;/' denotes an arbitrary
+	 * number of resource name segments (folders) incl. a trailing slash, whereas a simple asterisk '*'
+	 * denotes an arbitrary number of resource name characters, but not the segment separator '/'.
+	 * A dot is interpreted as a dot, all other special regular expression characters keep their
+	 * special meaning. This is a mixture of ANT-style path patterns and regular expressions.
+	 *
+	 * Excludes can be denoted by a leading '-' or '!', includes optionally by a leading '+'.
+	 * Order of filters is significant, a later exclusion overrides an earlier inclusion
+	 * and vice versa.
+	 *
+	 * Example:
+	 * <pre>
+	 *	 !sap/ui/core/
+	*	 +sap/ui/core/utils/
+	* </pre>
+	* excludes everything from sap/ui/core, but includes everything from the subpackage sap/ui/core/utils/.
+	*
+	* Note that the filter operates on the full name of each resource. If a resource name
+	* <code>prefix</code> is configured for a resource set, the filter will be applied
+	* to the combination of prefix and local file path and not only to the local file path.
+	*
+	* @param {string} filterStr comma separated list of simple filters
+	* @returns {ResourceFilterList}
+	*/
+	static fromString(filterStr) {
+		const result = new ResourceFilterList();
+		if ( filterStr != null ) {
+			result.addFilters( filterStr.trim().split(/\s*,\s*/).filter(Boolean) );
+		}
+		return result;
 	}
-	return result;
-};
+}
 
-ResourceFilterList.negateFilters = function(patterns) {
+export function negateFilters(patterns) {
 	return patterns.map((pattern) => {
 		let include = true;
 
@@ -181,6 +181,4 @@ ResourceFilterList.negateFilters = function(patterns) {
 			return "+" + pattern;
 		}
 	});
-};
-
-module.exports = ResourceFilterList;
+}

package/lib/lbt/resources/ResourceInfo.js

@@ -177,4 +177,4 @@ class ResourceInfo {
 	}
 }
 
-module.exports = ResourceInfo;
+export default ResourceInfo;

package/lib/lbt/resources/ResourceInfoList.js

@@ -1,4 +1,4 @@
-const ResourceInfo = require("./ResourceInfo");
+import ResourceInfo from "./ResourceInfo.js";
 
 const DEBUG_RESOURCES_PATTERN = /-dbg((?:\.view|\.fragment|\.controller|\.designtime|\.support)?\.js|\.css)$/;
 
@@ -24,7 +24,9 @@ class ResourceInfoList {
 
 		// --- transient state ---
 		/**
-		 * @type {string} name of the resource
+		 * The name of the resource
+		 *
+		 * @type {string}
 		 */
 		this.name = prefix;
 		/**
@@ -114,4 +116,4 @@ class ResourceInfoList {
 	}
 }
 
-module.exports = ResourceInfoList;
+export default ResourceInfoList;

package/lib/lbt/resources/ResourcePool.js

@@ -1,24 +1,18 @@
-"use strict";
-
-/*
-const fs = require("fs");
-const path = require("path");
-*/
-const {parseJS} = require("../utils/parseUtils");
-const ComponentAnalyzer = require("../analyzer/ComponentAnalyzer");
-const SmartTemplateAnalyzer = require("../analyzer/SmartTemplateAnalyzer");
-const FioriElementsAnalyzer = require("../analyzer/FioriElementsAnalyzer");
-const XMLCompositeAnalyzer = require("../analyzer/XMLCompositeAnalyzer");
-const JSModuleAnalyzer = require("../analyzer/JSModuleAnalyzer");
-const XMLTemplateAnalyzer = require("../analyzer/XMLTemplateAnalyzer");
-
-const LibraryFileAnalyzer = require("./LibraryFileAnalyzer");
-const ModuleInfo = require("./ModuleInfo");
-const ResourceFilterList = require("./ResourceFilterList");
+import {parseJS} from "../utils/parseUtils.js";
+import ComponentAnalyzer from "../analyzer/ComponentAnalyzer.js";
+import SmartTemplateAnalyzer from "../analyzer/SmartTemplateAnalyzer.js";
+import FioriElementsAnalyzer from "../analyzer/FioriElementsAnalyzer.js";
+import XMLCompositeAnalyzer from "../analyzer/XMLCompositeAnalyzer.js";
+import JSModuleAnalyzer from "../analyzer/JSModuleAnalyzer.js";
+import XMLTemplateAnalyzer from "../analyzer/XMLTemplateAnalyzer.js";
+import {getDependencyInfos} from "./LibraryFileAnalyzer.js";
+import ModuleInfo from "./ModuleInfo.js";
+import ResourceFilterList from "./ResourceFilterList.js";
+import logger from "@ui5/logger";
+const log = logger.getLogger("lbt:resources:ResourcePool");
 /*
-const Resource = require("./Resource");
+import Resource from "./Resource";
  */
-const log = require("@ui5/logger").getLogger("lbt:resources:ResourcePool");
 
 const jsAnalyzer = new JSModuleAnalyzer();
 
@@ -165,7 +159,7 @@ class ResourcePool {
 		if ( /\.library$/.test(resource.name) ) {
 			// read raw-module info from .library files
 			return resource.buffer().then( (buffer) => {
-				const infos = LibraryFileAnalyzer.getDependencyInfos( resource.name, buffer );
+				const infos = getDependencyInfos( resource.name, buffer );
 				for ( const name of Object.keys(infos) ) {
 					this._rawModuleInfos.set(name, infos[name]);
 				}
@@ -238,5 +232,5 @@ class ResourcePool {
 	}
 }
 
-module.exports = ResourcePool;
+export default ResourcePool;
 

package/lib/lbt/utils/ASTUtils.js

@@ -1,6 +1,5 @@
-"use strict";
 
-const {Syntax} = require("../utils/parseUtils");
+import {Syntax} from "../utils/parseUtils.js";
 
 /**
  * Checks whether the given node is a string literal.
@@ -12,21 +11,42 @@ const {Syntax} = require("../utils/parseUtils");
  * @param {string} [literal]
  * @returns {boolean} Whether the node is a literal and whether its value matches the given string
  */
-function isString(node, literal) {
-	if ( node == null || node.type !== Syntax.Literal || typeof node.value !== "string" ) {
+export function isString(node, literal) {
+	const value = getStringValue(node);
+	if (value === undefined) {
 		return false;
 	}
-	return literal == null ? true : node.value === literal;
+	return literal == null ? true: value === literal;
+}
+
+export function getStringValue(node) {
+	if (isLiteral(node)) {
+		return node.value;
+	} else if (isTemplateLiteralWithoutExpression(node)) {
+		return node?.quasis?.[0]?.value?.cooked;
+	} else {
+		return undefined;
+	}
+}
+
+export function isLiteral(node) {
+	return node && node.type === Syntax.Literal && typeof node.value === "string";
+}
+
+export function isTemplateLiteralWithoutExpression(node) {
+	return node?.type === Syntax.TemplateLiteral &&
+		node?.expressions?.length === 0 &&
+		node?.quasis?.length === 1;
 }
 
-function isBoolean(node, literal) {
+export function isBoolean(node, literal) {
 	if ( node == null || node.type !== Syntax.Literal || typeof node.value !== "boolean" ) {
 		return false;
 	}
 	return literal == null ? true : node.value === literal;
 }
 
-function isMethodCall(node, methodPath) {
+export function isMethodCall(node, methodPath) {
 	if ( node.type !== Syntax.CallExpression ) {
 		return false;
 	}
@@ -35,7 +55,9 @@ function isMethodCall(node, methodPath) {
 	return isNamedObject(node.callee, methodPath, methodPath.length);
 }
 
-function isNamedObject(node, objectPath, length) {
+export function isNamedObject(node, objectPath, length) {
+	// TODO: Support PrivateIdentifier (foo.#bar)
+
 	// console.log("checking for named object ", node, objectPath, length);
 	while ( length > 1 &&
 			node.type === Syntax.MemberExpression &&
@@ -46,37 +68,37 @@ function isNamedObject(node, objectPath, length) {
 	return length === 1 && isIdentifier(node, objectPath[0]);
 }
 
-function isIdentifier(node, name) {
-	if ( node.type != Syntax.Identifier ) {
-		return false;
-	}
-	if ( typeof name == "string" ) {
+export function isIdentifier(node, name) {
+	if ( node.type === Syntax.Identifier && typeof name == "string" ) {
 		return name === node.name;
+	} else if ( node.type === Syntax.Identifier && Array.isArray(name) ) {
+		return name.find((name) => name === node.name || name === "*") !== undefined;
+	} else if ( node.type === Syntax.ObjectPattern ) {
+		return node.properties.filter((childnode) => isIdentifier(childnode.key, name)).length > 0;
+	} else if ( node.type === Syntax.ArrayPattern ) {
+		return node.elements.filter((childnode) => isIdentifier(childnode, name)).length > 0;
+	} else {
+		return false;
 	}
-	for (let i = 0; i < name.length; i++) {
-		if ( name[i] === node.name || name[i] === "*" ) {
-			return true;
-		}
-	}
-	return false;
 }
 
-function getPropertyKey(property) {
-	if ( property.key.type === Syntax.Identifier ) {
+export function getPropertyKey(property) {
+	if ( property.type === Syntax.SpreadElement ) {
+		// TODO: Support interpreting SpreadElements
+		return;
+	} else if ( property.key.type === Syntax.Identifier && property.computed !== true ) {
 		return property.key.name;
 	} else if ( property.key.type === Syntax.Literal ) {
 		return String(property.key.value);
-	} else {
-		throw new Error();
 	}
 }
 
-function findOwnProperty(obj, name) {
+export function findOwnProperty(obj, name) {
 	const property = obj && obj.properties.find((property) => getPropertyKey(property) === name);
 	return property && property.value;
 }
 
-function getValue(obj, names) {
+export function getValue(obj, names) {
 	let i = 0;
 	while ( i < names.length ) {
 		if ( obj == null || obj.type !== Syntax.ObjectExpression ) {
@@ -100,29 +122,23 @@ function getValue(obj, names) {
  * @throws {TypeError}
  * @returns {string[]}
  */
-function getStringArray(array, skipNonStringLiterals) {
+export function getStringArray(array, skipNonStringLiterals) {
 	return array.elements.reduce( (result, item) => {
-		if ( isString(item) ) {
-			result.push(item.value);
+		const value = getStringValue(item);
+		if ( value !== undefined ) {
+			result.push(value);
 		} else if ( !skipNonStringLiterals ) {
-			throw new TypeError("array element is not a string literal:" + item.type);
+			if (item.type === Syntax.TemplateLiteral) {
+				throw new TypeError("array element is a template literal with expressions");
+			} else {
+				throw new TypeError("array element is not a string literal: " + item.type);
+			}
 		}
 		return result;
 	}, []);
 }
 
-module.exports = {
-	isString,
-	isBoolean,
-	isMethodCall,
-	isNamedObject,
-	isIdentifier,
-	getLocation: function(args) {
-		// NODE-TODO include line information in future
-		return args[0].value;
-	},
-	getPropertyKey,
-	findOwnProperty,
-	getValue,
-	getStringArray
-};
+export function	getLocation(args) {
+	// NODE-TODO include line information in future
+	return args[0].value;
+}

package/lib/lbt/utils/JSTokenizer.js

@@ -13,7 +13,7 @@
  * Code other than the OpenUI5 libraries must not introduce dependencies to this module.
  */
 //sap.ui.define([], function() {
-	"use strict";
+	//"use strict";
 
 	/*
 	 * The following code has been taken from the component JSON in JavaScript
@@ -25,7 +25,7 @@
 	 */
 
 	/**
-	 * @class Tokenizer for JS values.
+	 * Tokenizer for JS values.
 	 *
 	 * Contains functions to consume tokens on an input string.
 	 *
@@ -34,7 +34,7 @@
 	 *      JSTokenizer().parseJS("{test:'123'}"); // {test:'123'}
 	 * });
 	 *
-	 * @alias module:sap/base/util/JSTokenizer
+	 * @class sap/base/util/JSTokenizer
 	 * @since 1.58
 	 * @private
 	 * @ui5-restricted sap.ui.core
@@ -384,4 +384,4 @@
 //	return JSTokenizer;
 //});
 
-module.exports = JSTokenizer;
+export default JSTokenizer;

package/lib/lbt/utils/ModuleName.js

@@ -1,4 +1,3 @@
-"use strict";
 
 /**
  * Creates a ModuleName from a string in UI5 module name syntax.
@@ -8,7 +7,7 @@
  * @param {string} [suffix='.js'] Suffix to add to the resulting resource name
  * @returns {string} URN representing the same resource
  */
-function fromUI5LegacyName(name, suffix) {
+export function fromUI5LegacyName(name, suffix) {
 	// UI5 only supports a few names with dots in them, anything else will be converted to slashes
 	if ( name.startsWith("sap.ui.thirdparty.jquery.jquery-") ) {
 		name = "sap/ui/thirdparty/jquery/jquery-" + name.slice("sap.ui.thirdparty.jquery.jquery-".length);
@@ -20,7 +19,7 @@ function fromUI5LegacyName(name, suffix) {
 	return name + (suffix || ".js");
 }
 
-function toUI5LegacyName(path) {
+export function toUI5LegacyName(path) {
 	if ( !path.endsWith(".js") ) {
 		throw new Error("can't convert a non-JS resource name " + path + " to a UI5 module name");
 	}
@@ -34,11 +33,11 @@ function toUI5LegacyName(path) {
 	}
 }
 
-function fromRequireJSName(name) {
+export function fromRequireJSName(name) {
 	return name + ".js";
 }
 
-function toRequireJSName(path) {
+export function toRequireJSName(path) {
 	if ( !path.endsWith(".js") ) {
 		throw new Error("can't convert a non-JS resource name " + path + " to a requireJS module name");
 	}
@@ -47,7 +46,7 @@ function toRequireJSName(path) {
 
 const KNOWN_TYPES = /\.(properties|css|(?:(?:view\.|fragment\.)?(?:html|json|xml|js))|(?:(?:controller\.|designtime\.|support\.)?js))$/;
 
-function getDebugName(name) {
+export function getDebugName(name) {
 	const m = KNOWN_TYPES.exec(name);
 	if ( m && ( m[0].endsWith(".css") || m[0].endsWith(".js") ) && !name.slice(0, m.index).endsWith("-dbg") ) {
 		return name.slice(0, m.index) + "-dbg" + m[0];
@@ -55,7 +54,7 @@ function getDebugName(name) {
 	return null;
 }
 
-function getNonDebugName(name) {
+export function getNonDebugName(name) {
 	const m = KNOWN_TYPES.exec(name);
 	if ( m && ( m[0].endsWith(".css") || m[0].endsWith(".js") ) && name.slice(0, m.index).endsWith("-dbg") ) {
 		return name.slice(0, m.index - "-dbg".length) + m[0];
@@ -66,7 +65,7 @@ function getNonDebugName(name) {
 const ANY_SPECIAL_PATH_SEGMENT = /(?:^|\/)\.+\//;
 const SPECIAL_PATH_SEGMENT = /^\.+$/;
 
-function resolveRelativePath(path, relativePath) {
+export function resolveRelativePath(path, relativePath) {
 	// while has segment
 	//	 if ( segment == . )
 	//			ignore segment
@@ -117,16 +116,7 @@ function resolveRelativePath(path, relativePath) {
 	return relativePath;
 }
 
-module.exports = {
-	getDebugName,
-	getNonDebugName,
-	fromUI5LegacyName,
-	fromRequireJSName,
-	resolveRelativePath,
-	resolveRelativeRequireJSName: function(path, relativeName) {
-		return resolveRelativePath(path, relativeName + ".js");
-	},
-	toUI5LegacyName,
-	toRequireJSName
-};
+export function resolveRelativeRequireJSName(path, relativeName) {
+	return resolveRelativePath(path, relativeName + ".js");
+}
 

package/lib/lbt/utils/escapePropertiesFile.js

@@ -1,4 +1,4 @@
-const nonAsciiEscaper = require("../../processors/nonAsciiEscaper");
+import nonAsciiEscaper from "../../processors/nonAsciiEscaper.js";
 
 /**
  * Can be used to escape *.properties files.
@@ -10,12 +10,12 @@ const nonAsciiEscaper = require("../../processors/nonAsciiEscaper");
  * @param {Resource} resource the resource for which the content will be escaped
  * @returns {Promise<string>} resolves with the escaped string content of the given Resource
  */
-module.exports = async function(resource) {
+export default async function(resource) {
 	const project = resource.getProject();
 	let propertiesFileSourceEncoding = project && project.getPropertiesFileSourceEncoding();
 
 	if (!propertiesFileSourceEncoding) {
-		if (project && ["0.1", "1.0", "1.1"].includes(project.getSpecVersion())) {
+		if (project && project.getSpecVersion().lte("1.1")) {
 			// default encoding to "ISO-8859-1" for old specVersions
 			propertiesFileSourceEncoding = "ISO-8859-1";
 		} else {
@@ -34,4 +34,4 @@ module.exports = async function(resource) {
 	const fileContent = await resource.buffer();
 
 	return fileContent.toString();
-};
+}