@ui5/builder 3.0.0-alpha.1 → 3.0.0-alpha.11

package/index.js

@@ -3,10 +3,6 @@
  * @public
  */
 module.exports = {
-	/**
-	 * @type {import('./lib/builder/builder')}
-	 */
-	builder: "./lib/builder/builder",
 	/**
 	 * @public
 	 * @alias module:@ui5/builder.processors
@@ -156,45 +152,6 @@ module.exports = {
 		 * @type {import('./lib/tasks/taskRepository')}
 		 */
 		taskRepository: "./lib/tasks/taskRepository",
-		/**
-		 * @type {import('./lib/tasks/TaskUtil')}
-		 */
-		TaskUtil: "./lib/tasks/TaskUtil"
-	},
-	/**
-	 * @private
-	 * @alias module:@ui5/builder.types
-	 * @namespace
-	 */
-	types: {
-		/**
-		 * @type {typeof import('./lib/types/AbstractBuilder')}
-		 */
-		AbstractBuilder: "./lib/types/AbstractBuilder",
-		/**
-		 * @type {typeof import('./lib/types/AbstractFormatter')}
-		 */
-		AbstractFormatter: "./lib/types/AbstractFormatter",
-		/**
-		 * @type {import('./lib/types/application/applicationType')}
-		 */
-		application: "./lib/types/application/applicationType",
-		/**
-		 * @type {import('./lib/types/library/libraryType')}
-		 */
-		library: "./lib/types/library/libraryType",
-		/**
-		 * @type {import('./lib/types/themeLibrary/themeLibraryType')}
-		 */
-		themeLibrary: "./lib/types/themeLibrary/themeLibraryType",
-		/**
-		 * @type {import('./lib/types/module/moduleType')}
-		 */
-		module: "./lib/types/module/moduleType",
-		/**
-		 * @type {import('./lib/types/typeRepository')}
-		 */
-		typeRepository: "./lib/types/typeRepository"
 	}
 };
 

package/lib/lbt/analyzer/FioriElementsAnalyzer.js

@@ -61,7 +61,7 @@
 const ModuleName = require("../utils/ModuleName");
 const SapUiDefine = require("../calls/SapUiDefine");
 const {parseJS, Syntax} = require("../utils/parseUtils");
-const {getValue, isMethodCall, isString} = require("../utils/ASTUtils");
+const {getValue, isMethodCall, getStringValue} = require("../utils/ASTUtils");
 const log = require("@ui5/logger").getLogger("lbt:analyzer:FioriElementAnalyzer");
 
 // ---------------------------------------------------------------------------------------------------------
@@ -165,24 +165,35 @@ class FioriElementsAnalyzer {
 			const TA = defineCall.findImportName("sap/fe/core/TemplateAssembler.js");
 			// console.log("local name for TemplateAssembler: %s", TA);
 			if ( TA && defineCall.factory ) {
-				defineCall.factory.body.body.forEach( (stmt) => {
-					if ( stmt.type === Syntax.ReturnStatement &&
-							isMethodCall(stmt.argument, [TA, "getTemplateComponent"]) &&
-							stmt.argument.arguments.length > 2 &&
-							stmt.argument.arguments[2].type === "ObjectExpression" ) {
-						templateName = this._analyzeTemplateClassDefinition(stmt.argument.arguments[2]) || templateName;
+				if (defineCall.factory.type === Syntax.ArrowFunctionExpression &&
+					defineCall.factory.expression === true) {
+					if ( this._isTemplateClassDefinition(TA, defineCall.factory.body) ) {
+						templateName =
+							this._analyzeTemplateClassDefinition(defineCall.factory.body.arguments[2]) || templateName;
 					}
-				});
+				} else {
+					defineCall.factory.body.body.forEach( (stmt) => {
+						if ( stmt.type === Syntax.ReturnStatement &&
+							this._isTemplateClassDefinition(TA, stmt.argument)
+						) {
+							templateName =
+								this._analyzeTemplateClassDefinition(stmt.argument.arguments[2]) || templateName;
+						}
+					});
+				}
 			}
 		}
 		return templateName;
 	}
 
+	_isTemplateClassDefinition(TA, node) {
+		return isMethodCall(node, [TA, "getTemplateComponent"]) &&
+			node.arguments.length > 2 &&
+			node.arguments[2].type === "ObjectExpression";
+	}
+
 	_analyzeTemplateClassDefinition(clazz) {
-		const defaultValue = getValue(clazz, ["metadata", "properties", "templateName", "defaultValue"]);
-		if ( isString(defaultValue) ) {
-			return defaultValue.value;
-		}
+		return getStringValue(getValue(clazz, ["metadata", "properties", "templateName", "defaultValue"]));
 	}
 }
 

package/lib/lbt/analyzer/JSModuleAnalyzer.js

@@ -5,7 +5,9 @@ const escope = require("escope");
 const ModuleName = require("../utils/ModuleName");
 const {Format: ModuleFormat} = require("../resources/ModuleInfo");
 const UI5ClientConstants = require("../UI5ClientConstants");
-const {findOwnProperty, getLocation, getPropertyKey, isMethodCall, isString} = require("../utils/ASTUtils");
+const {
+	findOwnProperty, getLocation, getPropertyKey,
+	isMethodCall, isString, getStringValue} = require("../utils/ASTUtils");
 const log = require("@ui5/logger").getLogger("lbt:analyzer:JSModuleAnalyzer");
 
 // ------------------------------------------------------------------------------------------------------------------
@@ -64,7 +66,7 @@ const EnrichedVisitorKeys = (function() {
 		BreakStatement: [],
 		CallExpression: [], // special handling
 		CatchClause: ["param", "body"],
-		ChainExpression: [],
+		ChainExpression: ["expression"],
 		ClassBody: [],
 		ClassDeclaration: [],
 		ClassExpression: [],
@@ -114,7 +116,7 @@ const EnrichedVisitorKeys = (function() {
 		ImportSpecifier: [], // imported, local
 		Literal: [],
 		LabeledStatement: [],
-		LogicalExpression: [],
+		LogicalExpression: ["right"],
 		MemberExpression: [],
 		MetaProperty: toBeDone(["meta", "property"]),
 		MethodDefinition: [],
@@ -175,12 +177,11 @@ const EnrichedVisitorKeys = (function() {
 
 	// merge with 'official' visitor keys
 	Object.keys(VisitorKeys).forEach( (type) => {
-		// Check if the visitor-key exists in the available Syntax because
-		// the list of visitor-keys does not match the available Syntax.
-		if (!Syntax[type]) {
-			// Deprecated / removed:
-			// ExperimentalRestProperty
-			// ExperimentalSpreadProperty
+		// Ignore deprecated keys:
+		// - ExperimentalSpreadProperty => SpreadElement
+		// - ExperimentalRestProperty => RestElement
+		// They are about to be removed, see: https://github.com/eslint/eslint-visitor-keys/pull/36
+		if (type === "ExperimentalSpreadProperty" || type === "ExperimentalRestProperty") {
 			return;
 		}
 		// Ignore JSX visitor-keys because they aren't used.
@@ -188,6 +189,15 @@ const EnrichedVisitorKeys = (function() {
 			return;
 		}
 
+		// Ignore new ES2022 syntax as we currently use ES2021 (see parseUtils.js)
+		if (
+			type === "PrivateIdentifier" ||
+			type === "PropertyDefinition" ||
+			type === "StaticBlock"
+		) {
+			return;
+		}
+
 		const visitorKeys = VisitorKeys[type];
 		const condKeys = TempKeys[type];
 		if ( condKeys === undefined ) {
@@ -293,6 +303,9 @@ class JSModuleAnalyzer {
 		 */
 		let bIsUi5Module = false;
 
+		// Module name via @ui5-bundle comment in first line. Overrides all other main module candidates.
+		let firstLineBundleName;
+
 		// first analyze the whole AST...
 		visit(ast, false);
 
@@ -306,7 +319,12 @@ class JSModuleAnalyzer {
 						log.verbose(`bundle include directive ${subModule}`);
 					} else if ( comment.value.startsWith("@ui5-bundle ") ) {
 						const bundleName = comment.value.slice("@ui5-bundle ".length);
-						setMainModuleInfo(bundleName, null);
+						if (comment.start === 0) {
+							// Remember the name from the first line to use it as final name
+							firstLineBundleName = bundleName;
+						} else {
+							setMainModuleInfo(bundleName, null);
+						}
 						log.verbose(`bundle name directive ${bundleName}`);
 					} else {
 						log.warn(`unrecognized bundle directive ${comment.value}`);
@@ -316,7 +334,10 @@ class JSModuleAnalyzer {
 		}
 
 		// ...and finally take conclusions about the file's content
-		if ( !mainModuleFound ) {
+		if ( firstLineBundleName ) {
+			// If the first line has a bundle name, use it and override all other found names
+			info.name = firstLineBundleName;
+		} else if ( !mainModuleFound ) {
 			// if there's exactly one module definition in this file but it didn't
 			// immediately qualify as main module, make it now the main module
 			if ( candidateName != null && nModuleDeclarations == 1 ) {
@@ -522,21 +543,27 @@ class JSModuleAnalyzer {
 
 		function onDeclare(node) {
 			const args = node.arguments;
-			if ( args.length > 0 && isString(args[0]) ) {
-				const name = ModuleName.fromUI5LegacyName( args[0].value );
-				if ( nModuleDeclarations === 1 && !mainModuleFound) {
-					// if this is the first declaration, then this is the main module declaration
-					// note that this overrides an already given name
-					setMainModuleInfo(name, getDocumentation(node));
-				} else if ( nModuleDeclarations > 1 && name === info.name ) {
-					// ignore duplicate declarations (e.g. in behavior file of design time controls)
-					log.warn(`duplicate declaration of module name at ${getLocation(args)} in ${name}`);
+			if (args.length > 0) {
+				const value = getStringValue(args[0]);
+				if (value !== undefined) {
+					const name = ModuleName.fromUI5LegacyName(value);
+					if ( nModuleDeclarations === 1 && !mainModuleFound) {
+						// if this is the first declaration, then this is the main module declaration
+						// note that this overrides an already given name
+						setMainModuleInfo(name, getDocumentation(node));
+					} else if ( nModuleDeclarations > 1 && name === info.name ) {
+						// ignore duplicate declarations (e.g. in behavior file of design time controls)
+						log.warn(`duplicate declaration of module name at ${getLocation(args)} in ${name}`);
+					} else {
+						// otherwise it is just a submodule declaration
+						info.addSubModule(name);
+					}
+					return;
 				} else {
-					// otherwise it is just a submodule declaration
-					info.addSubModule(name);
+					log.error("jQuery.sap.declare: module name could not be determined from first argument:", args[0]);
 				}
 			} else {
-				log.error("jQuery.sap.declare: module name could not be determined from first argument:", args[0]);
+				log.error("jQuery.sap.declare: module name could not be determined, no arguments are given");
 			}
 		}
 
@@ -550,20 +577,26 @@ class JSModuleAnalyzer {
 
 			// determine the name of the module
 			let name = null;
-			if ( i < nArgs && isString(args[i]) ) {
-				name = ModuleName.fromRequireJSName( args[i++].value );
-				if ( name === defaultName ) {
-					// hardcoded name equals the file name, so this definition qualifies as main module definition
-					setMainModuleInfo(name, desc);
-				} else {
-					info.addSubModule(name);
-					if ( candidateName == null ) {
-						// remember the name and description in case no other module qualifies as main module
-						candidateName = name;
-						candidateDescription = desc;
+			if ( i < nArgs ) {
+				const value = getStringValue( args[i] );
+				if ( value !== undefined ) {
+					name = ModuleName.fromRequireJSName(value);
+					if ( name === defaultName ) {
+						// hardcoded name equals the file name, so this definition qualifies as main module definition
+						setMainModuleInfo(name, desc);
+					} else {
+						info.addSubModule(name);
+						if ( candidateName == null ) {
+							// remember the name and description in case no other module qualifies as main module
+							candidateName = name;
+							candidateDescription = desc;
+						}
 					}
+					i++;
 				}
-			} else {
+			}
+
+			if ( !name ) {
 				nUnnamedDefines++;
 				if ( nUnnamedDefines > 1 ) {
 					throw new Error(
@@ -595,15 +628,25 @@ class JSModuleAnalyzer {
 				// UI5 signature with one or many required modules
 				for (let i = 0; i < nArgs; i++) {
 					const arg = args[i];
-					if ( isString(arg) ) {
-						const requiredModuleName = ModuleName.fromUI5LegacyName( arg.value );
+					const value = getStringValue(arg);
+					if ( value !== undefined ) {
+						const requiredModuleName = ModuleName.fromUI5LegacyName( value );
 						info.addDependency(requiredModuleName, conditional);
-					} else if ( arg.type == Syntax.ConditionalExpression &&
-									isString(arg.consequent) && isString(arg.alternate) ) {
-						const requiredModuleName1 = ModuleName.fromUI5LegacyName( arg.consequent.value );
-						info.addDependency(requiredModuleName1, true);
-						const requiredModuleName2 = ModuleName.fromUI5LegacyName( arg.alternate.value );
-						info.addDependency(requiredModuleName2, true);
+					} else if ( arg.type == Syntax.ConditionalExpression) {
+						const consequentValue = getStringValue(arg.consequent);
+						const alternateValue = getStringValue(arg.alternate);
+						if ( consequentValue !== undefined ) {
+							const requiredModuleName1 = ModuleName.fromUI5LegacyName( consequentValue );
+							info.addDependency(requiredModuleName1, true);
+						}
+						if ( alternateValue !== undefined ) {
+							const requiredModuleName2 = ModuleName.fromUI5LegacyName( alternateValue );
+							info.addDependency(requiredModuleName2, true);
+						}
+						if ( consequentValue === undefined || alternateValue === undefined ) {
+							log.verbose("jQuery.sap.require: cannot evaluate dynamic arguments: ", arg && arg.type);
+							info.dynamicDependencies = true;
+						}
 					} else {
 						log.verbose("jQuery.sap.require: cannot evaluate dynamic arguments: ", arg && arg.type);
 						info.dynamicDependencies = true;
@@ -618,9 +661,10 @@ class JSModuleAnalyzer {
 			const i = 0;
 
 			if ( i < nArgs ) {
-				if ( isString(args[i]) ) {
+				const value = getStringValue(args[i]);
+				if ( value !== undefined ) {
 					// sap.ui.requireSync does not support relative dependencies
-					const moduleName = ModuleName.fromRequireJSName( args[i].value );
+					const moduleName = ModuleName.fromRequireJSName( value );
 					info.addDependency(moduleName, conditional);
 				} else {
 					log.verbose("sap.ui.requireSync: cannot evaluate dynamic arguments: ", args[i] && args[i].type);
@@ -635,18 +679,24 @@ class JSModuleAnalyzer {
 			let i = 0;
 
 			// determine the name of the module
-			if ( i < nArgs && isString(args[i]) ) {
-				const moduleName = ModuleName.fromRequireJSName( args[i++].value );
-				info.addSubModule(moduleName);
-
-				// add dependencies
-				// to correctly identify dependencies e.g. of a library-preload
-				const elementArg = args[i++];
-				if (elementArg && elementArg.type === Syntax.ArrayExpression) {
-					elementArg.elements.forEach((element) => {
-						const dependencyName = ModuleName.resolveRelativeRequireJSName(moduleName, element.value);
-						info.addDependency(dependencyName, conditional);
-					});
+			if ( i < nArgs ) {
+				const value = getStringValue(args[i++]);
+				if ( value !== undefined ) {
+					const moduleName = ModuleName.fromRequireJSName( value );
+					info.addSubModule(moduleName);
+
+					// add dependencies
+					// to correctly identify dependencies e.g. of a library-preload
+					const elementArg = args[i++];
+					if (elementArg && elementArg.type === Syntax.ArrayExpression) {
+						elementArg.elements.forEach((element) => {
+							const dependencyName = ModuleName.resolveRelativeRequireJSName(moduleName,
+								getStringValue(element));
+							info.addDependency(dependencyName, conditional);
+						});
+					}
+				} else {
+					log.warn("sap.ui.predefine call has a non supported type for module name (ignored)");
 				}
 			} else {
 				log.warn("sap.ui.predefine call is missing a module name (ignored)");
@@ -673,6 +723,9 @@ class JSModuleAnalyzer {
 			if ( modules && modules.type == Syntax.ObjectExpression ) {
 				modules.properties.forEach( function(property) {
 					let	moduleName = getPropertyKey(property);
+					if ( !moduleName ) {
+						return;
+					}
 					if ( namesUseLegacyNotation ) {
 						moduleName = ModuleName.fromUI5LegacyName(moduleName);
 					}
@@ -686,16 +739,17 @@ class JSModuleAnalyzer {
 		function analyzeDependencyArray(array, conditional, name) {
 			// console.log(array);
 			array.forEach( (item) => {
-				if ( isString(item) ) {
+				const value = getStringValue(item);
+				if ( value !== undefined ) {
 					// ignore special AMD dependencies (require, exports, module)
-					if ( SPECIAL_AMD_DEPENDENCIES.indexOf(item.value) >= 0 ) {
+					if ( SPECIAL_AMD_DEPENDENCIES.indexOf(value) >= 0 ) {
 						return;
 					}
 					let requiredModule;
 					if (name == null) {
-						requiredModule = ModuleName.fromRequireJSName( item.value );
+						requiredModule = ModuleName.fromRequireJSName( value );
 					} else {
-						requiredModule = ModuleName.resolveRelativeRequireJSName(name, item.value);
+						requiredModule = ModuleName.resolveRelativeRequireJSName(name, value);
 					}
 					info.addDependency( requiredModule, conditional );
 				} else {

package/lib/lbt/analyzer/SmartTemplateAnalyzer.js

@@ -28,7 +28,7 @@
 const ModuleName = require("../utils/ModuleName");
 const SapUiDefine = require("../calls/SapUiDefine");
 const {parseJS, Syntax} = require("../utils/parseUtils");
-const {getValue, isMethodCall, isString} = require("../utils/ASTUtils");
+const {getValue, isMethodCall, getStringValue} = require("../utils/ASTUtils");
 const log = require("@ui5/logger").getLogger("lbt:analyzer:SmartTemplateAnalyzer");
 
 // ---------------------------------------------------------------------------------------------------------
@@ -134,24 +134,35 @@ class TemplateComponentAnalyzer {
 			const TA = defineCall.findImportName("sap/suite/ui/generic/template/lib/TemplateAssembler.js");
 			// console.log("local name for TemplateAssembler: %s", TA);
 			if ( TA && defineCall.factory ) {
-				defineCall.factory.body.body.forEach( (stmt) => {
-					if ( stmt.type === Syntax.ReturnStatement &&
-							isMethodCall(stmt.argument, [TA, "getTemplateComponent"]) &&
-							stmt.argument.arguments.length > 2 &&
-							stmt.argument.arguments[2].type === "ObjectExpression" ) {
-						templateName = this._analyzeTemplateClassDefinition(stmt.argument.arguments[2]) || templateName;
+				if (defineCall.factory.type === Syntax.ArrowFunctionExpression &&
+					defineCall.factory.expression === true) {
+					if ( this._isTemplateClassDefinition(TA, defineCall.factory.body) ) {
+						templateName =
+							this._analyzeTemplateClassDefinition(defineCall.factory.body.arguments[2]) || templateName;
 					}
-				});
+				} else {
+					defineCall.factory.body.body.forEach( (stmt) => {
+						if ( stmt.type === Syntax.ReturnStatement &&
+							this._isTemplateClassDefinition(TA, stmt.argument)
+						) {
+							templateName =
+								this._analyzeTemplateClassDefinition(stmt.argument.arguments[2]) || templateName;
+						}
+					});
+				}
 			}
 		}
 		return templateName;
 	}
 
+	_isTemplateClassDefinition(TA, node) {
+		return isMethodCall(node, [TA, "getTemplateComponent"]) &&
+			node.arguments.length > 2 &&
+			node.arguments[2].type === "ObjectExpression";
+	}
+
 	_analyzeTemplateClassDefinition(clazz) {
-		const defaultValue = getValue(clazz, ["metadata", "properties", "templateName", "defaultValue"]);
-		if ( isString(defaultValue) ) {
-			return defaultValue.value;
-		}
+		return getStringValue(getValue(clazz, ["metadata", "properties", "templateName", "defaultValue"]));
 	}
 }
 

package/lib/lbt/analyzer/XMLCompositeAnalyzer.js

@@ -2,7 +2,7 @@
 
 const {Syntax} = require("../utils/parseUtils");
 const SapUiDefine = require("../calls/SapUiDefine");
-const {getValue, isMethodCall, isString} = require("../utils/ASTUtils");
+const {getValue, isMethodCall, getStringValue} = require("../utils/ASTUtils");
 const ModuleName = require("../utils/ModuleName");
 const log = require("@ui5/logger").getLogger("lbt:analyzer:XMLCompositeAnalyzer");
 
@@ -19,18 +19,30 @@ class XMLCompositeAnalyzer {
 			const XMLC = defineCall.findImportName("sap/ui/core/XMLComposite.js");
 			// console.log("local name for XMLComposite: %s", XMLC);
 			if ( XMLC && defineCall.factory ) {
-				defineCall.factory.body.body.forEach( (stmt) => {
-					if ( stmt.type === Syntax.VariableDeclaration ) {
-						stmt.declarations.forEach( (decl) => {
-							fragmentName = this._checkForXMLCClassDefinition( XMLC, decl.init ) || fragmentName;
-						});
-					} else if ( stmt.type === Syntax.ExpressionStatement &&
-								stmt.expression.type === Syntax.AssignmentExpression ) {
-						fragmentName = this._checkForXMLCClassDefinition( XMLC, stmt.expression.right ) || fragmentName;
-					}
-				});
-				if ( fragmentName ) {
-					const fragmentModule = ModuleName.fromUI5LegacyName( fragmentName, ".control.xml" );
+				if (defineCall.factory.type === Syntax.ArrowFunctionExpression &&
+					defineCall.factory.expression === true) {
+					fragmentName = this._checkForXMLCClassDefinition(XMLC, defineCall.factory.body);
+				} else {
+					defineCall.factory.body.body.forEach((stmt) => {
+						if (stmt.type === Syntax.VariableDeclaration) {
+							stmt.declarations.forEach((decl) => {
+								fragmentName = this._checkForXMLCClassDefinition(XMLC, decl.init) || fragmentName;
+							});
+						} else if (
+							stmt.type === Syntax.ReturnStatement &&
+							( stmt?.argument?.type === Syntax.CallExpression && stmt.argument.arguments?.length > 1 &&
+								stmt.argument.arguments[1].type === Syntax.ObjectExpression)) {
+							fragmentName =
+								this._checkForXMLCClassDefinition(XMLC, stmt.argument) || fragmentName;
+						} else if (stmt.type === Syntax.ExpressionStatement &&
+							stmt.expression.type === Syntax.AssignmentExpression) {
+							fragmentName =
+								this._checkForXMLCClassDefinition(XMLC, stmt.expression.right) || fragmentName;
+						}
+					});
+				}
+				if (fragmentName) {
+					const fragmentModule = ModuleName.fromUI5LegacyName(fragmentName, ".control.xml");
 					log.verbose("fragment control: add dependency to template fragment %s", fragmentModule);
 					info.addDependency(fragmentModule);
 				}
@@ -42,8 +54,9 @@ class XMLCompositeAnalyzer {
 		let fragmentName;
 		if ( isMethodCall(stmt, [XMLC, "extend"]) ) {
 			// log.verbose(stmt);
-			if ( stmt.arguments.length > 0 && isString(stmt.arguments[0]) ) {
-				fragmentName = stmt.arguments[0].value;
+			const value = getStringValue(stmt.arguments[0]);
+			if ( stmt.arguments.length > 0 && value ) {
+				fragmentName = value;
 			}
 			if ( stmt.arguments.length > 1 && stmt.arguments[1].type === Syntax.ObjectExpression ) {
 				fragmentName = this._analyzeXMLCClassDefinition(stmt.arguments[1]) || fragmentName;
@@ -54,10 +67,7 @@ class XMLCompositeAnalyzer {
 
 	_analyzeXMLCClassDefinition(clazz) {
 		// log.verbose(clazz);
-		const fragmentName = getValue(clazz, ["fragment"]);
-		if ( isString(fragmentName) ) {
-			return fragmentName.value;
-		}
+		return getStringValue(getValue(clazz, ["fragment"]));
 	}
 }
 

package/lib/lbt/analyzer/XMLTemplateAnalyzer.js

@@ -231,9 +231,10 @@ class XMLTemplateAnalyzer {
 			// looks like a UI5 library or package name
 			const moduleName = ModuleName.fromUI5LegacyName( (namespace ? namespace + "." : "") + localName );
 
+			this._analyzeCoreRequire(node);
+
 			// ignore FragmentDefinition (also skipped by runtime XMLTemplateProcessor)
 			if ( FRAGMENTDEFINITION_MODULE !== moduleName ) {
-				this._analyzeCoreRequire(node);
 				this.promises.push(this._analyzeModuleDependency(node, moduleName, this.conditional));
 			}
 		}

package/lib/lbt/analyzer/analyzeLibraryJS.js

@@ -1,6 +1,7 @@
 "use strict";
 const {parseJS, Syntax, VisitorKeys} = require("../utils/parseUtils");
 const {getPropertyKey, isMethodCall, isIdentifier, getStringArray} = require("../utils/ASTUtils");
+const log = require("@ui5/logger").getLogger("lbt:analyzer:LibraryJS");
 
 const CALL__SAP_UI_GETCORE = ["sap", "ui", "getCore"];
 
@@ -25,8 +26,14 @@ async function analyze(resource) {
 				node.arguments.length === 1 &&
 				node.arguments[0].type === Syntax.ObjectExpression ) {
 			node.arguments[0].properties.forEach( (prop) => {
+				if (prop.type === Syntax.SpreadElement) {
+					// SpreadElements are currently not supported
+					return;
+				}
+
 				const key = getPropertyKey(prop);
 				const value = prop.value;
+
 				if ( key === "noLibraryCSS" &&
 						(value.type === Syntax.Literal && typeof value.value === "boolean") ) {
 					libInfo.noLibraryCSS = value.value;
@@ -38,6 +45,14 @@ async function analyze(resource) {
 					libInfo.controls = getStringArray(value, true);
 				} else if ( key === "elements" && value.type == Syntax.ArrayExpression ) {
 					libInfo.elements = getStringArray(value, true);
+				} else if ( ["designtime", "dependencies", "extensions", "name", "version"].includes(key) ) {
+					// do nothing, for all other supported properties
+				} else {
+					log.error(
+						"Unexpected property '" + key +
+						"' or wrong type for '" + key +
+						"' in sap.ui.getCore().initLibrary call in '" + resource.getPath() + "'"
+					);
 				}
 			});