@ui5/builder 2.11.1 → 2.11.2

package/CHANGELOG.md

@@ -2,7 +2,14 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v2.11.1...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v2.11.2...HEAD).
+
+<a name="v2.11.2"></a>
+## [v2.11.2] - 2021-11-17
+### Bug Fixes
+- **Builder:** Emit warning on bundleInfo name without extension [`ed0da12`](https://github.com/SAP/ui5-builder/commit/ed0da123ac084d126a28f0f34d9740c310d91902)
+- **manifestCreator:** Trim whitespace/new-lines for sap.app/title [`019cfd7`](https://github.com/SAP/ui5-builder/commit/019cfd7031a2bd63ce93801ad027413151a3b060)
+
 
 <a name="v2.11.1"></a>
 ## [v2.11.1] - 2021-10-19
@@ -626,6 +633,7 @@ to load the custom bundle file instead.
 - Add ability to configure component preloads and custom bundles [`2241e5f`](https://github.com/SAP/ui5-builder/commit/2241e5ff98fd95f1f80cc74959655ae7a9c660e7)
 
 
+[v2.11.2]: https://github.com/SAP/ui5-builder/compare/v2.11.1...v2.11.2
 [v2.11.1]: https://github.com/SAP/ui5-builder/compare/v2.11.0...v2.11.1
 [v2.11.0]: https://github.com/SAP/ui5-builder/compare/v2.10.0...v2.11.0
 [v2.10.0]: https://github.com/SAP/ui5-builder/compare/v2.9.5...v2.10.0

package/lib/builder/ProjectBuildContext.js

@@ -1,5 +1,7 @@
 const ResourceTagCollection = require("@ui5/fs").ResourceTagCollection;
 
+// Note: When adding standard tags, always update the public documentation in TaskUtil
+// (Type "module:@ui5/builder.tasks.TaskUtil~StandardBuildTags")
 const STANDARD_TAGS = Object.freeze({
 	OmitFromBuildResult: "ui5:OmitFromBuildResult",
 	IsBundle: "ui5:IsBundle"

package/lib/lbt/bundle/Builder.js

@@ -2,6 +2,7 @@
 // for consistency of write calls, we generally allow template literals
 "use strict";
 
+const path = require("path");
 const terser = require("terser");
 const {pd} = require("pretty-data");
 const {parseJS, Syntax} = require("../utils/parseUtils");
@@ -486,6 +487,11 @@ class BundleBuilder {
 				if (!section.name) {
 					throw new Error(`A 'bundleInfo' section is missing the mandatory 'name' property.` );
 				}
+				if (!path.extname(section.name)) {
+					log.warn(`bundleInfo section name '${section.name}' is missing a file extension. ` +
+						`The info might not work as expected. ` +
+						`The name must match the bundle filename (incl. extension such as '.js')`);
+				}
 				this.outW.write(`"${section.name}":[${section.modules.map(makeStringLiteral).join(",")}]`);
 			});
 			this.outW.writeln();

package/lib/processors/manifestCreator.js

@@ -237,7 +237,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 			if ( library.getDocumentation() ) {
 				let desc = library.getDocumentation();
 				// remove all tags
-				desc = desc.replace(/\\s+/g, " ").replace(/<\/?[a-zA-Z][a-zA-Z0-9_$.]*(\s[^>]*)>/g, "");
+				desc = desc.replace(/\s+/g, " ").replace(/<\/?[a-zA-Z][a-zA-Z0-9_$.]*(\s[^>]*)>/g, "");
 				// extract summary (first sentence)
 				const m = /^([\w\W]+?[.;!?])[^a-zA-Z0-9_$]/.exec(desc);
 				return m ? m[1] : desc;

package/lib/tasks/TaskUtil.js

@@ -20,6 +20,8 @@ class TaskUtil {
 	 * @typedef {object} module:@ui5/builder.tasks.TaskUtil~StandardBuildTags
 	 * @property {string} OmitFromBuildResult
 	 * 		Setting this tag to true for a resource will prevent it from being written to the build target
+	 * @property {string} IsBundle
+	 * 		This tag identifies resources that contain (i.e. bundle) multiple other resources
 	 */
 
 	/**

package/lib/tasks/bundlers/generateLibraryPreload.js

@@ -280,59 +280,59 @@ module.exports = function({workspace, dependencies, taskUtil, options: {projectN
 	return combo.byGlob("/**/*.{js,json,xml,html,properties,library}").then((resources) => {
 		// Find all libraries and create a library-preload.js bundle
 
-		let p;
+		let p = Promise.resolve();
 
-		// Create sap-ui-core.js
-		// TODO: move to config of actual core project
+		// Create core bundles for older versions (<1.97.0) which don't define bundle configuration in the ui5.yaml
+		// See: https://github.com/SAP/openui5/commit/ff127fd2d009162ea43ad312dec99d759ebc23a0
 		if (projectName === "sap.ui.core") {
-			// Filter out sap-ui-core.js from further uglification/replacement processors
-			//	to prevent them from overwriting it
-			resources = resources.filter((resource) => {
-				return resource.getPath() !== "/resources/sap-ui-core.js";
-			});
-
-			const isEvo = resources.find((resource) => {
-				return resource.getPath() === "/resources/ui5loader.js";
-			});
-			let filters;
-			if (isEvo) {
-				filters = ["ui5loader-autoconfig.js"];
-			} else {
-				filters = ["jquery.sap.global.js"];
-			}
-
-			p = Promise.all([
-				moduleBundler({
-					options: getModuleBundlerOptions({name: "sap-ui-core.js", filters, preload: true}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({name: "sap-ui-core-dbg.js", filters, preload: false}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({
-						name: "sap-ui-core-nojQuery.js", filters, preload: true, provided: true
+			const coreProject = resources[0]._project;
+			const coreSpecVersion = coreProject && coreProject.specVersion;
+			// Instead of checking the sap.ui.core library version, the specVersion is checked against all versions
+			// that have been defined for sap.ui.core before the bundle configuration has been introduced.
+			// This is mainly to have an easier check without version parsing or using semver.
+			// If no project/specVersion is available, the bundles should also be created to not break potential
+			// existing use cases without a properly formed/formatted project tree.
+			if (!coreSpecVersion || ["0.1", "1.1", "2.0"].includes(coreSpecVersion)) {
+				const isEvo = resources.find((resource) => {
+					return resource.getPath() === "/resources/ui5loader.js";
+				});
+				let filters;
+				if (isEvo) {
+					filters = ["ui5loader-autoconfig.js"];
+				} else {
+					filters = ["jquery.sap.global.js"];
+				}
+				p = Promise.all([
+					moduleBundler({
+						options: getModuleBundlerOptions({name: "sap-ui-core.js", filters, preload: true}),
+						resources
 					}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({
-						name: "sap-ui-core-nojQuery-dbg.js", filters, preload: false, provided: true
+					moduleBundler({
+						options: getModuleBundlerOptions({name: "sap-ui-core-dbg.js", filters, preload: false}),
+						resources
 					}),
-					resources
-				}),
-			]).then((results) => {
-				const bundles = Array.prototype.concat.apply([], results);
-				return Promise.all(bundles.map((bundle) => {
-					if (taskUtil) {
-						taskUtil.setTag(bundle, taskUtil.STANDARD_TAGS.IsBundle);
-					}
-					return workspace.write(bundle);
-				}));
-			});
-		} else {
-			p = Promise.resolve();
+					moduleBundler({
+						options: getModuleBundlerOptions({
+							name: "sap-ui-core-nojQuery.js", filters, preload: true, provided: true
+						}),
+						resources
+					}),
+					moduleBundler({
+						options: getModuleBundlerOptions({
+							name: "sap-ui-core-nojQuery-dbg.js", filters, preload: false, provided: true
+						}),
+						resources
+					}),
+				]).then((results) => {
+					const bundles = Array.prototype.concat.apply([], results);
+					return Promise.all(bundles.map((bundle) => {
+						if (taskUtil) {
+							taskUtil.setTag(bundle, taskUtil.STANDARD_TAGS.IsBundle);
+						}
+						return workspace.write(bundle);
+					}));
+				});
+			}
 		}
 
 		return p.then(() => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ui5/builder",
-	"version": "2.11.1",
+	"version": "2.11.2",
 	"description": "UI5 Tooling - Builder",
 	"author": {
 		"name": "SAP SE",
@@ -134,7 +134,7 @@
 		"docdash": "^1.2.0",
 		"eslint": "^7.32.0",
 		"eslint-config-google": "^0.14.0",
-		"eslint-plugin-jsdoc": "^36.1.1",
+		"eslint-plugin-jsdoc": "^37.0.3",
 		"extract-zip": "^2.0.1",
 		"mock-require": "^3.0.3",
 		"nyc": "^15.1.0",