@ui5/builder 2.11.0 → 2.11.4

package/CHANGELOG.md

@@ -2,10 +2,35 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v2.11.0...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v2.11.4...HEAD).
+
+<a name="v2.11.4"></a>
+## [v2.11.4] - 2022-02-21
+### Bug Fixes
+- **generateFlexChangesBundle:** Fix minUI5Version check for UI5 v1.100.0+ ([#706](https://github.com/SAP/ui5-builder/issues/706)) [`fb1217a`](https://github.com/SAP/ui5-builder/commit/fb1217ac536c20da81526f82f2ecb03686815942)
+
+
+<a name="v2.11.3"></a>
+## [v2.11.3] - 2021-12-14
+### Bug Fixes
+- Enable buildThemes for libraries without .library [`7b941a7`](https://github.com/SAP/ui5-builder/commit/7b941a797210463a9fa8ca50753662c5db373aa6)
+
+
+<a name="v2.11.2"></a>
+## [v2.11.2] - 2021-11-17
+### Bug Fixes
+- **Builder:** Emit warning on bundleInfo name without extension [`ed0da12`](https://github.com/SAP/ui5-builder/commit/ed0da123ac084d126a28f0f34d9740c310d91902)
+- **manifestCreator:** Trim whitespace/new-lines for sap.app/title [`019cfd7`](https://github.com/SAP/ui5-builder/commit/019cfd7031a2bd63ce93801ad027413151a3b060)
+
+
+<a name="v2.11.1"></a>
+## [v2.11.1] - 2021-10-19
+### Bug Fixes
+- Minification excludes for application projects [`7f6fd68`](https://github.com/SAP/ui5-builder/commit/7f6fd68e1aed9131896723f1231816287eaf2fce)
+
 
 <a name="v2.11.0"></a>
-## [v2.11.0] - 2021-10-13
+## [v2.11.0] - 2021-10-19
 ### Bug Fixes
 - **manifestCreator:** supportedThemes should only list relevant themes [`01f3859`](https://github.com/SAP/ui5-builder/commit/01f3859070b6955b9824b0949e633c6d40244633)
 
@@ -620,6 +645,10 @@ to load the custom bundle file instead.
 - Add ability to configure component preloads and custom bundles [`2241e5f`](https://github.com/SAP/ui5-builder/commit/2241e5ff98fd95f1f80cc74959655ae7a9c660e7)
 
 
+[v2.11.4]: https://github.com/SAP/ui5-builder/compare/v2.11.3...v2.11.4
+[v2.11.3]: https://github.com/SAP/ui5-builder/compare/v2.11.2...v2.11.3
+[v2.11.2]: https://github.com/SAP/ui5-builder/compare/v2.11.1...v2.11.2
+[v2.11.1]: https://github.com/SAP/ui5-builder/compare/v2.11.0...v2.11.1
 [v2.11.0]: https://github.com/SAP/ui5-builder/compare/v2.10.0...v2.11.0
 [v2.10.0]: https://github.com/SAP/ui5-builder/compare/v2.9.5...v2.10.0
 [v2.9.5]: https://github.com/SAP/ui5-builder/compare/v2.9.4...v2.9.5

package/lib/builder/ProjectBuildContext.js

@@ -1,5 +1,7 @@
 const ResourceTagCollection = require("@ui5/fs").ResourceTagCollection;
 
+// Note: When adding standard tags, always update the public documentation in TaskUtil
+// (Type "module:@ui5/builder.tasks.TaskUtil~StandardBuildTags")
 const STANDARD_TAGS = Object.freeze({
 	OmitFromBuildResult: "ui5:OmitFromBuildResult",
 	IsBundle: "ui5:IsBundle"

package/lib/lbt/bundle/Builder.js

@@ -2,6 +2,7 @@
 // for consistency of write calls, we generally allow template literals
 "use strict";
 
+const path = require("path");
 const terser = require("terser");
 const {pd} = require("pretty-data");
 const {parseJS, Syntax} = require("../utils/parseUtils");
@@ -486,6 +487,11 @@ class BundleBuilder {
 				if (!section.name) {
 					throw new Error(`A 'bundleInfo' section is missing the mandatory 'name' property.` );
 				}
+				if (!path.extname(section.name)) {
+					log.warn(`bundleInfo section name '${section.name}' is missing a file extension. ` +
+						`The info might not work as expected. ` +
+						`The name must match the bundle filename (incl. extension such as '.js')`);
+				}
 				this.outW.write(`"${section.name}":[${section.modules.map(makeStringLiteral).join(",")}]`);
 			});
 			this.outW.writeln();

package/lib/processors/manifestCreator.js

@@ -237,7 +237,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 			if ( library.getDocumentation() ) {
 				let desc = library.getDocumentation();
 				// remove all tags
-				desc = desc.replace(/\\s+/g, " ").replace(/<\/?[a-zA-Z][a-zA-Z0-9_$.]*(\s[^>]*)>/g, "");
+				desc = desc.replace(/\s+/g, " ").replace(/<\/?[a-zA-Z][a-zA-Z0-9_$.]*(\s[^>]*)>/g, "");
 				// extract summary (first sentence)
 				const m = /^([\w\W]+?[.;!?])[^a-zA-Z0-9_$]/.exec(desc);
 				return m ? m[1] : desc;

package/lib/tasks/TaskUtil.js

@@ -20,6 +20,8 @@ class TaskUtil {
 	 * @typedef {object} module:@ui5/builder.tasks.TaskUtil~StandardBuildTags
 	 * @property {string} OmitFromBuildResult
 	 * 		Setting this tag to true for a resource will prevent it from being written to the build target
+	 * @property {string} IsBundle
+	 * 		This tag identifies resources that contain (i.e. bundle) multiple other resources
 	 */
 
 	/**

package/lib/tasks/buildThemes.js

@@ -54,8 +54,12 @@ module.exports = async function({
 		*/
 	let availableLibraries;
 	if (pAvailableLibraries) {
-		availableLibraries = (await pAvailableLibraries).map((resource) => {
-			return resource.getPath().replace(/[^/]*\.library/i, "");
+		availableLibraries = [];
+		(await pAvailableLibraries).forEach((resource) => {
+			const library = path.dirname(resource.getPath());
+			if (!availableLibraries.includes(library)) {
+				availableLibraries.push(library);
+			}
 		});
 	}
 	let availableThemes;

package/lib/tasks/bundlers/generateFlexChangesBundle.js

@@ -1,5 +1,6 @@
 const log = require("@ui5/logger").getLogger("builder:tasks:bundlers:generateFlexChangesBundle");
 const flexChangesBundler = require("../../processors/bundlers/flexChangesBundler");
+const semver = require("semver");
 
 /**
  * Task to create changesBundle.json file containing all changes stored in the /changes folder for easier consumption
@@ -68,9 +69,9 @@ module.exports = async function({workspace, taskUtil, options: {namespace}}) {
 	const allResources = await workspace.byGlob(
 		`${pathPrefix}/changes/*.{change,variant,ctrl_variant,ctrl_variant_change,ctrl_variant_management_change}`);
 	if (allResources.length > 0) {
-		const version = await readManifestMinUI5Version();
+		const version = semver.coerce(await readManifestMinUI5Version());
 		let hasFlexBundleVersion = false;
-		if (parseFloat(version) >= 1.73) {
+		if (semver.compare(version, "1.73.0") >= 0) {
 			hasFlexBundleVersion = true;
 		}
 		const processedResources = await flexChangesBundler({

package/lib/tasks/bundlers/generateLibraryPreload.js

@@ -280,59 +280,59 @@ module.exports = function({workspace, dependencies, taskUtil, options: {projectN
 	return combo.byGlob("/**/*.{js,json,xml,html,properties,library}").then((resources) => {
 		// Find all libraries and create a library-preload.js bundle
 
-		let p;
+		let p = Promise.resolve();
 
-		// Create sap-ui-core.js
-		// TODO: move to config of actual core project
+		// Create core bundles for older versions (<1.97.0) which don't define bundle configuration in the ui5.yaml
+		// See: https://github.com/SAP/openui5/commit/ff127fd2d009162ea43ad312dec99d759ebc23a0
 		if (projectName === "sap.ui.core") {
-			// Filter out sap-ui-core.js from further uglification/replacement processors
-			//	to prevent them from overwriting it
-			resources = resources.filter((resource) => {
-				return resource.getPath() !== "/resources/sap-ui-core.js";
-			});
-
-			const isEvo = resources.find((resource) => {
-				return resource.getPath() === "/resources/ui5loader.js";
-			});
-			let filters;
-			if (isEvo) {
-				filters = ["ui5loader-autoconfig.js"];
-			} else {
-				filters = ["jquery.sap.global.js"];
-			}
-
-			p = Promise.all([
-				moduleBundler({
-					options: getModuleBundlerOptions({name: "sap-ui-core.js", filters, preload: true}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({name: "sap-ui-core-dbg.js", filters, preload: false}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({
-						name: "sap-ui-core-nojQuery.js", filters, preload: true, provided: true
+			const coreProject = resources[0]._project;
+			const coreSpecVersion = coreProject && coreProject.specVersion;
+			// Instead of checking the sap.ui.core library version, the specVersion is checked against all versions
+			// that have been defined for sap.ui.core before the bundle configuration has been introduced.
+			// This is mainly to have an easier check without version parsing or using semver.
+			// If no project/specVersion is available, the bundles should also be created to not break potential
+			// existing use cases without a properly formed/formatted project tree.
+			if (!coreSpecVersion || ["0.1", "1.1", "2.0"].includes(coreSpecVersion)) {
+				const isEvo = resources.find((resource) => {
+					return resource.getPath() === "/resources/ui5loader.js";
+				});
+				let filters;
+				if (isEvo) {
+					filters = ["ui5loader-autoconfig.js"];
+				} else {
+					filters = ["jquery.sap.global.js"];
+				}
+				p = Promise.all([
+					moduleBundler({
+						options: getModuleBundlerOptions({name: "sap-ui-core.js", filters, preload: true}),
+						resources
 					}),
-					resources
-				}),
-				moduleBundler({
-					options: getModuleBundlerOptions({
-						name: "sap-ui-core-nojQuery-dbg.js", filters, preload: false, provided: true
+					moduleBundler({
+						options: getModuleBundlerOptions({name: "sap-ui-core-dbg.js", filters, preload: false}),
+						resources
 					}),
-					resources
-				}),
-			]).then((results) => {
-				const bundles = Array.prototype.concat.apply([], results);
-				return Promise.all(bundles.map((bundle) => {
-					if (taskUtil) {
-						taskUtil.setTag(bundle, taskUtil.STANDARD_TAGS.IsBundle);
-					}
-					return workspace.write(bundle);
-				}));
-			});
-		} else {
-			p = Promise.resolve();
+					moduleBundler({
+						options: getModuleBundlerOptions({
+							name: "sap-ui-core-nojQuery.js", filters, preload: true, provided: true
+						}),
+						resources
+					}),
+					moduleBundler({
+						options: getModuleBundlerOptions({
+							name: "sap-ui-core-nojQuery-dbg.js", filters, preload: false, provided: true
+						}),
+						resources
+					}),
+				]).then((results) => {
+					const bundles = Array.prototype.concat.apply([], results);
+					return Promise.all(bundles.map((bundle) => {
+						if (taskUtil) {
+							taskUtil.setTag(bundle, taskUtil.STANDARD_TAGS.IsBundle);
+						}
+						return workspace.write(bundle);
+					}));
+				});
+			}
 		}
 
 		return p.then(() => {

package/lib/types/application/ApplicationBuilder.js

@@ -143,7 +143,9 @@ class ApplicationBuilder extends AbstractBuilder {
 			const minificationExcludes = project.builder && project.builder.minification &&
 				project.builder.minification.excludes;
 			if (minificationExcludes) {
-				this.enhancePatternWithExcludes(minificationPattern, minificationExcludes, "/");
+				// TODO 3.0: namespaces should become mandatory, see existing check above
+				const patternPrefix = project.metadata.namespace ? "/resources/" : "/";
+				this.enhancePatternWithExcludes(minificationPattern, minificationExcludes, patternPrefix);
 			}
 		}
 		this.addTask("createDebugFiles", async () => {

package/lib/types/library/LibraryBuilder.js

@@ -176,7 +176,7 @@ class LibraryBuilder extends AbstractBuilder {
 				dependencies: resourceCollections.dependencies,
 				options: {
 					projectName: project.metadata.name,
-					librariesPattern: !taskUtil.isRootProject() ? "/resources/**/*.library" : undefined,
+					librariesPattern: !taskUtil.isRootProject() ? "/resources/**/(*.library|library.js)" : undefined,
 					themesPattern: !taskUtil.isRootProject() ? "/resources/sap/ui/core/themes/*" : undefined,
 					inputPattern
 				}

package/lib/types/themeLibrary/ThemeLibraryBuilder.js

@@ -29,7 +29,7 @@ class ThemeLibraryBuilder extends AbstractBuilder {
 				dependencies: resourceCollections.dependencies,
 				options: {
 					projectName: project.metadata.name,
-					librariesPattern: !taskUtil.isRootProject() ? "/resources/**/*.library" : undefined,
+					librariesPattern: !taskUtil.isRootProject() ? "/resources/**/(*.library|library.js)" : undefined,
 					themesPattern: !taskUtil.isRootProject() ? "/resources/sap/ui/core/themes/*" : undefined,
 					inputPattern: "/resources/**/themes/*/library.source.less"
 				}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ui5/builder",
-	"version": "2.11.0",
+	"version": "2.11.4",
 	"description": "UI5 Tooling - Builder",
 	"author": {
 		"name": "SAP SE",
@@ -110,9 +110,9 @@
 		"escape-unicode": "^0.2.0",
 		"escope": "^3.6.0",
 		"espree": "^6.2.1",
-		"globby": "^11.0.4",
-		"graceful-fs": "^4.2.8",
-		"jsdoc": "^3.6.7",
+		"globby": "^11.1.0",
+		"graceful-fs": "^4.2.9",
+		"jsdoc": "^3.6.10",
 		"less-openui5": "^0.11.2",
 		"make-dir": "^3.1.0",
 		"pretty-data": "^0.40.0",
@@ -120,21 +120,21 @@
 		"replacestream": "^4.0.3",
 		"rimraf": "^3.0.2",
 		"semver": "^7.3.5",
-		"terser": "^5.9.0",
+		"terser": "^5.10.0",
 		"xml2js": "^0.4.23",
 		"yazl": "^2.5.1"
 	},
 	"devDependencies": {
 		"ava": "^3.15.0",
-		"chai": "^4.3.4",
+		"chai": "^4.3.6",
 		"chai-fs": "^2.0.0",
 		"chokidar-cli": "^3.0.0",
 		"cross-env": "^7.0.3",
-		"depcheck": "^1.4.2",
+		"depcheck": "^1.4.3",
 		"docdash": "^1.2.0",
 		"eslint": "^7.32.0",
 		"eslint-config-google": "^0.14.0",
-		"eslint-plugin-jsdoc": "^36.1.1",
+		"eslint-plugin-jsdoc": "^37.9.4",
 		"extract-zip": "^2.0.1",
 		"mock-require": "^3.0.3",
 		"nyc": "^15.1.0",