@ucd-lib/theme-elements 0.0.13 → 0.0.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ucd-lib/theme-elements",
-  "version": "0.0.13",
+  "version": "0.0.14",
   "description": "Custom elements for the UCD brand theme",
   "main": "index.js",
   "scripts": {

package/ucdlib/ucdlib-icon/ucdlib-icon.js

@@ -44,17 +44,19 @@ export default class UcdlibIcon extends LitElement {
    * @private
    */
   disconnectedCallback() {
-    window.removeEventListener('ucdlib-iconset-added', this._onAddedIconset);
+    if ( this._setListener ){
+      window.removeEventListener('ucdlib-iconset-added', this._onAddedIconset);
+    }
     super.disconnectedCallback();
   }
 
   /**
-   * @method updated
-   * @description Lit lifecyle method called after element updates
+   * @method willUpdate
+   * @description Lit lifecyle method called right before element updates
    * @param {Map} props - Updated properties
    * @private
    */
-  updated(props){
+  willUpdate(props){
     if ( props.has('icon') || props.has('src') ){
       if ( this.src ) {
         this._updateIcon();
@@ -85,17 +87,27 @@ export default class UcdlibIcon extends LitElement {
   _updateIcon(){
     // using the icon attribute
     if ( this._usesIconSet() ) {
+      
+      // previously using the src attribute. remove it.
       if ( this._img && this._img.parentNode ) this.renderRoot.removeChild(this._img);
 
+      // empty icon name, remove it
       if ( this._iconName === '') {
         if ( this._iconset ) this._iconset.removeIcon(this);
+      
+      // check if iconset exists, add event listener if it doesn't
       } else if ( this._iconsetName ){
         this._iconset = this._getIconset();
-        if ( this._iconset ) {
+        if ( this._iconset && this._iconset.applyIcon ) {
           this._iconset.applyIcon(this, this._iconName);
-          window.addEventListener('ucdlib-iconset-added', this._onAddedIconset);
+          if ( this._setListener ){
+            window.removeEventListener('ucdlib-iconset-added', this._onAddedIconset);
+            this._setListener = false;
+          }
         } else {
-          window.removeEventListener('ucdlib-iconset-added', this._onAddedIconset);
+          if ( !this._setListener ){
+            this._setListener = window.addEventListener('ucdlib-iconset-added', this._onAddedIconset);
+          }
         }
       }
 

package/ucdlib/ucdlib-iconset/ucdlib-iconset.js

@@ -10,6 +10,7 @@ import { MutationObserverController } from '../../utils/controllers';
  * @property {String} name - Name of the icon set. Usage: <ucdlib-icon icon="{thisProperty}:{icon}"></ucdlib-icon>
  * @property {Number} size - The size of an individual icon. Note that icons must be square. 
  * @property {String} label - Optional friendly label for iconset.
+ * @property {String} suppressWarnings - Suppress any "you're doing it wrong" console warnings
  * @example
  * <ucdlib-iconset name="arrows">
     <svg>
@@ -28,6 +29,7 @@ export default class UcdlibIconset extends Mixin(LitElement)
       name: {type: String},
       size: {type: Number},
       label: {type: String},
+      suppressWarnings: {type: Boolean, attribute: 'suppress-warnings'},
       _iconMap: {type: Object, state: true}
     };
   }
@@ -40,7 +42,7 @@ export default class UcdlibIconset extends Mixin(LitElement)
     this.label = "";
     this.size = 24;
     this._iconMap = {};
-    this.style.display = "none";
+    this.suppressWarnings = false;
   }
 
   /**
@@ -51,12 +53,28 @@ export default class UcdlibIconset extends Mixin(LitElement)
    */
   updated( props ){
     if (props.has('name') && this.name ) {
-      this.dispatchEvent(
-        new CustomEvent('ucdlib-iconset-added', {bubbles: true, composed: true})
-      );
+      this.dispatchLoadEvent();
     }
   }
 
+  /**
+   * @method firstUpdated
+   * @description Lit lifecycle method when element is first updated
+   */
+  firstUpdated(){
+    this.style.display = "none";
+  }
+
+  /**
+   * @method dispatchLoadEvent
+   * @description fires off a 'ucdlib-iconset-added' event so ucdlib-icon elements can re-render if applicable
+   */
+  dispatchLoadEvent(){
+    this.dispatchEvent(
+      new CustomEvent('ucdlib-iconset-added', {bubbles: true, composed: true})
+    );
+  }
+
   /**
    * @method getIconNames
    * @description Returns a list of icon names for this set
@@ -173,7 +191,7 @@ export default class UcdlibIconset extends Mixin(LitElement)
       iconMap[icon.id] = icon;
     });
 
-    if ( !Object.keys(iconMap).length ) {
+    if ( !Object.keys(iconMap).length && !this.suppressWarnings ) {
       console.warn('No g elements with an id attribute found!.');
     }
     this._iconMap = iconMap;