@uarlouski/testrail-mcp-server 1.1.0 → 1.2.0

package/test/tools/get_templates.test.ts

@@ -32,36 +32,7 @@ describe('get_templates tool', () => {
         const result = await getTemplatesTool.handler({ project_id: '1' }, mockClient);
 
         expect(result).toBeDefined();
-        expect(result.content[0].type).toBe('text');
-
-        const parsed = JSON.parse(result.content[0].text);
-        expect(parsed.templates).toHaveLength(3);
+        expect(result.templates).toHaveLength(3);
         expect(mockClient.getTemplates).toHaveBeenCalledWith('1');
     });
-
-    test('returns correct template structure', async () => {
-        const result = await getTemplatesTool.handler({ project_id: '1' }, mockClient);
-        const parsed = JSON.parse(result.content[0].text);
-
-        expect(parsed.templates[0]).toEqual({
-            id: 1,
-            name: 'Test Case (Text)',
-        });
-
-        expect(parsed.templates[1]).toEqual({
-            id: 2,
-            name: 'Test Case (Steps)',
-        });
-    });
-
-    test('handler returns error on failure', async () => {
-        getTemplatesMock.mockRejectedValue(new Error('API Error'));
-
-        const result = await getTemplatesTool.handler({ project_id: '1' }, mockClient);
-
-        expect(result).toEqual({
-            content: [{ type: 'text', text: 'Error: API Error' }],
-            isError: true
-        });
-    });
 });

package/test/tools/update_case.test.ts

@@ -52,12 +52,9 @@ describe('update_case tool', () => {
         );
 
         expect(result).toBeDefined();
-        expect(result.content[0].type).toBe('text');
-
-        const parsed = JSON.parse(result.content[0].text);
-        expect(parsed.success).toBe(true);
-        expect(parsed.case_id).toBe(123);
-        expect(parsed.message).toContain('C123');
+        expect(result.success).toBe(true);
+        expect(result.case_id).toBe(123);
+        expect(result.message).toContain('C123');
         expect(mockClient.updateCase).toHaveBeenCalledWith('123', { title: 'Updated Title' });
     });
 
@@ -92,17 +89,14 @@ describe('update_case tool', () => {
         expect(mockClient.updateCase).toHaveBeenCalledWith('123', fields);
     });
 
-    test('handler returns error on failure', async () => {
+    test('handler throws error on failure', async () => {
         updateCaseMock.mockRejectedValue(new Error('API Error'));
 
-        const result = await updateCaseTool.handler(
-            { case_id: '123', fields: { title: 'Test' } },
-            mockClient
-        );
-
-        expect(result).toEqual({
-            content: [{ type: 'text', text: 'Error: API Error' }],
-            isError: true
-        });
+        await expect(
+            updateCaseTool.handler(
+                { case_id: '123', fields: { title: 'Test' } },
+                mockClient
+            )
+        ).rejects.toThrow('API Error');
     });
 });

package/test/tools/update_cases.test.ts

@@ -10,21 +10,21 @@ describe('update_cases tool', () => {
     const mockUpdatedCases: Case[] = [
         {
             id: 1, title: 'Test Case 1', section_id: 1, template_id: 1, type_id: 1,
-            priority_id: 3, milestone_id: null, refs: null, created_by: 1, created_on: 1700000000,
-            updated_by: 1, updated_on: 1700000001, estimate: null, estimate_forecast: null,
-            suite_id: 1, display_order: 1, is_deleted: 0, labels: []
+            priority_id: 3, milestone_id: null, refs: null, created_on: 1700000000,
+            updated_by: 1, updated_on: 1700000001, estimate: null,
+            suite_id: 1, labels: []
         },
         {
             id: 2, title: 'Test Case 2', section_id: 1, template_id: 1, type_id: 1,
-            priority_id: 3, milestone_id: null, refs: null, created_by: 1, created_on: 1700000000,
-            updated_by: 1, updated_on: 1700000001, estimate: null, estimate_forecast: null,
-            suite_id: 1, display_order: 2, is_deleted: 0, labels: []
+            priority_id: 3, milestone_id: null, refs: null, created_on: 1700000000,
+            updated_by: 1, updated_on: 1700000001, estimate: null,
+            suite_id: 1, labels: []
         },
         {
             id: 3, title: 'Test Case 3', section_id: 1, template_id: 1, type_id: 1,
-            priority_id: 3, milestone_id: null, refs: null, created_by: 1, created_on: 1700000000,
-            updated_by: 1, updated_on: 1700000001, estimate: null, estimate_forecast: null,
-            suite_id: 1, display_order: 3, is_deleted: 0, labels: []
+            priority_id: 3, milestone_id: null, refs: null, created_on: 1700000000,
+            updated_by: 1, updated_on: 1700000001, estimate: null,
+            suite_id: 1, labels: []
         },
     ];
 
@@ -52,37 +52,10 @@ describe('update_cases tool', () => {
         );
 
         expect(result).toBeDefined();
-        expect(result.content[0].type).toBe('text');
-
-        const parsed = JSON.parse(result.content[0].text);
-        expect(parsed.success).toBe(true);
-        expect(parsed.updated_count).toBe(3);
-        expect(parsed.case_ids).toEqual([1, 2, 3]);
-        expect(parsed.message).toContain('3 test cases');
-    });
-
-    test('passes case_ids and fields correctly', async () => {
-        const fields = { priority_id: 2, type_id: 1 };
-
-        await updateCasesTool.handler(
-            { case_ids: [10, 20, 30], fields },
-            mockClient
-        );
-
-        expect(mockClient.updateCases).toHaveBeenCalledWith([10, 20, 30], fields);
-    });
-
-    test('handler returns error on failure', async () => {
-        updateCasesMock.mockRejectedValue(new Error('API Error'));
-
-        const result = await updateCasesTool.handler(
-            { case_ids: [1, 2], fields: { priority_id: 2 } },
-            mockClient
-        );
-
-        expect(result).toEqual({
-            content: [{ type: 'text', text: 'Error: API Error' }],
-            isError: true
-        });
+        expect(result.success).toBe(true);
+        expect(result.updated_count).toBe(3);
+        expect(result.case_ids).toEqual([1, 2, 3]);
+        expect(result.message).toContain('3 test cases');
+        expect(mockClient.updateCases).toHaveBeenCalledWith([1, 2, 3], { priority_id: 3 });
     });
 });

package/test/utils/mapper.test.ts

@@ -6,13 +6,13 @@ describe('processCustomFields', () => {
 
     // Mock CaseField array simulating TestRail API response
     const mockCaseFields: CaseField[] = [
-        { id: 1, name: 'is_automated', system_name: 'custom_is_automated', label: 'Is Automated', type_id: 1, template_ids: [], include_all: true, is_active: true, display_order: 1, description: null, configs: [] },
-        { id: 2, name: 'refs', system_name: 'custom_refs', label: 'Defects', type_id: 1, template_ids: [], include_all: true, is_active: true, display_order: 2, description: null, configs: [] },
-        { id: 3, name: 'case_automation_priority', system_name: 'custom_case_automation_priority', label: 'Automation Priority', type_id: 6, template_ids: [], include_all: true, is_active: true, display_order: 3, description: null, configs: [{ context: { is_global: true, project_ids: null }, options: { items: '2, P0\n3, P1\n4, P2\n5, P3\n6, P4' } }] },
-        { id: 4, name: 'preconds', system_name: 'custom_preconds', label: 'Preconditions', type_id: 1, template_ids: [], include_all: true, is_active: true, display_order: 4, description: null, configs: [] },
-        { id: 5, name: 'steps', system_name: 'custom_steps', label: 'Steps', type_id: 1, template_ids: [1], include_all: false, is_active: true, display_order: 5, description: null, configs: [] },
-        { id: 6, name: 'expected', system_name: 'custom_expected', label: 'Expected', type_id: 1, template_ids: [1], include_all: false, is_active: true, display_order: 6, description: null, configs: [] },
-        { id: 7, name: 'steps_separated', system_name: 'custom_steps_separated', label: 'Steps Separated', type_id: 1, template_ids: [2], include_all: false, is_active: true, display_order: 7, description: null, configs: [] },
+        { id: 1, name: 'is_automated', system_name: 'custom_is_automated', label: 'Is Automated', type_id: 1, template_ids: [], include_all: true, is_active: true, description: null, configs: [] },
+        { id: 2, name: 'refs', system_name: 'custom_refs', label: 'Defects', type_id: 1, template_ids: [], include_all: true, is_active: true, description: null, configs: [] },
+        { id: 3, name: 'case_automation_priority', system_name: 'custom_case_automation_priority', label: 'Automation Priority', type_id: 6, template_ids: [], include_all: true, is_active: true, description: null, configs: [{ options: { items: '2, P0\n3, P1\n4, P2\n5, P3\n6, P4' } }] },
+        { id: 4, name: 'preconds', system_name: 'custom_preconds', label: 'Preconditions', type_id: 1, template_ids: [], include_all: true, is_active: true, description: null, configs: [] },
+        { id: 5, name: 'steps', system_name: 'custom_steps', label: 'Steps', type_id: 1, template_ids: [1], include_all: false, is_active: true, description: null, configs: [] },
+        { id: 6, name: 'expected', system_name: 'custom_expected', label: 'Expected', type_id: 1, template_ids: [1], include_all: false, is_active: true, description: null, configs: [] },
+        { id: 7, name: 'steps_separated', system_name: 'custom_steps_separated', label: 'Steps Separated', type_id: 1, template_ids: [2], include_all: false, is_active: true, description: null, configs: [] },
     ];
 
     test('maps custom fields using field metadata', () => {
@@ -21,7 +21,7 @@ describe('processCustomFields', () => {
             section_id: 0, type_id: 0, priority_id: 0,
             custom_is_automated: true,
             custom_refs: 'DEF-123',
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 
@@ -35,7 +35,7 @@ describe('processCustomFields', () => {
             id: 1, title: 'Foo', template_id: 1,
             section_id: 0, type_id: 0, priority_id: 0,
             custom_case_automation_priority: 2,
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 
@@ -50,7 +50,7 @@ describe('processCustomFields', () => {
             custom_expected: 'Expectation...',
             custom_steps_separated: [{ content: 'Should not appear' }], // Template 2 field
             section_id: 0, type_id: 0, priority_id: 0,
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 
@@ -66,7 +66,7 @@ describe('processCustomFields', () => {
             custom_steps: 'Should not appear', // Template 1 field
             custom_steps_separated: [{ content: 'Step 1' }],
             section_id: 0, type_id: 0, priority_id: 0,
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 
@@ -80,7 +80,7 @@ describe('processCustomFields', () => {
             id: 1, title: 'Foo', template_id: 999,
             custom_unknown_field: 'some value',
             section_id: 0, type_id: 0, priority_id: 0,
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 
@@ -101,7 +101,7 @@ describe('processCustomFields', () => {
             id: 1, title: 'Foo', template_id: 1,
             section_id: 0, type_id: 0, priority_id: 0,
             custom_case_automation_priority: 999, // Unknown option ID
-            display_order: 1, suite_id: 1, created_by: 1, created_on: 1, updated_by: 1, updated_on: 1,
+            display_order: 1, suite_id: 1, created_on: 1, updated_on: 1,
             is_deleted: 0, refs: null, labels: [],
         } as unknown as Case;
 

package/test/utils/sanitizer.test.ts

@@ -1,5 +1,5 @@
 import { describe, test, expect } from '@jest/globals';
-import { sanitizeValue } from '../../src/utils/sanitizer.js';
+import { sanitizeValue, removeNullish } from '../../src/utils/sanitizer.js';
 
 describe('sanitizeValue', () => {
     test('strips style attributes from string values', () => {
@@ -57,3 +57,87 @@ describe('sanitizeValue', () => {
         expect(sanitizeValue(null)).toBe(null);
     });
 });
+
+describe('removeNullish', () => {
+    test('removes null values from object', () => {
+        const input = { a: 1, b: null, c: 3 };
+        expect(removeNullish(input)).toEqual({ a: 1, c: 3 });
+    });
+
+    test('removes undefined values from object', () => {
+        const input = { a: 1, b: undefined, c: 3 };
+        expect(removeNullish(input)).toEqual({ a: 1, c: 3 });
+    });
+
+    test('handles nested objects', () => {
+        const input = {
+            name: 'test',
+            metadata: { id: 1, value: null, active: true },
+            count: null
+        };
+        expect(removeNullish(input)).toEqual({
+            name: 'test',
+            metadata: { id: 1, active: true }
+        });
+    });
+
+    test('filters null items from arrays', () => {
+        const input = [1, null, 3, undefined, 5];
+        expect(removeNullish(input)).toEqual([1, 3, 5]);
+    });
+
+    test('cleans nested objects in arrays', () => {
+        const input = [
+            { id: 1, name: 'item1', value: null },
+            { id: 2, name: null, value: 'test' }
+        ];
+        expect(removeNullish(input)).toEqual([
+            { id: 1, name: 'item1' },
+            { id: 2, value: 'test' }
+        ]);
+    });
+
+    test('handles deeply nested structures', () => {
+        const input = {
+            projects: [
+                {
+                    id: 1,
+                    name: 'Project A',
+                    metadata: { created: null, updated: '2024-01-01' },
+                    tags: [null, 'important', undefined, 'urgent']
+                },
+                null
+            ],
+            count: undefined
+        };
+        expect(removeNullish(input)).toEqual({
+            projects: [
+                {
+                    id: 1,
+                    name: 'Project A',
+                    metadata: { updated: '2024-01-01' },
+                    tags: ['important', 'urgent']
+                }
+            ]
+        });
+    });
+
+    test('preserves primitive values', () => {
+        expect(removeNullish(42)).toBe(42);
+        expect(removeNullish('test')).toBe('test');
+        expect(removeNullish(true)).toBe(true);
+        expect(removeNullish(0)).toBe(0);
+        expect(removeNullish('')).toBe('');
+        expect(removeNullish(false)).toBe(false);
+    });
+
+    test('returns null/undefined as-is for root values', () => {
+        expect(removeNullish(null)).toBe(null);
+        expect(removeNullish(undefined)).toBe(undefined);
+    });
+
+    test('handles empty objects and arrays', () => {
+        expect(removeNullish({})).toEqual({});
+        expect(removeNullish([])).toEqual([]);
+    });
+});