@tyvm/knowhow 0.0.33 → 0.0.35

package/tests/manual/ycmd/test_diagnostics_file_changes.ts

@@ -0,0 +1,249 @@
+import { ycmdStart, ycmdDiagnostics } from "../../../src/agents/tools/ycmd";
+import { ycmdServerManager } from "../../../src/agents/tools/ycmd/serverManager";
+import {
+  YcmdClient,
+  getFileTypes,
+} from "../../../src/agents/tools/ycmd/client";
+import * as fs from "fs";
+import * as path from "path";
+
+async function wait(ms: number) {
+  return new Promise((resolve) => setTimeout(resolve, ms));
+}
+
+async function testDiagnosticsWithFileChanges() {
+  console.log(
+    "🔧 Testing ycmd diagnostics with proper file change notifications..."
+  );
+
+  try {
+    // Start ycmd server
+    console.log("Starting ycmd server...");
+    const startResult = await ycmdStart({
+      workspaceRoot: process.cwd(),
+      logLevel: "debug",
+    });
+
+    if (!startResult.success) {
+      throw new Error(`Failed to start server: ${startResult.message}`);
+    }
+    console.log("✅ ycmd server started");
+
+    // Wait for server to initialize
+    console.log("⏳ Waiting for server initialization...");
+    await wait(2000);
+
+    const testDir = path.join(process.cwd(), "tests/ycmd/fixtures");
+    const testFile = path.join(testDir, "file_change_test.ts");
+
+    // Ensure test directory exists
+    if (!fs.existsSync(testDir)) {
+      fs.mkdirSync(testDir, { recursive: true });
+    }
+
+    // Get server info and create client
+    const serverInfo = ycmdServerManager.getServerInfo();
+    if (!serverInfo) {
+      throw new Error("Failed to get server info");
+    }
+
+    const client = new YcmdClient(serverInfo);
+    const filetypes = getFileTypes(testFile);
+
+    console.log("📝 Step 1: Creating valid TypeScript file...");
+    const validContent = `interface User {
+    name: string;
+    age: number;
+}
+
+function createUser(name: string, age: number): User {
+    return { name, age };
+}
+
+export { createUser };`;
+
+    fs.writeFileSync(testFile, validContent);
+
+    // Notify ycmd about the initial file
+    console.log("🔔 Notifying ycmd about initial file...");
+    await client.notifyFileEvent(
+      "BufferVisit",
+      testFile,
+      validContent,
+      filetypes
+    );
+    await wait(100);
+    await client.notifyFileEvent(
+      "FileReadyToParse",
+      testFile,
+      validContent,
+      filetypes
+    );
+    await wait(500);
+
+    // Test diagnostics on valid file
+    console.log("🔍 Testing diagnostics on valid file...");
+    let diagnostics = await ycmdDiagnostics({
+      filepath: testFile,
+      line: 1,
+      column: 1,
+    });
+
+    console.log(
+      "Valid file diagnostics:",
+      JSON.stringify(diagnostics, null, 2)
+    );
+
+    console.log("📝 Step 2: Modifying file to introduce TypeScript errors...");
+    const errorContent = `interface User {
+    name: string;
+    age: number;
+}
+
+function createUser(name: string, age: number): User {
+    // ERROR: Missing 'age' property - should cause TypeScript error
+    return { name };
+}
+
+// ERROR: Using undefined variable - should cause TypeScript error
+console.log(undefinedVariable);
+
+// ERROR: Type mismatch - missing required property - should cause TypeScript error
+const user: User = { name: 'Alice' };
+
+export { createUser };`;
+
+    fs.writeFileSync(testFile, errorContent);
+
+    // KEY STEP: Properly notify ycmd about file changes
+    console.log("🔔 Step 3: Notifying ycmd about file changes...");
+
+    // First unload the old version
+    console.log("  📤 Unloading old file version...");
+    await client.notifyFileEvent(
+      "BufferUnload",
+      testFile,
+      validContent,
+      filetypes
+    );
+    await wait(200);
+
+    // Then load the new version
+    console.log("  📥 Loading new file version...");
+    await client.notifyFileEvent(
+      "BufferVisit",
+      testFile,
+      errorContent,
+      filetypes
+    );
+    await wait(100);
+    await client.notifyFileEvent(
+      "FileReadyToParse",
+      testFile,
+      errorContent,
+      filetypes
+    );
+    await wait(100);
+
+    // Additional time for TSServer to process the changes
+    console.log("  ⏳ Waiting for TSServer to process changes...");
+    await wait(2000);
+
+    // Test diagnostics with the new content
+    console.log("🔍 Step 4: Testing diagnostics on modified file...");
+    diagnostics = await ycmdDiagnostics({
+      filepath: testFile,
+      fileContents: errorContent, // Pass the new content explicitly
+      line: 1,
+      column: 1,
+    });
+
+    console.log(
+      "Modified file diagnostics:",
+      JSON.stringify(diagnostics, null, 2)
+    );
+
+    if (
+      diagnostics.success &&
+      diagnostics.diagnostics &&
+      diagnostics.diagnostics.length > 0
+    ) {
+      console.log(
+        `🎉 SUCCESS: Found ${diagnostics.diagnostics.length} diagnostic(s)!`
+      );
+      diagnostics.diagnostics.forEach((diag, index) => {
+        console.log(`  ${index + 1}. Line ${diag.location.line}: ${diag.text}`);
+      });
+    } else {
+      console.log(
+        "❌ Still no diagnostics found. Trying alternative approaches..."
+      );
+
+      // Try triggering diagnostics on specific error lines
+      console.log("🎯 Testing specific error locations...");
+      const errorLines = [8, 11, 14]; // Lines with errors
+
+      for (const line of errorLines) {
+        console.log(`  Testing line ${line}...`);
+        const lineDiagnostics = await ycmdDiagnostics({
+          filepath: testFile,
+          fileContents: errorContent,
+          line,
+          column: 1,
+        });
+        console.log(
+          `  Line ${line} diagnostics:`,
+          JSON.stringify(lineDiagnostics, null, 2)
+        );
+
+        if (
+          lineDiagnostics.success &&
+          lineDiagnostics.diagnostics &&
+          lineDiagnostics.diagnostics.length > 0
+        ) {
+          console.log(`  🎉 Found diagnostics at line ${line}!`);
+          break;
+        }
+      }
+
+      // Try manual diagnostic check using client directly
+      console.log("🔧 Trying direct client diagnostic check...");
+      try {
+        const directDiagnostics = await client.getDiagnostics(
+          testFile,
+          errorContent,
+          filetypes,
+          1,
+          1
+        );
+        console.log(
+          "Direct client diagnostics:",
+          JSON.stringify(directDiagnostics, null, 2)
+        );
+
+        if (directDiagnostics.length > 0) {
+          console.log(
+            `🎉 SUCCESS via direct client: Found ${directDiagnostics.length} diagnostic(s)!`
+          );
+          directDiagnostics.forEach((diag, index) => {
+            console.log(
+              `  ${index + 1}. Line ${diag.location.line_num}: ${diag.text}`
+            );
+          });
+        }
+      } catch (error) {
+        console.log("Direct client diagnostics failed:", error.message);
+      }
+    }
+
+    // Clean up
+    fs.unlinkSync(testFile);
+    console.log("✅ Test completed");
+  } catch (error) {
+    console.error("❌ Test failed:", error.message);
+    console.error("Stack trace:", error.stack);
+    process.exit(1);
+  }
+}
+
+testDiagnosticsWithFileChanges();

package/tests/manual/ycmd/test_diagnostics_fix.ts

@@ -0,0 +1,99 @@
+#!/usr/bin/env npx tsx
+
+/**
+ * Test diagnostics fix - verify that the corrected diagnostics endpoint works
+ */
+
+import { ycmdDiagnostics } from '../../../src/agents/tools/ycmd/tools/diagnostics';
+import * as fs from 'fs';
+import * as path from 'path';
+
+async function testDiagnosticsFix() {
+  console.log('🧪 Testing Diagnostics Fix...\n');
+
+  // Create a test file with clear TypeScript errors
+  const testFilePath = path.join(__dirname, 'fixtures', 'test_diagnostics_fix.ts');
+  const testContent = `
+interface User {
+  name: string;
+  age: number;
+}
+
+// Error 1: Missing required property 'age'
+const user1: User = {
+  name: "John"
+};
+
+// Error 2: Undefined variable
+console.log(undefinedVariable);
+
+// Error 3: Type mismatch
+const user2: User = {
+  name: "Jane",
+  age: "not a number" // Should be number, not string
+};
+`;
+
+  // Write the test file
+  await fs.promises.writeFile(testFilePath, testContent, 'utf8');
+  console.log(`📝 Created test file: ${testFilePath}`);
+  console.log(`📄 Test file content:\n${testContent}`);
+
+  try {
+    console.log('🔍 Running diagnostics...');
+    
+    const result = await ycmdDiagnostics({
+      filepath: testFilePath,
+      fileContents: testContent
+    });
+
+    console.log('\n📊 Diagnostics Result:');
+    console.log(`Success: ${result.success}`);
+    console.log(`Message: ${result.message}`);
+    
+    if (result.diagnostics) {
+      console.log(`\n🔎 Found ${result.diagnostics.length} diagnostic(s):`);
+      
+      result.diagnostics.forEach((diag, index) => {
+        console.log(`\n${index + 1}. ${diag.kind}: ${diag.text}`);
+        console.log(`   Location: Line ${diag.location.line}, Column ${diag.location.column}`);
+        if (diag.fixit_available) {
+          console.log(`   ✨ Fix available`);
+        }
+      });
+
+      if (result.diagnostics.length > 0) {
+        console.log('\n✅ SUCCESS: Diagnostics are now working!');
+        
+        // Categorize the diagnostics
+        const errors = result.diagnostics.filter(d => d.kind === 'ERROR');
+        const warnings = result.diagnostics.filter(d => d.kind === 'WARNING');
+        const infos = result.diagnostics.filter(d => d.kind === 'INFO');
+        
+        console.log(`\n📈 Summary:`);
+        console.log(`   - Errors: ${errors.length}`);
+        console.log(`   - Warnings: ${warnings.length}`);
+        console.log(`   - Info: ${infos.length}`);
+        
+      } else {
+        console.log('\n❌ ISSUE: Still no diagnostics found');
+      }
+    } else {
+      console.log('\n❌ ISSUE: No diagnostics returned');
+    }
+
+  } catch (error) {
+    console.error('\n💥 Error during diagnostics test:', error);
+  } finally {
+    // Clean up test file
+    try {
+      await fs.promises.unlink(testFilePath);
+      console.log(`\n🧹 Cleaned up test file: ${testFilePath}`);
+    } catch (error) {
+      console.warn(`⚠️  Failed to clean up test file: ${error}`);
+    }
+  }
+}
+
+// Run the test
+testDiagnosticsFix().catch(console.error);

package/tests/manual/ycmd/test_diagnostics_simple.ts

@@ -0,0 +1,100 @@
+import { ycmdStart, ycmdDiagnostics } from '../../../src/agents/tools/ycmd';
+import * as fs from 'fs';
+import * as path from 'path';
+
+async function wait(ms: number) {
+    return new Promise(resolve => setTimeout(resolve, ms));
+}
+
+async function testDiagnosticsSimple() {
+    console.log('🔧 Testing ycmd diagnostics with TypeScript errors...');
+
+    try {
+        // Start ycmd server
+        console.log('Starting ycmd server...');
+        const startResult = await ycmdStart({
+            workspaceRoot: process.cwd(),
+            logLevel: 'debug'
+        });
+
+        if (!startResult.success) {
+            throw new Error(`Failed to start server: ${startResult.message}`);
+        }
+        console.log('✅ ycmd server started');
+
+        // Wait for server to initialize
+        console.log('⏳ Waiting for server initialization...');
+        await wait(3000);
+
+        const testDir = path.join(process.cwd(), 'tests/ycmd/fixtures');
+        const testFile = path.join(testDir, 'diagnostic_test.ts');
+
+        // Ensure test directory exists
+        if (!fs.existsSync(testDir)) {
+            fs.mkdirSync(testDir, { recursive: true });
+        }
+
+        console.log('📝 Creating TypeScript file with clear errors...');
+        const errorContent = `interface User {
+    name: string;
+    age: number;
+}
+
+function createUser(name: string, age: number): User {
+    // ERROR: Missing 'age' property - should cause TypeScript error
+    return { name };
+}
+
+// ERROR: Using undefined variable - should cause TypeScript error
+console.log(undefinedVariable);
+
+// ERROR: Type mismatch - missing required property
+const user: User = { name: 'Alice' };
+
+export { createUser };`;
+
+        fs.writeFileSync(testFile, errorContent);
+
+        console.log('🔍 Testing diagnostics (setupClient should handle notifications automatically)...');
+
+        // Test diagnostics - setupClientAndNotifyFile should handle all notifications
+        const diagnostics = await ycmdDiagnostics({
+            filepath: testFile,
+            fileContents: errorContent, // Pass content explicitly
+            line: 1,
+            column: 1
+        });
+
+        console.log('Diagnostics result:', JSON.stringify(diagnostics, null, 2));
+
+        if (diagnostics.success && diagnostics.diagnostics && diagnostics.diagnostics.length > 0) {
+            console.log(`🎉 SUCCESS: Found ${diagnostics.diagnostics.length} diagnostic(s)!`);
+            diagnostics.diagnostics.forEach((diag, index) => {
+                console.log(`  ${index + 1}. ${diag.kind} at line ${diag.location.line}: ${diag.text}`);
+            });
+        } else {
+            console.log('❌ No diagnostics found.');
+            console.log('This suggests either:');
+            console.log('  1. TSServer is not processing the file correctly');
+            console.log('  2. File notifications are not working as expected');
+            console.log('  3. ycmd diagnostics API has an issue');
+        }
+
+        // Clean up
+        if (fs.existsSync(testFile)) {
+            fs.unlinkSync(testFile);
+        }
+
+        console.log('✅ Test completed');
+
+    } catch (error) {
+        console.error('❌ Test failed:', error.message);
+        console.error('Stack trace:', error.stack);
+        process.exit(1);
+    }
+
+    // Important: Exit the process to prevent hanging
+    process.exit(0);
+}
+
+testDiagnosticsSimple();

package/tests/manual/ycmd/test_diagnostics_timing.ts

@@ -0,0 +1,120 @@
+import { ycmdStart, ycmdDiagnostics } from '../../../src/agents/tools/ycmd';
+import * as fs from 'fs';
+import * as path from 'path';
+
+async function testDiagnosticsTiming() {
+    console.log('🔧 Testing ycmd diagnostics with timing...');
+
+    try {
+        // Start ycmd server
+        console.log('Starting ycmd server...');
+        const startResult = await ycmdStart({
+            workspaceRoot: process.cwd(),
+            logLevel: 'debug'
+        });
+        console.log('✅ ycmd server started');
+
+        // Wait for server to initialize
+        console.log('⏳ Waiting 3 seconds for server initialization...');
+        await new Promise(resolve => setTimeout(resolve, 3000));
+
+        const testDir = path.join(process.cwd(), 'tests/ycmd/fixtures');
+        const testFile = path.join(testDir, 'timing_test.ts');
+
+        // First create a valid file
+        console.log('📝 Creating valid TypeScript file...');
+        const validContent = `interface User {
+    name: string;
+    age: number;
+}
+
+function createUser(name: string, age: number): User {
+    return { name, age };
+}
+
+export { createUser };`;
+
+        fs.writeFileSync(testFile, validContent);
+
+        // Test diagnostics on valid file
+        console.log('🔍 Testing diagnostics on valid file...');
+        let diagnostics = await ycmdDiagnostics({
+            filepath: testFile,
+            line: 1,
+            column: 1
+        });
+
+        console.log('Valid file diagnostics:', JSON.stringify(diagnostics, null, 2));
+
+        // Now introduce errors
+        console.log('📝 Introducing TypeScript errors...');
+        const errorContent = `interface User {
+    name: string;
+    age: number;
+}
+
+function createUser(name: string, age: number): User {
+    // This should cause an error - missing 'age' property
+    return { name };
+}
+
+// This should cause an error - undefined variable
+console.log(undefinedVariable);
+
+// This should cause an error - type mismatch
+const user: User = { name: 'Alice' };
+
+export { createUser };`;
+
+        fs.writeFileSync(testFile, errorContent);
+
+        // Test diagnostics at different delays
+        const delays = [500, 1000, 2000, 5000];
+
+        for (const delay of delays) {
+            console.log(`🔍 Testing diagnostics after ${delay}ms delay...`);
+            await new Promise(resolve => setTimeout(resolve, delay));
+
+            diagnostics = await ycmdDiagnostics({
+                filepath: testFile,
+                line: 1,
+                column: 1
+            });
+
+            console.log(`Diagnostics after ${delay}ms:`, JSON.stringify(diagnostics, null, 2));
+
+            if (diagnostics.success && diagnostics.diagnostics && diagnostics.diagnostics.length > 0) {
+                console.log(`✅ SUCCESS: Found ${diagnostics.diagnostics.length} diagnostic(s) after ${delay}ms!`);
+                diagnostics.diagnostics.forEach((diag, index) => {
+                    console.log(`  ${index + 1}. Line ${diag.location.line}: ${diag.text}`);
+                });
+                break;
+            }
+        }
+
+        // Try testing different lines where errors are
+        console.log('🎯 Testing specific error locations...');
+
+        const errorLines = [8, 11, 14]; // Lines with errors
+        for (const line of errorLines) {
+            console.log(`Testing line ${line}...`);
+            const lineDiagnostics = await ycmdDiagnostics({
+                filepath: testFile,
+                line: line,
+                column: 1
+            });
+            console.log(`Line ${line} diagnostics:`, JSON.stringify(lineDiagnostics, null, 2));
+        }
+
+        // Clean up
+        fs.unlinkSync(testFile);
+        console.log('✅ Test completed');
+        process.exit(0);
+
+    } catch (error) {
+        console.error('❌ Test failed:', error.message);
+        process.exit(1);
+    }
+}
+
+testDiagnosticsTiming();