@tyvm/knowhow 0.0.110 → 0.0.112

package/src/clients/xai.ts

@@ -425,7 +425,7 @@ export class GenericXAIClient implements GenericClient {
     options: VideoStatusOptions
   ): Promise<VideoStatusResponse> {
     const statusResponse = await fetch(
-      `https://api.x.ai/v1/videos/${options.jobId}`,
+      `https://api.x.ai/v1/videos/generations/${options.jobId}`,
       {
         method: "GET",
         headers: {
@@ -485,8 +485,25 @@ export class GenericXAIClient implements GenericClient {
   async downloadVideo(
     options: FileDownloadOptions
   ): Promise<FileDownloadResponse> {
-    // XAI returns a URL for the video, not raw bytes from their API
-    const url = options.uri || options.fileId;
+    // XAI returns a presigned URL from the status endpoint, not raw bytes.
+    // options.fileId is the request_id (jobId) — we need to fetch the status
+    // to get the actual video URL, then download from there.
+    let url = options.uri;
+    if (!url) {
+      const statusResponse = await fetch(
+        `https://api.x.ai/v1/videos/generations/${options.fileId}`,
+        { headers: { Authorization: `Bearer ${this.apiKey}` } }
+      );
+      if (!statusResponse.ok) {
+        const errorText = await statusResponse.text();
+        throw new Error(`XAI video status fetch failed: ${statusResponse.status} ${errorText}`);
+      }
+      const statusData = await statusResponse.json();
+      url = statusData.video?.url;
+      if (!url) {
+        throw new Error(`XAI video not ready yet or no URL available (status: ${statusData.status})`);
+      }
+    }
 
     const response = await fetch(url);
     if (!response.ok) {

package/src/login.ts

@@ -74,9 +74,10 @@ export async function login(jwtFlag?: boolean): Promise<void> {
     await updateConfig(config);
   } catch (error) {
     if (http.isHttpError(error) && error.response) {
-      const errData = await error.response.json().catch(() => ({ message: "Unknown error" }));
+      // error.body is the parsed JSON response body (set by http.ts when response is not ok)
+      const errData = error.body ?? { message: "Unknown error" };
       throw new Error(
-        `Error: ${error.status} - ${errData.message || "Unknown error"}`
+        `Error: ${error.status} - ${errData?.message || "Unknown error"}`
       );
     }
     console.log(

package/src/processors/CustomVariables.ts

@@ -2,6 +2,7 @@ import { Message } from "../clients/types";
 import { MessageProcessorFunction } from "../services/MessageProcessor";
 import { ToolsService } from "../services";
 import { Tool } from "../clients";
+import { ToolCall } from "../clients/types";
 
 interface VariableStorage {
   [name: string]: any;
@@ -238,6 +239,180 @@ export class CustomVariables {
     };
   }
 
+  /**
+   * Extracts all string values from a JSON-parsed object (recursively)
+   */
+  private extractStringValues(obj: any, results: string[] = []): string[] {
+    if (typeof obj === "string") {
+      results.push(obj);
+    } else if (Array.isArray(obj)) {
+      for (const item of obj) {
+        this.extractStringValues(item, results);
+      }
+    } else if (obj && typeof obj === "object") {
+      for (const val of Object.values(obj)) {
+        this.extractStringValues(val, results);
+      }
+    }
+    return results;
+  }
+
+  /**
+   * Collects all large string values from tool calls, keyed by tool name.
+   * Returns an array of {value, toolName} pairs.
+   */
+  private collectToolCallStrings(
+    messages: Message[],
+    minLength: number
+  ): Array<{ value: string; toolName: string }> {
+    const collected: Array<{ value: string; toolName: string }> = [];
+    for (const message of messages) {
+      if (!message.tool_calls) continue;
+      for (const toolCall of message.tool_calls) {
+        const strings = this.getToolCallStrings(toolCall);
+        for (const str of strings) {
+          if (str.length >= minLength) {
+            collected.push({ value: str, toolName: toolCall.function.name });
+          }
+        }
+      }
+    }
+    return collected;
+  }
+
+  /**
+   * Finds the longest common substring between two strings that is >= minLength.
+   * Returns the substring or null if none found.
+   */
+  private longestCommonSubstring(a: string, b: string, minLength: number): string | null {
+    let best = "";
+    for (let i = 0; i < a.length - minLength + 1; i++) {
+      for (let j = a.length; j > i + minLength - 1; j--) {
+        const sub = a.slice(i, j);
+        if (sub.length <= best.length) break; // already found longer
+        if (b.includes(sub)) {
+          best = sub;
+          break;
+        }
+      }
+    }
+    return best.length >= minLength ? best : null;
+  }
+
+  /**
+   * Extracts all string values from a tool call's arguments
+   */
+  private getToolCallStrings(toolCall: ToolCall): string[] {
+    try {
+      const parsed = JSON.parse(toolCall.function.arguments);
+      return this.extractStringValues(parsed);
+    } catch {
+      // If not JSON, treat the whole arguments string as a single value
+      return [toolCall.function.arguments];
+    }
+  }
+
+  /**
+   * Creates a processor that scans messages for repeated large string values
+   * in tool call arguments, and appends a hint suggesting variable storage.
+   *
+   * This helps the LLM discover that it can avoid re-outputting long strings
+   * (e.g. JWTs, file contents) by storing them once with setVariable or
+   * storeToolCallToVariable and then referencing them via {{varName}}.
+   */
+  createRepetitionHintProcessor(options: {
+    minLength?: number;       // Minimum string length to consider (default: 50)
+    minRepetitions?: number;  // Minimum occurrences to trigger hint (default: 2)
+    minSubstringLength?: number; // Minimum repeated substring length (default: 50)
+    recentMessagesWindow?: number; // Only scan the last N messages (default: 10)
+  } = {}): MessageProcessorFunction {
+    const minLength = options.minLength ?? 50;
+    const minRepetitions = options.minRepetitions ?? 2;
+    const minSubstringLength = options.minSubstringLength ?? 50;
+    const recentMessagesWindow = options.recentMessagesWindow ?? 10;
+
+    return async (originalMessages: Message[], modifiedMessages: Message[]) => {
+      // Count occurrences of each string value across all tool call arguments
+      const stringCounts = new Map<string, { count: number; toolNames: Set<string> }>();
+
+      // Only scan the most recent N messages to keep cost bounded
+      const recentMessages = modifiedMessages.slice(-recentMessagesWindow);
+
+      // Step 1: exact full-string matches
+      const toolStrings = this.collectToolCallStrings(recentMessages, minLength);
+
+      for (const { value, toolName } of toolStrings) {
+        const existing = stringCounts.get(value);
+        if (existing) {
+          existing.count++;
+          existing.toolNames.add(toolName);
+        } else {
+          stringCounts.set(value, { count: 1, toolNames: new Set([toolName]) });
+        }
+      }
+
+      // Step 2: detect repeated substrings across different full strings
+      // e.g. the same JWT embedded in many different commands
+      const substringCounts = new Map<string, { count: number; toolNames: Set<string> }>();
+
+      for (let i = 0; i < toolStrings.length; i++) {
+        for (let j = i + 1; j < toolStrings.length; j++) {
+          const a = toolStrings[i];
+          const b = toolStrings[j];
+          // Skip if the full strings are identical (already counted above)
+          if (a.value === b.value) continue;
+
+          const common = this.longestCommonSubstring(a.value, b.value, minSubstringLength);
+          if (common) {
+            const existing = substringCounts.get(common);
+            if (existing) {
+              existing.count++;
+              existing.toolNames.add(a.toolName);
+              existing.toolNames.add(b.toolName);
+            } else {
+              substringCounts.set(common, {
+                count: 1,
+                toolNames: new Set([a.toolName, b.toolName]),
+              });
+            }
+          }
+        }
+      }
+
+      // Merge substring counts: count = number of unique pairs, so count+1 = occurrences
+      for (const [sub, info] of substringCounts.entries()) {
+        if (info.count + 1 >= minRepetitions) {
+          const existing = stringCounts.get(sub);
+          if (!existing) {
+            stringCounts.set(sub, { count: info.count + 1, toolNames: info.toolNames });
+          }
+        }
+      }
+
+      // Find entries that exceed the repetition threshold
+      const repeatedTools: string[] = [];
+      for (const [str, info] of stringCounts.entries()) {
+        if (info.count >= minRepetitions) {
+          for (const toolName of info.toolNames) {
+            if (!repeatedTools.includes(toolName)) {
+              repeatedTools.push(toolName);
+            }
+          }
+        }
+      }
+
+      if (repeatedTools.length > 0) {
+        modifiedMessages.push({
+          role: "user",
+          content:
+            `⚠️ Tool inputs have large repetitions detected in: ${repeatedTools.join(", ")}. ` +
+            `Consider storing repeated values with \`setVariable\` or \`storeToolCallToVariable\`, ` +
+            `then reference them via {{variableName}} in future tool calls to avoid re-outputting large strings.`,
+        });
+      }
+    };
+  }
+
   /**
    * Registers all custom variable tools with the ToolsService
    */

package/src/services/EventService.ts

@@ -1,5 +1,6 @@
 import { EventEmitter } from "events";
 import { IAgent } from "../agents/interface";
+import { logger } from "../logger";
 
 export type LogLevel = "info" | "warn" | "error";
 
@@ -36,9 +37,9 @@ type ManagedListenerRecord = {
 /**
  * Default console handler for plugin:log events.
  * Active when no renderer has taken over (e.g. worker mode, CLI before chat starts).
- * Can be suppressed by calling suppressDefaultLogger() when a renderer is active.
+ * Respects logger.silence() — if the logger is silenced, this handler is a no-op.
  *
- * IMPORTANT: Uses process.stdout/stderr directly to avoid infinite recursion
+ * Uses process.stdout/stderr directly to avoid infinite recursion
  * with logger.installConsoleOverload() which overrides console.log/warn.
  */
 function defaultConsoleLogHandler(event: {
@@ -46,6 +47,7 @@ function defaultConsoleLogHandler(event: {
   message: string;
   level: LogLevel;
 }): void {
+  if (logger.isSilenced()) return;
   const prefix = event.source ? `[${event.source}] ` : "";
   const line = `${prefix}${event.message}\n`;
   switch (event.level) {
@@ -63,8 +65,6 @@ function defaultConsoleLogHandler(event: {
 export class EventService extends EventEmitter {
   private blockingHandlers: Map<string, EventHandler[]> = new Map();
   private managedListeners: Map<string, ManagedListenerRecord> = new Map();
-  private defaultLoggerActive = true;
-  private boundDefaultLogHandler = defaultConsoleLogHandler;
 
   eventTypes = {
     agentMsg: "agent:msg",
@@ -76,35 +76,7 @@ export class EventService extends EventEmitter {
   constructor() {
     super();
     this.setMaxListeners(100);
-    // Register the default console logger so Events.log() always produces output
-    // even before a renderer is attached (worker mode, module loading, etc.)
-    this.on(this.eventTypes.pluginLog, this.boundDefaultLogHandler);
-  }
-
-  /**
-   * Suppress the default console logger.
-   * Call this when a renderer has taken over and will handle plugin:log events.
-   * This prevents double-printing when both the renderer and the default handler fire.
-   */
-  suppressDefaultLogger(): void {
-    if (this.defaultLoggerActive) {
-      this.removeListener(
-        this.eventTypes.pluginLog,
-        this.boundDefaultLogHandler
-      );
-      this.defaultLoggerActive = false;
-    }
-  }
-
-  /**
-   * Restore the default console logger.
-   * Call this when the renderer is torn down.
-   */
-  restoreDefaultLogger(): void {
-    if (!this.defaultLoggerActive) {
-      this.on(this.eventTypes.pluginLog, this.boundDefaultLogHandler);
-      this.defaultLoggerActive = true;
-    }
+    this.on(this.eventTypes.pluginLog, defaultConsoleLogHandler);
   }
 
   /**

package/src/services/Mcp.ts

@@ -528,7 +528,20 @@ export class McpService {
         // skip adding tools for unconnected clients
         continue;
       }
-      const clientTools = await client.listTools();
+
+      let clientTools: Awaited<ReturnType<typeof client.listTools>>;
+      try {
+        clientTools = await client.listTools();
+      } catch (error) {
+        // The MCP server connected at the transport level but the underlying
+        // server returned an error (e.g. -32603 "Not connected" from the proxy).
+        // Mark it as disconnected and skip — don't crash the worker.
+        console.warn(
+          `⚠ MCP server '${config.name}' failed to list tools (marking as disconnected): ${error instanceof Error ? error.message : error}`
+        );
+        this.connected[i] = false;
+        continue;
+      }
 
       for (const tool of clientTools.tools) {
         const transformed = this.toOpenAiTool(i, tool as any as McpTool);

package/src/utils/http.ts

@@ -13,7 +13,8 @@ export class HttpError extends Error {
   constructor(
     public status: number,
     public response: Response,
-    message: string
+    message: string,
+    public body?: any,
   ) {
     super(message);
     this.name = "HttpError";
@@ -102,7 +103,13 @@ async function request<T = any>(
 
   if (!response.ok) {
     const text = await response.text().catch(() => "");
-    throw new HttpError(response.status, response, `HTTP ${response.status}: ${text}`);
+    let parsedBody: any;
+    try {
+      parsedBody = JSON.parse(text);
+    } catch {
+      parsedBody = { message: text };
+    }
+    throw new HttpError(response.status, response, `HTTP ${response.status}: ${text}`, parsedBody);
   }
 
   const data = await parseBody<T>(response, responseType);

package/src/utils/index.ts

@@ -40,6 +40,7 @@ export const setOnNewHistoryEntry = (
   inputQueue.setOnNewEntry(callback);
 };
 
+
 export const Marked = marked;
 
 export function dotp(x, y) {

package/tests/fixtures/fake-secret.txt

@@ -0,0 +1 @@
+eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJmYWtlLXVzZXItaWQiLCJuYW1lIjoiRmFrZSBVc2VyIiwiaWF0IjoxNTE2MjM5MDIyfQ.FAKE_SECRET_DO_NOT_USE

package/tests/manual/modalities/xai.modalities.test.ts

@@ -98,7 +98,7 @@ describe("XAI (Grok) Modalities", () => {
     const dataUrl = `data:image/png;base64,${base64Image}`;
 
     const response = await client.createCompletion("xai", {
-      model: Models.xai.Grok2Vision1212,
+      model: Models.xai.Grok_4_20_NonReasoning,
       messages: [
         {
           role: "user",