@tyvm/knowhow 0.0.108-dev.126b29e → 0.0.108-dev.501f36f

package/src/fileSync.ts

@@ -1,5 +1,6 @@
 import * as fs from "fs";
 import * as path from "path";
+import * as os from "os";
 import { KnowhowSimpleClient, KNOWHOW_API_URL } from "./services/KnowhowClient";
 import { loadJwt } from "./login";
 import { getConfig } from "./config";
@@ -7,6 +8,8 @@ import { services } from "./services";
 import { S3Service } from "./services/S3";
 import { getHashes, hasFileChangedSinceUpload, saveUploadHash, isLocalFileMatchingRemote, isLocalFileMatchingDownloadHash, saveDownloadHash } from "./hashes";
 
+export const DEFAULT_BATCH_SIZE = 5;
+
 export interface FileSyncOptions {
   upload?: boolean;
   download?: boolean;
@@ -15,6 +18,33 @@ export interface FileSyncOptions {
   dryRun?: boolean;
 }
 
+/**
+ * Run an array of async tasks in batches of `batchSize` at a time.
+ * Returns results in the same order as the input tasks.
+ */
+export async function batchRun<T>(
+  tasks: (() => Promise<T>)[],
+  batchSize: number = DEFAULT_BATCH_SIZE
+): Promise<T[]> {
+  const results: T[] = [];
+  for (let i = 0; i < tasks.length; i += batchSize) {
+    const batch = tasks.slice(i, i + batchSize);
+    const batchResults = await Promise.all(batch.map((t) => t()));
+    results.push(...batchResults);
+  }
+  return results;
+}
+
+/**
+ * Expands a leading ~ to the user's home directory
+ */
+function expandHome(p: string): string {
+  if (p === "~" || p.startsWith("~/") || p.startsWith("~\\")) {
+    return path.join(os.homedir(), p.slice(1));
+  }
+  return p;
+}
+
 /**
  * Returns true if the path looks like a directory (ends with /)
  */
@@ -25,7 +55,7 @@ function isDirectoryPath(p: string): boolean {
 /**
  * Recursively list all files in a local directory, returning relative paths
  */
-function listFilesRecursively(dir: string): string[] {
+export function listFilesRecursively(dir: string): string[] {
   const results: string[] = [];
   if (!fs.existsSync(dir)) return results;
   const entries = fs.readdirSync(dir, { withFileTypes: true });
@@ -83,7 +113,8 @@ export async function fileSync(options: FileSyncOptions = {}) {
 
   // Process each file mount
   for (const mount of config.files) {
-    const { remotePath, localPath, direction = "download" } = mount;
+    const { remotePath, localPath: rawLocalPath, direction = "download" } = mount;
+    const localPath = expandHome(rawLocalPath);
 
     // Determine actual direction based on flags and config
     let actualDirection = direction;
@@ -126,11 +157,10 @@ export async function fileSync(options: FileSyncOptions = {}) {
   }
 }
 
-
 /**
  * Download a file from Knowhow FS to local filesystem
  */
-async function downloadFile(
+export async function downloadFile(
   client: KnowhowSimpleClient,
   s3Service: S3Service,
   remotePath: string,
@@ -186,7 +216,7 @@ async function downloadFile(
 /**
  * Upload a file from local filesystem to Knowhow FS
  */
-async function uploadFile(
+export async function uploadFile(
   client: KnowhowSimpleClient,
   s3Service: S3Service,
   remotePath: string,
@@ -215,7 +245,7 @@ async function uploadFile(
   }
 
   // Get presigned upload URL
-  const presignedUrl = await client.getOrgFilePresignedUploadUrl(remotePath);
+  const presignedUrl = await client.getOrgFilePresignedUploadUrl(remotePath, localPath);
 
   // Upload file using presigned URL
   await s3Service.uploadToPresignedUrl(presignedUrl, localPath);
@@ -261,26 +291,28 @@ export async function uploadDirectory(
 
   console.log(`   Found ${localFiles.length} local file(s)`);
 
-  let count = 0;
-  for (const relFile of localFiles) {
+  const tasks = localFiles.map((relFile) => async () => {
     const localFilePath = localDir + relFile;
     const remoteFilePath = remoteDir + relFile;
     try {
       await uploadFile(client, s3Service, remoteFilePath, localFilePath, dryRun);
-      count++;
+      return 1;
     } catch (error) {
       console.error(
         `   ❌ Failed to upload ${localFilePath}, skipping: ${error.message}`
       );
+      return 0;
     }
-  }
-  return count;
+  });
+
+  const counts = await batchRun(tasks);
+  return counts.reduce((sum, n) => sum + n, 0);
 }
 
 /**
  * Download all files from a remote directory path to a local directory
  */
-async function downloadDirectory(
+export async function downloadDirectory(
   client: KnowhowSimpleClient,
   s3Service: S3Service,
   remotePath: string,
@@ -313,8 +345,7 @@ async function downloadDirectory(
 
   console.log(`   Found ${matchingFiles.length} remote file(s)`);
 
-  let count = 0;
-  for (const f of matchingFiles) {
+  const tasks = matchingFiles.map((f) => async () => {
     const fullRemotePath = f.folderPath.endsWith("/")
       ? f.folderPath + f.fileName
       : f.folderPath + "/" + f.fileName;
@@ -322,7 +353,9 @@ async function downloadDirectory(
     const relativePath = fullRemotePath.slice(remoteDir.length);
     const localFilePath = localDir + relativePath;
     await downloadFile(client, s3Service, fullRemotePath, localFilePath, dryRun);
-    count++;
-  }
-  return count;
+    return 1;
+  });
+
+  const counts = await batchRun(tasks);
+  return counts.reduce((sum, n) => sum + n, 0);
 }

package/src/index.ts

@@ -53,6 +53,7 @@ export * as ai from "./ai";
 
 // Export module system types for external modules
 export * from "./services/modules/types";
+export { ModulesService } from "./services/modules";
 // Export plugin types for external plugins
 export { PluginBase } from "./plugins/PluginBase";
 export { PluginMeta, Plugin, PluginContext } from "./plugins/types";

package/src/logger.ts

@@ -0,0 +1,197 @@
+import type { LogLevel } from "./services/EventService";
+
+/**
+ * App-wide logger utility.
+ *
+ * Features:
+ * 1. `logger.info/warn/error(source, message)` — routes through EventService
+ * 2. `Logger.of("ClassName")` — creates a bound logger so you don't repeat the source
+ * 3. `logger.installConsoleOverload()` — replaces console.log/warn/error/info with
+ *    our closure, so ALL output (including third-party modules) goes through us
+ * 4. `logger.silence()` / `logger.unsilence()` — suppress all output, useful for
+ *    commands that need clean stdout (e.g. github-credentials)
+ *
+ * Usage (module-level):
+ *   import { logger } from "../logger";
+ *   logger.info("MyService", "Something happened");
+ *
+ * Usage (class-level):
+ *   import { Logger } from "../logger";
+ *   class MyClass {
+ *     private logger = Logger.of("MyClass");
+ *     doThing() { this.logger.info("Something happened"); }
+ *   }
+ *
+ * Silence mode (for clean-stdout commands):
+ *   logger.silence();   // suppress everything
+ *   // ... do work that must produce clean stdout ...
+ *   logger.unsilence(); // restore
+ */
+
+// ---- Internal state ---------------------------------------------------------
+
+let silenced = false;
+
+// Original console methods — saved before any overload is installed
+const _originalConsole = {
+  log: console.log.bind(console),
+  warn: console.warn.bind(console),
+  error: console.error.bind(console),
+  info: console.info.bind(console),
+};
+
+let consoleOverloadInstalled = false;
+
+// ---- EventService lazy accessor ---------------------------------------------
+
+function getEvents() {
+  try {
+    const { services } = require("./services") as typeof import("./services");
+    return services().Events;
+  } catch {
+    return null;
+  }
+}
+
+// ---- Core emit logic --------------------------------------------------------
+
+function emit(source: string, message: string, level: LogLevel): void {
+  if (silenced) return;
+
+  try {
+    const events = getEvents();
+    if (events) {
+      events.log(source, message, level);
+      return;
+    }
+  } catch {
+    // fall through to direct console output
+  }
+
+  // Fallback: use original console methods (bypasses any overload we installed)
+  const prefix = source ? `[${source}] ` : "";
+  if (level === "warn") _originalConsole.warn(`${prefix}${message}`);
+  else if (level === "error") _originalConsole.error(`${prefix}${message}`);
+  else _originalConsole.log(`${prefix}${message}`);
+}
+
+// ---- Bound logger (returned by Logger.of) -----------------------------------
+
+export interface BoundLogger {
+  log(message: string, level?: LogLevel): void;
+  info(message: string): void;
+  warn(message: string): void;
+  error(message: string): void;
+}
+
+function makeBoundLogger(source: string): BoundLogger {
+  return {
+    log(message: string, level: LogLevel = "info"): void {
+      emit(source, message, level);
+    },
+    info(message: string): void {
+      emit(source, message, "info");
+    },
+    warn(message: string): void {
+      emit(source, message, "warn");
+    },
+    error(message: string): void {
+      emit(source, message, "error");
+    },
+  };
+}
+
+// ---- Public API -------------------------------------------------------------
+
+export const logger = {
+  log(source: string, message: string, level: LogLevel = "info"): void {
+    emit(source, message, level);
+  },
+
+  info(source: string, message: string): void {
+    emit(source, message, "info");
+  },
+
+  warn(source: string, message: string): void {
+    emit(source, message, "warn");
+  },
+
+  error(source: string, message: string): void {
+    emit(source, message, "error");
+  },
+
+  /**
+   * Suppress all log output. Useful for commands that need clean stdout
+   * (e.g. git credential helpers). All logger.* calls and overloaded
+   * console.* calls become no-ops until unsilence() is called.
+   */
+  silence(): void {
+    silenced = true;
+  },
+
+  /**
+   * Restore log output after a silence() call.
+   */
+  unsilence(): void {
+    silenced = false;
+  },
+
+  /**
+   * Returns true if the logger is currently silenced.
+   */
+  isSilenced(): boolean {
+    return silenced;
+  },
+
+  /**
+   * Install console overload. After this call, console.log/warn/error/info
+   * all route through our closure (respecting silence mode).
+   * Safe to call multiple times — only installs once.
+   *
+   * Call this early in CLI startup (before any modules are loaded) to ensure
+   * third-party module logs don't bypass the silence mechanism.
+   */
+  installConsoleOverload(): void {
+    if (consoleOverloadInstalled) return;
+    consoleOverloadInstalled = true;
+
+    const route = (originalFn: (...args: any[]) => void, args: any[]) => {
+      if (silenced) return;
+      originalFn(...args);
+    };
+
+    console.log = (...args: any[]) => route(_originalConsole.log, args);
+    console.info = (...args: any[]) => route(_originalConsole.info, args);
+    console.warn = (...args: any[]) => route(_originalConsole.warn, args);
+    // Note: console.error is intentionally NOT overloaded — real errors (stack
+    // traces, crash reports) should always be visible. Only suppress via silence().
+    // If you want to suppress errors too, call logger.silence() which checks the flag
+    // before the overloaded console.warn/log routes reach here anyway.
+  },
+
+  /**
+   * Remove the console overload and restore original console methods.
+   */
+  uninstallConsoleOverload(): void {
+    if (!consoleOverloadInstalled) return;
+    console.log = _originalConsole.log;
+    console.info = _originalConsole.info;
+    console.warn = _originalConsole.warn;
+    consoleOverloadInstalled = false;
+  },
+};
+
+/**
+ * Factory for creating a bound logger with a fixed source name.
+ * Ideal for class-level loggers:
+ *
+ *   class MyClass {
+ *     private logger = Logger.of("MyClass");
+ *     doThing() { this.logger.info("hello"); }
+ *   }
+ */
+export const Logger = {
+  of(source: string): BoundLogger {
+    return makeBoundLogger(source);
+  },
+};

package/src/plugins/plugins.ts

@@ -1,5 +1,4 @@
 import { Plugin, PluginContext } from "./types";
-import { Config } from "../types";
 import { VimPlugin } from "./vim";
 import { LinterPlugin } from "./LinterPlugin";
 import { LanguagePlugin } from "./language";
@@ -49,26 +48,6 @@ export class PluginService {
     return instance.meta.key;
   }
 
-  /**
-   * Load plugins from config's pluginPackages map.
-   * Each entry maps a plugin key to an npm package name or file path.
-   * Errors are caught and logged as warnings without crashing.
-   */
-  async loadPluginsFromConfig(config: Config): Promise<void> {
-    const pluginPackages = config.pluginPackages || {};
-    for (const [key, spec] of Object.entries(pluginPackages)) {
-      try {
-        await this.loadPlugin(spec);
-      } catch (error) {
-        this.events?.log(
-          "PluginService",
-          `Failed to load plugin "${key}" from "${spec}": ${error instanceof Error ? error.message : error}`,
-          "warn"
-        );
-      }
-    }
-  }
-
   /** Disable a plugin by its key; returns `true` if found. */
   disablePlugin(key: string): boolean {
     const p = this.pluginMap.get(key);

package/src/processors/JsonCompressor.ts

@@ -382,7 +382,7 @@ export class JsonCompressor {
             i + currentChunk.length - 1
           }]\nPreview: ${chunkString.substring(0, 100)}...\n[Use ${
             this.toolName
-          } tool with key "${key}" to retrieve this chunk]`;
+          } tool with key "${key}" to retrieve this chunk]\n[TIP: try jqToolResponse,grepToolResponse,tailToolResponse to filter/search/map without repeated ${this.toolName} calls - especially useful for JSON data]`;
           finalArray.unshift(stub); // Add stub to the start of our final result.
 
           currentChunk = [];
@@ -415,11 +415,11 @@ export class JsonCompressor {
       
       // Store objects on FIRST occurrence so second occurrence can reference it
       // We increment seenCount above, so after increment:
-      // seenCount=1: first occurrence (just incremented from 0 to 1), store it
-      // seenCount>=2: we already stored it on first occurrence, should be in dedup map
+      // seenCount=0: first occurrence (before increment), store it
+      // seenCount>=1: we already stored it on first occurrence, should be in dedup map
       // Note: This means we store proactively - first occurrence gets stored AND returned in full
       // Second+ occurrences will find it in the dedup map and return a reference
-      const isFirstOccurrence = seenCount === 1;
+      const isFirstOccurrence = seenCount === 0;
 
       // Process the object - apply low-signal detection
       const objWithLowSignalCompressed = this.compressObjectWithLowSignalDetection(obj, path);
@@ -453,7 +453,7 @@ export class JsonCompressor {
           result
         ).join(", ")}\nPreview: ${objectAsString.substring(0, 200)}...\n[Use ${
           this.toolName
-        } tool with key "${key}" to retrieve full content]`;
+        } tool with key "${key}" to retrieve full content]\n[TIP: try jqToolResponse,grepToolResponse,tailToolResponse to filter/search/map without repeated ${this.toolName} calls - especially useful for JSON data]`;
       }
       return result;
     }
@@ -486,7 +486,7 @@ export class JsonCompressor {
           200
         )}...\n[Use ${
           this.toolName
-        } tool with key "${key}" to retrieve full content]`;
+        } tool with key "${key}" to retrieve full content]\n[TIP: try jqToolResponse,grepToolResponse,tailToolResponse to filter/search/map without repeated ${this.toolName} calls - especially useful for JSON data]`;
       }
       return obj;
     }

package/src/services/EventService.ts

@@ -1,6 +1,8 @@
 import { EventEmitter } from "events";
 import { IAgent } from "../agents/interface";
 
+export type LogLevel = "info" | "warn" | "error";
+
 export type EventHandlerFn = (...args: any[]) => any;
 
 export interface EventHandler {
@@ -31,9 +33,38 @@ type ManagedListenerRecord = {
   blocking: boolean;
 };
 
+/**
+ * Default console handler for plugin:log events.
+ * Active when no renderer has taken over (e.g. worker mode, CLI before chat starts).
+ * Can be suppressed by calling suppressDefaultLogger() when a renderer is active.
+ *
+ * IMPORTANT: Uses process.stdout/stderr directly to avoid infinite recursion
+ * with logger.installConsoleOverload() which overrides console.log/warn.
+ */
+function defaultConsoleLogHandler(event: {
+  source: string;
+  message: string;
+  level: LogLevel;
+}): void {
+  const prefix = event.source ? `[${event.source}] ` : "";
+  const line = `${prefix}${event.message}\n`;
+  switch (event.level) {
+    case "warn":
+      process.stderr.write(line);
+      break;
+    case "error":
+      process.stderr.write(line);
+      break;
+    default:
+      process.stdout.write(line);
+  }
+}
+
 export class EventService extends EventEmitter {
   private blockingHandlers: Map<string, EventHandler[]> = new Map();
   private managedListeners: Map<string, ManagedListenerRecord> = new Map();
+  private defaultLoggerActive = true;
+  private boundDefaultLogHandler = defaultConsoleLogHandler;
 
   eventTypes = {
     agentMsg: "agent:msg",
@@ -45,6 +76,35 @@ export class EventService extends EventEmitter {
   constructor() {
     super();
     this.setMaxListeners(100);
+    // Register the default console logger so Events.log() always produces output
+    // even before a renderer is attached (worker mode, module loading, etc.)
+    this.on(this.eventTypes.pluginLog, this.boundDefaultLogHandler);
+  }
+
+  /**
+   * Suppress the default console logger.
+   * Call this when a renderer has taken over and will handle plugin:log events.
+   * This prevents double-printing when both the renderer and the default handler fire.
+   */
+  suppressDefaultLogger(): void {
+    if (this.defaultLoggerActive) {
+      this.removeListener(
+        this.eventTypes.pluginLog,
+        this.boundDefaultLogHandler
+      );
+      this.defaultLoggerActive = false;
+    }
+  }
+
+  /**
+   * Restore the default console logger.
+   * Call this when the renderer is torn down.
+   */
+  restoreDefaultLogger(): void {
+    if (!this.defaultLoggerActive) {
+      this.on(this.eventTypes.pluginLog, this.boundDefaultLogHandler);
+      this.defaultLoggerActive = true;
+    }
   }
 
   /**
@@ -232,7 +292,7 @@ export class EventService extends EventEmitter {
   log(
     source: string,
     message: string,
-    level: "info" | "warn" | "error" = "info"
+    level: LogLevel = "info"
   ): void {
     this.emit(this.eventTypes.pluginLog, {
       source,

package/src/services/KnowhowClient.ts

@@ -1,3 +1,4 @@
+import { createHash } from "crypto";
 import http from "../utils/http";
 import fs from "fs";
 import { Message } from "../clients/types";
@@ -663,8 +664,10 @@ export class KnowhowSimpleClient {
   /**
    * Get presigned S3 URL for uploading a file to Knowhow FS.
    * First finds or creates the file by path, then gets its upload URL.
+   * Computes SHA256 hash of the file content and stores it as S3 metadata
+   * so any client can determine if they already have this version without downloading.
    */
-  async getOrgFilePresignedUploadUrl(filePath: string): Promise<string> {
+  async getOrgFilePresignedUploadUrl(filePath: string, localFilePath?: string): Promise<string> {
     await this.checkJwt();
 
     // Find or create the file by path
@@ -675,10 +678,17 @@ export class KnowhowSimpleClient {
     const fileName =
       lastSlash >= 0 ? filePath.substring(lastSlash + 1) : filePath;
 
+    // Compute SHA256 hash if we have the local file path, so S3 stores it as metadata
+    let sha256Hash: string | undefined;
+    if (localFilePath) {
+      const fileContent = fs.readFileSync(localFilePath);
+      sha256Hash = createHash("sha256").update(fileContent).digest("base64");
+    }
+
     // Get upload URL using the file ID
     const response = await http.post<{ uploadUrl: string }>(
       `${this.baseUrl}/api/org-files/upload/${file.id}`,
-      { fileName },
+      { fileName, sha256Hash },
       { headers: this.headers }
     );
     return response.data.uploadUrl;

package/src/services/S3.ts

@@ -1,6 +1,5 @@
 import * as fs from "fs";
 import { createWriteStream, createReadStream } from "fs";
-import * as crypto from "crypto";
 import { pipeline, Readable } from "stream";
 import * as util from "util";
 
@@ -15,19 +14,10 @@ export class S3Service {
       const fileContent = fs.readFileSync(filePath);
       const fileStats = await fs.promises.stat(filePath);
 
-      // Compute SHA-256 checksum (base64) — required when presigned URL was
-      // generated with ChecksumAlgorithm: SHA256
-      const sha256Base64 = crypto
-        .createHash("sha256")
-        .update(fileContent)
-        .digest("base64");
-
       const response = await fetch(presignedUrl, {
         method: "PUT",
         headers: {
           "Content-Length": String(fileStats.size),
-          "x-amz-checksum-sha256": sha256Base64,
-          "x-amz-sdk-checksum-algorithm": "SHA256",
         },
         body: fileContent,
         // @ts-ignore