@typespec/http-client-python 0.13.0-dev.2 → 0.13.0-dev.3

package/generator/pygen/codegen/__init__.py

@@ -4,8 +4,7 @@
 # license information.
 # --------------------------------------------------------------------------
 import logging
-from typing import Dict, Any, Union, Optional
-from pathlib import Path
+from typing import Dict, Any
 import yaml
 
 
@@ -13,223 +12,12 @@ from .. import Plugin
 from ..utils import parse_args
 from .models.code_model import CodeModel
 from .serializers import JinjaSerializer
-from ._utils import VALID_PACKAGE_MODE, TYPESPEC_PACKAGE_MODE
-
-
-def _default_pprint(package_name: str) -> str:
-    return " ".join([i.capitalize() for i in package_name.split("-")])
 
 
 _LOGGER = logging.getLogger(__name__)
 
 
-class OptionsRetriever:
-    OPTIONS_TO_DEFAULT = {
-        "azure-arm": False,
-        "flavor": "azure",  # need to default to azure in shared code so we don't break swagger generation
-        "no-async": False,
-        "low-level-client": False,
-        "version-tolerant": True,
-        "keep-version-file": False,
-        "no-namespace-folders": False,
-        "basic-setup-py": False,
-        "client-side-validation": False,
-        "multiapi": False,
-        "polymorphic-examples": 5,
-        "generate-sample": False,
-        "generate-test": False,
-        "from-typespec": False,
-        "emit-cross-language-definition-file": False,
-    }
-
-    @property
-    def is_azure_flavor(self) -> bool:
-        return self.flavor == "azure"
-
-    def __init__(self, options: Dict[str, Any]) -> None:
-        self.options = options
-
-    def __getattr__(self, prop: str) -> Any:
-        key = prop.replace("_", "-")
-        return self.options.get(key, self.OPTIONS_TO_DEFAULT.get(key))
-
-    @property
-    def show_operations(self) -> bool:
-        return self.options.get("show-operations", not self.low_level_client)
-
-    @property
-    def _models_mode_default(self) -> str:
-        models_mode_default = "none" if self.low_level_client or self.version_tolerant else "msrest"
-        if self.options.get("tsp_file") is not None:
-            models_mode_default = "dpg"
-        return models_mode_default
-
-    @property
-    def original_models_mode(self) -> str:
-        return self.options.get("models-mode", self._models_mode_default)
-
-    @property
-    def models_mode(self) -> Union[str, bool]:
-        # switch to falsy value for easier code writing
-        return False if self.original_models_mode == "none" else self.original_models_mode
-
-    @property
-    def tracing(self) -> bool:
-        return self.options.get(
-            "tracing",
-            self.show_operations and self.is_azure_flavor,
-        )
-
-    @property
-    def show_send_request(self) -> bool:
-        return self.options.get(
-            "show-send-request",
-            self._low_level_or_version_tolerant,
-        )
-
-    @property
-    def _low_level_or_version_tolerant(self) -> bool:
-        return self.low_level_client or self.version_tolerant
-
-    @property
-    def only_path_and_body_params_positional(self) -> bool:
-        return self.options.get(
-            "only-path-and-body-params-positional",
-            self._low_level_or_version_tolerant,
-        )
-
-    @property
-    def combine_operation_files(self) -> bool:
-        return self.options.get(
-            "combine-operation-files",
-            self.version_tolerant,
-        )
-
-    @property
-    def package_pprint_name(self) -> str:
-        return self.options.get("package-pprint-name") or _default_pprint(str(self.package_name))
-
-    @property
-    def validate_versioning(self) -> bool:
-        return self.options.get("validate-versioning", True)
-
-    @property
-    def default_optional_constants_to_none(self) -> bool:
-        return self.options.get(
-            "default-optional-constants-to-none",
-            self._low_level_or_version_tolerant,
-        )
-
-    @property
-    def builders_visibility(self) -> str:
-        builders_visibility = self.options.get("builders-visibility")
-        if builders_visibility is None:
-            return "public" if self.low_level_client else "embedded"
-        return builders_visibility.lower()
-
-    @property
-    def head_as_boolean(self) -> bool:
-        head_as_boolean = self.options.get("head-as-boolean", True)
-        # Force some options in ARM MODE
-        return True if self.azure_arm else head_as_boolean
-
-    @property
-    def package_mode(self) -> str:
-        return self.options.get("packaging-files-dir") or self.options.get("package-mode", "")
-
-    @property
-    def packaging_files_config(self) -> Optional[Dict[str, Any]]:
-        packaging_files_config = self.options.get("packaging-files-config")
-        if packaging_files_config is None:
-            return None
-        # packaging-files-config is either a string or a dict
-        # if it's a string, we can split on the comma to get the dict
-        # otherwise we just return
-        try:
-            return {k.strip(): v.strip() for k, v in [i.split(":") for i in packaging_files_config.split("|")]}
-        except AttributeError:
-            return packaging_files_config
-
-    @property
-    def package_version(self) -> Optional[str]:
-        return str(self.options.get("package-version", ""))
-
-    @property
-    def header_text(self) -> Optional[str]:
-        return self.options.get("header-text")
-
-
 class CodeGenerator(Plugin):
-    def __init__(self, *args, **kwargs: Any) -> None:
-        super().__init__(*args, **kwargs)
-        self.options_retriever = OptionsRetriever(self.options)
-
-    def _validate_code_model_options(self) -> None:
-        if self.options_retriever.builders_visibility not in [
-            "public",
-            "hidden",
-            "embedded",
-        ]:
-            raise ValueError("The value of --builders-visibility must be either 'public', 'hidden', or 'embedded'")
-
-        if self.options_retriever.original_models_mode not in ["msrest", "dpg", "none"]:
-            raise ValueError(
-                "--models-mode can only be 'msrest', 'dpg' or 'none'. "
-                "Pass in 'msrest' if you want msrest models, or "
-                "'none' if you don't want any."
-            )
-
-        if not self.options_retriever.show_operations and self.options_retriever.builders_visibility == "embedded":
-            raise ValueError(
-                "Can not embed builders without operations. "
-                "Either set --show-operations to True, or change the value of --builders-visibility "
-                "to 'public' or 'hidden'."
-            )
-
-        if self.options_retriever.basic_setup_py and not self.options_retriever.package_version:
-            raise ValueError("--basic-setup-py must be used with --package-version")
-
-        if self.options_retriever.package_mode and not self.options_retriever.package_version:
-            raise ValueError("--package-mode must be used with --package-version")
-
-        if not self.options_retriever.show_operations and self.options_retriever.combine_operation_files:
-            raise ValueError(
-                "Can not combine operation files if you are not showing operations. "
-                "If you want operation files, pass in flag --show-operations"
-            )
-
-        if self.options_retriever.package_mode:
-            if (
-                (
-                    self.options_retriever.package_mode not in TYPESPEC_PACKAGE_MODE
-                    and self.options_retriever.from_typespec
-                )
-                or (
-                    self.options_retriever.package_mode not in VALID_PACKAGE_MODE
-                    and not self.options_retriever.from_typespec
-                )
-            ) and not Path(self.options_retriever.package_mode).exists():
-                raise ValueError(
-                    f"--package-mode can only be {' or '.join(TYPESPEC_PACKAGE_MODE)} or directory which contains template files"  # pylint: disable=line-too-long
-                )
-
-        if self.options_retriever.multiapi and self.options_retriever.version_tolerant:
-            raise ValueError(
-                "Can not currently generate version tolerant multiapi SDKs. "
-                "We are working on creating a new multiapi SDK for version tolerant and it is not available yet."
-            )
-
-        if self.options_retriever.client_side_validation and self.options_retriever.version_tolerant:
-            raise ValueError("Can not generate version tolerant with --client-side-validation. ")
-
-        if not (self.options_retriever.azure_arm or self.options_retriever.version_tolerant):
-            _LOGGER.warning(
-                "You are generating with options that would not allow the SDK to be shipped as an official Azure SDK. "
-                "Please read https://aka.ms/azsdk/dpcodegen for more details."
-            )
-
-        if not self.options_retriever.is_azure_flavor and self.options_retriever.tracing:
-            raise ValueError("Can only have tracing turned on for Azure SDKs.")
 
     @staticmethod
     def sort_exceptions(yaml_data: Dict[str, Any]) -> None:
@@ -272,43 +60,6 @@ class CodeGenerator(Plugin):
                     del yaml_data["schemas"]["objects"][i]
                     break
 
-    def _build_code_model_options(self) -> Dict[str, Any]:
-        flags = [
-            "azure_arm",
-            "head_as_boolean",
-            "header_text",
-            "keep_version_file",
-            "no_async",
-            "no_namespace_folders",
-            "basic_setup_py",
-            "package_name",
-            "package_version",
-            "client_side_validation",
-            "tracing",
-            "multiapi",
-            "polymorphic_examples",
-            "models_mode",
-            "builders_visibility",
-            "show_operations",
-            "show_send_request",
-            "only_path_and_body_params_positional",
-            "version_tolerant",
-            "low_level_client",
-            "combine_operation_files",
-            "package_mode",
-            "package_pprint_name",
-            "packaging_files_config",
-            "default_optional_constants_to_none",
-            "generate_sample",
-            "generate_test",
-            "default_api_version",
-            "from_typespec",
-            "flavor",
-            "emit_cross_language_definition_file",
-            "validate_versioning",
-        ]
-        return {f: getattr(self.options_retriever, f) for f in flags}
-
     def get_yaml(self) -> Dict[str, Any]:
         # tsp file doesn't have to be relative to output folder
         with open(self.options["tsp_file"], "r", encoding="utf-8-sig") as fd:
@@ -319,21 +70,18 @@ class CodeGenerator(Plugin):
 
     def process(self) -> bool:
         # List the input file, should be only one
-        self._validate_code_model_options()
-        options = self._build_code_model_options()
         yaml_data = self.get_yaml()
 
         self.sort_exceptions(yaml_data)
 
-        if self.options_retriever.azure_arm:
+        if self.options["azure-arm"]:
             self.remove_cloud_errors(yaml_data)
 
-        code_model = CodeModel(yaml_data=yaml_data, options=options)
-        if not self.options_retriever.is_azure_flavor and any(client.lro_operations for client in code_model.clients):
+        code_model = CodeModel(yaml_data=yaml_data, options=self.options)
+        if self.options["flavor"] != "azure" and any(client.lro_operations for client in code_model.clients):
             raise ValueError("Only support LROs for Azure SDKs")
         serializer = self.get_serializer(code_model)
         serializer.serialize()
-
         return True
 
 

package/generator/pygen/codegen/_utils.py

@@ -35,9 +35,6 @@ DEFAULT_LICENSE_DESCRIPTION = (
     "SOFTWARE."
 )
 
-SWAGGER_PACKAGE_MODE = ["mgmtplane", "dataplane"]  # for backward compatibility
-TYPESPEC_PACKAGE_MODE = ["azure-mgmt", "azure-dataplane", "generic"]
-VALID_PACKAGE_MODE = SWAGGER_PACKAGE_MODE + TYPESPEC_PACKAGE_MODE
 NAME_LENGTH_LIMIT = 40
 
 

package/generator/pygen/codegen/models/__init__.py

@@ -165,7 +165,7 @@ def build_type(yaml_data: Dict[str, Any], code_model: CodeModel) -> BaseType:
     response: Optional[BaseType] = None
     if yaml_data["type"] == "model":
         # need to special case model to avoid recursion
-        if yaml_data["base"] == "json" or not code_model.options["models_mode"]:
+        if yaml_data["base"] == "json" or not code_model.options["models-mode"]:
             model_type = JSONModelType
         elif yaml_data["base"] == "dpg":
             model_type = DPGModelType  # type: ignore

package/generator/pygen/codegen/models/base_builder.py

@@ -75,7 +75,7 @@ class BaseBuilder(
         self.external_docs: Optional[Dict[str, Any]] = yaml_data.get("externalDocs")
         self.client_namespace: str = yaml_data.get("clientNamespace", code_model.namespace)
 
-        if code_model.options["version_tolerant"] and yaml_data.get("abstract"):
+        if code_model.options["version-tolerant"] and yaml_data.get("abstract"):
             _LOGGER.warning(
                 'Not going to generate operation "%s" because we are unable to generate this '
                 "type of operation right now. "

package/generator/pygen/codegen/models/client.py

@@ -70,7 +70,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
         self.config = Config.from_yaml(yaml_data, self.code_model)
         self.is_subclient = is_subclient
         self.request_builders = self._build_request_builders()
-        if self.code_model.options["show_operations"]:
+        if self.code_model.options["show-operations"]:
             self.operation_groups = [
                 OperationGroup.from_yaml(op_group, code_model, self)
                 for op_group in self.yaml_data.get("operationGroups", [])
@@ -91,7 +91,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
     @property
     def need_cloud_setting(self) -> bool:
         return bool(
-            self.code_model.options.get("azure_arm", False)
+            self.code_model.options.get("azure-arm", False)
             and self.credential_scopes is not None
             and self.endpoint_parameter is not None
         )
@@ -144,7 +144,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
         return request_builders
 
     def pipeline_class(self, async_mode: bool) -> str:
-        if self.code_model.options["azure_arm"]:
+        if self.code_model.options["azure-arm"]:
             if async_mode:
                 return "AsyncARMPipelineClient"
             return "ARMPipelineClient"
@@ -160,7 +160,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
     @property
     def send_request_name(self) -> str:
         """Name of the send request function"""
-        return "send_request" if self.code_model.options["show_send_request"] else "_send_request"
+        return "send_request" if self.code_model.options["show-send-request"] else "_send_request"
 
     @property
     def has_parameterized_host(self) -> bool:
@@ -186,7 +186,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
     @property
     def filename(self) -> str:
         """Name of the file for the client"""
-        if self.code_model.options["version_tolerant"] or self.code_model.options["low_level_client"]:
+        if self.code_model.options["version-tolerant"] or self.code_model.options["low-level-client"]:
             return "_client"
         return f"_{self.legacy_filename}"
 
@@ -206,7 +206,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
     def _imports_shared(self, async_mode: bool, **kwargs) -> FileImport:
         file_import = FileImport(self.code_model)
         file_import.add_submodule_import("typing", "Any", ImportType.STDLIB, TypingSection.CONDITIONAL)
-        if self.code_model.options["azure_arm"]:
+        if self.code_model.options["azure-arm"]:
             file_import.add_submodule_import("azure.mgmt.core", self.pipeline_class(async_mode), ImportType.SDKCORE)
         else:
             file_import.add_submodule_import(
@@ -241,7 +241,7 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
             "policies",
             ImportType.SDKCORE,
         )
-        if self.code_model.options["azure_arm"]:
+        if self.code_model.options["azure-arm"]:
             async_prefix = "Async" if async_mode else ""
             file_import.add_submodule_import(
                 "azure.mgmt.core.policies",
@@ -331,10 +331,10 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):  # pylint: disable=t
                 ImportType.LOCAL,
             )
 
-        if self.code_model.model_types and self.code_model.options["models_mode"] == "msrest":
+        if self.code_model.model_types and self.code_model.options["models-mode"] == "msrest":
             path_to_models = ".." if async_mode else "."
             file_import.add_submodule_import(path_to_models, "models", ImportType.LOCAL, alias="_models")
-        elif self.code_model.options["models_mode"] == "msrest":
+        elif self.code_model.options["models-mode"] == "msrest":
             # in this case, we have client_models = {} in the service client, which needs a type annotation
             # this import will always be commented, so will always add it to the typing section
             file_import.add_submodule_import("typing", "Dict", ImportType.STDLIB)
@@ -404,7 +404,7 @@ class Config(_ClientConfigBase[ConfigGlobalParameterList]):
 
     @property
     def sdk_moniker(self) -> str:
-        package_name = self.code_model.options["package_name"]
+        package_name = self.code_model.options.get("package-name")
         if package_name and package_name.startswith("azure-"):
             package_name = package_name[len("azure-") :]
         return package_name if package_name else self.yaml_data["name"].lower()
@@ -421,14 +421,14 @@ class Config(_ClientConfigBase[ConfigGlobalParameterList]):
             ImportType.SDKCORE,
         )
         file_import.add_submodule_import("typing", "Any", ImportType.STDLIB, TypingSection.CONDITIONAL)
-        if self.code_model.options["package_version"]:
+        if self.code_model.options.get("package-version"):
             serialize_namespace = kwargs.get("serialize_namespace", self.code_model.namespace)
             file_import.add_submodule_import(
                 self.code_model.get_relative_import_path(serialize_namespace, module_name="_version"),
                 "VERSION",
                 ImportType.LOCAL,
             )
-        if self.code_model.options["azure_arm"]:
+        if self.code_model.options["azure-arm"]:
             policy = "AsyncARMChallengeAuthenticationPolicy" if async_mode else "ARMChallengeAuthenticationPolicy"
             file_import.add_submodule_import("azure.mgmt.core.policies", "ARMHttpLoggingPolicy", ImportType.SDKCORE)
             file_import.add_submodule_import("azure.mgmt.core.policies", policy, ImportType.SDKCORE)

package/generator/pygen/codegen/models/code_model.py

@@ -14,10 +14,11 @@ from .request_builder import RequestBuilder, OverloadedRequestBuilder
 from .operation_group import OperationGroup
 from .utils import NamespaceType
 from .._utils import DEFAULT_HEADER_TEXT, DEFAULT_LICENSE_DESCRIPTION
+from ... import OptionsDict
 
 
 def _is_legacy(options) -> bool:
-    return not (options.get("version_tolerant") or options.get("low_level_client"))
+    return not (options.get("version-tolerant") or options.get("low-level-client"))
 
 
 def get_all_operation_groups_recursively(clients: List[Client]) -> List[OperationGroup]:
@@ -72,7 +73,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
     def __init__(
         self,
         yaml_data: Dict[str, Any],
-        options: Dict[str, Any],
+        options: OptionsDict,
     ) -> None:
         self.yaml_data = yaml_data
         self.options = options
@@ -86,7 +87,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
         self.clients: List[Client] = [
             Client.from_yaml(client_yaml_data, self) for client_yaml_data in yaml_data["clients"]
         ]
-        if self.options["models_mode"] and self.model_types:
+        if self.options["models-mode"] and self.model_types:
             self.sort_model_types()
         self.named_unions: List[CombinedType] = [
             t for t in self.types_map.values() if isinstance(t, CombinedType) and t.name
@@ -227,7 +228,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
     @property
     def rest_layer_name(self) -> str:
         """If we have a separate rest layer, what is its name?"""
-        return "rest" if self.options["builders_visibility"] == "public" else "_rest"
+        return "rest" if self.options["builders-visibility"] == "public" else "_rest"
 
     @property
     def client_filename(self) -> str:
@@ -247,12 +248,12 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
         return (
             self.need_utils_utils(async_mode, client_namespace)
             or self.need_utils_serialization
-            or self.options["models_mode"] == "dpg"
+            or self.options["models-mode"] == "dpg"
         )
 
     @property
     def need_utils_serialization(self) -> bool:
-        return not self.options["client_side_validation"]
+        return not self.options["client-side-validation"]
 
     def need_utils_utils(self, async_mode: bool, client_namespace: str) -> bool:
         return (
@@ -267,7 +268,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
             (not async_mode)
             and self.is_top_namespace(client_namespace)
             and self.has_form_data
-            and self.options["models_mode"] == "dpg"
+            and self.options["models-mode"] == "dpg"
         )
 
     def need_utils_etag(self, client_namespace: str) -> bool:
@@ -292,7 +293,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
         if client_namespace not in self._operations_folder_name:
             name = "operations"
             operation_groups = self.client_namespace_types.get(client_namespace, ClientNamespaceType()).operation_groups
-            if self.options["version_tolerant"] and all(og.is_mixin for og in operation_groups):
+            if self.options["version-tolerant"] and all(og.is_mixin for og in operation_groups):
                 name = f"_{name}"
             self._operations_folder_name[client_namespace] = name
         return self._operations_folder_name[client_namespace]
@@ -427,7 +428,7 @@ class CodeModel:  # pylint: disable=too-many-public-methods, disable=too-many-in
             license_header = self.yaml_data.get("licenseInfo", {}).get("header", "")
         else:
             # typespec azure case without custom license and swagger case
-            license_header = self.options.get("header_text") or DEFAULT_HEADER_TEXT
+            license_header = self.options.get("header-text") or DEFAULT_HEADER_TEXT
         if license_header:
             license_header = license_header.replace("\n", "\n# ")
             license_header = (

package/generator/pygen/codegen/models/enum_type.py

@@ -170,7 +170,7 @@ class EnumType(BaseType):
         :return: The type annotation for this schema
         :rtype: str
         """
-        if self.code_model.options["models_mode"]:
+        if self.code_model.options["models-mode"]:
 
             module_name = ""
             if kwargs.get("need_model_alias", True):
@@ -190,13 +190,13 @@ class EnumType(BaseType):
         return self.value_type.get_declaration(value)
 
     def docstring_text(self, **kwargs: Any) -> str:
-        if self.code_model.options["models_mode"]:
+        if self.code_model.options["models-mode"]:
             return self.name
         return self.value_type.type_annotation(**kwargs)
 
     def docstring_type(self, **kwargs: Any) -> str:
         """The python type used for RST syntax input and type annotation."""
-        if self.code_model.options["models_mode"]:
+        if self.code_model.options["models-mode"]:
             type_annotation = self.value_type.type_annotation(**kwargs)
             enum_type_annotation = f"{self.client_namespace}.models.{self.name}"
             return f"{type_annotation} or ~{enum_type_annotation}"
@@ -230,7 +230,7 @@ class EnumType(BaseType):
     def imports(self, **kwargs: Any) -> FileImport:
         file_import = FileImport(self.code_model)
         file_import.merge(self.value_type.imports(**kwargs))
-        if self.code_model.options["models_mode"]:
+        if self.code_model.options["models-mode"]:
             file_import.add_submodule_import("typing", "Union", ImportType.STDLIB, TypingSection.CONDITIONAL)
 
             serialize_namespace = kwargs.get("serialize_namespace", self.code_model.namespace)

package/generator/pygen/codegen/models/imports.py

@@ -255,7 +255,7 @@ class FileImport:
         msrest_import_type: MsrestImportType,
         typing_section: TypingSection,
     ):
-        if self.code_model.options["client_side_validation"]:
+        if self.code_model.options["client-side-validation"]:
             if msrest_import_type == MsrestImportType.Module:
                 self.add_import("msrest.serialization", ImportType.SDKCORE, typing_section)
             else:

package/generator/pygen/codegen/models/list_type.py

@@ -34,9 +34,9 @@ class ListType(BaseType):
 
     def type_annotation(self, **kwargs: Any) -> str:
         if (
-            self.code_model.options["version_tolerant"]
+            self.code_model.options["version-tolerant"]
             and self.element_type.is_xml
-            and not self.code_model.options["models_mode"]
+            and not self.code_model.options["models-mode"]
         ):
             # this means we're version tolerant XML, we just return the XML element
             return self.element_type.type_annotation(**kwargs)
@@ -68,13 +68,13 @@ class ListType(BaseType):
         return ", ".join(attrs_list)
 
     def docstring_type(self, **kwargs: Any) -> str:
-        if self.code_model.options["version_tolerant"] and self.element_type.xml_metadata:
+        if self.code_model.options["version-tolerant"] and self.element_type.xml_metadata:
             # this means we're version tolerant XML, we just return the XML element
             return self.element_type.docstring_type(**kwargs)
         return f"list[{self.element_type.docstring_type(**kwargs)}]"
 
     def docstring_text(self, **kwargs: Any) -> str:
-        if self.code_model.options["version_tolerant"] and self.element_type.xml_metadata:
+        if self.code_model.options["version-tolerant"] and self.element_type.xml_metadata:
             # this means we're version tolerant XML, we just return the XML element
             return self.element_type.docstring_text(**kwargs)
         return f"list of {self.element_type.docstring_text(**kwargs)}"
@@ -129,9 +129,9 @@ class ListType(BaseType):
     def imports(self, **kwargs: Any) -> FileImport:
         file_import = FileImport(self.code_model)
         if not (
-            self.code_model.options["version_tolerant"]
+            self.code_model.options["version-tolerant"]
             and self.element_type.is_xml
-            and not self.code_model.options["models_mode"]
+            and not self.code_model.options["models-mode"]
         ):
             file_import.add_submodule_import("typing", "List", ImportType.STDLIB, TypingSection.CONDITIONAL)
         file_import.merge(self.element_type.imports(**kwargs))

package/generator/pygen/codegen/models/lro_operation.py

@@ -125,7 +125,7 @@ class LROOperationBase(OperationBase[LROResponseType]):
                 ImportType.SDKCORE,
             )
         if (
-            self.code_model.options["models_mode"] == "dpg"
+            self.code_model.options["models-mode"] == "dpg"
             and self.lro_response
             and self.lro_response.type
             and self.lro_response.type.type == "model"