@typescript-eslint/typescript-estree 8.52.1-alpha.1 → 8.52.1-alpha.10

package/dist/check-syntax-errors.js

@@ -90,19 +90,12 @@ function checkSyntaxError(tsNode, parent, allowPattern) {
             if (node.parent.kind === SyntaxKind.VariableDeclarationList) {
                 const variableDeclarationList = node.parent;
                 const kind = (0, node_utils_1.getDeclarationKind)(variableDeclarationList);
-                if ((variableDeclarationList.parent.kind === SyntaxKind.ForInStatement ||
-                    variableDeclarationList.parent.kind === SyntaxKind.ForStatement) &&
-                    (kind === 'using' || kind === 'await using')) {
-                    if (!node.initializer) {
-                        throw (0, node_utils_1.createError)(node, `'${kind}' declarations may not be initialized in for statement.`);
+                if (kind === 'using' || kind === 'await using') {
+                    if (variableDeclarationList.parent.kind === SyntaxKind.ForInStatement) {
+                        throw (0, node_utils_1.createError)(variableDeclarationList, `The left-hand side of a 'for...in' statement cannot be a '${kind}' declaration.`);
                     }
-                    if (node.name.kind !== SyntaxKind.Identifier) {
-                        throw (0, node_utils_1.createError)(node.name, `'${kind}' declarations may not have binding patterns.`);
-                    }
-                }
-                if (variableDeclarationList.parent.kind === SyntaxKind.VariableStatement) {
-                    const variableStatement = variableDeclarationList.parent;
-                    if (kind === 'using' || kind === 'await using') {
+                    if (variableDeclarationList.parent.kind === SyntaxKind.ForStatement ||
+                        variableDeclarationList.parent.kind === SyntaxKind.VariableStatement) {
                         if (!node.initializer) {
                             throw (0, node_utils_1.createError)(node, `'${kind}' declarations must be initialized.`);
                         }
@@ -110,6 +103,9 @@ function checkSyntaxError(tsNode, parent, allowPattern) {
                             throw (0, node_utils_1.createError)(node.name, `'${kind}' declarations may not have binding patterns.`);
                         }
                     }
+                }
+                if (variableDeclarationList.parent.kind === SyntaxKind.VariableStatement) {
+                    const variableStatement = variableDeclarationList.parent;
                     const hasDeclareKeyword = (0, node_utils_1.hasModifier)(SyntaxKind.DeclareKeyword, variableStatement);
                     // Definite assignment only allowed for non-declare let and var
                     if ((hasDeclareKeyword ||
@@ -305,6 +301,12 @@ function checkSyntaxError(tsNode, parent, allowPattern) {
                     if (seenImplementsClause) {
                         throw (0, node_utils_1.createError)(heritageClause, "'implements' clause already seen.");
                     }
+                    for (const heritageType of heritageClause.types) {
+                        if (!(0, node_utils_1.isEntityNameExpression)(heritageType.expression) ||
+                            ts.isOptionalChain(heritageType.expression)) {
+                            throw (0, node_utils_1.createError)(heritageType, 'A class can only implement an identifier/qualified-name with optional type arguments.');
+                        }
+                    }
                     seenImplementsClause = true;
                 }
             }
@@ -314,12 +316,16 @@ function checkSyntaxError(tsNode, parent, allowPattern) {
             const interfaceHeritageClauses = node.heritageClauses ?? [];
             let seenExtendsClause = false;
             for (const heritageClause of interfaceHeritageClauses) {
-                if (heritageClause.token !== SyntaxKind.ExtendsKeyword) {
-                    throw (0, node_utils_1.createError)(heritageClause, 
-                    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-                    heritageClause.token === SyntaxKind.ImplementsKeyword
-                        ? "Interface declaration cannot have 'implements' clause."
-                        : 'Unexpected token.');
+                const { token, types } = heritageClause;
+                if (token === SyntaxKind.ImplementsKeyword) {
+                    throw (0, node_utils_1.createError)(heritageClause, "Interface declaration cannot have 'implements' clause.");
+                }
+                // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+                if (token !== SyntaxKind.ExtendsKeyword) {
+                    throw (0, node_utils_1.createError)(heritageClause, 'Unexpected token.');
+                }
+                if (types.length === 0) {
+                    throw (0, node_utils_1.createError)(heritageClause, `'${ts.tokenToString(token)}' list cannot be empty.`);
                 }
                 if (seenExtendsClause) {
                     throw (0, node_utils_1.createError)(heritageClause, "'extends' clause already seen.");
@@ -364,6 +370,36 @@ function checkSyntaxError(tsNode, parent, allowPattern) {
             }
             break;
         }
+        case SyntaxKind.ImportEqualsDeclaration:
+            if (node.isTypeOnly &&
+                node.moduleReference.kind !== SyntaxKind.ExternalModuleReference) {
+                throw (0, node_utils_1.createError)(node, "An import alias cannot use 'import type'");
+            }
+            break;
+        case SyntaxKind.ModuleDeclaration: {
+            if (node.flags & ts.NodeFlags.GlobalAugmentation) {
+                const { body } = node;
+                if (body == null || body.kind === SyntaxKind.ModuleDeclaration) {
+                    throw (0, node_utils_1.createError)(node.body ?? node, 'Expected a valid module body');
+                }
+                const { name } = node;
+                if (name.kind !== ts.SyntaxKind.Identifier) {
+                    throw (0, node_utils_1.createError)(name, 'global module augmentation must have an Identifier id');
+                }
+                return;
+            }
+            if (ts.isStringLiteral(node.name)) {
+                return;
+            }
+            if (node.body == null) {
+                throw (0, node_utils_1.createError)(node, 'Expected a module body');
+            }
+            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- Fixme: confirm if it's possible
+            if (node.name.kind !== ts.SyntaxKind.Identifier) {
+                throw (0, node_utils_1.createError)(node.name, '`namespace`s must have an Identifier id');
+            }
+            break;
+        }
         case SyntaxKind.ForInStatement:
         case SyntaxKind.ForOfStatement: {
             checkForStatementDeclaration(node);
@@ -386,10 +422,6 @@ function checkForStatementDeclaration(node) {
         else if (declaration.type) {
             throw (0, node_utils_1.createError)(declaration, `The variable declaration of a '${loop}' statement cannot have a type annotation.`);
         }
-        if (kind === SyntaxKind.ForInStatement &&
-            initializer.flags & ts.NodeFlags.Using) {
-            throw (0, node_utils_1.createError)(initializer, "The left-hand side of a 'for...in' statement cannot be a 'using' declaration.");
-        }
     }
     else if (!(0, node_utils_1.isValidAssignmentTarget)(initializer) &&
         initializer.kind !== SyntaxKind.ObjectLiteralExpression &&

package/dist/convert.js

@@ -1996,23 +1996,12 @@ class Converter {
                 const result = this.createNode(node, {
                     type: ts_estree_1.AST_NODE_TYPES.TSModuleDeclaration,
                     ...(() => {
-                        // the constraints checked by this function are syntactically enforced by TS
-                        // the checks mostly exist for type's sake
                         if (node.flags & ts.NodeFlags.GlobalAugmentation) {
-                            const id = this.convertChild(node.name);
-                            const body = this.convertChild(node.body);
-                            if (body == null ||
-                                body.type === ts_estree_1.AST_NODE_TYPES.TSModuleDeclaration) {
-                                this.#throwError(node.body ?? node, 'Expected a valid module body');
-                            }
-                            if (id.type !== ts_estree_1.AST_NODE_TYPES.Identifier) {
-                                this.#throwError(node.name, 'global module augmentation must have an Identifier id');
-                            }
                             return {
-                                body: body,
+                                body: this.convertChild(node.body),
                                 declare: false,
                                 global: false,
-                                id,
+                                id: this.convertChild(node.name),
                                 kind: 'global',
                             };
                         }
@@ -2029,12 +2018,6 @@ class Converter {
                         // Nested module declarations are stored in TypeScript as nested tree nodes.
                         // We "unravel" them here by making our own nested TSQualifiedName,
                         // with the innermost node's body as the actual node body.
-                        if (node.body == null) {
-                            this.#throwError(node, 'Expected a module body');
-                        }
-                        if (node.name.kind !== ts.SyntaxKind.Identifier) {
-                            this.#throwError(node.name, '`namespace`s must have an Identifier id');
-                        }
                         let name = this.createNode(node.name, {
                             type: ts_estree_1.AST_NODE_TYPES.Identifier,
                             range: [node.name.getStart(this.ast), node.name.getEnd()],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/typescript-estree",
-  "version": "8.52.1-alpha.1",
+  "version": "8.52.1-alpha.10",
   "description": "A parser that converts TypeScript source code into an ESTree compatible form",
   "files": [
     "dist",
@@ -52,10 +52,10 @@
     "typecheck": "yarn run -BT nx typecheck"
   },
   "dependencies": {
-    "@typescript-eslint/project-service": "8.52.1-alpha.1",
-    "@typescript-eslint/tsconfig-utils": "8.52.1-alpha.1",
-    "@typescript-eslint/types": "8.52.1-alpha.1",
-    "@typescript-eslint/visitor-keys": "8.52.1-alpha.1",
+    "@typescript-eslint/project-service": "8.52.1-alpha.10",
+    "@typescript-eslint/tsconfig-utils": "8.52.1-alpha.10",
+    "@typescript-eslint/types": "8.52.1-alpha.10",
+    "@typescript-eslint/visitor-keys": "8.52.1-alpha.10",
     "debug": "^4.4.3",
     "minimatch": "^9.0.5",
     "semver": "^7.7.3",