@typescript-eslint/typescript-estree 8.51.1-alpha.8 → 8.52.0

package/dist/check-syntax-errors.js

@@ -234,6 +234,31 @@ function checkSyntaxError(tsNode) {
                 throw (0, node_utils_1.createError)(node.expression, 'String literal expected.');
             }
             break;
+        case SyntaxKind.PrefixUnaryExpression:
+        case SyntaxKind.PostfixUnaryExpression: {
+            const operator = (0, node_utils_1.getTextForTokenKind)(node.operator);
+            /**
+             * ESTree uses UpdateExpression for ++/--
+             */
+            if ((operator === '++' || operator === '--') &&
+                !(0, node_utils_1.isValidAssignmentTarget)(node.operand)) {
+                throw (0, node_utils_1.createError)(node.operand, 'Invalid left-hand side expression in unary operation');
+            }
+            break;
+        }
+        case SyntaxKind.ImportDeclaration:
+            assertModuleSpecifier(node, false);
+            break;
+        case SyntaxKind.ExportDeclaration:
+            assertModuleSpecifier(node, node.exportClause?.kind === SyntaxKind.NamedExports);
+            break;
+        case SyntaxKind.CallExpression:
+            if (node.expression.kind === SyntaxKind.ImportKeyword &&
+                node.arguments.length !== 1 &&
+                node.arguments.length !== 2) {
+                throw (0, node_utils_1.createError)(node.arguments.length > 1 ? node.arguments[2] : node, 'Dynamic import requires exactly one or two arguments.');
+            }
+            break;
         case SyntaxKind.ForInStatement:
         case SyntaxKind.ForOfStatement: {
             checkForStatementDeclaration(node);
@@ -267,3 +292,12 @@ function checkForStatementDeclaration(node) {
         throw (0, node_utils_1.createError)(initializer, `The left-hand side of a '${loop}' statement must be a variable or a property access.`);
     }
 }
+function assertModuleSpecifier(node, allowNull) {
+    if (!allowNull && node.moduleSpecifier == null) {
+        throw (0, node_utils_1.createError)(node, 'Module specifier must be a string literal.');
+    }
+    if (node.moduleSpecifier &&
+        node.moduleSpecifier.kind !== SyntaxKind.StringLiteral) {
+        throw (0, node_utils_1.createError)(node.moduleSpecifier, 'Module specifier must be a string literal.');
+    }
+}

package/dist/convert.d.ts

@@ -33,7 +33,6 @@ export declare class Converter {
      * @returns the converted ESTreeNode
      */
     constructor(ast: ts.SourceFile, options?: ConverterOptions);
-    private assertModuleSpecifier;
     private convertBindingNameWithTypeAnnotation;
     /**
      * Coverts body Nodes and add a directive field to StringLiterals
@@ -78,7 +77,7 @@ export declare class Converter {
      * @param node parent used to create this node
      * @returns TypeParameterInstantiation node
      */
-    private convertTypeArgumentsToTypeParameterInstantiation;
+    private convertTypeArguments;
     /**
      * Converts a ts.Node's typeParameters to TSTypeParameterDeclaration node
      * @param typeParameters ts.Node typeParameters

package/dist/convert.js

@@ -146,15 +146,6 @@ class Converter {
         });
         return node;
     }
-    assertModuleSpecifier(node, allowNull) {
-        if (!allowNull && node.moduleSpecifier == null) {
-            this.#throwError(node, 'Module specifier must be a string literal.');
-        }
-        if (node.moduleSpecifier &&
-            node.moduleSpecifier?.kind !== SyntaxKind.StringLiteral) {
-            this.#throwError(node.moduleSpecifier, 'Module specifier must be a string literal.');
-        }
-    }
     convertBindingNameWithTypeAnnotation(name, tsType, parent) {
         const id = this.convertPattern(name);
         if (tsType) {
@@ -277,7 +268,11 @@ class Converter {
      * @param node parent used to create this node
      * @returns TypeParameterInstantiation node
      */
-    convertTypeArgumentsToTypeParameterInstantiation(typeArguments, node) {
+    convertTypeArguments(node) {
+        const { typeArguments } = node;
+        if (!typeArguments) {
+            return undefined;
+        }
         const greaterThanToken = (0, node_utils_1.findNextToken)(typeArguments, this.ast, this.ast);
         const range = [typeArguments.pos - 1, greaterThanToken.end];
         if (typeArguments.length === 0) {
@@ -1130,8 +1125,7 @@ class Converter {
                     type: ts_estree_1.AST_NODE_TYPES.TaggedTemplateExpression,
                     quasi: this.convertChild(node.template),
                     tag: this.convertChild(node.tag),
-                    typeArguments: node.typeArguments &&
-                        this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node),
+                    typeArguments: this.convertTypeArguments(node),
                 });
             }
             case SyntaxKind.TemplateHead:
@@ -1277,8 +1271,7 @@ class Converter {
                         this.convertTSTypeParametersToTypeParametersDeclaration(node.typeParameters),
                 });
                 if (extendsClause?.types[0]?.typeArguments) {
-                    result.superTypeArguments =
-                        this.convertTypeArgumentsToTypeParameterInstantiation(extendsClause.types[0].typeArguments, extendsClause.types[0]);
+                    result.superTypeArguments = this.convertTypeArguments(extendsClause.types[0]);
                 }
                 return this.fixExports(node, result);
             }
@@ -1289,7 +1282,6 @@ class Converter {
                     body: this.convertBodyExpressions(node.statements, node),
                 });
             case SyntaxKind.ImportDeclaration: {
-                this.assertModuleSpecifier(node, false);
                 const result = this.createNode(node, this.#withDeprecatedAliasGetter({
                     type: ts_estree_1.AST_NODE_TYPES.ImportDeclaration,
                     attributes: this.convertImportAttributes(node),
@@ -1342,7 +1334,6 @@ class Converter {
             }
             case SyntaxKind.ExportDeclaration: {
                 if (node.exportClause?.kind === SyntaxKind.NamedExports) {
-                    this.assertModuleSpecifier(node, true);
                     return this.createNode(node, this.#withDeprecatedAliasGetter({
                         type: ts_estree_1.AST_NODE_TYPES.ExportNamedDeclaration,
                         attributes: this.convertImportAttributes(node),
@@ -1352,7 +1343,6 @@ class Converter {
                         specifiers: this.convertChildren(node.exportClause.elements, node),
                     }, 'assertions', 'attributes', true));
                 }
-                this.assertModuleSpecifier(node, false);
                 return this.createNode(node, this.#withDeprecatedAliasGetter({
                     type: ts_estree_1.AST_NODE_TYPES.ExportAllDeclaration,
                     attributes: this.convertImportAttributes(node),
@@ -1397,9 +1387,6 @@ class Converter {
                  * ESTree uses UpdateExpression for ++/--
                  */
                 if (operator === '++' || operator === '--') {
-                    if (!(0, node_utils_1.isValidAssignmentTarget)(node.operand)) {
-                        this.#throwError(node.operand, 'Invalid left-hand side expression in unary operation');
-                    }
                     return this.createNode(node, {
                         type: ts_estree_1.AST_NODE_TYPES.UpdateExpression,
                         argument: this.convertChild(node.operand),
@@ -1506,9 +1493,6 @@ class Converter {
             }
             case SyntaxKind.CallExpression: {
                 if (node.expression.kind === SyntaxKind.ImportKeyword) {
-                    if (node.arguments.length !== 1 && node.arguments.length !== 2) {
-                        this.#throwError(node.arguments[2] ?? node, 'Dynamic import requires exactly one or two arguments.');
-                    }
                     return this.createNode(node, this.#withDeprecatedAliasGetter({
                         type: ts_estree_1.AST_NODE_TYPES.ImportExpression,
                         options: node.arguments[1]
@@ -1519,8 +1503,7 @@ class Converter {
                 }
                 const callee = this.convertChild(node.expression);
                 const args = this.convertChildren(node.arguments);
-                const typeArguments = node.typeArguments &&
-                    this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node);
+                const typeArguments = this.convertTypeArguments(node);
                 const result = this.createNode(node, {
                     type: ts_estree_1.AST_NODE_TYPES.CallExpression,
                     arguments: args,
@@ -1531,8 +1514,7 @@ class Converter {
                 return this.convertChainExpression(result, node);
             }
             case SyntaxKind.NewExpression: {
-                const typeArguments = node.typeArguments &&
-                    this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node);
+                const typeArguments = this.convertTypeArguments(node);
                 // NOTE - NewExpression cannot have an optional chain in it
                 return this.createNode(node, {
                     type: ts_estree_1.AST_NODE_TYPES.NewExpression,
@@ -1681,9 +1663,7 @@ class Converter {
                         attributes: this.convertChildren(node.attributes.properties),
                         name: this.convertJSXTagName(node.tagName, node),
                         selfClosing: true,
-                        typeArguments: node.typeArguments
-                            ? this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node)
-                            : undefined,
+                        typeArguments: this.convertTypeArguments(node),
                     }),
                 });
             }
@@ -1693,8 +1673,7 @@ class Converter {
                     attributes: this.convertChildren(node.attributes.properties),
                     name: this.convertJSXTagName(node.tagName, node),
                     selfClosing: false,
-                    typeArguments: node.typeArguments &&
-                        this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node),
+                    typeArguments: this.convertTypeArguments(node),
                 });
             }
             case SyntaxKind.JsxClosingElement:
@@ -1762,8 +1741,7 @@ class Converter {
             case SyntaxKind.TypeReference:
                 return this.createNode(node, {
                     type: ts_estree_1.AST_NODE_TYPES.TSTypeReference,
-                    typeArguments: node.typeArguments &&
-                        this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node),
+                    typeArguments: this.convertTypeArguments(node),
                     typeName: this.convertChild(node.typeName),
                 });
             case SyntaxKind.TypeParameter: {
@@ -1836,8 +1814,7 @@ class Converter {
                 return this.createNode(node, {
                     type: ts_estree_1.AST_NODE_TYPES.TSTypeQuery,
                     exprName: this.convertChild(node.exprName),
-                    typeArguments: node.typeArguments &&
-                        this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node),
+                    typeArguments: this.convertTypeArguments(node),
                 });
             case SyntaxKind.MappedType: {
                 return this.createNode(node, this.#withDeprecatedGetter({
@@ -1930,8 +1907,7 @@ class Converter {
                 return this.createNode(node, {
                     type,
                     expression: this.convertChild(node.expression),
-                    typeArguments: node.typeArguments &&
-                        this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node),
+                    typeArguments: this.convertTypeArguments(node),
                 });
             }
             case SyntaxKind.InterfaceDeclaration: {
@@ -2055,9 +2031,7 @@ class Converter {
                     options,
                     qualifier: this.convertChild(node.qualifier),
                     source,
-                    typeArguments: node.typeArguments
-                        ? this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node)
-                        : null,
+                    typeArguments: this.convertTypeArguments(node) ?? null,
                 }, 'argument', 'source', argument));
                 if (node.isTypeOf) {
                     return this.createNode(node, {
@@ -2372,7 +2346,7 @@ class Converter {
         if ('typeArguments' in node) {
             result.typeArguments =
                 node.typeArguments && 'pos' in node.typeArguments
-                    ? this.convertTypeArgumentsToTypeParameterInstantiation(node.typeArguments, node)
+                    ? this.convertTypeArguments(node)
                     : null;
         }
         if ('typeParameters' in node) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/typescript-estree",
-  "version": "8.51.1-alpha.8",
+  "version": "8.52.0",
   "description": "A parser that converts TypeScript source code into an ESTree compatible form",
   "files": [
     "dist",
@@ -52,10 +52,10 @@
     "typecheck": "yarn run -BT nx typecheck"
   },
   "dependencies": {
-    "@typescript-eslint/project-service": "8.51.1-alpha.8",
-    "@typescript-eslint/tsconfig-utils": "8.51.1-alpha.8",
-    "@typescript-eslint/types": "8.51.1-alpha.8",
-    "@typescript-eslint/visitor-keys": "8.51.1-alpha.8",
+    "@typescript-eslint/project-service": "8.52.0",
+    "@typescript-eslint/tsconfig-utils": "8.52.0",
+    "@typescript-eslint/types": "8.52.0",
+    "@typescript-eslint/visitor-keys": "8.52.0",
     "debug": "^4.4.3",
     "minimatch": "^9.0.5",
     "semver": "^7.7.3",