@typescript-eslint/typescript-estree 8.45.1-alpha.11 → 8.45.1-alpha.12

package/dist/convert.js

@@ -985,6 +985,13 @@ class Converter {
             }
             // otherwise, it is a non-type accessor - intentional fallthrough
             case SyntaxKind.MethodDeclaration: {
+                const isAbstract = (0, node_utils_1.hasModifier)(SyntaxKind.AbstractKeyword, node);
+                if (isAbstract && node.body) {
+                    this.#throwError(node.name, node.kind === SyntaxKind.GetAccessor ||
+                        node.kind === SyntaxKind.SetAccessor
+                        ? 'An abstract accessor cannot have an implementation.'
+                        : `Method '${(0, node_utils_1.declarationNameToString)(node.name, this.ast)}' cannot have an implementation because it is marked abstract.`);
+                }
                 const method = this.createNode(node, {
                     type: !node.body
                         ? ts_estree_1.AST_NODE_TYPES.TSEmptyBodyFunctionExpression
@@ -1027,7 +1034,7 @@ class Converter {
                     /**
                      * TypeScript class methods can be defined as "abstract"
                      */
-                    const methodDefinitionType = (0, node_utils_1.hasModifier)(SyntaxKind.AbstractKeyword, node)
+                    const methodDefinitionType = isAbstract
                         ? ts_estree_1.AST_NODE_TYPES.TSAbstractMethodDefinition
                         : ts_estree_1.AST_NODE_TYPES.MethodDefinition;
                     result = this.createNode(node, {
@@ -1594,6 +1601,13 @@ class Converter {
                 });
             // Binary Operations
             case SyntaxKind.BinaryExpression: {
+                if (node.operatorToken.kind !== SyntaxKind.InKeyword &&
+                    node.left.kind === SyntaxKind.PrivateIdentifier) {
+                    this.#throwError(node.left, "Private identifiers cannot appear on the right-hand-side of an 'in' expression.");
+                }
+                else if (node.right.kind === SyntaxKind.PrivateIdentifier) {
+                    this.#throwError(node.right, "Private identifiers are only allowed on the left-hand-side of an 'in' expression.");
+                }
                 // TypeScript uses BinaryExpression for sequences as well
                 if ((0, node_utils_1.isComma)(node.operatorToken)) {
                     const result = this.createNode(node, {

package/dist/node-utils.d.ts

@@ -182,4 +182,5 @@ export declare function isThisIdentifier(node: ts.Node | undefined): node is ts.
 export declare function isThisInTypeQuery(node: ts.Node): boolean;
 export declare function isValidAssignmentTarget(node: ts.Node): boolean;
 export declare function getNamespaceModifiers(node: ts.ModuleDeclaration): ts.Modifier[] | undefined;
+export declare function declarationNameToString(name: ts.Node, ast: ts.SourceFile): string;
 export {};

package/dist/node-utils.js

@@ -69,6 +69,7 @@ exports.isThisIdentifier = isThisIdentifier;
 exports.isThisInTypeQuery = isThisInTypeQuery;
 exports.isValidAssignmentTarget = isValidAssignmentTarget;
 exports.getNamespaceModifiers = getNamespaceModifiers;
+exports.declarationNameToString = declarationNameToString;
 const ts = __importStar(require("typescript"));
 const getModifiers_1 = require("./getModifiers");
 const xhtml_entities_1 = require("./jsx/xhtml-entities");
@@ -643,3 +644,8 @@ function getNamespaceModifiers(node) {
     }
     return modifiers;
 }
+// `ts.declarationNameToString`
+function declarationNameToString(name, ast) {
+    const text = ast.text.slice(name.pos, name.end).trimStart();
+    return text || '(Missing)';
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/typescript-estree",
-  "version": "8.45.1-alpha.11",
+  "version": "8.45.1-alpha.12",
   "description": "A parser that converts TypeScript source code into an ESTree compatible form",
   "files": [
     "dist",
@@ -52,10 +52,10 @@
     "typecheck": "yarn run -BT nx typecheck"
   },
   "dependencies": {
-    "@typescript-eslint/project-service": "8.45.1-alpha.11",
-    "@typescript-eslint/tsconfig-utils": "8.45.1-alpha.11",
-    "@typescript-eslint/types": "8.45.1-alpha.11",
-    "@typescript-eslint/visitor-keys": "8.45.1-alpha.11",
+    "@typescript-eslint/project-service": "8.45.1-alpha.12",
+    "@typescript-eslint/tsconfig-utils": "8.45.1-alpha.12",
+    "@typescript-eslint/types": "8.45.1-alpha.12",
+    "@typescript-eslint/visitor-keys": "8.45.1-alpha.12",
     "debug": "^4.3.4",
     "fast-glob": "^3.3.2",
     "is-glob": "^4.0.3",