@typescript-eslint/eslint-plugin 8.71.2-alpha.4 → 8.71.2-alpha.5

package/dist/rules/no-unnecessary-type-parameters.js

@@ -113,7 +113,8 @@ exports.default = (0, util_1.createRule)({
                                             grandparent.type === utils_1.AST_NODE_TYPES.TSIntersectionType ||
                                             grandparent.type === utils_1.AST_NODE_TYPES.TSUnionType ||
                                             grandparent.type === utils_1.AST_NODE_TYPES.TSConditionalType ||
-                                            grandparent.type === utils_1.AST_NODE_TYPES.TSTypeOperator;
+                                            grandparent.type === utils_1.AST_NODE_TYPES.TSTypeOperator ||
+                                            grandparent.type === utils_1.AST_NODE_TYPES.TSOptionalType;
                                         if (isWeakPrecedenceConstraint &&
                                             isWeakPrecedenceTypeParent) {
                                             yield fixer.replaceText(referenceNode.parent, `(${constraintText})`);

package/dist/rules/no-unused-vars.js

@@ -654,7 +654,8 @@ exports.default = (0, util_1.createRule)({
                 const params = context.sourceCode.getDeclaredVariables(def.node);
                 const posteriorParams = params.slice(params.indexOf(variable) + 1);
                 // If any used parameters occur after this parameter, do not report.
-                return !posteriorParams.some(v => v.references.length > 0 || v.eslintUsed);
+                return !posteriorParams.some(v => v.eslintUsed ||
+                    v.references.some(ref => !(0, isTypeOnlyReference_1.isTypeOnlyReference)(v, ref)));
             }
             const analysisResults = (0, util_1.collectVariables)(context);
             const variables = [

package/dist/rules/prefer-optional-chain-utils/analyzeChain.js

@@ -589,8 +589,32 @@ function analyzeChain(context, parserServices, options, node, operator, chain, l
             // foo !== null && foo !== undefined
             validatedOperands[validatedOperands.length - 1].comparedName);
             if (comparisonResult === compareNodes_1.NodeComparisonResult.Subset) {
-                // the operands are comparable, so we can continue searching
-                subChain.push(currentOperand);
+                if (operator === '||' &&
+                    currentOperand.comparisonType ===
+                        gatherLogicalOperands_1.NullishComparisonType.StrictEqualNull &&
+                    // A paired `[=== null, === undefined]` operand is semantically safe
+                    // because it merges to `== null`. Only a lone `=== null` can produce
+                    // a broken strict-equality check in the merged chain.
+                    validatedOperands.length === 1 &&
+                    subChain
+                        .flat()
+                        .some(operand => operand.comparisonType ===
+                        gatherLogicalOperands_1.NullishComparisonType.StrictEqualUndefined)) {
+                    // For OR chains that contain a `=== undefined` guard anywhere,
+                    // extending the chain with a lone `=== null` subset changes
+                    // semantics: when the guarded node is undefined, `node?.child`
+                    // returns `undefined`, and `undefined === null` is false (strict),
+                    // but the original `=== undefined` guard was true.
+                    //
+                    // e.g. `foo === undefined || foo.bar === null` must NOT merge to
+                    // `foo?.bar === null`, and neither should a mid-chain form like
+                    // `a == null || a.b === undefined || a.b.c === null`.
+                    maybeReportThenReset(validatedOperands);
+                }
+                else {
+                    // the operands are comparable, so we can continue searching
+                    subChain.push(currentOperand);
+                }
             }
             else if (comparisonResult === compareNodes_1.NodeComparisonResult.Invalid) {
                 maybeReportThenReset(validatedOperands);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.71.2-alpha.4",
+  "version": "8.71.2-alpha.5",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -47,10 +47,10 @@
   ],
   "dependencies": {
     "@eslint-community/regexpp": "^4.12.2",
-    "@typescript-eslint/scope-manager": "8.71.2-alpha.4",
-    "@typescript-eslint/type-utils": "8.71.2-alpha.4",
-    "@typescript-eslint/utils": "8.71.2-alpha.4",
-    "@typescript-eslint/visitor-keys": "8.71.2-alpha.4",
+    "@typescript-eslint/scope-manager": "8.71.2-alpha.5",
+    "@typescript-eslint/type-utils": "8.71.2-alpha.5",
+    "@typescript-eslint/utils": "8.71.2-alpha.5",
+    "@typescript-eslint/visitor-keys": "8.71.2-alpha.5",
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.5.0"
@@ -60,8 +60,8 @@
     "@types/mdast": "^4.0.4",
     "@types/natural-compare": "^1.4.3",
     "@types/react": "^18.3.21",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.71.2-alpha.4",
-    "@typescript-eslint/rule-tester": "8.71.2-alpha.4",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.71.2-alpha.5",
+    "@typescript-eslint/rule-tester": "8.71.2-alpha.5",
     "@typescript/native": "npm:typescript@^7.0.2",
     "@vitest/coverage-v8": "^4.0.18",
     "ajv": "^6.12.6",
@@ -81,7 +81,7 @@
     "vitest": "^4.0.18"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.71.2-alpha.4",
+    "@typescript-eslint/parser": "^8.71.2-alpha.5",
     "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
     "typescript": ">=4.8.4 <6.1.0"
   },