@typescript-eslint/eslint-plugin 8.70.2-alpha.3 → 8.70.2-alpha.4

package/dist/rules/no-unnecessary-type-assertion.d.ts

@@ -4,7 +4,7 @@ export type Options = [
         typesToIgnore?: string[];
     }
 ];
-export type MessageIds = 'contextuallyUnnecessary' | 'unnecessaryAssertion';
+export type MessageIds = 'contextuallyInferredTypeArguments' | 'contextuallyUnnecessary' | 'unnecessaryAssertion';
 declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, Options, import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
     name: string;
 };

package/dist/rules/no-unnecessary-type-assertion.js

@@ -48,6 +48,7 @@ exports.default = (0, util_1.createRule)({
         },
         fixable: 'code',
         messages: {
+            contextuallyInferredTypeArguments: 'The type arguments for this generic call may be inferred from the assertion. Specify them explicitly instead.',
             contextuallyUnnecessary: 'This assertion is unnecessary since the receiver accepts the original type of the expression.',
             unnecessaryAssertion: 'This assertion is unnecessary since it does not change the type of the expression.',
         },
@@ -381,6 +382,27 @@ exports.default = (0, util_1.createRule)({
         function hasGenericCallSignature(type) {
             return type.getCallSignatures().some(hasTypeParams);
         }
+        function getInnermostCall(expression) {
+            switch (expression.type) {
+                case utils_1.AST_NODE_TYPES.AwaitExpression:
+                    return getInnermostCall(expression.argument);
+                case utils_1.AST_NODE_TYPES.CallExpression:
+                    return expression;
+                case utils_1.AST_NODE_TYPES.ChainExpression:
+                case utils_1.AST_NODE_TYPES.TSNonNullExpression:
+                    return getInnermostCall(expression.expression);
+                case utils_1.AST_NODE_TYPES.SequenceExpression:
+                    return getInnermostCall((0, util_1.nullThrows)(expression.expressions.at(-1), 'Expected SequenceExpression to have at least one expression'));
+                default:
+                    return undefined;
+            }
+        }
+        function isGenericCallWithInferredTypeArguments(expression) {
+            const call = getInnermostCall(expression);
+            return (call != null &&
+                call.typeArguments == null &&
+                hasGenericCallSignature(services.getTypeAtLocation(call.callee)));
+        }
         function isArgumentToOverloadedFunction(node) {
             const { parent } = node;
             if ((parent.type !== utils_1.AST_NODE_TYPES.CallExpression &&
@@ -647,11 +669,19 @@ exports.default = (0, util_1.createRule)({
                     ? isImplicitlyNarrowedLiteralDeclaration(node)
                     : !typeAnnotationIsConstAssertion;
                 if (typeIsUnchanged && wouldSameTypeBeInferred) {
-                    context.report({
-                        node,
-                        messageId: 'unnecessaryAssertion',
-                        fix: createAssertionFixer(node),
-                    });
+                    if (isGenericCallWithInferredTypeArguments(node.expression)) {
+                        context.report({
+                            node,
+                            messageId: 'contextuallyInferredTypeArguments',
+                        });
+                    }
+                    else {
+                        context.report({
+                            node,
+                            messageId: 'unnecessaryAssertion',
+                            fix: createAssertionFixer(node),
+                        });
+                    }
                     return;
                 }
                 const originalNode = services.esTreeNodeToTSNodeMap.get(node);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.70.2-alpha.3",
+  "version": "8.70.2-alpha.4",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -47,10 +47,10 @@
   ],
   "dependencies": {
     "@eslint-community/regexpp": "^4.12.2",
-    "@typescript-eslint/scope-manager": "8.70.2-alpha.3",
-    "@typescript-eslint/type-utils": "8.70.2-alpha.3",
-    "@typescript-eslint/utils": "8.70.2-alpha.3",
-    "@typescript-eslint/visitor-keys": "8.70.2-alpha.3",
+    "@typescript-eslint/scope-manager": "8.70.2-alpha.4",
+    "@typescript-eslint/type-utils": "8.70.2-alpha.4",
+    "@typescript-eslint/utils": "8.70.2-alpha.4",
+    "@typescript-eslint/visitor-keys": "8.70.2-alpha.4",
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.5.0"
@@ -60,8 +60,8 @@
     "@types/mdast": "^4.0.4",
     "@types/natural-compare": "^1.4.3",
     "@types/react": "^18.3.21",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.70.2-alpha.3",
-    "@typescript-eslint/rule-tester": "8.70.2-alpha.3",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.70.2-alpha.4",
+    "@typescript-eslint/rule-tester": "8.70.2-alpha.4",
     "@typescript/native": "npm:typescript@^7.0.2",
     "@vitest/coverage-v8": "^4.0.18",
     "ajv": "^6.12.6",
@@ -81,7 +81,7 @@
     "vitest": "^4.0.18"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.70.2-alpha.3",
+    "@typescript-eslint/parser": "^8.70.2-alpha.4",
     "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
     "typescript": ">=4.8.4 <6.1.0"
   },