@typescript-eslint/eslint-plugin 8.62.2-alpha.9 → 8.63.0

package/dist/rules/method-signature-style.d.ts

@@ -1,5 +1,5 @@
 export type Options = [('method' | 'property')?];
-export type MessageIds = 'errorMethod' | 'errorProperty';
+export type MessageIds = 'convertToMethodSignature' | 'errorMethod' | 'errorProperty';
 declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, Options, import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
     name: string;
 };

package/dist/rules/method-signature-style.js

@@ -10,7 +10,9 @@ exports.default = (0, util_1.createRule)({
             description: 'Enforce using a particular method signature syntax',
         },
         fixable: 'code',
+        hasSuggestions: true,
         messages: {
+            convertToMethodSignature: 'Convert to a method signature. This removes the `readonly` modifier, allowing the member to be reassigned.',
             errorMethod: 'Shorthand method signature is forbidden. Use a function property instead.',
             errorProperty: 'Function property signature is forbidden. Use a method shorthand instead.',
         },
@@ -32,9 +34,6 @@ exports.default = (0, util_1.createRule)({
             if (node.optional) {
                 key = `${key}?`;
             }
-            if (node.readonly) {
-                key = `readonly ${key}`;
-            }
             return key;
         }
         function getMethodParams(node) {
@@ -164,16 +163,30 @@ exports.default = (0, util_1.createRule)({
                     if (typeNode?.type !== utils_1.AST_NODE_TYPES.TSFunctionType) {
                         return;
                     }
+                    const fix = fixer => {
+                        const key = getMethodKey(propertyNode);
+                        const params = getMethodParams(typeNode);
+                        const returnType = getMethodReturnType(typeNode);
+                        const delimiter = getDelimiter(propertyNode);
+                        return fixer.replaceText(propertyNode, `${key}${params}: ${returnType}${delimiter}`);
+                    };
+                    // There is no syntax for a `readonly` method signature, so converting
+                    // a `readonly` function-typed property drops the `readonly` modifier.
+                    // That is a behavioral change (a method may be reassigned, a
+                    // `readonly` property may not), so it is offered as a suggestion
+                    // rather than applied as an autofix.
+                    if (propertyNode.readonly) {
+                        context.report({
+                            node: propertyNode,
+                            messageId: 'errorProperty',
+                            suggest: [{ messageId: 'convertToMethodSignature', fix }],
+                        });
+                        return;
+                    }
                     context.report({
                         node: propertyNode,
                         messageId: 'errorProperty',
-                        fix: fixer => {
-                            const key = getMethodKey(propertyNode);
-                            const params = getMethodParams(typeNode);
-                            const returnType = getMethodReturnType(typeNode);
-                            const delimiter = getDelimiter(propertyNode);
-                            return fixer.replaceText(propertyNode, `${key}${params}: ${returnType}${delimiter}`);
-                        },
+                        fix,
                     });
                 },
             }),

package/dist/rules/no-base-to-string.js

@@ -234,7 +234,7 @@ exports.default = (0, util_1.createRule)({
                 node.arguments[0]) {
                 const scope = context.sourceCode.getScope(node);
                 // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
-                const variable = scope.set.get('String');
+                const variable = utils_1.ASTUtils.findVariable(scope, 'String');
                 return !variable?.defs.length;
             }
             return false;

package/dist/rules/no-misused-promises.js

@@ -340,11 +340,27 @@ exports.default = (0, util_1.createRule)({
         }
         function checkVariableDeclaration(node) {
             const tsNode = services.esTreeNodeToTSNodeMap.get(node);
-            if (tsNode.initializer == null ||
-                node.init == null ||
-                node.id.typeAnnotation == null) {
+            if (tsNode.initializer == null || node.init == null) {
                 return;
             }
+            if (node.parent.kind === 'using' &&
+                hasWellKnownSymbolWithThenableReturn(checker, tsNode.initializer, checker.getTypeAtLocation(tsNode.initializer), 'dispose')) {
+                context.report({
+                    node: node.init,
+                    messageId: 'voidReturnVariable',
+                });
+            }
+            if (node.id.typeAnnotation == null) {
+                return;
+            }
+            const variableType = services.getTypeAtLocation(node.id);
+            if (hasWellKnownSymbolWithVoidReturn(checker, tsNode.name, variableType, 'dispose') &&
+                hasWellKnownSymbolWithThenableReturn(checker, tsNode.initializer, checker.getTypeAtLocation(tsNode.initializer), 'dispose')) {
+                context.report({
+                    node: node.init,
+                    messageId: 'voidReturnVariable',
+                });
+            }
             // syntactically ignore some known-good cases to avoid touching type info
             if (!isPossiblyFunctionType(node.id.typeAnnotation)) {
                 return;
@@ -763,3 +779,25 @@ function isStaticMember(node) {
         node.type === utils_1.AST_NODE_TYPES.AccessorProperty) &&
         node.static);
 }
+function hasWellKnownSymbolWithThenableReturn(checker, node, type, symbolName) {
+    return tsutils
+        .unionConstituents(checker.getApparentType(type))
+        .some(typePart => {
+        const symbol = tsutils.getWellKnownSymbolPropertyOfType(typePart, symbolName, checker);
+        if (symbol == null) {
+            return false;
+        }
+        return isThenableReturningFunctionType(checker, node, checker.getTypeOfSymbolAtLocation(symbol, node));
+    });
+}
+function hasWellKnownSymbolWithVoidReturn(checker, node, type, symbolName) {
+    return tsutils
+        .unionConstituents(checker.getApparentType(type))
+        .some(typePart => {
+        const symbol = tsutils.getWellKnownSymbolPropertyOfType(typePart, symbolName, checker);
+        if (symbol == null) {
+            return false;
+        }
+        return isVoidReturningFunctionType(checker, node, checker.getTypeOfSymbolAtLocation(symbol, node));
+    });
+}

package/dist/rules/no-unnecessary-type-assertion.js

@@ -414,7 +414,11 @@ exports.default = (0, util_1.createRule)({
                 !parent.arguments.includes(node)) {
                 return false;
             }
-            const calleeType = checker.getTypeAtLocation(services.esTreeNodeToTSNodeMap.get(parent.callee));
+            // An optional-chained callee (`foo?.bar(...)`) types as `<method> | undefined`,
+            // and a union exposes no call signatures — strip the nullability first.
+            const calleeType = services
+                .getTypeAtLocation(parent.callee)
+                .getNonNullableType();
             const signatures = calleeType.getCallSignatures();
             if (signatures.length <= 1) {
                 return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.62.2-alpha.9",
+  "version": "8.63.0",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -49,10 +49,10 @@
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.5.0",
-    "@typescript-eslint/scope-manager": "8.62.2-alpha.9",
-    "@typescript-eslint/type-utils": "8.62.2-alpha.9",
-    "@typescript-eslint/utils": "8.62.2-alpha.9",
-    "@typescript-eslint/visitor-keys": "8.62.2-alpha.9"
+    "@typescript-eslint/scope-manager": "8.63.0",
+    "@typescript-eslint/type-utils": "8.63.0",
+    "@typescript-eslint/utils": "8.63.0",
+    "@typescript-eslint/visitor-keys": "8.63.0"
   },
   "devDependencies": {
     "@types/json-schema": "^7.0.15",
@@ -76,13 +76,13 @@
     "typescript": ">=4.8.4 <6.1.0",
     "unist-util-visit": "^5.0.0",
     "vitest": "^4.0.18",
-    "@typescript-eslint/rule-tester": "8.62.2-alpha.9",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.62.2-alpha.9"
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.63.0",
+    "@typescript-eslint/rule-tester": "8.63.0"
   },
   "peerDependencies": {
     "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
     "typescript": ">=4.8.4 <6.1.0",
-    "@typescript-eslint/parser": "^8.62.2-alpha.9"
+    "@typescript-eslint/parser": "^8.63.0"
   },
   "funding": {
     "type": "opencollective",