@typescript-eslint/eslint-plugin 8.62.2-alpha.16 → 8.62.2-alpha.18

package/dist/rules/no-misused-promises.js

@@ -340,11 +340,27 @@ exports.default = (0, util_1.createRule)({
         }
         function checkVariableDeclaration(node) {
             const tsNode = services.esTreeNodeToTSNodeMap.get(node);
-            if (tsNode.initializer == null ||
-                node.init == null ||
-                node.id.typeAnnotation == null) {
+            if (tsNode.initializer == null || node.init == null) {
                 return;
             }
+            if (node.parent.kind === 'using' &&
+                hasWellKnownSymbolWithThenableReturn(checker, tsNode.initializer, checker.getTypeAtLocation(tsNode.initializer), 'dispose')) {
+                context.report({
+                    node: node.init,
+                    messageId: 'voidReturnVariable',
+                });
+            }
+            if (node.id.typeAnnotation == null) {
+                return;
+            }
+            const variableType = services.getTypeAtLocation(node.id);
+            if (hasWellKnownSymbolWithVoidReturn(checker, tsNode.name, variableType, 'dispose') &&
+                hasWellKnownSymbolWithThenableReturn(checker, tsNode.initializer, checker.getTypeAtLocation(tsNode.initializer), 'dispose')) {
+                context.report({
+                    node: node.init,
+                    messageId: 'voidReturnVariable',
+                });
+            }
             // syntactically ignore some known-good cases to avoid touching type info
             if (!isPossiblyFunctionType(node.id.typeAnnotation)) {
                 return;
@@ -763,3 +779,25 @@ function isStaticMember(node) {
         node.type === utils_1.AST_NODE_TYPES.AccessorProperty) &&
         node.static);
 }
+function hasWellKnownSymbolWithThenableReturn(checker, node, type, symbolName) {
+    return tsutils
+        .unionConstituents(checker.getApparentType(type))
+        .some(typePart => {
+        const symbol = tsutils.getWellKnownSymbolPropertyOfType(typePart, symbolName, checker);
+        if (symbol == null) {
+            return false;
+        }
+        return isThenableReturningFunctionType(checker, node, checker.getTypeOfSymbolAtLocation(symbol, node));
+    });
+}
+function hasWellKnownSymbolWithVoidReturn(checker, node, type, symbolName) {
+    return tsutils
+        .unionConstituents(checker.getApparentType(type))
+        .some(typePart => {
+        const symbol = tsutils.getWellKnownSymbolPropertyOfType(typePart, symbolName, checker);
+        if (symbol == null) {
+            return false;
+        }
+        return isVoidReturningFunctionType(checker, node, checker.getTypeOfSymbolAtLocation(symbol, node));
+    });
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.62.2-alpha.16",
+  "version": "8.62.2-alpha.18",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -49,10 +49,10 @@
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.5.0",
-    "@typescript-eslint/scope-manager": "8.62.2-alpha.16",
-    "@typescript-eslint/type-utils": "8.62.2-alpha.16",
-    "@typescript-eslint/visitor-keys": "8.62.2-alpha.16",
-    "@typescript-eslint/utils": "8.62.2-alpha.16"
+    "@typescript-eslint/scope-manager": "8.62.2-alpha.18",
+    "@typescript-eslint/type-utils": "8.62.2-alpha.18",
+    "@typescript-eslint/utils": "8.62.2-alpha.18",
+    "@typescript-eslint/visitor-keys": "8.62.2-alpha.18"
   },
   "devDependencies": {
     "@types/json-schema": "^7.0.15",
@@ -76,13 +76,13 @@
     "typescript": ">=4.8.4 <6.1.0",
     "unist-util-visit": "^5.0.0",
     "vitest": "^4.0.18",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.62.2-alpha.16",
-    "@typescript-eslint/rule-tester": "8.62.2-alpha.16"
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.62.2-alpha.18",
+    "@typescript-eslint/rule-tester": "8.62.2-alpha.18"
   },
   "peerDependencies": {
     "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
     "typescript": ">=4.8.4 <6.1.0",
-    "@typescript-eslint/parser": "^8.62.2-alpha.16"
+    "@typescript-eslint/parser": "^8.62.2-alpha.18"
   },
   "funding": {
     "type": "opencollective",