@typescript-eslint/eslint-plugin 8.53.2-alpha.4 → 8.53.2-alpha.6

package/dist/rules/no-unnecessary-type-assertion.js

@@ -281,8 +281,17 @@ exports.default = (0, util_1.createRule)({
                     return;
                 }
                 const originalNode = services.esTreeNodeToTSNodeMap.get(node);
-                const type = (0, util_1.getConstrainedTypeAtLocation)(services, node.expression);
-                if (!(0, util_1.isNullableType)(type)) {
+                const constrainedType = (0, util_1.getConstrainedTypeAtLocation)(services, node.expression);
+                const actualType = services.getTypeAtLocation(node.expression);
+                // Check both the constrained type and the actual type.
+                // If either is nullable, we should not report the assertion as unnecessary.
+                // This handles cases like generic constraints with `any` where the
+                // constrained type is `any` (nullable) but the actual type might be
+                // a type parameter that TypeScript treats nominally.
+                // See: https://github.com/typescript-eslint/typescript-eslint/issues/11559
+                const constrainedTypeIsNullable = (0, util_1.isNullableType)(constrainedType);
+                const actualTypeIsNullable = (0, util_1.isNullableType)(actualType);
+                if (!constrainedTypeIsNullable && !actualTypeIsNullable) {
                     if (node.expression.type === utils_1.AST_NODE_TYPES.Identifier &&
                         isPossiblyUsedBeforeAssigned(node.expression)) {
                         return;
@@ -296,17 +305,25 @@ exports.default = (0, util_1.createRule)({
                 else {
                     // we know it's a nullable type
                     // so figure out if the variable is used in a place that accepts nullable types
+                    // If the constrained type differs from the actual type (e.g., when dealing
+                    // with unresolved generic type parameters), we should not report the assertion
+                    // as contextually unnecessary. TypeScript may still require the assertion
+                    // even if the constraint is nullable (like `any`).
+                    // See: https://github.com/typescript-eslint/typescript-eslint/issues/11559
+                    if (constrainedType !== actualType) {
+                        return;
+                    }
                     const contextualType = (0, util_1.getContextualType)(checker, originalNode);
                     if (contextualType) {
-                        if ((0, util_1.isTypeFlagSet)(type, ts.TypeFlags.Unknown) &&
+                        if ((0, util_1.isTypeFlagSet)(constrainedType, ts.TypeFlags.Unknown) &&
                             !(0, util_1.isTypeFlagSet)(contextualType, ts.TypeFlags.Unknown)) {
                             return;
                         }
                         // in strict mode you can't assign null to undefined, so we have to make sure that
                         // the two types share a nullable type
-                        const typeIncludesUndefined = (0, util_1.isTypeFlagSet)(type, ts.TypeFlags.Undefined);
-                        const typeIncludesNull = (0, util_1.isTypeFlagSet)(type, ts.TypeFlags.Null);
-                        const typeIncludesVoid = (0, util_1.isTypeFlagSet)(type, ts.TypeFlags.Void);
+                        const typeIncludesUndefined = (0, util_1.isTypeFlagSet)(constrainedType, ts.TypeFlags.Undefined);
+                        const typeIncludesNull = (0, util_1.isTypeFlagSet)(constrainedType, ts.TypeFlags.Null);
+                        const typeIncludesVoid = (0, util_1.isTypeFlagSet)(constrainedType, ts.TypeFlags.Void);
                         const contextualTypeIncludesUndefined = (0, util_1.isTypeFlagSet)(contextualType, ts.TypeFlags.Undefined);
                         const contextualTypeIncludesNull = (0, util_1.isTypeFlagSet)(contextualType, ts.TypeFlags.Null);
                         const contextualTypeIncludesVoid = (0, util_1.isTypeFlagSet)(contextualType, ts.TypeFlags.Void);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.53.2-alpha.4",
+  "version": "8.53.2-alpha.6",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.12.2",
-    "@typescript-eslint/scope-manager": "8.53.2-alpha.4",
-    "@typescript-eslint/type-utils": "8.53.2-alpha.4",
-    "@typescript-eslint/utils": "8.53.2-alpha.4",
-    "@typescript-eslint/visitor-keys": "8.53.2-alpha.4",
+    "@typescript-eslint/scope-manager": "8.53.2-alpha.6",
+    "@typescript-eslint/type-utils": "8.53.2-alpha.6",
+    "@typescript-eslint/utils": "8.53.2-alpha.6",
+    "@typescript-eslint/visitor-keys": "8.53.2-alpha.6",
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.4.0"
@@ -70,8 +70,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.4",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.53.2-alpha.4",
-    "@typescript-eslint/rule-tester": "8.53.2-alpha.4",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.53.2-alpha.6",
+    "@typescript-eslint/rule-tester": "8.53.2-alpha.6",
     "@vitest/coverage-v8": "^3.2.4",
     "ajv": "^6.12.6",
     "eslint": "*",
@@ -81,7 +81,7 @@
     "mdast-util-from-markdown": "^2.0.2",
     "mdast-util-mdx": "^3.0.0",
     "micromark-extension-mdxjs": "^3.0.0",
-    "prettier": "3.7.4",
+    "prettier": "3.8.0",
     "rimraf": "*",
     "title-case": "^4.3.2",
     "tsx": "*",
@@ -90,7 +90,7 @@
     "vitest": "^3.2.4"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.53.2-alpha.4",
+    "@typescript-eslint/parser": "^8.53.2-alpha.6",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },