@typescript-eslint/eslint-plugin 8.52.1-alpha.0 → 8.52.1-alpha.10

package/dist/rules/no-unsafe-call.d.ts

@@ -1,4 +1,4 @@
-export type MessageIds = 'unsafeCall' | 'unsafeCallThis' | 'unsafeNew' | 'unsafeTemplateTag';
+export type MessageIds = 'errorCall' | 'errorCallThis' | 'errorNew' | 'errorTemplateTag' | 'unsafeCall' | 'unsafeCallThis' | 'unsafeNew' | 'unsafeTemplateTag';
 declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
     name: string;
 };

package/dist/rules/no-unsafe-call.js

@@ -45,13 +45,17 @@ exports.default = (0, util_1.createRule)({
             requiresTypeChecking: true,
         },
         messages: {
-            unsafeCall: 'Unsafe call of a(n) {{type}} typed value.',
+            errorCall: 'Unsafe call of a type that could not be resolved.',
+            errorCallThis: 'Unsafe call of a `this` type that could not be resolved.',
+            errorNew: 'Unsafe construction of a type that could not be resolved.',
+            errorTemplateTag: 'Unsafe use of a template tag whose type could not be resolved.',
+            unsafeCall: 'Unsafe call of {{type}} typed value.',
             unsafeCallThis: [
-                'Unsafe call of a(n) {{type}} typed value. `this` is typed as {{type}}.',
+                'Unsafe call of {{type}} typed value. `this` is typed as {{type}}.',
                 'You can try to fix this by turning on the `noImplicitThis` compiler option, or adding a `this` parameter to the function.',
             ].join('\n'),
-            unsafeNew: 'Unsafe construction of a(n) {{type}} typed value.',
-            unsafeTemplateTag: 'Unsafe use of a(n) {{type}} typed template tag.',
+            unsafeNew: 'Unsafe construction of {{type}} typed value.',
+            unsafeTemplateTag: 'Unsafe use of {{type}} typed template tag.',
         },
         schema: [],
     },
@@ -60,7 +64,7 @@ exports.default = (0, util_1.createRule)({
         const services = (0, util_1.getParserServices)(context);
         const compilerOptions = services.program.getCompilerOptions();
         const isNoImplicitThis = tsutils.isStrictCompilerOptionEnabled(compilerOptions, 'noImplicitThis');
-        function checkCall(node, reportingNode, messageId) {
+        function checkCall(node, reportingNode, unsafeMessageId, errorMessageId) {
             const type = (0, util_1.getConstrainedTypeAtLocation)(services, node);
             if ((0, util_1.isTypeAnyType)(type)) {
                 if (!isNoImplicitThis) {
@@ -68,15 +72,16 @@ exports.default = (0, util_1.createRule)({
                     const thisExpression = (0, util_1.getThisExpression)(node);
                     if (thisExpression &&
                         (0, util_1.isTypeAnyType)((0, util_1.getConstrainedTypeAtLocation)(services, thisExpression))) {
-                        messageId = 'unsafeCallThis';
+                        unsafeMessageId = 'unsafeCallThis';
+                        errorMessageId = 'errorCallThis';
                     }
                 }
                 const isErrorType = tsutils.isIntrinsicErrorType(type);
                 context.report({
                     node: reportingNode,
-                    messageId,
+                    messageId: isErrorType ? errorMessageId : unsafeMessageId,
                     data: {
-                        type: isErrorType ? '`error` type' : '`any`',
+                        type: 'an `any`',
                     },
                 });
                 return;
@@ -98,7 +103,7 @@ exports.default = (0, util_1.createRule)({
                     return;
                 }
                 const callSignatures = type.getCallSignatures();
-                if (messageId === 'unsafeNew') {
+                if (unsafeMessageId === 'unsafeNew') {
                     if (callSignatures.some(signature => !tsutils.isIntrinsicVoidType(signature.getReturnType()))) {
                         return;
                     }
@@ -108,9 +113,9 @@ exports.default = (0, util_1.createRule)({
                 }
                 context.report({
                     node: reportingNode,
-                    messageId,
+                    messageId: unsafeMessageId,
                     data: {
-                        type: '`Function`',
+                        type: 'a `Function`',
                     },
                 });
                 return;
@@ -118,13 +123,13 @@ exports.default = (0, util_1.createRule)({
         }
         return {
             'CallExpression > *.callee'(node) {
-                checkCall(node, node, 'unsafeCall');
+                checkCall(node, node, 'unsafeCall', 'errorCall');
             },
             NewExpression(node) {
-                checkCall(node.callee, node, 'unsafeNew');
+                checkCall(node.callee, node, 'unsafeNew', 'errorNew');
             },
             'TaggedTemplateExpression > *.tag'(node) {
-                checkCall(node, node, 'unsafeTemplateTag');
+                checkCall(node, node, 'unsafeTemplateTag', 'errorTemplateTag');
             },
         };
     },

package/dist/rules/no-unsafe-member-access.d.ts

@@ -3,7 +3,7 @@ export type Options = [
         allowOptionalChaining?: boolean;
     }
 ];
-export type MessageIds = 'unsafeComputedMemberAccess' | 'unsafeMemberExpression' | 'unsafeThisMemberExpression';
+export type MessageIds = 'errorComputedMemberAccess' | 'errorMemberExpression' | 'errorThisMemberExpression' | 'unsafeComputedMemberAccess' | 'unsafeMemberExpression' | 'unsafeThisMemberExpression';
 declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, Options, import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
     name: string;
 };

package/dist/rules/no-unsafe-member-access.js

@@ -42,10 +42,6 @@ var State;
     State[State["Safe"] = 2] = "Safe";
     State[State["Chained"] = 3] = "Chained";
 })(State || (State = {}));
-function createDataType(type) {
-    const isErrorType = tsutils.isIntrinsicErrorType(type);
-    return isErrorType ? '`error` typed' : '`any`';
-}
 exports.default = (0, util_1.createRule)({
     name: 'no-unsafe-member-access',
     meta: {
@@ -56,8 +52,14 @@ exports.default = (0, util_1.createRule)({
             requiresTypeChecking: true,
         },
         messages: {
-            unsafeComputedMemberAccess: 'Computed name {{property}} resolves to an {{type}} value.',
-            unsafeMemberExpression: 'Unsafe member access {{property}} on an {{type}} value.',
+            errorComputedMemberAccess: 'The type of computed name {{property}} cannot be resolved.',
+            errorMemberExpression: 'Unsafe member access {{property}} on a type that cannot be resolved.',
+            errorThisMemberExpression: [
+                'Unsafe member access {{property}}. The type of `this` cannot be resolved.',
+                'You can try to fix this by turning on the `noImplicitThis` compiler option, or adding a `this` parameter to the function.',
+            ].join('\n'),
+            unsafeComputedMemberAccess: 'Computed name {{property}} resolves to an `any` value.',
+            unsafeMemberExpression: 'Unsafe member access {{property}} on an `any` value.',
             unsafeThisMemberExpression: [
                 'Unsafe member access {{property}} on an `any` value. `this` is typed as `any`.',
                 'You can try to fix this by turning on the `noImplicitThis` compiler option, or adding a `this` parameter to the function.',
@@ -116,20 +118,28 @@ exports.default = (0, util_1.createRule)({
             stateCache.set(node, state);
             if (state === State.Unsafe) {
                 const propertyName = context.sourceCode.getText(node.property);
-                let messageId = 'unsafeMemberExpression';
+                let messageId;
                 if (!isNoImplicitThis) {
                     // `this.foo` or `this.foo[bar]`
                     const thisExpression = (0, util_1.getThisExpression)(node);
-                    if (thisExpression &&
-                        (0, util_1.isTypeAnyType)((0, util_1.getConstrainedTypeAtLocation)(services, thisExpression))) {
-                        messageId = 'unsafeThisMemberExpression';
+                    if (thisExpression) {
+                        const thisType = (0, util_1.getConstrainedTypeAtLocation)(services, thisExpression);
+                        if ((0, util_1.isTypeAnyType)(thisType)) {
+                            messageId = tsutils.isIntrinsicErrorType(thisType)
+                                ? 'errorThisMemberExpression'
+                                : 'unsafeThisMemberExpression';
+                        }
                     }
                 }
+                if (!messageId) {
+                    messageId = tsutils.isIntrinsicErrorType(type)
+                        ? 'errorMemberExpression'
+                        : 'unsafeMemberExpression';
+                }
                 context.report({
                     node: node.property,
                     messageId,
                     data: {
-                        type: createDataType(type),
                         property: node.computed ? `[${propertyName}]` : `.${propertyName}`,
                     },
                 });
@@ -159,9 +169,10 @@ exports.default = (0, util_1.createRule)({
                     const propertyName = context.sourceCode.getText(node);
                     context.report({
                         node,
-                        messageId: 'unsafeComputedMemberAccess',
+                        messageId: tsutils.isIntrinsicErrorType(type)
+                            ? 'errorComputedMemberAccess'
+                            : 'unsafeComputedMemberAccess',
                         data: {
-                            type: createDataType(type),
                             property: `[${propertyName}]`,
                         },
                     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.52.1-alpha.0",
+  "version": "8.52.1-alpha.10",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.12.2",
-    "@typescript-eslint/scope-manager": "8.52.1-alpha.0",
-    "@typescript-eslint/type-utils": "8.52.1-alpha.0",
-    "@typescript-eslint/utils": "8.52.1-alpha.0",
-    "@typescript-eslint/visitor-keys": "8.52.1-alpha.0",
+    "@typescript-eslint/scope-manager": "8.52.1-alpha.10",
+    "@typescript-eslint/type-utils": "8.52.1-alpha.10",
+    "@typescript-eslint/utils": "8.52.1-alpha.10",
+    "@typescript-eslint/visitor-keys": "8.52.1-alpha.10",
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.4.0"
@@ -70,8 +70,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.4",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.52.1-alpha.0",
-    "@typescript-eslint/rule-tester": "8.52.1-alpha.0",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.52.1-alpha.10",
+    "@typescript-eslint/rule-tester": "8.52.1-alpha.10",
     "@vitest/coverage-v8": "^3.2.4",
     "ajv": "^6.12.6",
     "eslint": "*",
@@ -90,7 +90,7 @@
     "vitest": "^3.2.4"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.52.1-alpha.0",
+    "@typescript-eslint/parser": "^8.52.1-alpha.10",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },