@typescript-eslint/eslint-plugin 8.51.1-alpha.8 → 8.52.0

package/dist/rules/no-base-to-string.js

@@ -213,30 +213,19 @@ exports.default = (0, util_1.createRule)({
             if (checker.isArrayType(type)) {
                 return collectArrayCertainty(type, new Set([...visited, type]));
             }
-            const toString = checker.getPropertyOfType(type, 'toString') ??
-                checker.getPropertyOfType(type, 'toLocaleString');
-            if (!toString) {
-                // unknown
-                if (option.checkUnknown && type.flags === ts.TypeFlags.Unknown) {
-                    return Usefulness.Sometimes;
-                }
-                // e.g. any
-                return Usefulness.Always;
-            }
-            const declarations = toString.getDeclarations();
-            // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
-            if (declarations == null || declarations.length !== 1) {
-                // If there are multiple declarations, at least one of them must not be
-                // the default object toString.
-                //
-                // This may only matter for older versions of TS
-                // see https://github.com/typescript-eslint/typescript-eslint/issues/8585
-                return Usefulness.Always;
+            switch (isToStringLikeFromObject(type)) {
+                case undefined:
+                    // unknown
+                    if (option.checkUnknown && type.flags === ts.TypeFlags.Unknown) {
+                        return Usefulness.Sometimes;
+                    }
+                    // e.g. any
+                    return Usefulness.Always;
+                case true:
+                    return Usefulness.Never;
+                case false:
+                    return Usefulness.Always;
             }
-            const declaration = declarations[0];
-            const isBaseToString = ts.isInterfaceDeclaration(declaration.parent) &&
-                declaration.parent.name.text === 'Object';
-            return isBaseToString ? Usefulness.Never : Usefulness.Always;
         }
         function isBuiltInStringCall(node) {
             if (node.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
@@ -250,6 +239,53 @@ exports.default = (0, util_1.createRule)({
             }
             return false;
         }
+        function isSymbolToPrimitiveMethod(node) {
+            return (ts.isMethodSignature(node) &&
+                ts.isComputedPropertyName(node.name) &&
+                ts.isPropertyAccessExpression(node.name.expression) &&
+                ts.isIdentifier(node.name.expression.expression) &&
+                node.name.expression.expression.text === 'Symbol' &&
+                ts.isIdentifier(node.name.expression.name) &&
+                node.name.expression.name.text === 'toPrimitive' &&
+                checker
+                    .getSymbolAtLocation(node.name.expression.expression)
+                    ?.valueDeclaration?.getSourceFile().hasNoDefaultLib);
+        }
+        function isToStringLikeFromObject(type) {
+            // An explicit [Symbol.toPrimitive] declaration is always user-defined
+            if (type
+                .getProperties()
+                .some(property => property.valueDeclaration &&
+                isSymbolToPrimitiveMethod(property.valueDeclaration))) {
+                return false;
+            }
+            // Otherwise, we check for known methods used in type coercion.
+            // We'll try to find one that's not declared on Object itself.
+            // Failing that, we'll fall back to one that is.
+            let foundFallbackOnObject = false;
+            for (const propertyName of ['toLocaleString', 'toString', 'valueOf']) {
+                const candidate = checker.getPropertyOfType(type, propertyName);
+                if (!candidate) {
+                    continue;
+                }
+                const declarations = candidate.getDeclarations();
+                // If there are multiple declarations, at least one of them must not be
+                // the default object toString.
+                //
+                // This may only matter for older versions of TS
+                // see https://github.com/typescript-eslint/typescript-eslint/issues/8585
+                if (declarations?.length !== 1) {
+                    continue;
+                }
+                // Not being the Object interface means this is user-defined.
+                if (!ts.isInterfaceDeclaration(declarations[0].parent) ||
+                    declarations[0].parent.name.text !== 'Object') {
+                    return false;
+                }
+                foundFallbackOnObject = true;
+            }
+            return foundFallbackOnObject ? true : undefined;
+        }
         return {
             'AssignmentExpression[operator = "+="], BinaryExpression[operator = "+"]'(node) {
                 const leftType = services.getTypeAtLocation(node.left);

package/dist/rules/no-useless-default-assignment.js

@@ -66,13 +66,6 @@ exports.default = (0, util_1.createRule)({
                 .unionConstituents(type)
                 .some(part => (0, util_1.isTypeFlagSet)(part, ts.TypeFlags.Undefined));
         }
-        function getPropertyType(objectType, propertyName) {
-            const symbol = objectType.getProperty(propertyName);
-            if (!symbol) {
-                return null;
-            }
-            return checker.getTypeOfSymbol(symbol);
-        }
         function getArrayElementType(arrayType, elementIndex) {
             if (checker.isTupleType(arrayType)) {
                 const tupleArgs = checker.getTypeArguments(arrayType);
@@ -167,7 +160,26 @@ exports.default = (0, util_1.createRule)({
             if (!propertyName) {
                 return null;
             }
-            return getPropertyType(sourceType, propertyName);
+            const symbol = sourceType.getProperty(propertyName);
+            if (!symbol) {
+                return null;
+            }
+            if (symbol.flags & ts.SymbolFlags.Optional &&
+                hasConditionalInitializer(objectPattern)) {
+                return null;
+            }
+            return checker.getTypeOfSymbol(symbol);
+        }
+        function hasConditionalInitializer(node) {
+            const parent = node.parent;
+            if (!parent) {
+                return false;
+            }
+            if (parent.type === utils_1.AST_NODE_TYPES.VariableDeclarator && parent.init) {
+                return (parent.init.type === utils_1.AST_NODE_TYPES.ConditionalExpression ||
+                    parent.init.type === utils_1.AST_NODE_TYPES.LogicalExpression);
+            }
+            return hasConditionalInitializer(parent);
         }
         function getSourceTypeForPattern(pattern) {
             const parent = (0, util_1.nullThrows)(pattern.parent, util_1.NullThrowsReasons.MissingParent);
@@ -189,12 +201,11 @@ exports.default = (0, util_1.createRule)({
                 return getTypeOfProperty(parent);
             }
             if (parent.type === utils_1.AST_NODE_TYPES.ArrayPattern) {
-                const arrayPattern = parent;
-                const arrayType = getSourceTypeForPattern(arrayPattern);
+                const arrayType = getSourceTypeForPattern(parent);
                 if (!arrayType) {
                     return null;
                 }
-                const elementIndex = arrayPattern.elements.indexOf(pattern);
+                const elementIndex = parent.elements.indexOf(pattern);
                 return getArrayElementType(arrayType, elementIndex);
             }
             return null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.51.1-alpha.8",
+  "version": "8.52.0",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.12.2",
-    "@typescript-eslint/scope-manager": "8.51.1-alpha.8",
-    "@typescript-eslint/type-utils": "8.51.1-alpha.8",
-    "@typescript-eslint/utils": "8.51.1-alpha.8",
-    "@typescript-eslint/visitor-keys": "8.51.1-alpha.8",
+    "@typescript-eslint/scope-manager": "8.52.0",
+    "@typescript-eslint/type-utils": "8.52.0",
+    "@typescript-eslint/utils": "8.52.0",
+    "@typescript-eslint/visitor-keys": "8.52.0",
     "ignore": "^7.0.5",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.4.0"
@@ -70,8 +70,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.4",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.51.1-alpha.8",
-    "@typescript-eslint/rule-tester": "8.51.1-alpha.8",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.52.0",
+    "@typescript-eslint/rule-tester": "8.52.0",
     "@vitest/coverage-v8": "^3.2.4",
     "ajv": "^6.12.6",
     "eslint": "*",
@@ -90,7 +90,7 @@
     "vitest": "^3.2.4"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.51.1-alpha.8",
+    "@typescript-eslint/parser": "^8.52.0",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },