@typescript-eslint/eslint-plugin 8.50.2-alpha.14 → 8.50.2-alpha.16

package/dist/index.d.ts

@@ -988,7 +988,7 @@ declare const _default: {
         'no-useless-constructor': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noUselessConstructor" | "removeConstructor", [], import("../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
-        'no-useless-default-assignment': import("@typescript-eslint/utils/ts-eslint").RuleModule<"uselessDefaultAssignment" | "uselessUndefined", [], import("../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+        'no-useless-default-assignment': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferOptionalSyntax" | "uselessDefaultAssignment" | "uselessUndefined", [], import("../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
         'no-useless-empty-export': import("@typescript-eslint/utils/ts-eslint").RuleModule<"uselessExport", [], import("../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {

package/dist/raw-plugin.d.ts

@@ -1011,7 +1011,7 @@ declare const _default: {
             'no-useless-constructor': TSESLint.RuleModule<"noUselessConstructor" | "removeConstructor", [], import("../rules").ESLintPluginDocs, TSESLint.RuleListener> & {
                 name: string;
             };
-            'no-useless-default-assignment': TSESLint.RuleModule<"uselessDefaultAssignment" | "uselessUndefined", [], import("../rules").ESLintPluginDocs, TSESLint.RuleListener> & {
+            'no-useless-default-assignment': TSESLint.RuleModule<"preferOptionalSyntax" | "uselessDefaultAssignment" | "uselessUndefined", [], import("../rules").ESLintPluginDocs, TSESLint.RuleListener> & {
                 name: string;
             };
             'no-useless-empty-export': TSESLint.RuleModule<"uselessExport", [], import("../rules").ESLintPluginDocs, TSESLint.RuleListener> & {

package/dist/rules/index.d.ts

@@ -312,7 +312,7 @@ declare const rules: {
     'no-useless-constructor': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noUselessConstructor" | "removeConstructor", [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
         name: string;
     };
-    'no-useless-default-assignment': import("@typescript-eslint/utils/ts-eslint").RuleModule<"uselessDefaultAssignment" | "uselessUndefined", [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+    'no-useless-default-assignment': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferOptionalSyntax" | "uselessDefaultAssignment" | "uselessUndefined", [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
         name: string;
     };
     'no-useless-empty-export': import("@typescript-eslint/utils/ts-eslint").RuleModule<"uselessExport", [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {

package/dist/rules/no-useless-default-assignment.d.ts

@@ -1,5 +1,6 @@
-type MessageId = 'uselessDefaultAssignment' | 'uselessUndefined';
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageId, [], import("../../rules").ESLintPluginDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+import type { TSESLint } from '@typescript-eslint/utils';
+type MessageId = 'preferOptionalSyntax' | 'uselessDefaultAssignment' | 'uselessUndefined';
+declare const _default: TSESLint.RuleModule<MessageId, [], import("../../rules").ESLintPluginDocs, TSESLint.RuleListener> & {
     name: string;
 };
 export default _default;

package/dist/rules/no-useless-default-assignment.js

@@ -48,6 +48,7 @@ exports.default = (0, util_1.createRule)({
         },
         fixable: 'code',
         messages: {
+            preferOptionalSyntax: 'Using `= undefined` to make a parameter optional adds unnecessary runtime logic. Use the `?` optional syntax instead.',
             uselessDefaultAssignment: 'Default value is useless because the {{ type }} is not optional.',
             uselessUndefined: 'Default value is useless because it is undefined. Optional {{ type }}s are already undefined by default.',
         },
@@ -84,11 +85,18 @@ exports.default = (0, util_1.createRule)({
         function checkAssignmentPattern(node) {
             if (node.right.type === utils_1.AST_NODE_TYPES.Identifier &&
                 node.right.name === 'undefined') {
+                const tsNode = services.esTreeNodeToTSNodeMap.get(node);
+                if (ts.isParameter(tsNode) &&
+                    tsNode.type &&
+                    canBeUndefined(checker.getTypeFromTypeNode(tsNode.type))) {
+                    reportPreferOptionalSyntax(node);
+                    return;
+                }
                 const type = node.parent.type === utils_1.AST_NODE_TYPES.Property ||
                     node.parent.type === utils_1.AST_NODE_TYPES.ArrayPattern
                     ? 'property'
                     : 'parameter';
-                reportUselessDefault(node, type, 'uselessUndefined');
+                reportUselessUndefined(node, type);
                 return;
             }
             const parent = node.parent;
@@ -113,7 +121,7 @@ exports.default = (0, util_1.createRule)({
                             if ((paramSymbol.flags & ts.SymbolFlags.Optional) === 0) {
                                 const paramType = checker.getTypeOfSymbol(paramSymbol);
                                 if (!canBeUndefined(paramType)) {
-                                    reportUselessDefault(node, 'parameter', 'uselessDefaultAssignment');
+                                    reportUselessDefaultAssignment(node, 'parameter');
                                 }
                             }
                         }
@@ -127,7 +135,7 @@ exports.default = (0, util_1.createRule)({
                     return;
                 }
                 if (!canBeUndefined(propertyType)) {
-                    reportUselessDefault(node, 'property', 'uselessDefaultAssignment');
+                    reportUselessDefaultAssignment(node, 'property');
                 }
             }
             else if (parent.type === utils_1.AST_NODE_TYPES.ArrayPattern) {
@@ -145,7 +153,7 @@ exports.default = (0, util_1.createRule)({
                 }
                 const elementType = tupleArgs[elementIndex];
                 if (!canBeUndefined(elementType)) {
-                    reportUselessDefault(node, 'property', 'uselessDefaultAssignment');
+                    reportUselessDefaultAssignment(node, 'property');
                 }
             }
         }
@@ -201,20 +209,40 @@ exports.default = (0, util_1.createRule)({
                     return null;
             }
         }
-        function reportUselessDefault(node, type, messageId) {
+        function reportUselessDefaultAssignment(node, type) {
+            context.report({
+                node: node.right,
+                messageId: 'uselessDefaultAssignment',
+                data: { type },
+                fix: fixer => removeDefault(fixer, node),
+            });
+        }
+        function reportUselessUndefined(node, type) {
             context.report({
                 node: node.right,
-                messageId,
+                messageId: 'uselessUndefined',
                 data: { type },
-                fix(fixer) {
-                    // Remove from before the = to the end of the default value
-                    // Find the start position (including whitespace before =)
-                    const start = node.left.range[1];
-                    const end = node.range[1];
-                    return fixer.removeRange([start, end]);
+                fix: fixer => removeDefault(fixer, node),
+            });
+        }
+        function reportPreferOptionalSyntax(node) {
+            context.report({
+                node: node.right,
+                messageId: 'preferOptionalSyntax',
+                *fix(fixer) {
+                    yield removeDefault(fixer, node);
+                    const { left } = node;
+                    if (left.type === utils_1.AST_NODE_TYPES.Identifier) {
+                        yield fixer.insertTextAfterRange([left.range[0], left.range[0] + left.name.length], '?');
+                    }
                 },
             });
         }
+        function removeDefault(fixer, node) {
+            const start = node.left.range[1];
+            const end = node.range[1];
+            return fixer.removeRange([start, end]);
+        }
         return {
             AssignmentPattern: checkAssignmentPattern,
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.50.2-alpha.14",
+  "version": "8.50.2-alpha.16",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.50.2-alpha.14",
-    "@typescript-eslint/type-utils": "8.50.2-alpha.14",
-    "@typescript-eslint/utils": "8.50.2-alpha.14",
-    "@typescript-eslint/visitor-keys": "8.50.2-alpha.14",
+    "@typescript-eslint/scope-manager": "8.50.2-alpha.16",
+    "@typescript-eslint/type-utils": "8.50.2-alpha.16",
+    "@typescript-eslint/utils": "8.50.2-alpha.16",
+    "@typescript-eslint/visitor-keys": "8.50.2-alpha.16",
     "ignore": "^7.0.0",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.2.0"
@@ -70,8 +70,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.50.2-alpha.14",
-    "@typescript-eslint/rule-tester": "8.50.2-alpha.14",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.50.2-alpha.16",
+    "@typescript-eslint/rule-tester": "8.50.2-alpha.16",
     "@vitest/coverage-v8": "^3.1.3",
     "ajv": "^6.12.6",
     "eslint": "*",
@@ -90,7 +90,7 @@
     "vitest": "^3.1.3"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.50.2-alpha.14",
+    "@typescript-eslint/parser": "^8.50.2-alpha.16",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },