@typescript-eslint/eslint-plugin 8.50.1-alpha.0 → 8.50.1-alpha.2

package/dist/rules/method-signature-style.js

@@ -83,6 +83,7 @@ exports.default = (0, util_1.createRule)({
                     if (methodNode.kind !== 'method') {
                         return;
                     }
+                    const skipFix = returnTypeReferencesThisType(methodNode.returnType);
                     const parent = methodNode.parent;
                     const members = parent.type === utils_1.AST_NODE_TYPES.TSInterfaceBody
                         ? parent.body
@@ -102,32 +103,34 @@ exports.default = (0, util_1.createRule)({
                             context.report({
                                 node: methodNode,
                                 messageId: 'errorMethod',
-                                *fix(fixer) {
-                                    const methodNodes = [
-                                        methodNode,
-                                        ...duplicatedKeyMethodNodes,
-                                    ].sort((a, b) => (a.range[0] < b.range[0] ? -1 : 1));
-                                    const typeString = methodNodes
-                                        .map(node => {
-                                        const params = getMethodParams(node);
-                                        const returnType = getMethodReturnType(node);
-                                        return `(${params} => ${returnType})`;
-                                    })
-                                        .join(' & ');
-                                    const key = getMethodKey(methodNode);
-                                    const delimiter = getDelimiter(methodNode);
-                                    yield fixer.replaceText(methodNode, `${key}: ${typeString}${delimiter}`);
-                                    for (const node of duplicatedKeyMethodNodes) {
-                                        const lastToken = context.sourceCode.getLastToken(node);
-                                        if (lastToken) {
-                                            const nextToken = context.sourceCode.getTokenAfter(lastToken);
-                                            if (nextToken) {
-                                                yield fixer.remove(node);
-                                                yield fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], '');
+                                fix: skipFix
+                                    ? undefined
+                                    : function* fix(fixer) {
+                                        const methodNodes = [
+                                            methodNode,
+                                            ...duplicatedKeyMethodNodes,
+                                        ].sort((a, b) => (a.range[0] < b.range[0] ? -1 : 1));
+                                        const typeString = methodNodes
+                                            .map(node => {
+                                            const params = getMethodParams(node);
+                                            const returnType = getMethodReturnType(node);
+                                            return `(${params} => ${returnType})`;
+                                        })
+                                            .join(' & ');
+                                        const key = getMethodKey(methodNode);
+                                        const delimiter = getDelimiter(methodNode);
+                                        yield fixer.replaceText(methodNode, `${key}: ${typeString}${delimiter}`);
+                                        for (const node of duplicatedKeyMethodNodes) {
+                                            const lastToken = context.sourceCode.getLastToken(node);
+                                            if (lastToken) {
+                                                const nextToken = context.sourceCode.getTokenAfter(lastToken);
+                                                if (nextToken) {
+                                                    yield fixer.remove(node);
+                                                    yield fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], '');
+                                                }
                                             }
                                         }
-                                    }
-                                },
+                                    },
                             });
                         }
                         return;
@@ -142,13 +145,15 @@ exports.default = (0, util_1.createRule)({
                         context.report({
                             node: methodNode,
                             messageId: 'errorMethod',
-                            fix: fixer => {
-                                const key = getMethodKey(methodNode);
-                                const params = getMethodParams(methodNode);
-                                const returnType = getMethodReturnType(methodNode);
-                                const delimiter = getDelimiter(methodNode);
-                                return fixer.replaceText(methodNode, `${key}: ${params} => ${returnType}${delimiter}`);
-                            },
+                            fix: skipFix
+                                ? undefined
+                                : fixer => {
+                                    const key = getMethodKey(methodNode);
+                                    const params = getMethodParams(methodNode);
+                                    const returnType = getMethodReturnType(methodNode);
+                                    const delimiter = getDelimiter(methodNode);
+                                    return fixer.replaceText(methodNode, `${key}: ${params} => ${returnType}${delimiter}`);
+                                },
                         });
                     }
                 },
@@ -175,3 +180,7 @@ exports.default = (0, util_1.createRule)({
         };
     },
 });
+function returnTypeReferencesThisType(node) {
+    return (node &&
+        (0, util_1.forEachChildESTree)(node.typeAnnotation, child => child.type === utils_1.AST_NODE_TYPES.TSThisType));
+}

package/dist/rules/no-unnecessary-type-assertion.js

@@ -187,6 +187,30 @@ exports.default = (0, util_1.createRule)({
         function isTypeLiteral(type) {
             return type.isLiteral() || tsutils.isBooleanLiteralType(type);
         }
+        function isIIFE(expression) {
+            return (expression.type === utils_1.AST_NODE_TYPES.CallExpression &&
+                (expression.callee.type === utils_1.AST_NODE_TYPES.ArrowFunctionExpression ||
+                    expression.callee.type === utils_1.AST_NODE_TYPES.FunctionExpression));
+        }
+        function getUncastType(node) {
+            // Special handling for IIFE: extract the function's return type
+            if (isIIFE(node.expression)) {
+                const callee = node.expression.callee;
+                const functionType = services.getTypeAtLocation(callee);
+                const signatures = functionType.getCallSignatures();
+                if (signatures.length > 0) {
+                    const returnType = checker.getReturnTypeOfSignature(signatures[0]);
+                    // If the function has no explicit return type annotation and returns undefined,
+                    // treat it as void (TypeScript infers () => {} as () => undefined, but it should be void)
+                    if (callee.returnType == null &&
+                        (0, util_1.isTypeFlagSet)(returnType, ts.TypeFlags.Undefined)) {
+                        return checker.getVoidType();
+                    }
+                    return returnType;
+                }
+            }
+            return services.getTypeAtLocation(node.expression);
+        }
         return {
             'TSAsExpression, TSTypeAssertion'(node) {
                 if (options.typesToIgnore?.includes(context.sourceCode.getText(node.typeAnnotation))) {
@@ -200,7 +224,7 @@ exports.default = (0, util_1.createRule)({
                     typeAnnotationIsConstAssertion) {
                     return;
                 }
-                const uncastType = services.getTypeAtLocation(node.expression);
+                const uncastType = getUncastType(node);
                 const typeIsUnchanged = isTypeUnchanged(uncastType, castType);
                 const wouldSameTypeBeInferred = castTypeIsLiteral
                     ? isImplicitlyNarrowedLiteralDeclaration(node)

package/dist/util/astUtils.d.ts

@@ -10,3 +10,8 @@ export * from '@typescript-eslint/utils/ast-utils';
  */
 export declare function getNameLocationInGlobalDirectiveComment(sourceCode: TSESLint.SourceCode, comment: TSESTree.Comment, name: string): TSESTree.SourceLocation;
 export declare function forEachReturnStatement<T>(body: ts.Block, visitor: (stmt: ts.ReturnStatement) => T): T | undefined;
+/**
+ * Rough equivalent to ts.forEachChild for ESTree nodes.
+ * It returns the first truthy value returned by the callback, if any.
+ */
+export declare function forEachChildESTree<Result>(node: TSESTree.Node, callback: (child: TSESTree.Node) => false | Result | null | undefined): Result | undefined;

package/dist/util/astUtils.js

@@ -38,6 +38,8 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getNameLocationInGlobalDirectiveComment = getNameLocationInGlobalDirectiveComment;
 exports.forEachReturnStatement = forEachReturnStatement;
+exports.forEachChildESTree = forEachChildESTree;
+const visitor_keys_1 = require("@typescript-eslint/visitor-keys");
 const ts = __importStar(require("typescript"));
 const escapeRegExp_1 = require("./escapeRegExp");
 // deeply re-export, for convenience
@@ -95,3 +97,47 @@ function forEachReturnStatement(body, visitor) {
         return undefined;
     }
 }
+function isESTreeNodeLike(node) {
+    return (typeof node === 'object' &&
+        node != null &&
+        'type' in node &&
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
+        typeof node.type === 'string');
+}
+/**
+ * Rough equivalent to ts.forEachChild for ESTree nodes.
+ * It returns the first truthy value returned by the callback, if any.
+ */
+function forEachChildESTree(node, callback) {
+    function visit(currentNode) {
+        const result = callback(currentNode);
+        if (result) {
+            return result;
+        }
+        const currentKeys = visitor_keys_1.visitorKeys[currentNode.type];
+        if (!currentKeys) {
+            return undefined;
+        }
+        for (const key of currentKeys) {
+            const currentProperty = currentNode[key];
+            if (Array.isArray(currentProperty)) {
+                for (const child of currentProperty) {
+                    if (isESTreeNodeLike(child)) {
+                        const result = visit(child);
+                        if (result) {
+                            return result;
+                        }
+                    }
+                }
+            }
+            else if (isESTreeNodeLike(currentProperty)) {
+                const result = visit(currentProperty);
+                if (result) {
+                    return result;
+                }
+            }
+        }
+        return undefined;
+    }
+    return visit(node);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.50.1-alpha.0",
+  "version": "8.50.1-alpha.2",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.50.1-alpha.0",
-    "@typescript-eslint/type-utils": "8.50.1-alpha.0",
-    "@typescript-eslint/utils": "8.50.1-alpha.0",
-    "@typescript-eslint/visitor-keys": "8.50.1-alpha.0",
+    "@typescript-eslint/scope-manager": "8.50.1-alpha.2",
+    "@typescript-eslint/type-utils": "8.50.1-alpha.2",
+    "@typescript-eslint/utils": "8.50.1-alpha.2",
+    "@typescript-eslint/visitor-keys": "8.50.1-alpha.2",
     "ignore": "^7.0.0",
     "natural-compare": "^1.4.0",
     "ts-api-utils": "^2.1.0"
@@ -70,8 +70,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.50.1-alpha.0",
-    "@typescript-eslint/rule-tester": "8.50.1-alpha.0",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.50.1-alpha.2",
+    "@typescript-eslint/rule-tester": "8.50.1-alpha.2",
     "@vitest/coverage-v8": "^3.1.3",
     "ajv": "^6.12.6",
     "cross-fetch": "*",
@@ -91,7 +91,7 @@
     "vitest": "^3.1.3"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.50.1-alpha.0",
+    "@typescript-eslint/parser": "^8.50.1-alpha.2",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },