@typescript-eslint/eslint-plugin 8.43.1-alpha.1 → 8.43.1-alpha.3

package/dist/rules/await-thenable.d.ts

@@ -1,5 +1,5 @@
 import type { TSESLint } from '@typescript-eslint/utils';
-export type MessageId = 'await' | 'awaitUsingOfNonAsyncDisposable' | 'convertToOrdinaryFor' | 'forAwaitOfNonAsyncIterable' | 'removeAwait';
+export type MessageId = 'await' | 'awaitUsingOfNonAsyncDisposable' | 'convertToOrdinaryFor' | 'forAwaitOfNonAsyncIterable' | 'invalidPromiseAggregatorInput' | 'removeAwait';
 declare const _default: TSESLint.RuleModule<MessageId, [], import("../../rules").ESLintPluginDocs, TSESLint.RuleListener>;
 export default _default;
 //# sourceMappingURL=await-thenable.d.ts.map

package/dist/rules/await-thenable.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"await-thenable.d.ts","sourceRoot":"","sources":["../../src/rules/await-thenable.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAiBnE,MAAM,MAAM,SAAS,GACjB,OAAO,GACP,gCAAgC,GAChC,sBAAsB,GACtB,4BAA4B,GAC5B,aAAa,CAAC;;AAElB,wBAyJG"}
+{"version":3,"file":"await-thenable.d.ts","sourceRoot":"","sources":["../../src/rules/await-thenable.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAqBzD,MAAM,MAAM,SAAS,GACjB,OAAO,GACP,gCAAgC,GAChC,sBAAsB,GACtB,4BAA4B,GAC5B,+BAA+B,GAC/B,aAAa,CAAC;;AAElB,wBA0MG"}

package/dist/rules/await-thenable.js

@@ -33,9 +33,11 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("@typescript-eslint/utils");
 const tsutils = __importStar(require("ts-api-utils"));
 const util_1 = require("../util");
 const getForStatementHeadLoc_1 = require("../util/getForStatementHeadLoc");
+const isPromiseAggregatorMethod_1 = require("../util/isPromiseAggregatorMethod");
 exports.default = (0, util_1.createRule)({
     name: 'await-thenable',
     meta: {
@@ -51,6 +53,7 @@ exports.default = (0, util_1.createRule)({
             awaitUsingOfNonAsyncDisposable: 'Unexpected `await using` of a value that is not async disposable.',
             convertToOrdinaryFor: 'Convert to an ordinary `for...of` loop.',
             forAwaitOfNonAsyncIterable: 'Unexpected `for await...of` of a value that is not async iterable.',
+            invalidPromiseAggregatorInput: 'Unexpected iterable of non-Promise (non-"Thenable") values passed to promise aggregator.',
             removeAwait: 'Remove unnecessary `await`.',
         },
         schema: [],
@@ -81,6 +84,38 @@ exports.default = (0, util_1.createRule)({
                     });
                 }
             },
+            CallExpression(node) {
+                if (!(0, isPromiseAggregatorMethod_1.isPromiseAggregatorMethod)(context, services, node)) {
+                    return;
+                }
+                const argument = node.arguments.at(0);
+                if (argument == null) {
+                    return;
+                }
+                if (argument.type === utils_1.TSESTree.AST_NODE_TYPES.ArrayExpression) {
+                    for (const element of argument.elements) {
+                        if (element == null) {
+                            continue;
+                        }
+                        const type = (0, util_1.getConstrainedTypeAtLocation)(services, element);
+                        const tsNode = services.esTreeNodeToTSNodeMap.get(element);
+                        if (containsNonAwaitableType(type, tsNode, checker)) {
+                            context.report({
+                                node: element,
+                                messageId: 'invalidPromiseAggregatorInput',
+                            });
+                        }
+                    }
+                    return;
+                }
+                const type = (0, util_1.getConstrainedTypeAtLocation)(services, argument);
+                if (isInvalidPromiseAggregatorInput(checker, services.esTreeNodeToTSNodeMap.get(argument), type)) {
+                    context.report({
+                        node: argument,
+                        messageId: 'invalidPromiseAggregatorInput',
+                    });
+                }
+            },
             'ForOfStatement[await=true]'(node) {
                 const type = services.getTypeAtLocation(node.right);
                 if ((0, util_1.isTypeAnyType)(type)) {
@@ -144,3 +179,45 @@ exports.default = (0, util_1.createRule)({
         };
     },
 });
+function isInvalidPromiseAggregatorInput(checker, node, type) {
+    // non array/tuple/iterable types already show up as a type error
+    if (!isIterable(type, checker)) {
+        return false;
+    }
+    for (const part of tsutils.unionConstituents(type)) {
+        const valueTypes = getValueTypesOfArrayLike(part, checker);
+        if (valueTypes != null) {
+            for (const typeArgument of valueTypes) {
+                if (containsNonAwaitableType(typeArgument, node, checker)) {
+                    return true;
+                }
+            }
+        }
+    }
+    return false;
+}
+function getValueTypesOfArrayLike(type, checker) {
+    if (checker.isTupleType(type)) {
+        return checker.getTypeArguments(type);
+    }
+    if (checker.isArrayLikeType(type)) {
+        return [
+            (0, util_1.nullThrows)(type.getNumberIndexType(), 'number index type should exist on an array-like'),
+        ];
+    }
+    // `Iterable<...>`
+    if (tsutils.isTypeReference(type)) {
+        return checker.getTypeArguments(type).slice(0, 1);
+    }
+    return null;
+}
+function containsNonAwaitableType(type, node, checker) {
+    return tsutils
+        .unionConstituents(type)
+        .some(typeArgumentPart => (0, util_1.needsToBeAwaited)(checker, node, typeArgumentPart) === util_1.Awaitable.Never);
+}
+function isIterable(type, checker) {
+    return tsutils
+        .unionConstituents(type)
+        .every(part => !!tsutils.getWellKnownSymbolPropertyOfType(part, 'iterator', checker));
+}

package/dist/rules/prefer-string-starts-ends-with.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-string-starts-ends-with.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-string-starts-ends-with.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAqBnE,KAAK,4BAA4B,GAAG,QAAQ,GAAG,OAAO,CAAC;AAEvD,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,0BAA0B,CAAC,EAAE,4BAA4B,CAAC;KAC3D;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAAG,gBAAgB,GAAG,kBAAkB,CAAC;;AAE/D,wBAkrBG"}
+{"version":3,"file":"prefer-string-starts-ends-with.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-string-starts-ends-with.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAEV,QAAQ,EAET,MAAM,0BAA0B,CAAC;AAqBlC,KAAK,4BAA4B,GAAG,QAAQ,GAAG,OAAO,CAAC;AAEvD,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,0BAA0B,CAAC,EAAE,4BAA4B,CAAC;KAC3D;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAAG,gBAAgB,GAAG,kBAAkB,CAAC;;AAE/D,wBA+qBG"}

package/dist/rules/prefer-string-starts-ends-with.js

@@ -260,9 +260,9 @@ exports.default = (0, util_1.createRule)({
             yield fixer.removeRange([callNode.range[1], node.range[1]]);
         }
         function getParent(node) {
-            return (0, util_1.nullThrows)(node.parent?.type === utils_1.AST_NODE_TYPES.ChainExpression
+            return node.parent.type === utils_1.AST_NODE_TYPES.ChainExpression
                 ? node.parent.parent
-                : node.parent, util_1.NullThrowsReasons.MissingParent);
+                : node.parent;
         }
         return {
             // foo[0] === "a"

package/dist/util/explicitReturnTypeUtils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"explicitReturnTypeUtils.d.ts","sourceRoot":"","sources":["../../src/util/explicitReturnTypeUtils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAWnE,MAAM,MAAM,kBAAkB,GAC1B,QAAQ,CAAC,uBAAuB,GAChC,QAAQ,CAAC,kBAAkB,CAAC;AAChC,MAAM,MAAM,YAAY,GAAG,kBAAkB,GAAG,QAAQ,CAAC,mBAAmB,CAAC;AAE7E,MAAM,WAAW,YAAY,CAAC,CAAC,SAAS,YAAY;IAClD,IAAI,EAAE,CAAC,CAAC;IACR,OAAO,EAAE,QAAQ,CAAC,eAAe,EAAE,CAAC;CACrC;AA6HD;;;;;;;;;;GAUG;AACH,wBAAgB,uCAAuC,CAAC,EACtD,IAAI,EACJ,OAAO,GACR,EAAE,YAAY,CAAC,YAAY,CAAC,GAAG,OAAO,CAetC;AAyBD,UAAU,OAAO;IACf,yCAAyC,CAAC,EAAE,OAAO,CAAC;IACpD,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B,yBAAyB,CAAC,EAAE,OAAO,CAAC;IACpC,6BAA6B,CAAC,EAAE,OAAO,CAAC;CACzC;AAED;;GAEG;AACH,wBAAgB,yBAAyB,CACvC,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,OAAO,GACf,OAAO,CAeT;AAED;;;GAGG;AACH,wBAAgB,mCAAmC,CACjD,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,OAAO,GACf,OAAO,CAiCT;AAuBD;;GAEG;AACH,wBAAgB,uBAAuB,CACrC,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,YAAY,CAAC,YAAY,CAAC,EAC7C,OAAO,EAAE,OAAO,EAChB,UAAU,EAAE,QAAQ,CAAC,UAAU,EAC/B,MAAM,EAAE,CAAC,GAAG,EAAE,QAAQ,CAAC,cAAc,KAAK,IAAI,GAC7C,IAAI,CAMN;AAED;;GAEG;AACH,wBAAgB,iCAAiC,CAC/C,IAAI,EAAE,YAAY,CAAC,kBAAkB,CAAC,EACtC,OAAO,EAAE,OAAO,EAChB,UAAU,EAAE,QAAQ,CAAC,UAAU,EAC/B,MAAM,EAAE,CAAC,GAAG,EAAE,QAAQ,CAAC,cAAc,KAAK,IAAI,GAC7C,IAAI,CAMN;AAED;;GAEG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,YAAY,GAAG,OAAO,CAyCjE"}
+{"version":3,"file":"explicitReturnTypeUtils.d.ts","sourceRoot":"","sources":["../../src/util/explicitReturnTypeUtils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAOnE,MAAM,MAAM,kBAAkB,GAC1B,QAAQ,CAAC,uBAAuB,GAChC,QAAQ,CAAC,kBAAkB,CAAC;AAChC,MAAM,MAAM,YAAY,GAAG,kBAAkB,GAAG,QAAQ,CAAC,mBAAmB,CAAC;AAE7E,MAAM,WAAW,YAAY,CAAC,CAAC,SAAS,YAAY;IAClD,IAAI,EAAE,CAAC,CAAC;IACR,OAAO,EAAE,QAAQ,CAAC,eAAe,EAAE,CAAC;CACrC;AA6HD;;;;;;;;;;GAUG;AACH,wBAAgB,uCAAuC,CAAC,EACtD,IAAI,EACJ,OAAO,GACR,EAAE,YAAY,CAAC,YAAY,CAAC,GAAG,OAAO,CAetC;AAyBD,UAAU,OAAO;IACf,yCAAyC,CAAC,EAAE,OAAO,CAAC;IACpD,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B,yBAAyB,CAAC,EAAE,OAAO,CAAC;IACpC,6BAA6B,CAAC,EAAE,OAAO,CAAC;CACzC;AAED;;GAEG;AACH,wBAAgB,yBAAyB,CACvC,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,OAAO,GACf,OAAO,CAUT;AAED;;;GAGG;AACH,wBAAgB,mCAAmC,CACjD,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,OAAO,GACf,OAAO,CA6BT;AAuBD;;GAEG;AACH,wBAAgB,uBAAuB,CACrC,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,YAAY,CAAC,YAAY,CAAC,EAC7C,OAAO,EAAE,OAAO,EAChB,UAAU,EAAE,QAAQ,CAAC,UAAU,EAC/B,MAAM,EAAE,CAAC,GAAG,EAAE,QAAQ,CAAC,cAAc,KAAK,IAAI,GAC7C,IAAI,CAMN;AAED;;GAEG;AACH,wBAAgB,iCAAiC,CAC/C,IAAI,EAAE,YAAY,CAAC,kBAAkB,CAAC,EACtC,OAAO,EAAE,OAAO,EAChB,UAAU,EAAE,QAAQ,CAAC,UAAU,EAC/B,MAAM,EAAE,CAAC,GAAG,EAAE,QAAQ,CAAC,cAAc,KAAK,IAAI,GAC7C,IAAI,CAMN;AAED;;GAEG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,YAAY,GAAG,OAAO,CAyCjE"}

package/dist/util/explicitReturnTypeUtils.js

@@ -136,13 +136,12 @@ function isConstAssertion(node) {
  * True when the provided function expression is typed.
  */
 function isTypedFunctionExpression(node, options) {
-    const parent = utils_1.ESLintUtils.nullThrows(node.parent, utils_1.ESLintUtils.NullThrowsReasons.MissingParent);
     if (!options.allowTypedFunctionExpressions) {
         return false;
     }
-    return (isTypedParent(parent, node) ||
-        isPropertyOfObjectWithType(parent) ||
-        isConstructorArgument(parent));
+    return (isTypedParent(node.parent, node) ||
+        isPropertyOfObjectWithType(node.parent) ||
+        isConstructorArgument(node.parent));
 }
 /**
  * Check whether the function expression return type is either typed or valid
@@ -152,12 +151,11 @@ function isValidFunctionExpressionReturnType(node, options) {
     if (isTypedFunctionExpression(node, options)) {
         return true;
     }
-    const parent = utils_1.ESLintUtils.nullThrows(node.parent, utils_1.ESLintUtils.NullThrowsReasons.MissingParent);
     if (options.allowExpressions &&
-        parent.type !== utils_1.AST_NODE_TYPES.VariableDeclarator &&
-        parent.type !== utils_1.AST_NODE_TYPES.MethodDefinition &&
-        parent.type !== utils_1.AST_NODE_TYPES.ExportDefaultDeclaration &&
-        parent.type !== utils_1.AST_NODE_TYPES.PropertyDefinition) {
+        node.parent.type !== utils_1.AST_NODE_TYPES.VariableDeclarator &&
+        node.parent.type !== utils_1.AST_NODE_TYPES.MethodDefinition &&
+        node.parent.type !== utils_1.AST_NODE_TYPES.ExportDefaultDeclaration &&
+        node.parent.type !== utils_1.AST_NODE_TYPES.PropertyDefinition) {
         return true;
     }
     // https://github.com/typescript-eslint/typescript-eslint/issues/653

package/dist/util/isPromiseAggregatorMethod.d.ts

@@ -0,0 +1,4 @@
+import type { ParserServicesWithTypeInformation, TSESTree } from '@typescript-eslint/utils';
+import type { RuleContext } from '@typescript-eslint/utils/ts-eslint';
+export declare function isPromiseAggregatorMethod(context: RuleContext<string, unknown[]>, services: ParserServicesWithTypeInformation, node: TSESTree.CallExpression): boolean;
+//# sourceMappingURL=isPromiseAggregatorMethod.d.ts.map

package/dist/util/isPromiseAggregatorMethod.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"isPromiseAggregatorMethod.d.ts","sourceRoot":"","sources":["../../src/util/isPromiseAggregatorMethod.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,iCAAiC,EACjC,QAAQ,EACT,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oCAAoC,CAAC;AAiBtE,wBAAgB,yBAAyB,CACvC,OAAO,EAAE,WAAW,CAAC,MAAM,EAAE,OAAO,EAAE,CAAC,EACvC,QAAQ,EAAE,iCAAiC,EAC3C,IAAI,EAAE,QAAQ,CAAC,cAAc,GAC5B,OAAO,CAeT"}

package/dist/util/isPromiseAggregatorMethod.js

@@ -0,0 +1,22 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isPromiseAggregatorMethod = isPromiseAggregatorMethod;
+const type_utils_1 = require("@typescript-eslint/type-utils");
+const utils_1 = require("@typescript-eslint/utils");
+const misc_1 = require("./misc");
+const PROMISE_CONSTRUCTOR_ARRAY_METHODS = new Set([
+    'all',
+    'allSettled',
+    'race',
+    'any',
+]);
+function isPromiseAggregatorMethod(context, services, node) {
+    if (node.callee.type !== utils_1.AST_NODE_TYPES.MemberExpression) {
+        return false;
+    }
+    const staticAccessValue = (0, misc_1.getStaticMemberAccessValue)(node.callee, context);
+    if (!PROMISE_CONSTRUCTOR_ARRAY_METHODS.has(staticAccessValue)) {
+        return false;
+    }
+    return (0, type_utils_1.isPromiseConstructorLike)(services.program, (0, type_utils_1.getConstrainedTypeAtLocation)(services, node.callee.object));
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.43.1-alpha.1",
+  "version": "8.43.1-alpha.3",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -59,10 +59,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.43.1-alpha.1",
-    "@typescript-eslint/type-utils": "8.43.1-alpha.1",
-    "@typescript-eslint/utils": "8.43.1-alpha.1",
-    "@typescript-eslint/visitor-keys": "8.43.1-alpha.1",
+    "@typescript-eslint/scope-manager": "8.43.1-alpha.3",
+    "@typescript-eslint/type-utils": "8.43.1-alpha.3",
+    "@typescript-eslint/utils": "8.43.1-alpha.3",
+    "@typescript-eslint/visitor-keys": "8.43.1-alpha.3",
     "graphemer": "^1.4.0",
     "ignore": "^7.0.0",
     "natural-compare": "^1.4.0",
@@ -71,8 +71,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.43.1-alpha.1",
-    "@typescript-eslint/rule-tester": "8.43.1-alpha.1",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.43.1-alpha.3",
+    "@typescript-eslint/rule-tester": "8.43.1-alpha.3",
     "@vitest/coverage-v8": "^3.1.3",
     "ajv": "^6.12.6",
     "cross-fetch": "*",
@@ -92,7 +92,7 @@
     "vitest": "^3.1.3"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.43.1-alpha.1",
+    "@typescript-eslint/parser": "^8.43.1-alpha.3",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <6.0.0"
   },