@typescript-eslint/eslint-plugin 8.28.0 → 8.28.1-alpha.1

package/dist/rules/no-unnecessary-condition.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-unnecessary-condition.d.ts","sourceRoot":"","sources":["../../src/rules/no-unnecessary-condition.ts"],"names":[],"mappings":"AAyHA,KAAK,iCAAiC,GAAG,OAAO,CAAC;AAEjD,KAAK,2BAA2B,GAAG,QAAQ,GAAG,OAAO,GAAG,uBAAuB,CAAC;AAShF,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,2BAA2B,CAAC,EACxB,2BAA2B,GAC3B,iCAAiC,CAAC;QACtC,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,mBAAmB,CAAC,EAAE,OAAO,CAAC;KAC/B;CACF,CAAC;AAEF,MAAM,MAAM,SAAS,GACjB,aAAa,GACb,iBAAiB,GACjB,eAAe,GACf,cAAc,GACd,kBAAkB,GAClB,+BAA+B,GAC/B,OAAO,GACP,cAAc,GACd,oBAAoB,GACpB,4BAA4B,GAC5B,mBAAmB,GACnB,wBAAwB,CAAC;;AAE7B,wBAgwBG"}
+{"version":3,"file":"no-unnecessary-condition.d.ts","sourceRoot":"","sources":["../../src/rules/no-unnecessary-condition.ts"],"names":[],"mappings":"AAyHA,KAAK,iCAAiC,GAAG,OAAO,CAAC;AAEjD,KAAK,2BAA2B,GAAG,QAAQ,GAAG,OAAO,GAAG,uBAAuB,CAAC;AAShF,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,2BAA2B,CAAC,EACxB,2BAA2B,GAC3B,iCAAiC,CAAC;QACtC,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,mBAAmB,CAAC,EAAE,OAAO,CAAC;KAC/B;CACF,CAAC;AAEF,MAAM,MAAM,SAAS,GACjB,aAAa,GACb,iBAAiB,GACjB,eAAe,GACf,cAAc,GACd,kBAAkB,GAClB,+BAA+B,GAC/B,OAAO,GACP,cAAc,GACd,oBAAoB,GACpB,4BAA4B,GAC5B,mBAAmB,GACnB,wBAAwB,CAAC;;AAE7B,wBAowBG"}

package/dist/rules/no-unnecessary-condition.js

@@ -258,7 +258,7 @@ exports.default = (0, util_1.createRule)({
             // Since typescript array index signature types don't represent the
             //  possibility of out-of-bounds access, if we're indexing into an array
             //  just skip the check, to avoid false positives
-            if (isArrayIndexExpression(expression)) {
+            if (!isNoUncheckedIndexedAccess && isArrayIndexExpression(expression)) {
                 return;
             }
             // When checking logical expressions, only check the right side
@@ -308,10 +308,11 @@ exports.default = (0, util_1.createRule)({
                 // Since typescript array index signature types don't represent the
                 //  possibility of out-of-bounds access, if we're indexing into an array
                 //  just skip the check, to avoid false positives
-                if (!isArrayIndexExpression(node) &&
-                    !(node.type === utils_1.AST_NODE_TYPES.ChainExpression &&
-                        node.expression.type !== utils_1.AST_NODE_TYPES.TSNonNullExpression &&
-                        optionChainContainsOptionArrayIndex(node.expression))) {
+                if (isNoUncheckedIndexedAccess ||
+                    (!isArrayIndexExpression(node) &&
+                        !(node.type === utils_1.AST_NODE_TYPES.ChainExpression &&
+                            node.expression.type !== utils_1.AST_NODE_TYPES.TSNonNullExpression &&
+                            optionChainContainsOptionArrayIndex(node.expression)))) {
                     messageId = 'neverNullish';
                 }
             }
@@ -598,7 +599,8 @@ exports.default = (0, util_1.createRule)({
             // Since typescript array index signature types don't represent the
             //  possibility of out-of-bounds access, if we're indexing into an array
             //  just skip the check, to avoid false positives
-            if (optionChainContainsOptionArrayIndex(node)) {
+            if (!isNoUncheckedIndexedAccess &&
+                optionChainContainsOptionArrayIndex(node)) {
                 return;
             }
             const nodeToCheck = node.type === utils_1.AST_NODE_TYPES.CallExpression ? node.callee : node.object;

package/dist/rules/prefer-nullish-coalescing.d.ts

@@ -4,6 +4,7 @@ export type Options = [
         allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing?: boolean;
         ignoreBooleanCoercion?: boolean;
         ignoreConditionalTests?: boolean;
+        ignoreIfStatements?: boolean;
         ignoreMixedLogicalExpressions?: boolean;
         ignorePrimitives?: {
             bigint?: boolean;

package/dist/rules/prefer-nullish-coalescing.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-nullish-coalescing.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-nullish-coalescing.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAqCnE,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,qBAAqB,CAAC,EAAE,OAAO,CAAC;QAChC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,gBAAgB,CAAC,EACb;YACE,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,OAAO,CAAC,EAAE,OAAO,CAAC;YAClB,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,MAAM,CAAC,EAAE,OAAO,CAAC;SAClB,GACD,IAAI,CAAC;QACT,kBAAkB,CAAC,EAAE,OAAO,CAAC;KAC9B;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,6BAA6B,GAC7B,qBAAqB,GACrB,0BAA0B,GAC1B,gBAAgB,CAAC;;AAErB,wBAujBG"}
+{"version":3,"file":"prefer-nullish-coalescing.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-nullish-coalescing.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAqCnE,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,qBAAqB,CAAC,EAAE,OAAO,CAAC;QAChC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,kBAAkB,CAAC,EAAE,OAAO,CAAC;QAC7B,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,gBAAgB,CAAC,EACb;YACE,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,OAAO,CAAC,EAAE,OAAO,CAAC;YAClB,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,MAAM,CAAC,EAAE,OAAO,CAAC;SAClB,GACD,IAAI,CAAC;QACT,kBAAkB,CAAC,EAAE,OAAO,CAAC;KAC9B;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,6BAA6B,GAC7B,qBAAqB,GACrB,0BAA0B,GAC1B,gBAAgB,CAAC;;AAErB,wBA8jBG"}

package/dist/rules/prefer-nullish-coalescing.js

@@ -79,6 +79,10 @@ exports.default = (0, util_1.createRule)({
                         type: 'boolean',
                         description: 'Whether to ignore cases that are located within a conditional test.',
                     },
+                    ignoreIfStatements: {
+                        type: 'boolean',
+                        description: 'Whether to ignore any if statements that could be simplified by using the nullish coalescing operator.',
+                    },
                     ignoreMixedLogicalExpressions: {
                         type: 'boolean',
                         description: 'Whether to ignore any logical or expressions that are part of a mixed logical expression (with `&&`).',
@@ -128,6 +132,7 @@ exports.default = (0, util_1.createRule)({
             allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
             ignoreBooleanCoercion: false,
             ignoreConditionalTests: true,
+            ignoreIfStatements: false,
             ignoreMixedLogicalExpressions: false,
             ignorePrimitives: {
                 bigint: false,
@@ -138,7 +143,7 @@ exports.default = (0, util_1.createRule)({
             ignoreTernaryTests: false,
         },
     ],
-    create(context, [{ allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing, ignoreBooleanCoercion, ignoreConditionalTests, ignoreMixedLogicalExpressions, ignorePrimitives, ignoreTernaryTests, },]) {
+    create(context, [{ allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing, ignoreBooleanCoercion, ignoreConditionalTests, ignoreIfStatements, ignoreMixedLogicalExpressions, ignorePrimitives, ignoreTernaryTests, },]) {
         const parserServices = (0, util_1.getParserServices)(context);
         const compilerOptions = parserServices.program.getCompilerOptions();
         const isStrictNullChecks = tsutils.isStrictCompilerOptionEnabled(compilerOptions, 'strictNullChecks');
@@ -369,7 +374,7 @@ exports.default = (0, util_1.createRule)({
                 }
             },
             IfStatement(node) {
-                if (node.alternate != null) {
+                if (ignoreIfStatements || node.alternate != null) {
                     return;
                 }
                 let assignmentExpression;

package/dist/rules/use-unknown-in-catch-callback-variable.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"use-unknown-in-catch-callback-variable.d.ts","sourceRoot":"","sources":["../../src/rules/use-unknown-in-catch-callback-variable.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAgBnE,MAAM,MAAM,UAAU,GAClB,wCAAwC,GACxC,oCAAoC,GACpC,YAAY,GACZ,qCAAqC,GACrC,sCAAsC,GACtC,mCAAmC,GACnC,+BAA+B,CAAC;;AAKpC,wBAmSG"}
+{"version":3,"file":"use-unknown-in-catch-callback-variable.d.ts","sourceRoot":"","sources":["../../src/rules/use-unknown-in-catch-callback-variable.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAgBnE,MAAM,MAAM,UAAU,GAClB,wCAAwC,GACxC,oCAAoC,GACpC,YAAY,GACZ,qCAAqC,GACrC,sCAAsC,GACtC,mCAAmC,GACnC,+BAA+B,CAAC;;AAKpC,wBAkSG"}

package/dist/rules/use-unknown-in-catch-callback-variable.js

@@ -46,7 +46,6 @@ exports.default = (0, util_1.createRule)({
             recommended: 'strict',
             requiresTypeChecking: true,
         },
-        fixable: 'code',
         hasSuggestions: true,
         messages: {
             addUnknownRestTypeAnnotationSuggestion: 'Add an explicit `: [unknown]` type annotation to the rejection callback rest variable.',

package/dist/util/isAssignee.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"isAssignee.d.ts","sourceRoot":"","sources":["../../src/util/isAssignee.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAIzD,wBAAgB,UAAU,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,OAAO,CAoDvD"}
+{"version":3,"file":"isAssignee.d.ts","sourceRoot":"","sources":["../../src/util/isAssignee.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAIzD,wBAAgB,UAAU,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,OAAO,CA+DvD"}

package/dist/util/isAssignee.js

@@ -38,5 +38,13 @@ function isAssignee(node) {
         isAssignee(parent.parent)) {
         return true;
     }
+    // (a[i] as number)++, [...a[i]!] = [0], etc.
+    if ((parent.type === utils_1.AST_NODE_TYPES.TSNonNullExpression ||
+        parent.type === utils_1.AST_NODE_TYPES.TSAsExpression ||
+        parent.type === utils_1.AST_NODE_TYPES.TSTypeAssertion ||
+        parent.type === utils_1.AST_NODE_TYPES.TSSatisfiesExpression) &&
+        isAssignee(parent)) {
+        return true;
+    }
     return false;
 }

package/docs/rules/no-unsafe-argument.mdx

@@ -45,10 +45,10 @@ foo('a', ...tuple2, anyTyped);
 
 declare function bar(arg1: string, arg2: number, ...rest: string[]): void;
 const x = [1, 2] as [number, ...number[]];
-foo('a', ...x, anyTyped);
+bar('a', ...x, anyTyped);
 
 declare function baz(arg1: Set<string>, arg2: Map<string, string>): void;
-foo(new Set<any>(), new Map<any, string>());
+baz(new Set<any>(), new Map<any, string>());
 ```
 
 </TabItem>
@@ -67,7 +67,7 @@ const array: string[] = ['a'];
 bar('a', 1, ...array);
 
 declare function baz(arg1: Set<string>, arg2: Map<string, string>): void;
-foo(new Set<string>(), new Map<string, string>());
+baz(new Set<string>(), new Map<string, string>());
 ```
 
 </TabItem>

package/docs/rules/prefer-nullish-coalescing.mdx

@@ -118,6 +118,49 @@ c ?? 'a string';
 </TabItem>
 </Tabs>
 
+### `ignoreIfStatements`
+
+{/* insert option description */}
+
+Examples of code for this rule with `{ ignoreIfStatements: false }`:
+
+<Tabs>
+<TabItem value="❌ Incorrect">
+
+```ts option='{ "ignoreIfStatements": false }'
+declare let foo: { a: string } | null;
+declare function makeFoo(): { a: string };
+
+function lazyInitializeFoo1() {
+  if (!foo) {
+    foo = makeFoo();
+  }
+}
+
+function lazyInitializeFoo2() {
+  if (!foo) foo = makeFoo();
+}
+```
+
+</TabItem>
+<TabItem value="✅ Correct">
+
+```ts option='{ "ignoreIfStatements": false }'
+declare let foo: { a: string } | null;
+declare function makeFoo(): { a: string };
+
+function lazyInitializeFoo1() {
+  foo ??= makeFoo();
+}
+
+function lazyInitializeFoo2() {
+  foo ??= makeFoo();
+}
+```
+
+</TabItem>
+</Tabs>
+
 ### `ignoreConditionalTests`
 
 {/* insert option description */}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.28.0",
+  "version": "8.28.1-alpha.1",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -62,10 +62,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.28.0",
-    "@typescript-eslint/type-utils": "8.28.0",
-    "@typescript-eslint/utils": "8.28.0",
-    "@typescript-eslint/visitor-keys": "8.28.0",
+    "@typescript-eslint/scope-manager": "8.28.1-alpha.1",
+    "@typescript-eslint/type-utils": "8.28.1-alpha.1",
+    "@typescript-eslint/utils": "8.28.1-alpha.1",
+    "@typescript-eslint/visitor-keys": "8.28.1-alpha.1",
     "graphemer": "^1.4.0",
     "ignore": "^5.3.1",
     "natural-compare": "^1.4.0",
@@ -76,8 +76,8 @@
     "@types/marked": "^5.0.2",
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.28.0",
-    "@typescript-eslint/rule-tester": "8.28.0",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.28.1-alpha.1",
+    "@typescript-eslint/rule-tester": "8.28.1-alpha.1",
     "ajv": "^6.12.6",
     "cross-env": "^7.0.3",
     "cross-fetch": "*",