@typescript-eslint/eslint-plugin 8.26.1-alpha.1 → 8.26.1-alpha.2

package/dist/rules/no-unnecessary-condition.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-unnecessary-condition.d.ts","sourceRoot":"","sources":["../../src/rules/no-unnecessary-condition.ts"],"names":[],"mappings":"AAwGA,KAAK,iCAAiC,GAAG,OAAO,CAAC;AAEjD,KAAK,2BAA2B,GAAG,QAAQ,GAAG,OAAO,GAAG,uBAAuB,CAAC;AAShF,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,2BAA2B,CAAC,EACxB,2BAA2B,GAC3B,iCAAiC,CAAC;QACtC,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,mBAAmB,CAAC,EAAE,OAAO,CAAC;KAC/B;CACF,CAAC;AAEF,MAAM,MAAM,SAAS,GACjB,aAAa,GACb,iBAAiB,GACjB,eAAe,GACf,cAAc,GACd,kBAAkB,GAClB,+BAA+B,GAC/B,OAAO,GACP,cAAc,GACd,oBAAoB,GACpB,4BAA4B,GAC5B,mBAAmB,GACnB,wBAAwB,CAAC;;AAE7B,wBAgwBG"}
+{"version":3,"file":"no-unnecessary-condition.d.ts","sourceRoot":"","sources":["../../src/rules/no-unnecessary-condition.ts"],"names":[],"mappings":"AAyHA,KAAK,iCAAiC,GAAG,OAAO,CAAC;AAEjD,KAAK,2BAA2B,GAAG,QAAQ,GAAG,OAAO,GAAG,uBAAuB,CAAC;AAShF,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,2BAA2B,CAAC,EACxB,2BAA2B,GAC3B,iCAAiC,CAAC;QACtC,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,mBAAmB,CAAC,EAAE,OAAO,CAAC;KAC/B;CACF,CAAC;AAEF,MAAM,MAAM,SAAS,GACjB,aAAa,GACb,iBAAiB,GACjB,eAAe,GACf,cAAc,GACd,kBAAkB,GAClB,+BAA+B,GAC/B,OAAO,GACP,cAAc,GACd,oBAAoB,GACpB,4BAA4B,GAC5B,mBAAmB,GACnB,wBAAwB,CAAC;;AAE7B,wBAgwBG"}

package/dist/rules/no-unnecessary-condition.js

@@ -39,6 +39,20 @@ const ts = __importStar(require("typescript"));
 const util_1 = require("../util");
 const assertionFunctionUtils_1 = require("../util/assertionFunctionUtils");
 // #region
+const nullishFlag = ts.TypeFlags.Undefined | ts.TypeFlags.Null;
+function isNullishType(type) {
+    return tsutils.isTypeFlagSet(type, nullishFlag);
+}
+function isAlwaysNullish(type) {
+    return tsutils.unionTypeParts(type).every(isNullishType);
+}
+/**
+ * Note that this differs from {@link isNullableType} in that it doesn't consider
+ * `any` or `unknown` to be nullable.
+ */
+function isPossiblyNullish(type) {
+    return tsutils.unionTypeParts(type).some(isNullishType);
+}
 function toStaticValue(type) {
     // type.isLiteral() only covers numbers/bigints and strings, hence the rest of the branches.
     if (tsutils.isBooleanLiteralType(type)) {
@@ -288,7 +302,7 @@ exports.default = (0, util_1.createRule)({
             if ((0, util_1.isTypeFlagSet)(type, ts.TypeFlags.Never)) {
                 messageId = 'never';
             }
-            else if (!(0, util_1.isPossiblyNullish)(type) &&
+            else if (!isPossiblyNullish(type) &&
                 !(node.type === utils_1.AST_NODE_TYPES.MemberExpression &&
                     isNullableMemberExpression(node))) {
                 // Since typescript array index signature types don't represent the
@@ -301,7 +315,7 @@ exports.default = (0, util_1.createRule)({
                     messageId = 'neverNullish';
                 }
             }
-            else if ((0, util_1.isAlwaysNullish)(type)) {
+            else if (isAlwaysNullish(type)) {
                 messageId = 'alwaysNullish';
             }
             if (messageId) {

package/dist/rules/prefer-nullish-coalescing.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-nullish-coalescing.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-nullish-coalescing.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AA8BnE,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,qBAAqB,CAAC,EAAE,OAAO,CAAC;QAChC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,gBAAgB,CAAC,EACb;YACE,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,OAAO,CAAC,EAAE,OAAO,CAAC;YAClB,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,MAAM,CAAC,EAAE,OAAO,CAAC;SAClB,GACD,IAAI,CAAC;QACT,kBAAkB,CAAC,EAAE,OAAO,CAAC;KAC9B;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,qBAAqB,GACrB,0BAA0B,GAC1B,gBAAgB,CAAC;;AAErB,wBAmeG"}
+{"version":3,"file":"prefer-nullish-coalescing.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-nullish-coalescing.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AA8BnE,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,sDAAsD,CAAC,EAAE,OAAO,CAAC;QACjE,qBAAqB,CAAC,EAAE,OAAO,CAAC;QAChC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,gBAAgB,CAAC,EACb;YACE,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,OAAO,CAAC,EAAE,OAAO,CAAC;YAClB,MAAM,CAAC,EAAE,OAAO,CAAC;YACjB,MAAM,CAAC,EAAE,OAAO,CAAC;SAClB,GACD,IAAI,CAAC;QACT,kBAAkB,CAAC,EAAE,OAAO,CAAC;KAC9B;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,qBAAqB,GACrB,0BAA0B,GAC1B,gBAAgB,CAAC;;AAErB,wBAsfG"}

package/dist/rules/prefer-nullish-coalescing.js

@@ -153,7 +153,7 @@ exports.default = (0, util_1.createRule)({
          * a nullishness check, taking into account the rule's configuration.
          */
         function isTypeEligibleForPreferNullish(type) {
-            if (!(0, util_1.isPossiblyNullish)(type)) {
+            if (!(0, util_1.isNullableType)(type)) {
                 return false;
             }
             const ignorableFlags = [
@@ -170,11 +170,25 @@ exports.default = (0, util_1.createRule)({
             ]
                 .filter((flag) => typeof flag === 'number')
                 .reduce((previous, flag) => previous | flag, 0);
-            if (type.flags !== ts.TypeFlags.Null &&
-                type.flags !== ts.TypeFlags.Undefined &&
-                type.types.some(t => tsutils
-                    .intersectionTypeParts(t)
-                    .some(t => tsutils.isTypeFlagSet(t, ignorableFlags)))) {
+            if (ignorableFlags === 0) {
+                // any types are eligible for conversion.
+                return true;
+            }
+            // if the type is `any` or `unknown` we can't make any assumptions
+            // about the value, so it could be any primitive, even though the flags
+            // won't be set.
+            //
+            // technically, this is true of `void` as well, however, it's a TS error
+            // to test `void` for truthiness, so we don't need to bother checking for
+            // it in valid code.
+            if (tsutils.isTypeFlagSet(type, ts.TypeFlags.Any | ts.TypeFlags.Unknown)) {
+                return false;
+            }
+            if (tsutils
+                .typeParts(type)
+                .some(t => tsutils
+                .intersectionTypeParts(t)
+                .some(t => tsutils.isTypeFlagSet(t, ignorableFlags)))) {
                 return false;
             }
             return true;

package/dist/util/index.d.ts

@@ -27,7 +27,7 @@ export * from './getConstraintInfo';
 export * from './getValueOfLiteralType';
 export * from './isHigherPrecedenceThanAwait';
 export * from './skipChainExpression';
-export * from './truthinessAndNullishUtils';
+export * from './truthinessUtils';
 export * from '@typescript-eslint/type-utils';
 export declare const applyDefault: typeof ESLintUtils.applyDefault, deepMerge: typeof ESLintUtils.deepMerge, getParserServices: typeof ESLintUtils.getParserServices, isObjectNotArray: typeof ESLintUtils.isObjectNotArray, nullThrows: typeof ESLintUtils.nullThrows, NullThrowsReasons: {
     readonly MissingParent: "Expected node to have a parent.";

package/dist/util/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/util/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAEvD,cAAc,YAAY,CAAC;AAC3B,cAAc,0BAA0B,CAAC;AACzC,cAAc,cAAc,CAAC;AAC7B,cAAc,mBAAmB,CAAC;AAClC,cAAc,sBAAsB,CAAC;AACrC,cAAc,yBAAyB,CAAC;AACxC,cAAc,wBAAwB,CAAC;AACvC,cAAc,mBAAmB,CAAC;AAClC,cAAc,0BAA0B,CAAC;AACzC,cAAc,qBAAqB,CAAC;AACpC,cAAc,oBAAoB,CAAC;AACnC,cAAc,yBAAyB,CAAC;AACxC,cAAc,kCAAkC,CAAC;AACjD,cAAc,cAAc,CAAC;AAC7B,cAAc,eAAe,CAAC;AAC9B,cAAc,iBAAiB,CAAC;AAChC,cAAc,gCAAgC,CAAC;AAC/C,cAAc,yBAAyB,CAAC;AACxC,cAAc,QAAQ,CAAC;AACvB,cAAc,2BAA2B,CAAC;AAC1C,cAAc,mBAAmB,CAAC;AAClC,cAAc,oBAAoB,CAAC;AACnC,cAAc,cAAc,CAAC;AAC7B,cAAc,SAAS,CAAC;AACxB,cAAc,qBAAqB,CAAC;AACpC,cAAc,yBAAyB,CAAC;AACxC,cAAc,+BAA+B,CAAC;AAC9C,cAAc,uBAAuB,CAAC;AACtC,cAAc,6BAA6B,CAAC;AAG5C,cAAc,+BAA+B,CAAC;AAE9C,eAAO,MACL,YAAY,mCACZ,SAAS,gCACT,iBAAiB,wCACjB,gBAAgB,uCAChB,UAAU,iCACV,iBAAiB;;;CACJ,CAAC;AAChB,MAAM,MAAM,2BAA2B,CAAC,CAAC,IACvC,WAAW,CAAC,2BAA2B,CAAC,CAAC,CAAC,CAAC;AAC7C,MAAM,MAAM,wBAAwB,CAAC,CAAC,IACpC,WAAW,CAAC,wBAAwB,CAAC,CAAC,CAAC,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/util/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAEvD,cAAc,YAAY,CAAC;AAC3B,cAAc,0BAA0B,CAAC;AACzC,cAAc,cAAc,CAAC;AAC7B,cAAc,mBAAmB,CAAC;AAClC,cAAc,sBAAsB,CAAC;AACrC,cAAc,yBAAyB,CAAC;AACxC,cAAc,wBAAwB,CAAC;AACvC,cAAc,mBAAmB,CAAC;AAClC,cAAc,0BAA0B,CAAC;AACzC,cAAc,qBAAqB,CAAC;AACpC,cAAc,oBAAoB,CAAC;AACnC,cAAc,yBAAyB,CAAC;AACxC,cAAc,kCAAkC,CAAC;AACjD,cAAc,cAAc,CAAC;AAC7B,cAAc,eAAe,CAAC;AAC9B,cAAc,iBAAiB,CAAC;AAChC,cAAc,gCAAgC,CAAC;AAC/C,cAAc,yBAAyB,CAAC;AACxC,cAAc,QAAQ,CAAC;AACvB,cAAc,2BAA2B,CAAC;AAC1C,cAAc,mBAAmB,CAAC;AAClC,cAAc,oBAAoB,CAAC;AACnC,cAAc,cAAc,CAAC;AAC7B,cAAc,SAAS,CAAC;AACxB,cAAc,qBAAqB,CAAC;AACpC,cAAc,yBAAyB,CAAC;AACxC,cAAc,+BAA+B,CAAC;AAC9C,cAAc,uBAAuB,CAAC;AACtC,cAAc,mBAAmB,CAAC;AAGlC,cAAc,+BAA+B,CAAC;AAE9C,eAAO,MACL,YAAY,mCACZ,SAAS,gCACT,iBAAiB,wCACjB,gBAAgB,uCAChB,UAAU,iCACV,iBAAiB;;;CACJ,CAAC;AAChB,MAAM,MAAM,2BAA2B,CAAC,CAAC,IACvC,WAAW,CAAC,2BAA2B,CAAC,CAAC,CAAC,CAAC;AAC7C,MAAM,MAAM,wBAAwB,CAAC,CAAC,IACpC,WAAW,CAAC,wBAAwB,CAAC,CAAC,CAAC,CAAC"}

package/dist/util/index.js

@@ -44,7 +44,7 @@ __exportStar(require("./getConstraintInfo"), exports);
 __exportStar(require("./getValueOfLiteralType"), exports);
 __exportStar(require("./isHigherPrecedenceThanAwait"), exports);
 __exportStar(require("./skipChainExpression"), exports);
-__exportStar(require("./truthinessAndNullishUtils"), exports);
+__exportStar(require("./truthinessUtils"), exports);
 // this is done for convenience - saves migrating all of the old rules
 __exportStar(require("@typescript-eslint/type-utils"), exports);
 exports.applyDefault = utils_1.ESLintUtils.applyDefault, exports.deepMerge = utils_1.ESLintUtils.deepMerge, exports.getParserServices = utils_1.ESLintUtils.getParserServices, exports.isObjectNotArray = utils_1.ESLintUtils.isObjectNotArray, exports.nullThrows = utils_1.ESLintUtils.nullThrows, exports.NullThrowsReasons = utils_1.ESLintUtils.NullThrowsReasons;

package/dist/util/truthinessUtils.d.ts

@@ -0,0 +1,4 @@
+import * as ts from 'typescript';
+export declare const isPossiblyFalsy: (type: ts.Type) => boolean;
+export declare const isPossiblyTruthy: (type: ts.Type) => boolean;
+//# sourceMappingURL=truthinessUtils.d.ts.map

package/dist/util/truthinessUtils.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"truthinessUtils.d.ts","sourceRoot":"","sources":["../../src/util/truthinessUtils.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AASjC,eAAO,MAAM,eAAe,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OAS0B,CAAC;AAE3E,eAAO,MAAM,gBAAgB,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OAQ5C,CAAC"}

package/dist/util/{truthinessAndNullishUtils.js → truthinessUtils.js}

@@ -33,7 +33,7 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isAlwaysNullish = exports.isPossiblyNullish = exports.isPossiblyTruthy = exports.isPossiblyFalsy = void 0;
+exports.isPossiblyTruthy = exports.isPossiblyFalsy = void 0;
 const tsutils = __importStar(require("ts-api-utils"));
 const ts = __importStar(require("typescript"));
 const getValueOfLiteralType_1 = require("./getValueOfLiteralType");
@@ -58,10 +58,3 @@ const isPossiblyTruthy = (type) => tsutils
 // like `"" & { __brand: string }`.
 intersectionParts.every(type => !tsutils.isFalsyType(type)));
 exports.isPossiblyTruthy = isPossiblyTruthy;
-// Nullish utilities
-const nullishFlag = ts.TypeFlags.Undefined | ts.TypeFlags.Null;
-const isNullishType = (type) => tsutils.isTypeFlagSet(type, nullishFlag);
-const isPossiblyNullish = (type) => tsutils.unionTypeParts(type).some(isNullishType);
-exports.isPossiblyNullish = isPossiblyNullish;
-const isAlwaysNullish = (type) => tsutils.unionTypeParts(type).every(isNullishType);
-exports.isAlwaysNullish = isAlwaysNullish;

package/docs/rules/prefer-nullish-coalescing.mdx

@@ -84,7 +84,7 @@ Examples of code for this rule with `{ ignoreConditionalTests: false }`:
 <TabItem value="❌ Incorrect">
 
 ```ts option='{ "ignoreConditionalTests": false }'
-declare const a: string | null;
+declare let a: string | null;
 declare const b: string | null;
 
 if (a || b) {
@@ -102,7 +102,7 @@ a || b ? true : false;
 <TabItem value="✅ Correct">
 
 ```ts option='{ "ignoreConditionalTests": false }'
-declare const a: string | null;
+declare let a: string | null;
 declare const b: string | null;
 
 if (a ?? b) {
@@ -133,7 +133,7 @@ Examples of code for this rule with `{ ignoreMixedLogicalExpressions: false }`:
 <TabItem value="❌ Incorrect">
 
 ```ts option='{ "ignoreMixedLogicalExpressions": false }'
-declare const a: string | null;
+declare let a: string | null;
 declare const b: string | null;
 declare const c: string | null;
 declare const d: string | null;
@@ -149,7 +149,7 @@ a || (b && c && d);
 <TabItem value="✅ Correct">
 
 ```ts option='{ "ignoreMixedLogicalExpressions": false }'
-declare const a: string | null;
+declare let a: string | null;
 declare const b: string | null;
 declare const c: string | null;
 declare const d: string | null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.26.1-alpha.1",
+  "version": "8.26.1-alpha.2",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -62,10 +62,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.26.1-alpha.1",
-    "@typescript-eslint/type-utils": "8.26.1-alpha.1",
-    "@typescript-eslint/utils": "8.26.1-alpha.1",
-    "@typescript-eslint/visitor-keys": "8.26.1-alpha.1",
+    "@typescript-eslint/scope-manager": "8.26.1-alpha.2",
+    "@typescript-eslint/type-utils": "8.26.1-alpha.2",
+    "@typescript-eslint/utils": "8.26.1-alpha.2",
+    "@typescript-eslint/visitor-keys": "8.26.1-alpha.2",
     "graphemer": "^1.4.0",
     "ignore": "^5.3.1",
     "natural-compare": "^1.4.0",
@@ -76,8 +76,8 @@
     "@types/marked": "^5.0.2",
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.26.1-alpha.1",
-    "@typescript-eslint/rule-tester": "8.26.1-alpha.1",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.26.1-alpha.2",
+    "@typescript-eslint/rule-tester": "8.26.1-alpha.2",
     "ajv": "^6.12.6",
     "cross-env": "^7.0.3",
     "cross-fetch": "*",

package/dist/util/truthinessAndNullishUtils.d.ts

@@ -1,6 +0,0 @@
-import * as ts from 'typescript';
-export declare const isPossiblyFalsy: (type: ts.Type) => boolean;
-export declare const isPossiblyTruthy: (type: ts.Type) => boolean;
-export declare const isPossiblyNullish: (type: ts.Type) => boolean;
-export declare const isAlwaysNullish: (type: ts.Type) => boolean;
-//# sourceMappingURL=truthinessAndNullishUtils.d.ts.map

package/dist/util/truthinessAndNullishUtils.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"truthinessAndNullishUtils.d.ts","sourceRoot":"","sources":["../../src/util/truthinessAndNullishUtils.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AASjC,eAAO,MAAM,eAAe,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OAS0B,CAAC;AAE3E,eAAO,MAAM,gBAAgB,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OAQ5C,CAAC;AAON,eAAO,MAAM,iBAAiB,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OACA,CAAC;AAEnD,eAAO,MAAM,eAAe,GAAI,MAAM,EAAE,CAAC,IAAI,KAAG,OACG,CAAC"}