@typescript-eslint/eslint-plugin 6.0.1-alpha.2 → 6.0.1-alpha.22
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/rules/comma-dangle.js +3 -1
- package/dist/rules/comma-dangle.js.map +1 -1
- package/dist/rules/no-floating-promises.js +81 -24
- package/dist/rules/no-floating-promises.js.map +1 -1
- package/docs/rules/camelcase.md +1 -1
- package/docs/rules/explicit-member-accessibility.md +1 -1
- package/docs/rules/no-floating-promises.md +1 -1
- package/package.json +12 -11
- package/rules.d.ts +44 -0
|
@@ -107,7 +107,9 @@ exports.default = util.createRule({
|
|
|
107
107
|
'always-multiline': forceCommaIfMultiline,
|
|
108
108
|
'only-multiline': allowCommaIfMultiline,
|
|
109
109
|
never: forbidComma,
|
|
110
|
-
|
|
110
|
+
// https://github.com/typescript-eslint/typescript-eslint/issues/7220
|
|
111
|
+
// eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/no-empty-function
|
|
112
|
+
ignore: () => { },
|
|
111
113
|
};
|
|
112
114
|
function last(nodes) {
|
|
113
115
|
return nodes[nodes.length - 1] ?? null;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"comma-dangle.js","sourceRoot":"","sources":["../../src/rules/comma-dangle.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;AACA,oDAA0D;AAE1D,8CAAgC;AAChC,iEAA8D;AAE9D,MAAM,QAAQ,GAAG,IAAA,qCAAiB,EAAC,cAAc,CAAC,CAAC;AAUnD,MAAM,mBAAmB,GAAG;IAC1B,kBAAkB;IAClB,QAAQ;IACR,OAAO;IACP,gBAAgB;CACjB,CAAC;AAEF,MAAM,oBAAoB,GAAG,OAAO,CAAC;AAErC,SAAS,gBAAgB,CAAC,OAAe;IACvC,IAAI,OAAO,OAAO,KAAK,QAAQ,EAAE;QAC/B,OAAO;YACL,KAAK,EAAE,OAAO;YACd,QAAQ,EAAE,OAAO;YACjB,MAAM,EAAE,OAAO;SAChB,CAAC;KACH;IACD,OAAO;QACL,KAAK,EAAE,OAAO,CAAC,KAAK,IAAI,oBAAoB;QAC5C,QAAQ,EAAE,OAAO,CAAC,QAAQ,IAAI,oBAAoB;QAClD,MAAM,EAAE,OAAO,CAAC,MAAM,IAAI,oBAAoB;KAC/C,CAAC;AACJ,CAAC;AAED,kBAAe,IAAI,CAAC,UAAU,CAAsB;IAClD,IAAI,EAAE,cAAc;IACpB,IAAI,EAAE;QACJ,IAAI,EAAE,QAAQ;QACd,IAAI,EAAE;YACJ,WAAW,EAAE,qCAAqC;YAClD,eAAe,EAAE,IAAI;SACtB;QACD,MAAM,EAAE;YACN,KAAK,EAAE;gBACL,KAAK,EAAE;oBACL,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,mBAAmB;iBAC1B;gBACD,eAAe,EAAE;oBACf,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,CAAC,GAAG,mBAAmB,EAAE,QAAQ,CAAC;iBACzC;aACF;YACD,IAAI,EAAE,OAAO;YACb,KAAK,EAAE;gBACL;oBACE,KAAK,EAAE;wBACL;4BACE,IAAI,EAAE,eAAe;yBACtB;wBACD;4BACE,IAAI,EAAE,QAAQ;4BACd,UAAU,EAAE;gCACV,MAAM,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC3C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,SAAS,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC9C,KAAK,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC1C,QAAQ,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC7C,MAAM,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;6BAC5C;4BACD,oBAAoB,EAAE,KAAK;yBAC5B;qBACF;iBACF;aACF;YACD,eAAe,EAAE,KAAK;SACvB;QACD,OAAO,EAAE,MAAM;QACf,cAAc,EAAE,QAAQ,CAAC,IAAI,CAAC,cAAc;QAC5C,QAAQ,EAAE,QAAQ,CAAC,IAAI,CAAC,QAAQ;KACjC;IACD,cAAc,EAAE,CAAC,OAAO,CAAC;IACzB,MAAM,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC;QACvB,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;QACvC,MAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,MAAM,iBAAiB,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,SAAS,GAAG;YAChB,MAAM,EAAE,UAAU;YAClB,kBAAkB,EAAE,qBAAqB;YACzC,gBAAgB,EAAE,qBAAqB;YACvC,KAAK,EAAE,WAAW;YAClB,MAAM,EAAE,
|
|
1
|
+
{"version":3,"file":"comma-dangle.js","sourceRoot":"","sources":["../../src/rules/comma-dangle.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;AACA,oDAA0D;AAE1D,8CAAgC;AAChC,iEAA8D;AAE9D,MAAM,QAAQ,GAAG,IAAA,qCAAiB,EAAC,cAAc,CAAC,CAAC;AAUnD,MAAM,mBAAmB,GAAG;IAC1B,kBAAkB;IAClB,QAAQ;IACR,OAAO;IACP,gBAAgB;CACjB,CAAC;AAEF,MAAM,oBAAoB,GAAG,OAAO,CAAC;AAErC,SAAS,gBAAgB,CAAC,OAAe;IACvC,IAAI,OAAO,OAAO,KAAK,QAAQ,EAAE;QAC/B,OAAO;YACL,KAAK,EAAE,OAAO;YACd,QAAQ,EAAE,OAAO;YACjB,MAAM,EAAE,OAAO;SAChB,CAAC;KACH;IACD,OAAO;QACL,KAAK,EAAE,OAAO,CAAC,KAAK,IAAI,oBAAoB;QAC5C,QAAQ,EAAE,OAAO,CAAC,QAAQ,IAAI,oBAAoB;QAClD,MAAM,EAAE,OAAO,CAAC,MAAM,IAAI,oBAAoB;KAC/C,CAAC;AACJ,CAAC;AAED,kBAAe,IAAI,CAAC,UAAU,CAAsB;IAClD,IAAI,EAAE,cAAc;IACpB,IAAI,EAAE;QACJ,IAAI,EAAE,QAAQ;QACd,IAAI,EAAE;YACJ,WAAW,EAAE,qCAAqC;YAClD,eAAe,EAAE,IAAI;SACtB;QACD,MAAM,EAAE;YACN,KAAK,EAAE;gBACL,KAAK,EAAE;oBACL,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,mBAAmB;iBAC1B;gBACD,eAAe,EAAE;oBACf,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,CAAC,GAAG,mBAAmB,EAAE,QAAQ,CAAC;iBACzC;aACF;YACD,IAAI,EAAE,OAAO;YACb,KAAK,EAAE;gBACL;oBACE,KAAK,EAAE;wBACL;4BACE,IAAI,EAAE,eAAe;yBACtB;wBACD;4BACE,IAAI,EAAE,QAAQ;4BACd,UAAU,EAAE;gCACV,MAAM,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC3C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,OAAO,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC5C,SAAS,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC9C,KAAK,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC1C,QAAQ,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;gCAC7C,MAAM,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE;6BAC5C;4BACD,oBAAoB,EAAE,KAAK;yBAC5B;qBACF;iBACF;aACF;YACD,eAAe,EAAE,KAAK;SACvB;QACD,OAAO,EAAE,MAAM;QACf,cAAc,EAAE,QAAQ,CAAC,IAAI,CAAC,cAAc;QAC5C,QAAQ,EAAE,QAAQ,CAAC,IAAI,CAAC,QAAQ;KACjC;IACD,cAAc,EAAE,CAAC,OAAO,CAAC;IACzB,MAAM,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC;QACvB,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;QACvC,MAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,MAAM,iBAAiB,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,SAAS,GAAG;YAChB,MAAM,EAAE,UAAU;YAClB,kBAAkB,EAAE,qBAAqB;YACzC,gBAAgB,EAAE,qBAAqB;YACvC,KAAK,EAAE,WAAW;YAClB,qEAAqE;YACrE,kHAAkH;YAClH,MAAM,EAAE,GAAG,EAAE,GAAE,CAAC;SACjB,CAAC;QAEF,SAAS,IAAI,CAAC,KAAsB;YAClC,OAAO,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC;QACzC,CAAC;QAED,SAAS,WAAW,CAAC,IAAmB;YACtC,QAAQ,IAAI,CAAC,IAAI,EAAE;gBACjB,KAAK,sBAAc,CAAC,iBAAiB;oBACnC,OAAO,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;gBAC5B,KAAK,sBAAc,CAAC,0BAA0B;oBAC5C,OAAO,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;gBAC3B,KAAK,sBAAc,CAAC,WAAW;oBAC7B,OAAO,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;gBACjC;oBACE,OAAO,IAAI,CAAC;aACf;QACH,CAAC;QAED,SAAS,gBAAgB,CAAC,IAAmB;YAC3C,MAAM,IAAI,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;YAC/B,MAAM,QAAQ,GAAG,IAAI,IAAI,UAAU,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC;YACxD,OAAO,QAAQ,CAAC;QAClB,CAAC;QAED,SAAS,WAAW,CAAC,IAAmB;YACtC,MAAM,IAAI,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;YAC/B,MAAM,SAAS,GAAG,UAAU,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;YAChD,OAAO,IAAI,EAAE,GAAG,CAAC,GAAG,CAAC,IAAI,KAAK,SAAS,EAAE,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC;QACxD,CAAC;QAED,SAAS,WAAW,CAAC,IAAmB;YACtC,MAAM,IAAI,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;YAC/B,MAAM,QAAQ,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;YACxC,IAAI,IAAI,IAAI,QAAQ,IAAI,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,EAAE;gBACnD,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,YAAY;oBACvB,GAAG,CAAC,KAAK;wBACP,OAAO,KAAK,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;oBAChC,CAAC;iBACF,CAAC,CAAC;aACJ;QACH,CAAC;QAED,SAAS,UAAU,CAAC,IAAmB;YACrC,MAAM,IAAI,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;YAC/B,MAAM,QAAQ,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;YACxC,IAAI,IAAI,IAAI,QAAQ,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,EAAE;gBACpD,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,SAAS;oBACpB,GAAG,CAAC,KAAK;wBACP,OAAO,KAAK,CAAC,eAAe,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;oBAC1C,CAAC;iBACF,CAAC,CAAC;aACJ;QACH,CAAC;QAED,SAAS,qBAAqB,CAAC,IAAmB;YAChD,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE;gBACtB,WAAW,CAAC,IAAI,CAAC,CAAC;aACnB;QACH,CAAC;QAED,SAAS,qBAAqB,CAAC,IAAmB;YAChD,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE;gBACrB,UAAU,CAAC,IAAI,CAAC,CAAC;aAClB;iBAAM;gBACL,WAAW,CAAC,IAAI,CAAC,CAAC;aACnB;QACH,CAAC;QAED,OAAO;YACL,GAAG,KAAK;YACR,iBAAiB,EAAE,SAAS,CAAC,iBAAiB,CAAC,KAAK,CAAC;YACrD,0BAA0B,EAAE,SAAS,CAAC,iBAAiB,CAAC,QAAQ,CAAC;YACjE,WAAW,EAAE,SAAS,CAAC,iBAAiB,CAAC,MAAM,CAAC;SACjD,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -28,6 +28,10 @@ const tsutils = __importStar(require("ts-api-utils"));
|
|
|
28
28
|
const ts = __importStar(require("typescript"));
|
|
29
29
|
const util = __importStar(require("../util"));
|
|
30
30
|
const util_1 = require("../util");
|
|
31
|
+
const messageBase = 'Promises must be awaited, end with a call to .catch, or end with a call to .then with a rejection handler.';
|
|
32
|
+
const messageBaseVoid = 'Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler' +
|
|
33
|
+
' or be explicitly marked as ignored with the `void` operator.';
|
|
34
|
+
const messageRejectionHandler = 'A rejection handler that is not a function will be ignored.';
|
|
31
35
|
exports.default = util.createRule({
|
|
32
36
|
name: 'no-floating-promises',
|
|
33
37
|
meta: {
|
|
@@ -38,11 +42,12 @@ exports.default = util.createRule({
|
|
|
38
42
|
},
|
|
39
43
|
hasSuggestions: true,
|
|
40
44
|
messages: {
|
|
41
|
-
floating:
|
|
45
|
+
floating: messageBase,
|
|
42
46
|
floatingFixAwait: 'Add await operator.',
|
|
43
|
-
floatingVoid:
|
|
44
|
-
' or be explicitly marked as ignored with the `void` operator.',
|
|
47
|
+
floatingVoid: messageBaseVoid,
|
|
45
48
|
floatingFixVoid: 'Add void operator to ignore.',
|
|
49
|
+
floatingUselessRejectionHandler: messageBase + ' ' + messageRejectionHandler,
|
|
50
|
+
floatingUselessRejectionHandlerVoid: messageBaseVoid + ' ' + messageRejectionHandler,
|
|
46
51
|
},
|
|
47
52
|
schema: [
|
|
48
53
|
{
|
|
@@ -53,7 +58,7 @@ exports.default = util.createRule({
|
|
|
53
58
|
type: 'boolean',
|
|
54
59
|
},
|
|
55
60
|
ignoreIIFE: {
|
|
56
|
-
description: 'Whether to ignore async IIFEs (Immediately
|
|
61
|
+
description: 'Whether to ignore async IIFEs (Immediately Invoked Function Expressions).',
|
|
57
62
|
type: 'boolean',
|
|
58
63
|
},
|
|
59
64
|
},
|
|
@@ -80,11 +85,14 @@ exports.default = util.createRule({
|
|
|
80
85
|
if (expression.type === utils_1.AST_NODE_TYPES.ChainExpression) {
|
|
81
86
|
expression = expression.expression;
|
|
82
87
|
}
|
|
83
|
-
|
|
88
|
+
const { isUnhandled, nonFunctionHandler } = isUnhandledPromise(checker, expression);
|
|
89
|
+
if (isUnhandled) {
|
|
84
90
|
if (options.ignoreVoid) {
|
|
85
91
|
context.report({
|
|
86
92
|
node,
|
|
87
|
-
messageId:
|
|
93
|
+
messageId: nonFunctionHandler
|
|
94
|
+
? 'floatingUselessRejectionHandlerVoid'
|
|
95
|
+
: 'floatingVoid',
|
|
88
96
|
suggest: [
|
|
89
97
|
{
|
|
90
98
|
messageId: 'floatingFixVoid',
|
|
@@ -107,7 +115,9 @@ exports.default = util.createRule({
|
|
|
107
115
|
else {
|
|
108
116
|
context.report({
|
|
109
117
|
node,
|
|
110
|
-
messageId:
|
|
118
|
+
messageId: nonFunctionHandler
|
|
119
|
+
? 'floatingUselessRejectionHandler'
|
|
120
|
+
: 'floating',
|
|
111
121
|
suggest: [
|
|
112
122
|
{
|
|
113
123
|
messageId: 'floatingFixAwait',
|
|
@@ -150,13 +160,21 @@ exports.default = util.createRule({
|
|
|
150
160
|
utils_1.AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
151
161
|
node.expression.callee.type === utils_1.AST_NODE_TYPES.FunctionExpression));
|
|
152
162
|
}
|
|
163
|
+
function isValidRejectionHandler(rejectionHandler) {
|
|
164
|
+
return (services.program
|
|
165
|
+
.getTypeChecker()
|
|
166
|
+
.getTypeAtLocation(services.esTreeNodeToTSNodeMap.get(rejectionHandler))
|
|
167
|
+
.getCallSignatures().length > 0);
|
|
168
|
+
}
|
|
153
169
|
function isUnhandledPromise(checker, node) {
|
|
154
170
|
// First, check expressions whose resulting types may not be promise-like
|
|
155
171
|
if (node.type === utils_1.AST_NODE_TYPES.SequenceExpression) {
|
|
156
172
|
// Any child in a comma expression could return a potentially unhandled
|
|
157
173
|
// promise, so we check them all regardless of whether the final returned
|
|
158
174
|
// value is promise-like.
|
|
159
|
-
return node.expressions
|
|
175
|
+
return (node.expressions
|
|
176
|
+
.map(item => isUnhandledPromise(checker, item))
|
|
177
|
+
.find(result => result.isUnhandled) ?? { isUnhandled: false });
|
|
160
178
|
}
|
|
161
179
|
if (!options.ignoreVoid &&
|
|
162
180
|
node.type === utils_1.AST_NODE_TYPES.UnaryExpression &&
|
|
@@ -167,20 +185,44 @@ exports.default = util.createRule({
|
|
|
167
185
|
}
|
|
168
186
|
// Check the type. At this point it can't be unhandled if it isn't a promise
|
|
169
187
|
if (!isPromiseLike(checker, services.esTreeNodeToTSNodeMap.get(node))) {
|
|
170
|
-
return false;
|
|
188
|
+
return { isUnhandled: false };
|
|
171
189
|
}
|
|
172
190
|
if (node.type === utils_1.AST_NODE_TYPES.CallExpression) {
|
|
173
191
|
// If the outer expression is a call, it must be either a `.then()` or
|
|
174
192
|
// `.catch()` that handles the promise.
|
|
175
|
-
|
|
176
|
-
|
|
177
|
-
|
|
193
|
+
const catchRejectionHandler = getRejectionHandlerFromCatchCall(node);
|
|
194
|
+
if (catchRejectionHandler) {
|
|
195
|
+
if (isValidRejectionHandler(catchRejectionHandler)) {
|
|
196
|
+
return { isUnhandled: false };
|
|
197
|
+
}
|
|
198
|
+
else {
|
|
199
|
+
return { isUnhandled: true, nonFunctionHandler: true };
|
|
200
|
+
}
|
|
201
|
+
}
|
|
202
|
+
const thenRejectionHandler = getRejectionHandlerFromThenCall(node);
|
|
203
|
+
if (thenRejectionHandler) {
|
|
204
|
+
if (isValidRejectionHandler(thenRejectionHandler)) {
|
|
205
|
+
return { isUnhandled: false };
|
|
206
|
+
}
|
|
207
|
+
else {
|
|
208
|
+
return { isUnhandled: true, nonFunctionHandler: true };
|
|
209
|
+
}
|
|
210
|
+
}
|
|
211
|
+
if (isPromiseFinallyCallWithHandler(node)) {
|
|
212
|
+
return { isUnhandled: false };
|
|
213
|
+
}
|
|
214
|
+
return { isUnhandled: true };
|
|
178
215
|
}
|
|
179
216
|
else if (node.type === utils_1.AST_NODE_TYPES.ConditionalExpression) {
|
|
180
217
|
// We must be getting the promise-like value from one of the branches of the
|
|
181
218
|
// ternary. Check them directly.
|
|
182
|
-
|
|
183
|
-
|
|
219
|
+
const alternateResult = isUnhandledPromise(checker, node.alternate);
|
|
220
|
+
if (alternateResult.isUnhandled) {
|
|
221
|
+
return alternateResult;
|
|
222
|
+
}
|
|
223
|
+
else {
|
|
224
|
+
return isUnhandledPromise(checker, node.consequent);
|
|
225
|
+
}
|
|
184
226
|
}
|
|
185
227
|
else if (node.type === utils_1.AST_NODE_TYPES.MemberExpression ||
|
|
186
228
|
node.type === utils_1.AST_NODE_TYPES.Identifier ||
|
|
@@ -188,16 +230,21 @@ exports.default = util.createRule({
|
|
|
188
230
|
// If it is just a property access chain or a `new` call (e.g. `foo.bar` or
|
|
189
231
|
// `new Promise()`), the promise is not handled because it doesn't have the
|
|
190
232
|
// necessary then/catch call at the end of the chain.
|
|
191
|
-
return true;
|
|
233
|
+
return { isUnhandled: true };
|
|
192
234
|
}
|
|
193
235
|
else if (node.type === utils_1.AST_NODE_TYPES.LogicalExpression) {
|
|
194
|
-
|
|
195
|
-
|
|
236
|
+
const leftResult = isUnhandledPromise(checker, node.left);
|
|
237
|
+
if (leftResult.isUnhandled) {
|
|
238
|
+
return leftResult;
|
|
239
|
+
}
|
|
240
|
+
else {
|
|
241
|
+
return isUnhandledPromise(checker, node.right);
|
|
242
|
+
}
|
|
196
243
|
}
|
|
197
244
|
// We conservatively return false for all other types of expressions because
|
|
198
245
|
// we don't want to accidentally fail if the promise is handled internally but
|
|
199
246
|
// we just can't tell.
|
|
200
|
-
return false;
|
|
247
|
+
return { isUnhandled: false };
|
|
201
248
|
}
|
|
202
249
|
},
|
|
203
250
|
});
|
|
@@ -238,17 +285,27 @@ function isFunctionParam(checker, param, node) {
|
|
|
238
285
|
}
|
|
239
286
|
return false;
|
|
240
287
|
}
|
|
241
|
-
function
|
|
242
|
-
|
|
288
|
+
function getRejectionHandlerFromCatchCall(expression) {
|
|
289
|
+
if (expression.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
|
|
243
290
|
expression.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
|
|
244
291
|
expression.callee.property.name === 'catch' &&
|
|
245
|
-
expression.arguments.length >= 1)
|
|
292
|
+
expression.arguments.length >= 1) {
|
|
293
|
+
return expression.arguments[0];
|
|
294
|
+
}
|
|
295
|
+
else {
|
|
296
|
+
return undefined;
|
|
297
|
+
}
|
|
246
298
|
}
|
|
247
|
-
function
|
|
248
|
-
|
|
299
|
+
function getRejectionHandlerFromThenCall(expression) {
|
|
300
|
+
if (expression.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
|
|
249
301
|
expression.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
|
|
250
302
|
expression.callee.property.name === 'then' &&
|
|
251
|
-
expression.arguments.length >= 2)
|
|
303
|
+
expression.arguments.length >= 2) {
|
|
304
|
+
return expression.arguments[1];
|
|
305
|
+
}
|
|
306
|
+
else {
|
|
307
|
+
return undefined;
|
|
308
|
+
}
|
|
252
309
|
}
|
|
253
310
|
function isPromiseFinallyCallWithHandler(expression) {
|
|
254
311
|
return (expression.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-floating-promises.js","sourceRoot":"","sources":["../../src/rules/no-floating-promises.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;AACA,oDAA0D;AAC1D,sDAAwC;AACxC,+CAAiC;AAEjC,8CAAgC;AAChC,kCAA6C;
|
|
1
|
+
{"version":3,"file":"no-floating-promises.js","sourceRoot":"","sources":["../../src/rules/no-floating-promises.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;AACA,oDAA0D;AAC1D,sDAAwC;AACxC,+CAAiC;AAEjC,8CAAgC;AAChC,kCAA6C;AAiB7C,MAAM,WAAW,GACf,4GAA4G,CAAC;AAE/G,MAAM,eAAe,GACnB,wGAAwG;IACxG,+DAA+D,CAAC;AAElE,MAAM,uBAAuB,GAC3B,6DAA6D,CAAC;AAEhE,kBAAe,IAAI,CAAC,UAAU,CAAqB;IACjD,IAAI,EAAE,sBAAsB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE;YACJ,WAAW,EACT,6DAA6D;YAC/D,WAAW,EAAE,aAAa;YAC1B,oBAAoB,EAAE,IAAI;SAC3B;QACD,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,QAAQ,EAAE,WAAW;YACrB,gBAAgB,EAAE,qBAAqB;YACvC,YAAY,EAAE,eAAe;YAC7B,eAAe,EAAE,8BAA8B;YAC/C,+BAA+B,EAC7B,WAAW,GAAG,GAAG,GAAG,uBAAuB;YAC7C,mCAAmC,EACjC,eAAe,GAAG,GAAG,GAAG,uBAAuB;SAClD;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,UAAU,EAAE;wBACV,WAAW,EAAE,uCAAuC;wBACpD,IAAI,EAAE,SAAS;qBAChB;oBACD,UAAU,EAAE;wBACV,WAAW,EACT,2EAA2E;wBAC7E,IAAI,EAAE,SAAS;qBAChB;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;QACD,IAAI,EAAE,SAAS;KAChB;IACD,cAAc,EAAE;QACd;YACE,UAAU,EAAE,IAAI;YAChB,UAAU,EAAE,KAAK;SAClB;KACF;IAED,MAAM,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC;QACvB,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;QACjD,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;QAElD,OAAO;YACL,mBAAmB,CAAC,IAAI;gBACtB,IAAI,OAAO,CAAC,UAAU,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE;oBAC3C,OAAO;iBACR;gBAED,IAAI,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC;gBAEjC,IAAI,UAAU,CAAC,IAAI,KAAK,sBAAc,CAAC,eAAe,EAAE;oBACtD,UAAU,GAAG,UAAU,CAAC,UAAU,CAAC;iBACpC;gBAED,MAAM,EAAE,WAAW,EAAE,kBAAkB,EAAE,GAAG,kBAAkB,CAC5D,OAAO,EACP,UAAU,CACX,CAAC;gBAEF,IAAI,WAAW,EAAE;oBACf,IAAI,OAAO,CAAC,UAAU,EAAE;wBACtB,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,kBAAkB;gCAC3B,CAAC,CAAC,qCAAqC;gCACvC,CAAC,CAAC,cAAc;4BAClB,OAAO,EAAE;gCACP;oCACE,SAAS,EAAE,iBAAiB;oCAC5B,GAAG,CAAC,KAAK;wCACP,MAAM,MAAM,GAAG,QAAQ,CAAC,qBAAqB,CAAC,GAAG,CAC/C,IAAI,CAAC,UAAU,CAChB,CAAC;wCACF,IAAI,2BAA2B,CAAC,MAAM,CAAC,EAAE;4CACvC,OAAO,KAAK,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;yCAC9C;6CAAM;4CACL,OAAO;gDACL,KAAK,CAAC,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC;gDACtC,KAAK,CAAC,oBAAoB,CACxB,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAC1C,GAAG,CACJ;6CACF,CAAC;yCACH;oCACH,CAAC;iCACF;6BACF;yBACF,CAAC,CAAC;qBACJ;yBAAM;wBACL,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,kBAAkB;gCAC3B,CAAC,CAAC,iCAAiC;gCACnC,CAAC,CAAC,UAAU;4BACd,OAAO,EAAE;gCACP;oCACE,SAAS,EAAE,kBAAkB;oCAC7B,GAAG,CAAC,KAAK;wCACP,IACE,UAAU,CAAC,IAAI,KAAK,sBAAc,CAAC,eAAe;4CAClD,UAAU,CAAC,QAAQ,KAAK,MAAM,EAC9B;4CACA,OAAO,KAAK,CAAC,gBAAgB,CAC3B,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,EAC9C,OAAO,CACR,CAAC;yCACH;wCACD,MAAM,MAAM,GAAG,QAAQ,CAAC,qBAAqB,CAAC,GAAG,CAC/C,IAAI,CAAC,UAAU,CAChB,CAAC;wCACF,IAAI,2BAA2B,CAAC,MAAM,CAAC,EAAE;4CACvC,OAAO,KAAK,CAAC,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;yCAC/C;6CAAM;4CACL,OAAO;gDACL,KAAK,CAAC,gBAAgB,CAAC,IAAI,EAAE,SAAS,CAAC;gDACvC,KAAK,CAAC,oBAAoB,CACxB,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAC1C,GAAG,CACJ;6CACF,CAAC;yCACH;oCACH,CAAC;iCACF;6BACF;yBACF,CAAC,CAAC;qBACJ;iBACF;YACH,CAAC;SACF,CAAC;QAEF,SAAS,2BAA2B,CAAC,IAAa;YAChD,MAAM,QAAQ,GAAG,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC;gBAC1C,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,IAAI;gBACzB,CAAC,CAAC,EAAE,CAAC,UAAU,CAAC,OAAO,CAAC;YAC1B,MAAM,cAAc,GAAG,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;YACvE,OAAO,cAAc,GAAG,yBAAkB,CAAC,KAAK,CAAC;QACnD,CAAC;QAED,SAAS,WAAW,CAAC,IAAkC;YACrD,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,sBAAc,CAAC,cAAc,EAAE;gBAC1D,OAAO,KAAK,CAAC;aACd;YAED,OAAO,CACL,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,sBAAc,CAAC,cAAc;gBACtD,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI;oBAC1B,sBAAc,CAAC,uBAAuB;oBACtC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,KAAK,sBAAc,CAAC,kBAAkB,CAAC,CACrE,CAAC;QACJ,CAAC;QAED,SAAS,uBAAuB,CAAC,gBAA+B;YAC9D,OAAO,CACL,QAAQ,CAAC,OAAO;iBACb,cAAc,EAAE;iBAChB,iBAAiB,CAChB,QAAQ,CAAC,qBAAqB,CAAC,GAAG,CAAC,gBAAgB,CAAC,CACrD;iBACA,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,CAClC,CAAC;QACJ,CAAC;QAED,SAAS,kBAAkB,CACzB,OAAuB,EACvB,IAAmB;YAEnB,yEAAyE;YACzE,IAAI,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,kBAAkB,EAAE;gBACnD,uEAAuE;gBACvE,yEAAyE;gBACzE,yBAAyB;gBACzB,OAAO,CACL,IAAI,CAAC,WAAW;qBACb,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;qBAC9C,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,CAChE,CAAC;aACH;YAED,IACE,CAAC,OAAO,CAAC,UAAU;gBACnB,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,eAAe;gBAC5C,IAAI,CAAC,QAAQ,KAAK,MAAM,EACxB;gBACA,yEAAyE;gBACzE,4EAA4E;gBAC5E,OAAO,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;aACnD;YAED,4EAA4E;YAC5E,IAAI,CAAC,aAAa,CAAC,OAAO,EAAE,QAAQ,CAAC,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,EAAE;gBACrE,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;aAC/B;YAED,IAAI,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,cAAc,EAAE;gBAC/C,sEAAsE;gBACtE,uCAAuC;gBAEvC,MAAM,qBAAqB,GAAG,gCAAgC,CAAC,IAAI,CAAC,CAAC;gBACrE,IAAI,qBAAqB,EAAE;oBACzB,IAAI,uBAAuB,CAAC,qBAAqB,CAAC,EAAE;wBAClD,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;qBAC/B;yBAAM;wBACL,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,kBAAkB,EAAE,IAAI,EAAE,CAAC;qBACxD;iBACF;gBAED,MAAM,oBAAoB,GAAG,+BAA+B,CAAC,IAAI,CAAC,CAAC;gBACnE,IAAI,oBAAoB,EAAE;oBACxB,IAAI,uBAAuB,CAAC,oBAAoB,CAAC,EAAE;wBACjD,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;qBAC/B;yBAAM;wBACL,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,kBAAkB,EAAE,IAAI,EAAE,CAAC;qBACxD;iBACF;gBAED,IAAI,+BAA+B,CAAC,IAAI,CAAC,EAAE;oBACzC,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;iBAC/B;gBAED,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;aAC9B;iBAAM,IAAI,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,qBAAqB,EAAE;gBAC7D,4EAA4E;gBAC5E,gCAAgC;gBAChC,MAAM,eAAe,GAAG,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC;gBACpE,IAAI,eAAe,CAAC,WAAW,EAAE;oBAC/B,OAAO,eAAe,CAAC;iBACxB;qBAAM;oBACL,OAAO,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,CAAC,CAAC;iBACrD;aACF;iBAAM,IACL,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,gBAAgB;gBAC7C,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU;gBACvC,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,aAAa,EAC1C;gBACA,2EAA2E;gBAC3E,2EAA2E;gBAC3E,qDAAqD;gBACrD,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;aAC9B;iBAAM,IAAI,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,iBAAiB,EAAE;gBACzD,MAAM,UAAU,GAAG,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;gBAC1D,IAAI,UAAU,CAAC,WAAW,EAAE;oBAC1B,OAAO,UAAU,CAAC;iBACnB;qBAAM;oBACL,OAAO,kBAAkB,CAAC,OAAO,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;iBAChD;aACF;YAED,4EAA4E;YAC5E,8EAA8E;YAC9E,sBAAsB;YACtB,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;QAChC,CAAC;IACH,CAAC;CACF,CAAC,CAAC;AAEH,6EAA6E;AAC7E,0EAA0E;AAC1E,EAAE;AACF,0GAA0G;AAC1G,SAAS,aAAa,CAAC,OAAuB,EAAE,IAAa;IAC3D,MAAM,IAAI,GAAG,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAC7C,KAAK,MAAM,EAAE,IAAI,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,EAAE;QACtE,MAAM,IAAI,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QACpC,IAAI,IAAI,KAAK,SAAS,EAAE;YACtB,SAAS;SACV;QAED,MAAM,QAAQ,GAAG,OAAO,CAAC,yBAAyB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;QAC/D,IACE,oBAAoB,CAClB,QAAQ,EACR,SAAS,CAAC,EAAE,CACV,SAAS,CAAC,UAAU,CAAC,MAAM,IAAI,CAAC;YAChC,eAAe,CAAC,OAAO,EAAE,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC;YACvD,eAAe,CAAC,OAAO,EAAE,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC,CAC1D,EACD;YACA,OAAO,IAAI,CAAC;SACb;KACF;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,oBAAoB,CAC3B,IAAa,EACb,OAA6C;IAE7C,KAAK,MAAM,CAAC,IAAI,OAAO,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE;QAC5C,IAAI,CAAC,CAAC,iBAAiB,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE;YACvC,OAAO,IAAI,CAAC;SACb;KACF;IAED,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,eAAe,CACtB,OAAuB,EACvB,KAAgB,EAChB,IAAa;IAEb,MAAM,IAAI,GAAwB,OAAO,CAAC,eAAe,CACvD,OAAO,CAAC,yBAAyB,CAAC,KAAK,EAAE,IAAI,CAAC,CAC/C,CAAC;IACF,KAAK,MAAM,CAAC,IAAI,OAAO,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE;QAC5C,IAAI,CAAC,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,EAAE;YACtC,OAAO,IAAI,CAAC;SACb;KACF;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,gCAAgC,CACvC,UAAmC;IAEnC,IACE,UAAU,CAAC,MAAM,CAAC,IAAI,KAAK,sBAAc,CAAC,gBAAgB;QAC1D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU;QAC7D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,OAAO;QAC3C,UAAU,CAAC,SAAS,CAAC,MAAM,IAAI,CAAC,EAChC;QACA,OAAO,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;KAChC;SAAM;QACL,OAAO,SAAS,CAAC;KAClB;AACH,CAAC;AAED,SAAS,+BAA+B,CACtC,UAAmC;IAEnC,IACE,UAAU,CAAC,MAAM,CAAC,IAAI,KAAK,sBAAc,CAAC,gBAAgB;QAC1D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU;QAC7D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,MAAM;QAC1C,UAAU,CAAC,SAAS,CAAC,MAAM,IAAI,CAAC,EAChC;QACA,OAAO,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;KAChC;SAAM;QACL,OAAO,SAAS,CAAC;KAClB;AACH,CAAC;AAED,SAAS,+BAA+B,CACtC,UAAmC;IAEnC,OAAO,CACL,UAAU,CAAC,MAAM,CAAC,IAAI,KAAK,sBAAc,CAAC,gBAAgB;QAC1D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU;QAC7D,UAAU,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS;QAC7C,UAAU,CAAC,SAAS,CAAC,MAAM,IAAI,CAAC,CACjC,CAAC;AACJ,CAAC"}
|
package/docs/rules/camelcase.md
CHANGED
|
@@ -5,6 +5,6 @@ This rule has been deprecated in favour of the [`naming-convention`](./naming-co
|
|
|
5
5
|
:::
|
|
6
6
|
|
|
7
7
|
<!--
|
|
8
|
-
This doc file has been left on purpose because `camelcase` is a core
|
|
8
|
+
This doc file has been left on purpose because `camelcase` is a core ESLint rule.
|
|
9
9
|
This exists to help direct people to the replacement rule.
|
|
10
10
|
-->
|
|
@@ -7,7 +7,7 @@ description: 'Require explicit accessibility modifiers on class properties and m
|
|
|
7
7
|
> See **https://typescript-eslint.io/rules/explicit-member-accessibility** for documentation.
|
|
8
8
|
|
|
9
9
|
TypeScript allows placing explicit `public`, `protected`, and `private` accessibility modifiers in front of class members.
|
|
10
|
-
The modifiers exist solely in the type system and just
|
|
10
|
+
The modifiers exist solely in the type system and just serve to describe who is allowed to access those members.
|
|
11
11
|
|
|
12
12
|
Leaving off accessibility modifiers makes for less code to read and write.
|
|
13
13
|
Members are `public` by default.
|
|
@@ -83,7 +83,7 @@ With this option set to `true`, and if you are using `no-void`, you should turn
|
|
|
83
83
|
|
|
84
84
|
### `ignoreIIFE`
|
|
85
85
|
|
|
86
|
-
This allows you to skip checking of async IIFEs (Immediately
|
|
86
|
+
This allows you to skip checking of async IIFEs (Immediately Invoked function Expressions).
|
|
87
87
|
|
|
88
88
|
Examples of **correct** code for this rule with `{ ignoreIIFE: true }`:
|
|
89
89
|
|
package/package.json
CHANGED
|
@@ -1,11 +1,12 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@typescript-eslint/eslint-plugin",
|
|
3
|
-
"version": "6.0.1-alpha.
|
|
3
|
+
"version": "6.0.1-alpha.22+3b0e9d3b7",
|
|
4
4
|
"description": "TypeScript plugin for ESLint",
|
|
5
5
|
"files": [
|
|
6
6
|
"dist",
|
|
7
7
|
"docs",
|
|
8
8
|
"index.d.ts",
|
|
9
|
+
"rules.d.ts",
|
|
9
10
|
"package.json",
|
|
10
11
|
"README.md",
|
|
11
12
|
"LICENSE"
|
|
@@ -55,17 +56,17 @@
|
|
|
55
56
|
"typecheck": "tsc -p tsconfig.json --noEmit"
|
|
56
57
|
},
|
|
57
58
|
"dependencies": {
|
|
58
|
-
"@eslint-community/regexpp": "^4.5.
|
|
59
|
-
"@typescript-eslint/scope-manager": "6.0.1-alpha.
|
|
60
|
-
"@typescript-eslint/type-utils": "6.0.1-alpha.
|
|
61
|
-
"@typescript-eslint/utils": "6.0.1-alpha.
|
|
62
|
-
"@typescript-eslint/visitor-keys": "6.0.1-alpha.
|
|
59
|
+
"@eslint-community/regexpp": "^4.5.1",
|
|
60
|
+
"@typescript-eslint/scope-manager": "6.0.1-alpha.22+3b0e9d3b7",
|
|
61
|
+
"@typescript-eslint/type-utils": "6.0.1-alpha.22+3b0e9d3b7",
|
|
62
|
+
"@typescript-eslint/utils": "6.0.1-alpha.22+3b0e9d3b7",
|
|
63
|
+
"@typescript-eslint/visitor-keys": "6.0.1-alpha.22+3b0e9d3b7",
|
|
63
64
|
"debug": "^4.3.4",
|
|
64
65
|
"graphemer": "^1.4.0",
|
|
65
66
|
"ignore": "^5.2.4",
|
|
66
67
|
"natural-compare": "^1.4.0",
|
|
67
68
|
"natural-compare-lite": "^1.4.0",
|
|
68
|
-
"semver": "^7.5.
|
|
69
|
+
"semver": "^7.5.4",
|
|
69
70
|
"ts-api-utils": "^1.0.1"
|
|
70
71
|
},
|
|
71
72
|
"devDependencies": {
|
|
@@ -74,14 +75,14 @@
|
|
|
74
75
|
"@types/natural-compare": "*",
|
|
75
76
|
"@types/prettier": "*",
|
|
76
77
|
"@typescript-eslint/rule-schema-to-typescript-types": "6.0.0",
|
|
77
|
-
"@typescript-eslint/rule-tester": "6.0.1-alpha.
|
|
78
|
+
"@typescript-eslint/rule-tester": "6.0.1-alpha.22+3b0e9d3b7",
|
|
78
79
|
"ajv": "^6.12.6",
|
|
79
|
-
"chalk": "^5.0
|
|
80
|
+
"chalk": "^5.3.0",
|
|
80
81
|
"cross-fetch": "*",
|
|
81
82
|
"jest-specific-snapshot": "*",
|
|
82
83
|
"json-schema": "*",
|
|
83
84
|
"markdown-table": "^3.0.3",
|
|
84
|
-
"marked": "^
|
|
85
|
+
"marked": "^5.1.1",
|
|
85
86
|
"prettier": "*",
|
|
86
87
|
"title-case": "^3.0.3",
|
|
87
88
|
"typescript": "*"
|
|
@@ -99,5 +100,5 @@
|
|
|
99
100
|
"type": "opencollective",
|
|
100
101
|
"url": "https://opencollective.com/typescript-eslint"
|
|
101
102
|
},
|
|
102
|
-
"gitHead": "
|
|
103
|
+
"gitHead": "3b0e9d3b772035036aed871ddae5a15865fe0523"
|
|
103
104
|
}
|
package/rules.d.ts
ADDED
|
@@ -0,0 +1,44 @@
|
|
|
1
|
+
/*
|
|
2
|
+
We purposely don't generate types for our plugin because TL;DR:
|
|
3
|
+
1) there's no real reason that anyone should do a typed import of our rules,
|
|
4
|
+
2) it would require us to change our code so there aren't as many inferred types
|
|
5
|
+
|
|
6
|
+
This type declaration exists as a hacky way to add a type to the export for our
|
|
7
|
+
internal packages that require it.
|
|
8
|
+
|
|
9
|
+
*** Long reason ***
|
|
10
|
+
|
|
11
|
+
When you turn on declaration files, TS requires all types to be "fully resolvable"
|
|
12
|
+
without changes to the code.
|
|
13
|
+
All of our lint rules `export default createRule(...)`, which means they all
|
|
14
|
+
implicitly reference the `TSESLint.Rule` type for the export.
|
|
15
|
+
|
|
16
|
+
TS wants to transpile each rule file to this `.d.ts` file:
|
|
17
|
+
|
|
18
|
+
```ts
|
|
19
|
+
import type { TSESLint } from '@typescript-eslint/utils';
|
|
20
|
+
declare const _default: TSESLint.RuleModule<TMessageIds, TOptions, TSESLint.RuleListener>;
|
|
21
|
+
export default _default;
|
|
22
|
+
```
|
|
23
|
+
|
|
24
|
+
Because we don't import `TSESLint` in most files, it means that TS would have to
|
|
25
|
+
insert a new import during the declaration emit to make this work.
|
|
26
|
+
However TS wants to avoid adding new imports to the file because a new module
|
|
27
|
+
could have type side-effects (like global augmentation) which could cause weird
|
|
28
|
+
type side-effects in the decl file that wouldn't exist in source TS file.
|
|
29
|
+
|
|
30
|
+
So TS errors on most of our rules with the following error:
|
|
31
|
+
```
|
|
32
|
+
The inferred type of 'default' cannot be named without a reference to
|
|
33
|
+
'../../../../node_modules/@typescript-eslint/utils/src/ts-eslint/Rule'.
|
|
34
|
+
This is likely not portable. A type annotation is necessary. ts(2742)
|
|
35
|
+
```
|
|
36
|
+
*/
|
|
37
|
+
|
|
38
|
+
import type { RuleModule } from '@typescript-eslint/utils/ts-eslint';
|
|
39
|
+
|
|
40
|
+
export interface TypeScriptESLintRules {
|
|
41
|
+
[ruleName: string]: RuleModule<string, unknown[]>;
|
|
42
|
+
}
|
|
43
|
+
declare const rules: TypeScriptESLintRules;
|
|
44
|
+
export = rules;
|