@typescript-deploys/pr-build 5.6.0-pr-59514-2 → 5.6.0-pr-59523-2

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.6";
-var version = `${versionMajorMinor}.0-insiders.20240802`;
+var version = `${versionMajorMinor}.0-insiders.20240803`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -25403,7 +25403,7 @@ var asyncGeneratorHelper = {
         var __asyncGenerator = (this && this.__asyncGenerator) || function (thisArg, _arguments, generator) {
             if (!Symbol.asyncIterator) throw new TypeError("Symbol.asyncIterator is not defined.");
             var g = generator.apply(thisArg, _arguments || []), i, q = [];
-            return i = Object.create((typeof AsyncIterator === "function" ? AsyncIterator : Object).prototype), verb("next"), verb("throw"), verb("return", awaitReturn), i[Symbol.asyncIterator] = function () { return this; }, i;
+            return i = {}, verb("next"), verb("throw"), verb("return", awaitReturn), i[Symbol.asyncIterator] = function () { return this; }, i;
             function awaitReturn(f) { return function (v) { return Promise.resolve(v).then(f, reject); }; }
             function verb(n, f) { if (g[n]) { i[n] = function (v) { return new Promise(function (a, b) { q.push([n, v, a, b]) > 1 || resume(n, v); }); }; if (f) i[n] = f(i[n]); } }
             function resume(n, v) { try { step(g[n](v)); } catch (e) { settle(q[0][3], e); } }
@@ -25585,8 +25585,8 @@ var generatorHelper = {
   priority: 6,
   text: `
             var __generator = (this && this.__generator) || function (thisArg, body) {
-                var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g = Object.create((typeof Iterator === "function" ? Iterator : Object).prototype);
-                return g.next = verb(0), g["throw"] = verb(1), g["return"] = verb(2), typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
+                var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g;
+                return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
                 function verb(n) { return function (v) { return step([n, v]); }; }
                 function step(op) {
                     if (f) throw new TypeError("Generator is already executing.");
@@ -72892,8 +72892,21 @@ function createTypeChecker(host) {
   function getEnclosingClassFromThisParameter(node) {
     const thisParameter = getThisParameterFromNodeContext(node);
     let thisType = (thisParameter == null ? void 0 : thisParameter.type) && getTypeFromTypeNode(thisParameter.type);
-    if (thisType && thisType.flags & 262144 /* TypeParameter */) {
-      thisType = getConstraintOfTypeParameter(thisType);
+    if (thisType) {
+      if (thisType.flags & 262144 /* TypeParameter */) {
+        thisType = getConstraintOfTypeParameter(thisType);
+      }
+    } else {
+      const thisContainer = getThisContainer(
+        node,
+        /*includeArrowFunctions*/
+        false,
+        /*includeClassComputedPropertyName*/
+        false
+      );
+      if (isFunctionLike(thisContainer)) {
+        thisType = getContextualThisParameterType(thisContainer);
+      }
     }
     if (thisType && getObjectFlags(thisType) & (3 /* ClassOrInterface */ | 4 /* Reference */)) {
       return getTargetType(thisType);
@@ -79046,9 +79059,7 @@ function createTypeChecker(host) {
     }
     checkSourceElement(node.type);
     const { parameterName } = node;
-    if (typePredicate.kind === 0 /* This */ || typePredicate.kind === 2 /* AssertsThis */) {
-      getTypeFromThisTypeNode(parameterName);
-    } else {
+    if (typePredicate.kind !== 0 /* This */ && typePredicate.kind !== 2 /* AssertsThis */) {
       if (typePredicate.parameterIndex >= 0) {
         if (signatureHasRestParameter(signature) && typePredicate.parameterIndex === signature.parameters.length - 1) {
           error(parameterName, Diagnostics.A_type_predicate_cannot_reference_a_rest_parameter);
@@ -81397,7 +81408,7 @@ function createTypeChecker(host) {
         bothHelper(location, body2);
         return;
       }
-      const type = location === condExpr2 ? condType : checkTruthinessExpression(location);
+      const type = location === condExpr2 ? condType : checkExpression(location);
       if (type.flags & 1024 /* EnumLiteral */ && isPropertyAccessExpression(location) && (getNodeLinks(location.expression).resolvedSymbol ?? unknownSymbol).flags & 384 /* Enum */) {
         error(location, Diagnostics.This_condition_will_always_return_0, !!type.value ? "true" : "false");
         return;
@@ -83592,6 +83603,7 @@ function createTypeChecker(host) {
         grammarErrorOnFirstToken(node, Diagnostics.Exports_and_export_assignments_are_not_permitted_in_module_augmentations);
         break;
       case 271 /* ImportEqualsDeclaration */:
+        if (isInternalModuleImportEqualsDeclaration(node)) break;
       case 272 /* ImportDeclaration */:
         grammarErrorOnFirstToken(node, Diagnostics.Imports_are_not_permitted_in_module_augmentations_Consider_moving_them_to_the_enclosing_external_module);
         break;

package/lib/typescript.js

@@ -2260,7 +2260,7 @@ module.exports = __toCommonJS(typescript_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.6";
-var version = `${versionMajorMinor}.0-insiders.20240802`;
+var version = `${versionMajorMinor}.0-insiders.20240803`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -29552,7 +29552,7 @@ var asyncGeneratorHelper = {
         var __asyncGenerator = (this && this.__asyncGenerator) || function (thisArg, _arguments, generator) {
             if (!Symbol.asyncIterator) throw new TypeError("Symbol.asyncIterator is not defined.");
             var g = generator.apply(thisArg, _arguments || []), i, q = [];
-            return i = Object.create((typeof AsyncIterator === "function" ? AsyncIterator : Object).prototype), verb("next"), verb("throw"), verb("return", awaitReturn), i[Symbol.asyncIterator] = function () { return this; }, i;
+            return i = {}, verb("next"), verb("throw"), verb("return", awaitReturn), i[Symbol.asyncIterator] = function () { return this; }, i;
             function awaitReturn(f) { return function (v) { return Promise.resolve(v).then(f, reject); }; }
             function verb(n, f) { if (g[n]) { i[n] = function (v) { return new Promise(function (a, b) { q.push([n, v, a, b]) > 1 || resume(n, v); }); }; if (f) i[n] = f(i[n]); } }
             function resume(n, v) { try { step(g[n](v)); } catch (e) { settle(q[0][3], e); } }
@@ -29734,8 +29734,8 @@ var generatorHelper = {
   priority: 6,
   text: `
             var __generator = (this && this.__generator) || function (thisArg, body) {
-                var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g = Object.create((typeof Iterator === "function" ? Iterator : Object).prototype);
-                return g.next = verb(0), g["throw"] = verb(1), g["return"] = verb(2), typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
+                var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g;
+                return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
                 function verb(n) { return function (v) { return step([n, v]); }; }
                 function step(op) {
                     if (f) throw new TypeError("Generator is already executing.");
@@ -77511,8 +77511,21 @@ function createTypeChecker(host) {
   function getEnclosingClassFromThisParameter(node) {
     const thisParameter = getThisParameterFromNodeContext(node);
     let thisType = (thisParameter == null ? void 0 : thisParameter.type) && getTypeFromTypeNode(thisParameter.type);
-    if (thisType && thisType.flags & 262144 /* TypeParameter */) {
-      thisType = getConstraintOfTypeParameter(thisType);
+    if (thisType) {
+      if (thisType.flags & 262144 /* TypeParameter */) {
+        thisType = getConstraintOfTypeParameter(thisType);
+      }
+    } else {
+      const thisContainer = getThisContainer(
+        node,
+        /*includeArrowFunctions*/
+        false,
+        /*includeClassComputedPropertyName*/
+        false
+      );
+      if (isFunctionLike(thisContainer)) {
+        thisType = getContextualThisParameterType(thisContainer);
+      }
     }
     if (thisType && getObjectFlags(thisType) & (3 /* ClassOrInterface */ | 4 /* Reference */)) {
       return getTargetType(thisType);
@@ -83665,9 +83678,7 @@ function createTypeChecker(host) {
     }
     checkSourceElement(node.type);
     const { parameterName } = node;
-    if (typePredicate.kind === 0 /* This */ || typePredicate.kind === 2 /* AssertsThis */) {
-      getTypeFromThisTypeNode(parameterName);
-    } else {
+    if (typePredicate.kind !== 0 /* This */ && typePredicate.kind !== 2 /* AssertsThis */) {
       if (typePredicate.parameterIndex >= 0) {
         if (signatureHasRestParameter(signature) && typePredicate.parameterIndex === signature.parameters.length - 1) {
           error2(parameterName, Diagnostics.A_type_predicate_cannot_reference_a_rest_parameter);
@@ -86016,7 +86027,7 @@ function createTypeChecker(host) {
         bothHelper(location, body2);
         return;
       }
-      const type = location === condExpr2 ? condType : checkTruthinessExpression(location);
+      const type = location === condExpr2 ? condType : checkExpression(location);
       if (type.flags & 1024 /* EnumLiteral */ && isPropertyAccessExpression(location) && (getNodeLinks(location.expression).resolvedSymbol ?? unknownSymbol).flags & 384 /* Enum */) {
         error2(location, Diagnostics.This_condition_will_always_return_0, !!type.value ? "true" : "false");
         return;
@@ -88211,6 +88222,7 @@ function createTypeChecker(host) {
         grammarErrorOnFirstToken(node, Diagnostics.Exports_and_export_assignments_are_not_permitted_in_module_augmentations);
         break;
       case 271 /* ImportEqualsDeclaration */:
+        if (isInternalModuleImportEqualsDeclaration(node)) break;
       case 272 /* ImportDeclaration */:
         grammarErrorOnFirstToken(node, Diagnostics.Imports_are_not_permitted_in_module_augmentations_Consider_moving_them_to_the_enclosing_external_module);
         break;
@@ -163133,6 +163145,8 @@ var SortText = {
     return sortText + "1";
   }
 };
+var allCommitCharacters = [".", ",", ";"];
+var noCommaCommitCharacters = [".", ";"];
 var CompletionSource = /* @__PURE__ */ ((CompletionSource2) => {
   CompletionSource2["ThisProperty"] = "ThisProperty/";
   CompletionSource2["ClassMemberSnippet"] = "ClassMemberSnippet/";
@@ -163239,7 +163253,7 @@ function getDefaultCommitCharacters(isNewIdentifierLocation) {
   if (isNewIdentifierLocation) {
     return [];
   }
-  return [".", ",", ";"];
+  return allCommitCharacters;
 }
 function getCompletionsAtPosition(host, program, log, sourceFile, position, preferences, triggerCharacter, completionKind, cancellationToken, formatContext, includeSymbol = false) {
   var _a;
@@ -163737,7 +163751,8 @@ function completionInfoFromData(sourceFile, host, program, compilerOptions, log,
     importStatementCompletion,
     insideJsDocTagTypeExpression,
     symbolToSortTextMap,
-    hasUnresolvedAutoImports
+    hasUnresolvedAutoImports,
+    defaultCommitCharacters
   } = completionData;
   let literals = completionData.literals;
   const checker = program.getTypeChecker();
@@ -163855,7 +163870,7 @@ function completionInfoFromData(sourceFile, host, program, compilerOptions, log,
     isNewIdentifierLocation,
     optionalReplacementSpan: getOptionalReplacementSpan(location),
     entries,
-    defaultCommitCharacters: getDefaultCommitCharacters(isNewIdentifierLocation)
+    defaultCommitCharacters: defaultCommitCharacters ?? getDefaultCommitCharacters(isNewIdentifierLocation)
   };
 }
 function isCheckedFile(sourceFile, compilerOptions) {
@@ -165247,6 +165262,7 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
   let keywordFilters = 0 /* None */;
   let isNewIdentifierLocation = false;
   let flags = 0 /* None */;
+  let defaultCommitCharacters;
   if (contextToken) {
     const importStatementCompletionInfo = getImportStatementCompletionInfo(contextToken, sourceFile);
     if (importStatementCompletionInfo.keywordCompletion) {
@@ -165266,7 +165282,7 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
     }
     if (!importStatementCompletionInfo.replacementSpan && isCompletionListBlocker(contextToken)) {
       log("Returning an empty list because completion was requested in an invalid position.");
-      return keywordFilters ? keywordCompletionData(keywordFilters, isJsOnlyLocation, isNewIdentifierDefinitionLocation()) : void 0;
+      return keywordFilters ? keywordCompletionData(keywordFilters, isJsOnlyLocation, computeCommitCharactersAndIsNewIdentifier().isNewIdentifierLocation) : void 0;
     }
     let parent2 = contextToken.parent;
     if (contextToken.kind === 25 /* DotToken */ || contextToken.kind === 29 /* QuestionDotToken */) {
@@ -165425,7 +165441,8 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
     isRightOfDotOrQuestionDot: isRightOfDot || isRightOfQuestionDot,
     importStatementCompletion,
     hasUnresolvedAutoImports,
-    flags
+    flags,
+    defaultCommitCharacters
   };
   function isTagWithTypeExpression(tag) {
     switch (tag.kind) {
@@ -165460,7 +165477,10 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
     const isRhsOfImportDeclaration = isInRightSideOfInternalImportEqualsDeclaration(node);
     if (isEntityName(node) || isImportType || isPropertyAccessExpression(node)) {
       const isNamespaceName = isModuleDeclaration(node.parent);
-      if (isNamespaceName) isNewIdentifierLocation = true;
+      if (isNamespaceName) {
+        isNewIdentifierLocation = true;
+        defaultCommitCharacters = [];
+      }
       let symbol = typeChecker.getSymbolAtLocation(node);
       if (symbol) {
         symbol = skipAlias(symbol, typeChecker);
@@ -165530,9 +165550,13 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
     }
   }
   function addTypeProperties(type, insertAwait, insertQuestionDot) {
-    isNewIdentifierLocation = !!type.getStringIndexType();
+    if (type.getStringIndexType()) {
+      isNewIdentifierLocation = true;
+      defaultCommitCharacters = [];
+    }
     if (isRightOfQuestionDot && some(type.getCallSignatures())) {
       isNewIdentifierLocation = true;
+      defaultCommitCharacters ?? (defaultCommitCharacters = allCommitCharacters);
     }
     const propertyAccess = node.kind === 205 /* ImportType */ ? node : node.parent;
     if (inCheckedFile) {
@@ -165671,7 +165695,7 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
   function getGlobalCompletions() {
     keywordFilters = tryGetFunctionLikeBodyCompletionContainer(contextToken) ? 5 /* FunctionLikeBodyKeywords */ : 1 /* All */;
     completionKind = 1 /* Global */;
-    isNewIdentifierLocation = isNewIdentifierDefinitionLocation();
+    ({ isNewIdentifierLocation, defaultCommitCharacters } = computeCommitCharactersAndIsNewIdentifier());
     if (previousToken !== contextToken) {
       Debug.assert(!!previousToken, "Expected 'contextToken' to be defined when different from 'previousToken'.");
     }
@@ -165937,41 +165961,109 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
     }
     return false;
   }
-  function isNewIdentifierDefinitionLocation() {
+  function computeCommitCharactersAndIsNewIdentifier() {
     if (contextToken) {
       const containingNodeKind = contextToken.parent.kind;
       const tokenKind = keywordForNode(contextToken);
       switch (tokenKind) {
         case 28 /* CommaToken */:
-          return containingNodeKind === 213 /* CallExpression */ || containingNodeKind === 176 /* Constructor */ || containingNodeKind === 214 /* NewExpression */ || containingNodeKind === 209 /* ArrayLiteralExpression */ || containingNodeKind === 226 /* BinaryExpression */ || containingNodeKind === 184 /* FunctionType */ || containingNodeKind === 210 /* ObjectLiteralExpression */;
+          switch (containingNodeKind) {
+            case 213 /* CallExpression */:
+            case 214 /* NewExpression */: {
+              const expression = contextToken.parent.expression;
+              if (getLineAndCharacterOfPosition(sourceFile, expression.end).line !== getLineAndCharacterOfPosition(sourceFile, position).line) {
+                return { defaultCommitCharacters: noCommaCommitCharacters, isNewIdentifierLocation: true };
+              }
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: true };
+            }
+            case 226 /* BinaryExpression */:
+              return { defaultCommitCharacters: noCommaCommitCharacters, isNewIdentifierLocation: true };
+            case 176 /* Constructor */:
+            case 184 /* FunctionType */:
+            case 210 /* ObjectLiteralExpression */:
+              return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
+            case 209 /* ArrayLiteralExpression */:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 21 /* OpenParenToken */:
-          return containingNodeKind === 213 /* CallExpression */ || containingNodeKind === 176 /* Constructor */ || containingNodeKind === 214 /* NewExpression */ || containingNodeKind === 217 /* ParenthesizedExpression */ || containingNodeKind === 196 /* ParenthesizedType */;
+          switch (containingNodeKind) {
+            case 213 /* CallExpression */:
+            case 214 /* NewExpression */: {
+              const expression = contextToken.parent.expression;
+              if (getLineAndCharacterOfPosition(sourceFile, expression.end).line !== getLineAndCharacterOfPosition(sourceFile, position).line) {
+                return { defaultCommitCharacters: noCommaCommitCharacters, isNewIdentifierLocation: true };
+              }
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: true };
+            }
+            case 217 /* ParenthesizedExpression */:
+              return { defaultCommitCharacters: noCommaCommitCharacters, isNewIdentifierLocation: true };
+            case 176 /* Constructor */:
+            case 196 /* ParenthesizedType */:
+              return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 23 /* OpenBracketToken */:
-          return containingNodeKind === 209 /* ArrayLiteralExpression */ || containingNodeKind === 181 /* IndexSignature */ || containingNodeKind === 167 /* ComputedPropertyName */;
+          switch (containingNodeKind) {
+            case 209 /* ArrayLiteralExpression */:
+            case 181 /* IndexSignature */:
+            case 189 /* TupleType */:
+            case 167 /* ComputedPropertyName */:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 144 /* ModuleKeyword */:
         case 145 /* NamespaceKeyword */:
         case 102 /* ImportKeyword */:
-          return true;
+          return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
         case 25 /* DotToken */:
-          return containingNodeKind === 267 /* ModuleDeclaration */;
+          switch (containingNodeKind) {
+            case 267 /* ModuleDeclaration */:
+              return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 19 /* OpenBraceToken */:
-          return containingNodeKind === 263 /* ClassDeclaration */ || containingNodeKind === 210 /* ObjectLiteralExpression */;
+          switch (containingNodeKind) {
+            case 263 /* ClassDeclaration */:
+            case 210 /* ObjectLiteralExpression */:
+              return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 64 /* EqualsToken */:
-          return containingNodeKind === 260 /* VariableDeclaration */ || containingNodeKind === 226 /* BinaryExpression */;
+          switch (containingNodeKind) {
+            case 260 /* VariableDeclaration */:
+            case 226 /* BinaryExpression */:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: true };
+            default:
+              return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
+          }
         case 16 /* TemplateHead */:
-          return containingNodeKind === 228 /* TemplateExpression */;
+          return {
+            defaultCommitCharacters: allCommitCharacters,
+            isNewIdentifierLocation: containingNodeKind === 228 /* TemplateExpression */
+            // `aa ${|
+          };
         case 17 /* TemplateMiddle */:
-          return containingNodeKind === 239 /* TemplateSpan */;
+          return {
+            defaultCommitCharacters: allCommitCharacters,
+            isNewIdentifierLocation: containingNodeKind === 239 /* TemplateSpan */
+            // `aa ${10} dd ${|
+          };
         case 134 /* AsyncKeyword */:
-          return containingNodeKind === 174 /* MethodDeclaration */ || containingNodeKind === 304 /* ShorthandPropertyAssignment */;
+          return containingNodeKind === 174 /* MethodDeclaration */ || containingNodeKind === 304 /* ShorthandPropertyAssignment */ ? { defaultCommitCharacters: [], isNewIdentifierLocation: true } : { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
         case 42 /* AsteriskToken */:
-          return containingNodeKind === 174 /* MethodDeclaration */;
+          return containingNodeKind === 174 /* MethodDeclaration */ ? { defaultCommitCharacters: [], isNewIdentifierLocation: true } : { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
       }
       if (isClassMemberCompletionKeyword(tokenKind)) {
-        return true;
+        return { defaultCommitCharacters: [], isNewIdentifierLocation: true };
       }
     }
-    return false;
+    return { defaultCommitCharacters: allCommitCharacters, isNewIdentifierLocation: false };
   }
   function isInStringOrRegularExpressionOrTemplateLiteral(contextToken2) {
     return (isRegularExpressionLiteral(contextToken2) || isStringTextContainingNode(contextToken2)) && (rangeContainsPositionExclusive(contextToken2, position) || position === contextToken2.end && (!!contextToken2.isUnterminated || isRegularExpressionLiteral(contextToken2)));