@typescript-deploys/pr-build 5.5.0-pr-57465-98 → 5.5.0-pr-57465-103

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.5";
-var version = `${versionMajorMinor}.0-insiders.20240313`;
+var version = `${versionMajorMinor}.0-insiders.20240314`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -6096,6 +6096,8 @@ var Diagnostics = {
   The_left_hand_side_of_a_for_in_statement_cannot_be_an_await_using_declaration: diag(1494, 1 /* Error */, "The_left_hand_side_of_a_for_in_statement_cannot_be_an_await_using_declaration_1494", "The left-hand side of a 'for...in' statement cannot be an 'await using' declaration."),
   _0_modifier_cannot_appear_on_an_await_using_declaration: diag(1495, 1 /* Error */, "_0_modifier_cannot_appear_on_an_await_using_declaration_1495", "'{0}' modifier cannot appear on an 'await using' declaration."),
   Identifier_string_literal_or_number_literal_expected: diag(1496, 1 /* Error */, "Identifier_string_literal_or_number_literal_expected_1496", "Identifier, string literal, or number literal expected."),
+  Expression_must_be_enclosed_in_parentheses_to_be_used_as_a_decorator: diag(1497, 1 /* Error */, "Expression_must_be_enclosed_in_parentheses_to_be_used_as_a_decorator_1497", "Expression must be enclosed in parentheses to be used as a decorator."),
+  Invalid_syntax_in_decorator: diag(1498, 1 /* Error */, "Invalid_syntax_in_decorator_1498", "Invalid syntax in decorator."),
   The_types_of_0_are_incompatible_between_these_types: diag(2200, 1 /* Error */, "The_types_of_0_are_incompatible_between_these_types_2200", "The types of '{0}' are incompatible between these types."),
   The_types_returned_by_0_are_incompatible_between_these_types: diag(2201, 1 /* Error */, "The_types_returned_by_0_are_incompatible_between_these_types_2201", "The types returned by '{0}' are incompatible between these types."),
   Call_signature_return_types_0_and_1_are_incompatible: diag(
@@ -7747,6 +7749,8 @@ var Diagnostics = {
   Add_optional_parameter_to_0: diag(95191, 3 /* Message */, "Add_optional_parameter_to_0_95191", "Add optional parameter to '{0}'"),
   Add_optional_parameters_to_0: diag(95192, 3 /* Message */, "Add_optional_parameters_to_0_95192", "Add optional parameters to '{0}'"),
   Add_all_optional_parameters: diag(95193, 3 /* Message */, "Add_all_optional_parameters_95193", "Add all optional parameters"),
+  Wrap_in_parentheses: diag(95194, 3 /* Message */, "Wrap_in_parentheses_95194", "Wrap in parentheses"),
+  Wrap_all_invalid_decorator_expressions_in_parentheses: diag(95195, 3 /* Message */, "Wrap_all_invalid_decorator_expressions_in_parentheses_95195", "Wrap all invalid decorator expressions in parentheses"),
   No_value_exists_in_scope_for_the_shorthand_property_0_Either_declare_one_or_provide_an_initializer: diag(18004, 1 /* Error */, "No_value_exists_in_scope_for_the_shorthand_property_0_Either_declare_one_or_provide_an_initializer_18004", "No value exists in scope for the shorthand property '{0}'. Either declare one or provide an initializer."),
   Classes_may_not_have_a_field_named_constructor: diag(18006, 1 /* Error */, "Classes_may_not_have_a_field_named_constructor_18006", "Classes may not have a field named 'constructor'."),
   JSX_expressions_may_not_use_the_comma_operator_Did_you_mean_to_write_an_array: diag(18007, 1 /* Error */, "JSX_expressions_may_not_use_the_comma_operator_Did_you_mean_to_write_an_array_18007", "JSX expressions may not use the comma operator. Did you mean to write an array?"),
@@ -17650,6 +17654,20 @@ function replaceFirstStar(s, replacement) {
 function getNameFromImportAttribute(node) {
   return isIdentifier(node.name) ? node.name.escapedText : escapeLeadingUnderscores(node.name.text);
 }
+function isSyntacticallyString(expr) {
+  expr = skipOuterExpressions(expr);
+  switch (expr.kind) {
+    case 226 /* BinaryExpression */:
+      const left = expr.left;
+      const right = expr.right;
+      return expr.operatorToken.kind === 40 /* PlusToken */ && (isSyntacticallyString(left) || isSyntacticallyString(right));
+    case 228 /* TemplateExpression */:
+    case 11 /* StringLiteral */:
+    case 15 /* NoSubstitutionTemplateLiteral */:
+      return true;
+  }
+  return false;
+}
 
 // src/compiler/factory/baseNodeFactory.ts
 function createBaseNodeFactory() {
@@ -55643,7 +55661,7 @@ function createTypeChecker(host) {
         }
         if (type || jsdocPredicate) {
           signature.resolvedTypePredicate = type && isTypePredicateNode(type) ? createTypePredicateFromTypePredicateNode(type, signature) : jsdocPredicate || noTypePredicate;
-        } else if (signature.declaration && isFunctionLikeDeclaration(signature.declaration) && (!signature.resolvedReturnType || signature.resolvedReturnType.flags & 16 /* Boolean */)) {
+        } else if (signature.declaration && isFunctionLikeDeclaration(signature.declaration) && (!signature.resolvedReturnType || signature.resolvedReturnType.flags & 16 /* Boolean */) && getParameterCount(signature) > 0) {
           const { declaration } = signature;
           signature.resolvedTypePredicate = noTypePredicate;
           signature.resolvedTypePredicate = getTypePredicateFromBody(declaration) || noTypePredicate;
@@ -57599,7 +57617,7 @@ function createTypeChecker(host) {
       const typeVarIndex = typeSet[0].flags & 8650752 /* TypeVariable */ ? 0 : 1;
       const typeVariable = typeSet[typeVarIndex];
       const primitiveType = typeSet[1 - typeVarIndex];
-      if (typeVariable.flags & 8650752 /* TypeVariable */ && (primitiveType.flags & (402784252 /* Primitive */ | 67108864 /* NonPrimitive */) || includes & 16777216 /* IncludesEmptyObject */)) {
+      if (typeVariable.flags & 8650752 /* TypeVariable */ && (primitiveType.flags & (402784252 /* Primitive */ | 67108864 /* NonPrimitive */) && !isGenericStringLikeType(primitiveType) || includes & 16777216 /* IncludesEmptyObject */)) {
         const constraint = getBaseConstraintOfType(typeVariable);
         if (constraint && everyType(constraint, (t) => !!(t.flags & (402784252 /* Primitive */ | 67108864 /* NonPrimitive */)) || isEmptyAnonymousObjectType(t))) {
           if (isTypeStrictSubtypeOf(constraint, primitiveType)) {
@@ -58204,6 +58222,9 @@ function createTypeChecker(host) {
   function isPatternLiteralType(type) {
     return !!(type.flags & 134217728 /* TemplateLiteral */) && every(type.types, isPatternLiteralPlaceholderType) || !!(type.flags & 268435456 /* StringMapping */) && isPatternLiteralPlaceholderType(type.type);
   }
+  function isGenericStringLikeType(type) {
+    return !!(type.flags & (134217728 /* TemplateLiteral */ | 268435456 /* StringMapping */)) && !isPatternLiteralType(type);
+  }
   function isGenericType(type) {
     return !!getGenericObjectFlags(type);
   }
@@ -58226,7 +58247,7 @@ function createTypeChecker(host) {
       }
       return type.objectFlags & 12582912 /* IsGenericType */;
     }
-    return (type.flags & 58982400 /* InstantiableNonPrimitive */ || isGenericMappedType(type) || isGenericTupleType(type) ? 4194304 /* IsGenericObjectType */ : 0) | (type.flags & (58982400 /* InstantiableNonPrimitive */ | 4194304 /* Index */ | 134217728 /* TemplateLiteral */ | 268435456 /* StringMapping */) && !isPatternLiteralType(type) ? 8388608 /* IsGenericIndexType */ : 0);
+    return (type.flags & 58982400 /* InstantiableNonPrimitive */ || isGenericMappedType(type) || isGenericTupleType(type) ? 4194304 /* IsGenericObjectType */ : 0) | (type.flags & (58982400 /* InstantiableNonPrimitive */ | 4194304 /* Index */) || isGenericStringLikeType(type) ? 8388608 /* IsGenericIndexType */ : 0);
   }
   function getSimplifiedType(type, writing) {
     return type.flags & 8388608 /* IndexedAccess */ ? getSimplifiedIndexedAccessType(type, writing) : type.flags & 16777216 /* Conditional */ ? getSimplifiedConditionalType(type, writing) : type;
@@ -74081,7 +74102,7 @@ function createTypeChecker(host) {
         return void 0;
     }
     const functionFlags = getFunctionFlags(func);
-    if (functionFlags !== 0 /* Normal */ || func.parameters.length === 0)
+    if (functionFlags !== 0 /* Normal */)
       return void 0;
     let singleReturn;
     if (func.body && func.body.kind !== 241 /* Block */) {
@@ -74108,7 +74129,7 @@ function createTypeChecker(host) {
       return void 0;
     return forEach(func.parameters, (param, i) => {
       const initType = getTypeOfSymbol(param.symbol);
-      if (!initType || initType.flags & 16 /* Boolean */ || !isIdentifier(param.name) || isSymbolAssigned(param.symbol)) {
+      if (!initType || initType.flags & 16 /* Boolean */ || !isIdentifier(param.name) || isSymbolAssigned(param.symbol) || isRestParameter(param)) {
         return;
       }
       const trueType2 = checkIfExpressionRefinesParameter(func, expr, param, initType);
@@ -77414,7 +77435,56 @@ function createTypeChecker(host) {
       }
     }
   }
+  function checkGrammarDecorator(decorator) {
+    const sourceFile = getSourceFileOfNode(decorator);
+    if (!hasParseDiagnostics(sourceFile)) {
+      let node = decorator.expression;
+      if (isParenthesizedExpression(node)) {
+        return false;
+      }
+      let canHaveCallExpression = true;
+      let errorNode;
+      while (true) {
+        if (isExpressionWithTypeArguments(node) || isNonNullExpression(node)) {
+          node = node.expression;
+          continue;
+        }
+        if (isCallExpression(node)) {
+          if (!canHaveCallExpression) {
+            errorNode = node;
+          }
+          if (node.questionDotToken) {
+            errorNode = node.questionDotToken;
+          }
+          node = node.expression;
+          canHaveCallExpression = false;
+          continue;
+        }
+        if (isPropertyAccessExpression(node)) {
+          if (node.questionDotToken) {
+            errorNode = node.questionDotToken;
+          }
+          node = node.expression;
+          canHaveCallExpression = false;
+          continue;
+        }
+        if (!isIdentifier(node)) {
+          errorNode = node;
+        }
+        break;
+      }
+      if (errorNode) {
+        addRelatedInfo(
+          error(decorator.expression, Diagnostics.Expression_must_be_enclosed_in_parentheses_to_be_used_as_a_decorator),
+          createDiagnosticForNode(errorNode, Diagnostics.Invalid_syntax_in_decorator)
+        );
+        return true;
+      }
+    }
+    return false;
+  }
   function checkDecorator(node) {
+    checkGrammarDecorator(node);
     const signature = getResolvedSignature(node);
     checkDeprecatedSignature(signature, node);
     const returnType = getReturnTypeOfSignature(signature);
@@ -89403,7 +89473,7 @@ function transformTypeScript(context) {
       ),
       valueExpression
     );
-    const outerAssignment = valueExpression.kind === 11 /* StringLiteral */ ? innerAssignment : factory2.createAssignment(
+    const outerAssignment = isSyntacticallyString(valueExpression) ? innerAssignment : factory2.createAssignment(
       factory2.createElementAccessExpression(
         currentNamespaceContainerName,
         innerAssignment