@typescript-deploys/pr-build 5.4.0-pr-56418-6 → 5.4.0-pr-56429-7

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -48268,6 +48268,8 @@ function createTypeChecker(host) {
           context.symbolDepth.set(id, depth + 1);
         }
         context.visitedTypes.add(typeId);
+        const prevTrackedSymbols = context.trackedSymbols;
+        context.trackedSymbols = void 0;
         const startLength = context.approximateLength;
         const result = transform(type2);
         const addedLength = context.approximateLength - startLength;
@@ -48283,6 +48285,7 @@ function createTypeChecker(host) {
         if (id) {
           context.symbolDepth.set(id, depth);
         }
+        context.trackedSymbols = prevTrackedSymbols;
         return result;
         function deepCloneOrReuseNode(node) {
           if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -52607,7 +52610,7 @@ function createTypeChecker(host) {
         } else if (getter && noImplicitAny) {
           error(getter, Diagnostics._0_implicitly_has_return_type_any_because_it_does_not_have_a_return_type_annotation_and_is_referenced_directly_or_indirectly_in_one_of_its_return_expressions, symbolToString(symbol));
         }
-        type = anyType;
+        type = errorType;
       }
       links.type = type;
     }
@@ -52625,7 +52628,7 @@ function createTypeChecker(host) {
         if (getAnnotatedAccessorTypeNode(setter)) {
           error(setter, Diagnostics._0_is_referenced_directly_or_indirectly_in_its_own_type_annotation, symbolToString(symbol));
         }
-        writeType = anyType;
+        writeType = errorType;
       }
       links.writeType = writeType || getTypeOfAccessors(symbol);
     }
@@ -52706,8 +52709,7 @@ function createTypeChecker(host) {
       const declaredType = firstDefined(exportSymbol == null ? void 0 : exportSymbol.declarations, (d) => isExportAssignment(d) ? tryGetTypeFromEffectiveTypeNode(d) : void 0);
       links.type = (exportSymbol == null ? void 0 : exportSymbol.declarations) && isDuplicatedCommonJSExport(exportSymbol.declarations) && symbol.declarations.length ? getFlowTypeFromCommonJSExport(exportSymbol) : isDuplicatedCommonJSExport(symbol.declarations) ? autoType : declaredType ? declaredType : getSymbolFlags(targetSymbol) & 111551 /* Value */ ? getTypeOfSymbol(targetSymbol) : errorType;
       if (!popTypeResolution()) {
-        reportCircularityError(exportSymbol ?? symbol);
-        return links.type = errorType;
+        return links.type = reportCircularityError(exportSymbol ?? symbol);
       }
     }
     return links.type;
@@ -52736,7 +52738,7 @@ function createTypeChecker(host) {
         error(node, Diagnostics.Circular_definition_of_import_alias_0, symbolToString(symbol));
       }
     }
-    return anyType;
+    return errorType;
   }
   function getTypeOfSymbolWithDeferredType(symbol) {
     const links = getSymbolLinks(symbol);
@@ -55497,7 +55499,7 @@ function createTypeChecker(host) {
             }
           }
         }
-        type = anyType;
+        type = errorType;
       }
       signature.resolvedReturnType = type;
     }
@@ -75536,7 +75538,7 @@ function createTypeChecker(host) {
       const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
       if (modifiers) {
         const symbol = getSymbolOfDeclaration(node.parent);
-        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
           error(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
         } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
           (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });

package/lib/tsserver.js

@@ -2330,7 +2330,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -52976,6 +52976,8 @@ function createTypeChecker(host) {
           context.symbolDepth.set(id, depth + 1);
         }
         context.visitedTypes.add(typeId);
+        const prevTrackedSymbols = context.trackedSymbols;
+        context.trackedSymbols = void 0;
         const startLength = context.approximateLength;
         const result = transform2(type2);
         const addedLength = context.approximateLength - startLength;
@@ -52991,6 +52993,7 @@ function createTypeChecker(host) {
         if (id) {
           context.symbolDepth.set(id, depth);
         }
+        context.trackedSymbols = prevTrackedSymbols;
         return result;
         function deepCloneOrReuseNode(node) {
           if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -57315,7 +57318,7 @@ function createTypeChecker(host) {
         } else if (getter && noImplicitAny) {
           error2(getter, Diagnostics._0_implicitly_has_return_type_any_because_it_does_not_have_a_return_type_annotation_and_is_referenced_directly_or_indirectly_in_one_of_its_return_expressions, symbolToString(symbol));
         }
-        type = anyType;
+        type = errorType;
       }
       links.type = type;
     }
@@ -57333,7 +57336,7 @@ function createTypeChecker(host) {
         if (getAnnotatedAccessorTypeNode(setter)) {
           error2(setter, Diagnostics._0_is_referenced_directly_or_indirectly_in_its_own_type_annotation, symbolToString(symbol));
         }
-        writeType = anyType;
+        writeType = errorType;
       }
       links.writeType = writeType || getTypeOfAccessors(symbol);
     }
@@ -57414,8 +57417,7 @@ function createTypeChecker(host) {
       const declaredType = firstDefined(exportSymbol == null ? void 0 : exportSymbol.declarations, (d) => isExportAssignment(d) ? tryGetTypeFromEffectiveTypeNode(d) : void 0);
       links.type = (exportSymbol == null ? void 0 : exportSymbol.declarations) && isDuplicatedCommonJSExport(exportSymbol.declarations) && symbol.declarations.length ? getFlowTypeFromCommonJSExport(exportSymbol) : isDuplicatedCommonJSExport(symbol.declarations) ? autoType : declaredType ? declaredType : getSymbolFlags(targetSymbol) & 111551 /* Value */ ? getTypeOfSymbol(targetSymbol) : errorType;
       if (!popTypeResolution()) {
-        reportCircularityError(exportSymbol ?? symbol);
-        return links.type = errorType;
+        return links.type = reportCircularityError(exportSymbol ?? symbol);
       }
     }
     return links.type;
@@ -57444,7 +57446,7 @@ function createTypeChecker(host) {
         error2(node, Diagnostics.Circular_definition_of_import_alias_0, symbolToString(symbol));
       }
     }
-    return anyType;
+    return errorType;
   }
   function getTypeOfSymbolWithDeferredType(symbol) {
     const links = getSymbolLinks(symbol);
@@ -60205,7 +60207,7 @@ function createTypeChecker(host) {
             }
           }
         }
-        type = anyType;
+        type = errorType;
       }
       signature.resolvedReturnType = type;
     }
@@ -80244,7 +80246,7 @@ function createTypeChecker(host) {
       const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
       if (modifiers) {
         const symbol = getSymbolOfDeclaration(node.parent);
-        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
           error2(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
         } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
           (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });
@@ -175479,7 +175481,7 @@ var TypingsInstaller = class {
   }
   /** @internal */
   installPackage(req) {
-    const { fileName, packageName, projectName, projectRootPath } = req;
+    const { fileName, packageName, projectName, projectRootPath, id } = req;
     const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
       if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
         return directory;
@@ -175491,6 +175493,7 @@ var TypingsInstaller = class {
         const response = {
           kind: ActionPackageInstalled,
           projectName,
+          id,
           success,
           message
         };
@@ -175500,6 +175503,7 @@ var TypingsInstaller = class {
       const response = {
         kind: ActionPackageInstalled,
         projectName,
+        id,
         success: false,
         message: "Could not determine a project root path."
       };
@@ -186695,6 +186699,7 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     // Maps project name to newest requestQueue entry for that project
     /** We will lazily request the types registry on the first call to `isKnownTypesPackageName` and store it in `typesRegistryCache`. */
     this.requestedRegistry = false;
+    this.packageInstallId = 0;
   }
   isKnownTypesPackageName(name) {
     var _a;
@@ -186709,11 +186714,13 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     return !!((_a = this.typesRegistryCache) == null ? void 0 : _a.has(name));
   }
   installPackage(options) {
-    this.installer.send({ kind: "installPackage", ...options });
-    Debug.assert(this.packageInstalledPromise === void 0);
-    return new Promise((resolve, reject) => {
-      this.packageInstalledPromise = { resolve, reject };
+    this.packageInstallId++;
+    const request = { kind: "installPackage", ...options, id: this.packageInstallId };
+    const promise = new Promise((resolve, reject) => {
+      (this.packageInstalledPromise ?? (this.packageInstalledPromise = /* @__PURE__ */ new Map())).set(this.packageInstallId, { resolve, reject });
     });
+    this.installer.send(request);
+    return promise;
   }
   attach(projectService) {
     this.projectService = projectService;
@@ -186738,6 +186745,7 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     }
   }
   handleMessage(response) {
+    var _a, _b;
     if (this.logger.hasLevel(3 /* verbose */)) {
       this.logger.info(`TIAdapter:: Received response:${stringifyIndented(response)}`);
     }
@@ -186746,13 +186754,14 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
         this.typesRegistryCache = new Map(Object.entries(response.typesRegistry));
         break;
       case ActionPackageInstalled: {
-        const { success, message } = response;
-        if (success) {
-          this.packageInstalledPromise.resolve({ successMessage: message });
+        const promise = (_a = this.packageInstalledPromise) == null ? void 0 : _a.get(response.id);
+        Debug.assertIsDefined(promise, "Should find the promise for package install");
+        (_b = this.packageInstalledPromise) == null ? void 0 : _b.delete(response.id);
+        if (response.success) {
+          promise.resolve({ successMessage: response.message });
         } else {
-          this.packageInstalledPromise.reject(message);
+          promise.reject(response.message);
         }
-        this.packageInstalledPromise = void 0;
         this.projectService.updateTypingsForProject(response);
         this.event(response, "setTypings");
         break;

package/lib/typescript.d.ts

@@ -49,9 +49,11 @@ declare namespace ts {
             readonly fileName: Path;
             readonly packageName: string;
             readonly projectRootPath: Path;
+            readonly id: number;
         }
         interface PackageInstalledResponse extends ProjectResponse {
             readonly kind: ActionPackageInstalled;
+            readonly id: number;
             readonly success: boolean;
             readonly message: string;
         }

package/lib/typescript.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.4";
-      version = `${versionMajorMinor}.0-insiders.20231115`;
+      version = `${versionMajorMinor}.0-insiders.20231116`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -50741,6 +50741,8 @@ ${lanes.join("\n")}
             context.symbolDepth.set(id, depth + 1);
           }
           context.visitedTypes.add(typeId);
+          const prevTrackedSymbols = context.trackedSymbols;
+          context.trackedSymbols = void 0;
           const startLength = context.approximateLength;
           const result = transform2(type2);
           const addedLength = context.approximateLength - startLength;
@@ -50756,6 +50758,7 @@ ${lanes.join("\n")}
           if (id) {
             context.symbolDepth.set(id, depth);
           }
+          context.trackedSymbols = prevTrackedSymbols;
           return result;
           function deepCloneOrReuseNode(node) {
             if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -55080,7 +55083,7 @@ ${lanes.join("\n")}
           } else if (getter && noImplicitAny) {
             error2(getter, Diagnostics._0_implicitly_has_return_type_any_because_it_does_not_have_a_return_type_annotation_and_is_referenced_directly_or_indirectly_in_one_of_its_return_expressions, symbolToString(symbol));
           }
-          type = anyType;
+          type = errorType;
         }
         links.type = type;
       }
@@ -55098,7 +55101,7 @@ ${lanes.join("\n")}
           if (getAnnotatedAccessorTypeNode(setter)) {
             error2(setter, Diagnostics._0_is_referenced_directly_or_indirectly_in_its_own_type_annotation, symbolToString(symbol));
           }
-          writeType = anyType;
+          writeType = errorType;
         }
         links.writeType = writeType || getTypeOfAccessors(symbol);
       }
@@ -55179,8 +55182,7 @@ ${lanes.join("\n")}
         const declaredType = firstDefined(exportSymbol == null ? void 0 : exportSymbol.declarations, (d) => isExportAssignment(d) ? tryGetTypeFromEffectiveTypeNode(d) : void 0);
         links.type = (exportSymbol == null ? void 0 : exportSymbol.declarations) && isDuplicatedCommonJSExport(exportSymbol.declarations) && symbol.declarations.length ? getFlowTypeFromCommonJSExport(exportSymbol) : isDuplicatedCommonJSExport(symbol.declarations) ? autoType : declaredType ? declaredType : getSymbolFlags(targetSymbol) & 111551 /* Value */ ? getTypeOfSymbol(targetSymbol) : errorType;
         if (!popTypeResolution()) {
-          reportCircularityError(exportSymbol ?? symbol);
-          return links.type = errorType;
+          return links.type = reportCircularityError(exportSymbol ?? symbol);
         }
       }
       return links.type;
@@ -55209,7 +55211,7 @@ ${lanes.join("\n")}
           error2(node, Diagnostics.Circular_definition_of_import_alias_0, symbolToString(symbol));
         }
       }
-      return anyType;
+      return errorType;
     }
     function getTypeOfSymbolWithDeferredType(symbol) {
       const links = getSymbolLinks(symbol);
@@ -57970,7 +57972,7 @@ ${lanes.join("\n")}
               }
             }
           }
-          type = anyType;
+          type = errorType;
         }
         signature.resolvedReturnType = type;
       }
@@ -78009,7 +78011,7 @@ ${lanes.join("\n")}
         const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
         if (modifiers) {
           const symbol = getSymbolOfDeclaration(node.parent);
-          if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+          if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
             error2(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
           } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
             (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });
@@ -172693,7 +172695,7 @@ ${options.prefix}` : "\n" : options.prefix
         }
         /** @internal */
         installPackage(req) {
-          const { fileName, packageName, projectName, projectRootPath } = req;
+          const { fileName, packageName, projectName, projectRootPath, id } = req;
           const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
             if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
               return directory;
@@ -172705,6 +172707,7 @@ ${options.prefix}` : "\n" : options.prefix
               const response = {
                 kind: ActionPackageInstalled,
                 projectName,
+                id,
                 success,
                 message
               };
@@ -172714,6 +172717,7 @@ ${options.prefix}` : "\n" : options.prefix
             const response = {
               kind: ActionPackageInstalled,
               projectName,
+              id,
               success: false,
               message: "Could not determine a project root path."
             };
@@ -184034,6 +184038,7 @@ ${e.message}`;
           // Maps project name to newest requestQueue entry for that project
           /** We will lazily request the types registry on the first call to `isKnownTypesPackageName` and store it in `typesRegistryCache`. */
           this.requestedRegistry = false;
+          this.packageInstallId = 0;
         }
         isKnownTypesPackageName(name) {
           var _a;
@@ -184048,11 +184053,13 @@ ${e.message}`;
           return !!((_a = this.typesRegistryCache) == null ? void 0 : _a.has(name));
         }
         installPackage(options) {
-          this.installer.send({ kind: "installPackage", ...options });
-          Debug.assert(this.packageInstalledPromise === void 0);
-          return new Promise((resolve, reject) => {
-            this.packageInstalledPromise = { resolve, reject };
+          this.packageInstallId++;
+          const request = { kind: "installPackage", ...options, id: this.packageInstallId };
+          const promise = new Promise((resolve, reject) => {
+            (this.packageInstalledPromise ?? (this.packageInstalledPromise = /* @__PURE__ */ new Map())).set(this.packageInstallId, { resolve, reject });
           });
+          this.installer.send(request);
+          return promise;
         }
         attach(projectService) {
           this.projectService = projectService;
@@ -184077,6 +184084,7 @@ ${e.message}`;
           }
         }
         handleMessage(response) {
+          var _a, _b;
           if (this.logger.hasLevel(3 /* verbose */)) {
             this.logger.info(`TIAdapter:: Received response:${stringifyIndented(response)}`);
           }
@@ -184085,13 +184093,14 @@ ${e.message}`;
               this.typesRegistryCache = new Map(Object.entries(response.typesRegistry));
               break;
             case ActionPackageInstalled: {
-              const { success, message } = response;
-              if (success) {
-                this.packageInstalledPromise.resolve({ successMessage: message });
+              const promise = (_a = this.packageInstalledPromise) == null ? void 0 : _a.get(response.id);
+              Debug.assertIsDefined(promise, "Should find the promise for package install");
+              (_b = this.packageInstalledPromise) == null ? void 0 : _b.delete(response.id);
+              if (response.success) {
+                promise.resolve({ successMessage: response.message });
               } else {
-                this.packageInstalledPromise.reject(message);
+                promise.reject(response.message);
               }
-              this.packageInstalledPromise = void 0;
               this.projectService.updateTypingsForProject(response);
               this.event(response, "setTypings");
               break;

package/lib/typingsInstaller.js

@@ -54,7 +54,7 @@ var path = __toESM(require("path"));
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -31947,7 +31947,7 @@ var TypingsInstaller = class {
   }
   /** @internal */
   installPackage(req) {
-    const { fileName, packageName, projectName, projectRootPath } = req;
+    const { fileName, packageName, projectName, projectRootPath, id } = req;
     const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
       if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
         return directory;
@@ -31959,6 +31959,7 @@ var TypingsInstaller = class {
         const response = {
           kind: ActionPackageInstalled,
           projectName,
+          id,
           success,
           message
         };
@@ -31968,6 +31969,7 @@ var TypingsInstaller = class {
       const response = {
         kind: ActionPackageInstalled,
         projectName,
+        id,
         success: false,
         message: "Could not determine a project root path."
       };

package/package.json

@@ -2,7 +2,7 @@
   "name": "@typescript-deploys/pr-build",
   "author": "Microsoft Corp.",
   "homepage": "https://www.typescriptlang.org/",
-  "version": "5.4.0-pr-56418-6",
+  "version": "5.4.0-pr-56429-7",
   "license": "Apache-2.0",
   "description": "TypeScript is a language for application scale JavaScript development",
   "keywords": [
@@ -115,5 +115,5 @@
     "node": "20.1.0",
     "npm": "8.19.4"
   },
-  "gitHead": "66b933eedd4e6149c1a51829ee6d2047ff00c8d2"
+  "gitHead": "1f095db76098959d2ad1e8beef365f4e5b2a7b9a"
 }